summaryrefslogtreecommitdiffstats
path: root/tools
Commit message (Collapse)AuthorAgeFilesLines
* releasetools: support reading release keys out of some sort of commandTom Powell2017-01-231-1/+16
| | | | | | | key passphrases may live in some sort of secure storage, support running an arbitrary command to retrieve them. Change-Id: I49862cf60f1b73a2356e0c492e1038beef28a95f
* releasetools: Add script to sign zipsGabriele M2017-01-231-0/+69
| | | | Change-Id: I9cbeb6edea79a7e9bb0fc692e53497b54058d67f
* build: support lineage device treesSimon Shields2017-01-091-14/+19
| | | | Change-Id: I087a97e31cab2ccfba16b5378cef429785baf7d0
* build: Rebrand to LineageOSZhao Wei Liew2016-12-274-11/+13
| | | | Change-Id: Ie03583dc2a974a159fa50c6cb19cb68aa256ca77
* build: repopick: Avoid failing on commits lookupAdrian DC2016-12-041-0/+2
| | | | | | | | | | * Some projects with multiple merges and discountinuous histories could trigger an error here when the HEAD~{?} does not exist, hence avoid this by ignoring the commit and continue the search Change-Id: Ice28c87d1bf8897da52236b637bbb0c5d349f848
* build: repopick: Support squashed commits for Change-Id detectionAdrian DC2016-12-041-1/+5
| | | | | | | | | | | | * Commits are identified by their last Change-Id, but the parser only considers the first one found * Reverse the list to find the last Change-Id and avoid multiple repopick attempts on the same commit RM-290 Change-Id: Ie0204245a47799f8ead21148e0b4e9356cf271eb
* build: repopick: Support projects with less than 10 commitsAdrian DC2016-12-041-2/+8
| | | | | | | | | * Verify that the project has at least 10 commits to verify, if not check only the amount of existing commits RM-290 Change-Id: Ic95212510d8f5b980c9a94af8d5ac1e0dfd94b3e
* repopick: handle revisions with slashesDan Pasanen2016-12-041-1/+2
| | | | | | RM-290 Change-Id: I6f7891a52fb1538e88f5a68dd28ef1c603ee7067
* repopick: don't re-pick duplicate changesSimon Shields2016-12-041-0/+14
| | | | | | | | check the last 10 commits to HEAD for a dupe change id. RM-290 Change-Id: Icfbf8b4eae165cf84ef4a82f54f792e9c9acd67b
* repopick: try to use remote's default revisionDan Pasanen2016-12-041-1/+6
| | | | | | | | | | * If the project doesn't have a revision specified, try to see if it's remote has one specified before falling back to the global default. RM-290 Change-Id: I05129413b154e5d08d0fa9ef0ce853631b7e1562
* releasetools: Rebuild recovery when signing target imagesDiogo Ferreira2016-11-092-7/+9
| | | | | | | | | | | | | | | | | When signing a build, the recovery can be built twice, once when signing and again when adding the image to target files. This is usally not a problem for deterministic signatures but a custom signing method might include a time-based component which affects checksums of the generated images. This means that the recovery patches (i.e. install-recovery) will fail to checksum. This patch makes adding images to target files, when invoked from sign_target_files_apks, always rebuild the recovery patch with the newly generated images so that the checksums are consistent irrespective of potential time components. Change-Id: I575c69dc96a6d4d69b3ea9d037f5f13c97afa87e
* build: Use the password manager for the verity key if possibleRicardo Cerqueira2016-07-112-3/+30
| | | | | | | If we're operating with a password dict, try to use it for verity Change-Id: Ie0e8e33c873fc9f1ae9bd6da559f9cbbced183e9 Ref: CYNGNOS-3156
* build: Let the verity signer and metadata builders ask for a passwordRicardo Cerqueira2016-07-042-4/+8
| | | | | | | | | Don't grab stdin/out for these tools. We want to know when a password is being requested (and be able to actually provide one) if the corresponding key needs it Change-Id: I8dd439322b7d8942adc9ce7ce0912fb20c69654f Ref: CYNGNOS-3156
* ereleasetools: Allow for custom boot image signing toolsBrint E. Kriebel2016-05-171-1/+10
| | | | | | | | Some boot images will need to be signed using specific tools. Allow passing the path to this tool through an environment variable. Change-Id: I958726fdae8d63fe99d639dfa361046b528a087c Ticket: CYNGNOS-2868
* repopick: support specifying a range of commits to pickDan Pasanen2016-05-111-2/+8
| | | | | | * for example: repopick 12345-12350 Change-Id: I3b8f2c331a6ac5488032432e133bd4b44d0bf007
* img_from_target_files: Skip oem.img in fastboot image creationBrint E. Kriebel2016-04-181-6/+3
| | | | | | | | We don't need this package to be included in fastboot images, so skip it when we are creating fastboot images. Change-Id: I1e0676f5cbf7468088e6997f83ae845578864668 Ticket: CYNGNOS-936
* releasetools: Fix print in boot image signingBrint E. Kriebel2016-04-181-1/+1
| | | | | | | Python 3 compatibility fail Change-Id: I0acb7059b554ad16833ccdd09643f52f2c44a3f2 Ticket: RM-233
* releasetools: Add bootable image signingBrint E. Kriebel2016-04-181-1/+39
| | | | | | | | Set PRODUCT_PRIVATE_KEY to the path of the boot image signing certificate to sign an image for secure boot. Ticket: RM-233 Change-Id: I2c767c6f9c3740bed3d7094d2d0b50a075e08abc
* build: skip 'ro.product.device' using new macro "TARGET_SKIP_PRODUCT_DEVICE"Edward Wang2016-04-151-1/+3
| | | | | Change-Id: Id17ef7de8b0146dd6e4b2cc3cc5b88453da38f6c Ticket: FEIJ-62
* build: Create a oem image when BOARD_OEMIMAGE_FILE_SYSTEM_TYPE is definedDiogo Ferreira2016-04-152-0/+39
| | | | | | | | | | This adds the capability of generating a OEM image with the build and adding it to target files when BOARD_OEMIMAGE_FILE_SYSTEM_TYPE is set. Change-Id: I6c596d58d9d5ece1a261d953eeb8c60eac30e642 Ticket: CYNGNOS-936 (cherry picked from commit 1966a9e7c22b95eb4c16be6aee7adf43cb6ce118)
* Preventing default locale from being overridden because of buildinfo.shAbhishek G2016-04-051-1/+1
| | | | | | | | | Adding the ability to set default locale from the device tree. Adding the TARGET_SKIP_DEFAULT_LOCALE flag which can be set in the device tree, thus preventing buildinfo.sh from overriding default locale. Change-Id: I66bcedb42216acee56ceaf657a39dc23d7eea6f4 Issue-Id: FEIJ-22
* Merge tag 'android-6.0.1_r22' of ↵Steve Kondik2016-03-112-10/+39
|\ | | | | | | | | | | | | | | https://android.googlesource.com/platform/build into cm-13.0 Android 6.0.1 release 22 Change-Id: Icd3603c1efc5fa85f48c19d13d484f0371ddae37
| * am 46ae586a: am e09359ab: DO NOT MERGE Pass source\'s info_dict to vendor\'s ↵Tao Bao2015-10-172-3/+11
| |\ | | | | | | | | | | | | | | | | | | releasetools.py. * commit '46ae586ab26f5bf63baaac6c68942f1bfba4addc': DO NOT MERGE Pass source's info_dict to vendor's releasetools.py.
| * \ am b03d55aa: Merge "DO NOT MERGE: Only use a fixed timestamp when ↵Tao Bao2015-10-122-0/+20
| |\ \ | | | | | | | | | | | | | | | | | | | | | | | | packaging." into mnc-dr-dev * commit 'b03d55aaeb5962690631ed1a25d8e628667d8ad2': DO NOT MERGE: Only use a fixed timestamp when packaging.
| * \ \ am 1b5eef1b: am b16edb5f: Merge "add unique ID to each windows download ↵Joe Fernandez2015-10-101-2/+2
| |\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | link. These IDs are necessary for the TOS wall to identify which link should be applied to the download button." into mnc-dev * commit '1b5eef1b490cc143474ec74d58369aac9bf6629e': add unique ID to each windows download link. These IDs are necessary for the TOS wall to identify which link should be applied to the download button.
| * \ \ \ am 59f4ff10: Add verity_signer and verity_key flags to add_img_to_target_files.Baligh Uddin2015-09-171-2/+14
| |\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | * commit '59f4ff109d7da6d608cb6b1248a4403b13d8b2bc': Add verity_signer and verity_key flags to add_img_to_target_files.
| * \ \ \ \ am a0abf49d: resolved conflicts for a1fcaf86 to mnc-dr-devIan Pedowitz2015-09-161-1/+9
| |\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | * commit 'a0abf49d2bdc42c81e5f636e54da9038de9dfc21': Add an option to include a full bootloader in incremental OTA.
| * \ \ \ \ \ am 1e7f6f74: Fix build.leozwang2015-09-151-1582/+1
| |\ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * commit '1e7f6f7442ca2addc8e4447d3070c625dbba8d3f': Fix build.
| * \ \ \ \ \ \ am 888b6f47: am 47f6a4e7: am 1c1a6d15: am 2c9dfb82: am 1d4ad515: Revert "Add ↵Leo Wang2015-09-151-9/+0
| |\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | an option to include a full bootloader in incremental OTA." * commit '888b6f47c73c7ff0f4780e4406f18a83dbd4d8c2': Revert "Add an option to include a full bootloader in incremental OTA."
| * \ \ \ \ \ \ \ am 160603cf: am 5837f102: am 1753b4e9: resolved conflicts for 00fdede3 to ↵leozwang2015-09-151-1/+1591
| |\ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | lmp-mr1-ub-dev * commit '160603cfc20362df30886a05735054842c6f79b8': Add an option to include a full bootloader in incremental OTA.
| * \ \ \ \ \ \ \ \ am e35d00d0: am 265d9aeb: releasetools: Update the fingerprint when signing.Tao Bao2015-09-121-1/+7
| |\ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * commit 'e35d00d019aaff92b5e20b86d9c3b8222c0c946a': releasetools: Update the fingerprint when signing.
| * \ \ \ \ \ \ \ \ \ am 28f6f9c3: releasetools: Always write the last block if it\'s padded.Tao Bao2015-09-081-6/+21
| |\ \ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * commit '28f6f9c3deb4d23fd627d15631d682a5cfa989fc': releasetools: Always write the last block if it's padded.
| * \ \ \ \ \ \ \ \ \ \ am a6e6afbc: am 39c322ce: releasetools: Fix the bug in symlink deletion.Tao Bao2015-09-032-4/+38
| |\ \ \ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * commit 'a6e6afbce69da968299898944bb2165f5e799886': releasetools: Fix the bug in symlink deletion.
| * \ \ \ \ \ \ \ \ \ \ \ am 77c1ff7b: am 4ffdc8fa: Fix bug that caused table of Studio links to ↵smain@google.com2015-08-311-6/+10
| |\ \ \ \ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | result in "stand-alone" tools instructions. bug: 23570662 * commit '77c1ff7bf983ef4622ecb227d4e5b0c75728c28f': Fix bug that caused table of Studio links to result in "stand-alone" tools instructions. bug: 23570662
| * \ \ \ \ \ \ \ \ \ \ \ \ am e337093e: Merge changes from topic \'stash-size\' into mnc-dr-devTao Bao2015-08-313-18/+213
| |\ \ \ \ \ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * commit 'e337093e6c5d502f0f4094639b41c001b3048d0f': Split large files for BBOTA v3. Revise stash for BBOTAs when needed. Assert the stash size when generating OTAs.
| * \ \ \ \ \ \ \ \ \ \ \ \ \ am 15bb28fc: am ed7e864a: fix a few bugs in the studio download button ↵smain@google.com2015-08-242-5/+3
| |\ \ \ \ \ \ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | behavior: - make button text always white (avoid blue on blue during hover) - revise logic to add the platform name to download button to avoid weird duplicity bug on small screens - remove the * commit '15bb28fc73fa30e9c7b8ee0d924c8906724809e0': fix a few bugs in the studio download button behavior: - make button text always white (avoid blue on blue during hover) - revise logic to add the platform name to download button to avoid weird duplicity bug on small screens - remove the animation script when clicking download before agree because it reloaded the page (unkown cause) depends on: https://googleplex-android-review.git.corp.google.com/#/c/752757/
| * | | | | | | | | | | | | | | sparse_img.py: Divide NONZERO blocks into groups.Tao Bao2015-08-191-3/+23
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | For squashfs, we currently don't have a system.map. So the whole system image will be treated as a single file. But for some unknown bug, the updater will be killed due to OOM when writing back the patched image to flash (observed on lenok-userdebug MEA49). Prior to getting a real fix, we evenly divide the non-zero blocks into smaller groups (currently 1024 blocks or 4MB per group). Bug: 23227672 Change-Id: Ifeddd8d802f01f8cd2a743a1d1217a284fb6e182
| * | | | | | | | | | | | | | | am 8ea2636c: am 6a8f88cd: adjust image placement for m hero on medium screens.Dirk Dougherty2015-08-171-1/+5
| |\ \ \ \ \ \ \ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * commit '8ea2636c190789263aaf78b89163c8e85bef3417': adjust image placement for m hero on medium screens.
| * \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ am a2869db8: am 71e0a80c: Merge "doc change: Add hero image for m and css ↵Joe Fernandez2015-08-132-0/+66
| |\ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | for landing pages." into mnc-dev * commit 'a2869db89eb59e57b7f0cdfc5e526d5257b95ecc': doc change: Add hero image for m and css for landing pages.
| * \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ am 897f3ba8: am 25abc5a3: Merge "Fix issie #23116383: Include security patch ↵Dianne Hackborn2015-08-131-0/+2
| |\ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | level in Settings" into mnc-dev * commit '897f3ba8b1cc402fca16720be345ba9c587c326b': Fix issie #23116383: Include security patch level in Settings
| * \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ am 86e510cc: am 71a33c4d: Merge "Add the ability to display annotations in ↵Clay Murphy2015-08-112-1/+9
| |\ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | the generated docs (cherry-picked from commit 87c44d8a11d6f9e94c90197e7f8adf430c949c86) Bug: 8440225 Change-Id: I41c1c7909b283832b818b8860ffe370cd4328f20" into mnc-dev * commit '86e510cc313a464870ff82a9cd7f7206ea4aeb63': Add the ability to display annotations in the generated docs (cherry-picked from commit 87c44d8a11d6f9e94c90197e7f8adf430c949c86) Bug: 8440225 Change-Id: I41c1c7909b283832b818b8860ffe370cd4328f20
| * \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ am 9f5c487e: Merge "releasetools: Fix parameters for vboot_signer" into ↵Furquan Shaikh2015-08-101-1/+3
| |\ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | mnc-dr-dev * commit '9f5c487ef586d20c273cafba6ce663287ef6a37a': releasetools: Fix parameters for vboot_signer
| * \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ am 15b42c42: am cce673b6: Read fstab from the source build.Tao Bao2015-07-291-6/+8
| |\ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * commit '15b42c426715c2221f49d0cf2181ba869b84bc94': Read fstab from the source build.
| * \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ am 7f8ecb7f: Merge "Zero out blocks that may be touched by dm-verity." into ↵Tao Bao2015-07-104-14/+73
| |\ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | mnc-dev * commit '7f8ecb7f5c21630a75c69d170ba2b401d7a311a5': Zero out blocks that may be touched by dm-verity.
| * \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ am 74a81e66: fix device specific fs_config on build serverThierry Strudel2015-07-104-11/+24
| |\ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * commit '74a81e6633276d92337749a5ee9d921207814dd4': fix device specific fs_config on build server
| * \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ resolved conflicts for merge of 610754e5 to cw-e-devTao Bao2015-07-081-6/+16
| |\ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Change-Id: Ia0d0d82c7fec86e1585a9e2c90ac877c363ed491
| | * | | | | | | | | | | | | | | | | | | | | | | Scan all init.*.rc files for flash_recovery service.Tao Bao2015-07-071-7/+17
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Clockwork builds may rename init.rc to init.core.rc. Change the OTA script to scan all init.*.rc files to determine the proper location for install-recovery.sh. Bug: 22128990 Change-Id: If96bd0b81090683ad0bbfddb735d390204849d9f
| | * | | | | | | | | | | | | | | | | | | | | | | Merge "DO NOT MERGE Fix the syntax error in the edify script generator" into ↵Chris Elliott2015-07-021-5/+5
| | |\ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | cw-d-mr1-dev
| | | * | | | | | | | | | | | | | | | | | | | | | | DO NOT MERGE Fix the syntax error in the edify script generatorTao Bao2015-07-021-5/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | file_getprop() always expects two arguments. Bug: 19881931 Change-Id: Icf5577ad34188991c03f68c1217642d3adc4201c
* | | | | | | | | | | | | | | | | | | | | | | | | | releasetool: add OSIP partitions specificsArtefvck 072016-02-202-2/+7
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | - Declare OSIP as a new partition type - Standard boot.img update is not possible for OSIP partitions We are simply removing it on AOSP handling, and let the board handle it in its own releasetool.py Change-Id: Ie19fc3f6a0ca42e2eda264904b20fceeddbeaf53