| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
| |
Change-Id: I2884f34700cd1cd66f0604378cf12b713263a9d1
Signed-off-by: Iliyan Malchev <malchev@google.com>
|
|
|
|
|
|
|
|
|
|
|
| |
bug fix: Duplicated setting of cameraid is caused that
setParameters fail. So, operations about setting of camera
id are moved for setting once.
bug:3512875
Change-Id: I48d0847644525a658b4415fffcf2910a83a65e43
Signed-off-by: Jeong-Seok Yang <jseok.yang@samsung.com>
|
|
|
|
|
|
|
|
|
|
| |
Bug fix: Camcording video has tearing issues on low resolution or
in daylight condition. It is caused overwriting buffers
before processing recording. So we increase number of buffers.
Signed-off-by: Jeong-Seok Yang <jseok.yang@samsung.com>
Change-Id: I2a02183174a18472df2506c5f20f324644161c32
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Cleanup how buffers are managed. Before, buffers for preview
and capture and record were mixed together, with one thread
cleaning up buffers for another. Now, each mode cleans up
its own buffers. Implement asychronous buffer release for record
case to fix a bug where we allowed FIMC to update a buffer that
was still in use by encoder, resulting in encoding a frame that
was part one image and part another.
Change-Id: I42d0032cea61197a1f3a665a7248b700599d5a6a
Signed-off-by: Mike J. Chen <mjchen@sta.samsung.com>
|
|
|
|
|
|
|
|
|
|
| |
Remove a bunch of #ifdef conditionals to cleanup the code. The #else
cases have generally not been tested for months now and we don't use
them, and this makes it easier to follow for the next round of logic
cleanup coming up.
Change-Id: I4a78901916ed9393ef9b904a1e8037cd645be3b4
Signed-off-by: Mike J. Chen <mjchen@sta.samsung.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
1. Adding checking preview status in CameraHardwareSec::stopPreview().
So if its status is not previewing, It doesn't call SecCamera::stopPreview.
Thus, buffers what be used by picture thread will not be cleared.
2. Adding killing thread and clear buffers in CameraHardwareSec::cancelPicture()
3. CameraHardwareSec::SplitFrame was modified to remove potential problem
about memory access.
fix : bug 3093595
Change-Id: Iefa85df297a6abdbb5fb7772b58e0c949aeda0de
Signed-off-by: Jeong-Seok Yang <jseok.yang@samsung.com>
|
|
|
|
|
|
|
|
| |
Check preview status to prevent abnormal working by electronic
discharge.
Change-Id: Ie2d7f9de2cc2efa1c5d26bf445b9e75adff49650
Signed-off-by: Jeong-Seok Yang <jseok.yang@samsung.com>
|
|
|
|
|
|
|
|
|
| |
Binary version, ISO, focal-length, and flash informations
in EXIF are fixed correctly.
Change-Id: I2dbfd217ae1e1bb875848ba89c4633a93d337779
Signed-off-by: Jeong-Seok Yang <jseok.yang@samsung.com>
pid:3604
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* don't save parameters that aren't valid
* correct the focal length exif info - should be 3.43mm
* update with right focus distance info for front camera
* correct thumbnail size in params to match HAL code
* fix advertized 1M picture size to match recent driver change
* don't generate thumbnails if size set to 0x0
* set right max preview size
* don't set scene mode if we don't have any in front camera
* update to latest fps ranges in rear sensor (min of 15fps in normal mode, 4fps in night mode)
* add support for GPS_TIMESTAMP, GPS_DATESTAMP, GPS_PROCESSING_METHOD
* remove gps settings if passed NULL
* move recording-size info to internal params
* workaround front camera not supporting get_iso and get_shot_time for now
* remove antibanding code since we don't support it
* ignore invalid jpeg quality settings
* reject fps max and min different than our current setting
* simplify scene mode settings. driver should have all the
right settings already for things like iso, sharpness, saturation,
etc. the HAL shouldn't set these separately because that will
just confuse and override the sensors own settings.
Change-Id: Ib6121cc1ceb650a993661d0ec7498a3472a1dd89
Signed-off-by: Mike J. Chen <mjchen@sta.samsung.com>
|
|
|
|
|
|
|
| |
Add thumbnail image in EXIF on capturing image of front camera
Change-Id: I4f6f4eca5c29f397f793ea6a802997a2d2c65dc7
Signed-off-by: Jeong-Seok Yang <jseok.yang@samsung.com>
|
|
|
|
|
| |
Change-Id: If70052d910cc904ac29f048ad28bcbb5fa0ddda0
Signed-off-by: Jeong-Seok Yang <jseok.yang@samsung.com>
|
|
|
|
|
|
|
|
|
|
|
| |
This is part of change to the interface between driver
and HAL so that driver doesn't do anything if a setting
is the same as current. The HAL part is to send all
settings for preview in one ioctl, instead of about
a dozen to save even more time (total is about 500ms).
Change-Id: I46392e970fd1725719359cdf7fb6ca2006beba4c
Signed-off-by: Mike J. Chen <mjchen@sta.samsung.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Remove unofficial parameters so 3rd party apps don't start using
them and become incompatible with the offical Google API.
Put placeholders for new API KEY_SUPPORTED_PREVIEW_FPS_RANGE and
KEY_FOCUS_DISTANCES. Will update when we get info from HW team.
Simplify scene settings.
Fix a bunch of log messages and reduce unneeded chatter.
Fix callback result sent for CAMREA_MSG_FOCUS to be boolean since
that's what it's supposed to be.
Remove unneeded sleep in cancelAutoFocus.
Add FOCUS_MODE_INFINITY support (driver needs to go in first).
Change-Id: I10cb8e0f279d3229008fa04771c94bbf9e86d5d8
Signed-off-by: Mike J. Chen <mjchen@sta.samsung.com>
id:3180
|
|
|
|
|
|
|
|
|
|
| |
Cleaned up parameters so that we advertise the
right features for the front and back cameras.
Also remove a lot of unsupported features.
Change-Id: I3b2fd77153c7855cccf27733ee87c1379d357be8
Signed-off-by: Jeong-Seok Yang <jseok.yang@samsung.com>
Signed-off-by: Mike J. Chen <mjchen@sta.samsung.com>
|
|
|
|
|
| |
Change-Id: I3333df8437bb54897df8594229ffcc1b23221f7f
Signed-off-by: Jeong-Seok Yang <jseok.yang@samsung.com>
|
|
|
|
|
| |
Change-Id: I3df95e29de2ccd4cc4643205b6ce6eae6916d32b
Signed-off-by: Jeong-Seok Yang <jseok.yang@samsung.com>
|
|
|
|
|
|
|
| |
Also clean up supported picture sizes, frame rates and remove
use of hardcoded LCD dimensions.
Change-Id: I30a1035864f3a878ae58f2d6d649a91b5dc44a75
|
|
|
|
|
|
|
| |
Removed inconsistent coding style. Aligned better.
Change-Id: Ib6fa351cc39ede6881ed4937594689246b87bca8
Signed-off-by: Jeong-Seok Yang <jseok.yang@samsung.com>
|
|
|
|
|
| |
Signed-off-by: Mingyu Kim <mingyu0.kim@samsung.com>
Change-Id: I5b55678032bb633103ee596288cd7b7770596b87
|
|
|
|
|
|
|
|
|
|
|
|
| |
libs3cjpeg is library about JPEG encoding by H/W IP.
But libs3cjpeg is Samsung confidential library.
There is some license issues.
In addition, Google doesn't want using H/W JPEG encoder.
So It was modified for just working some function and building binary.
It doesn't work to capture the picture cause problem of jpeg encoding.
Change-Id: Ib5e1377d91a536002a2f94206bb3bdfdbc330688
Signed-off-by: Jeong-Seok Yang <jseok.yang@samsung.com>
|
|
Change-Id: I4a6ee248b407c67682eb8884d1176f4807288c7c
|