From 694a471276aaf69fac39f0f2380908b88ddb76cb Mon Sep 17 00:00:00 2001
From: James Dong <jdong@google.com>
Date: Thu, 11 Nov 2010 20:43:57 -0800
Subject: Fix a bug in overlay where the check on the overlay creation was
 mistakenly bypassed

bug - 3188835

Change-Id: Ie7ef190086084cb5098de91d88b4d2d2381216d2
---
 libstagefrighthw/SecHardwareRenderer.cpp | 11 +++++++----
 1 file changed, 7 insertions(+), 4 deletions(-)

(limited to 'libstagefrighthw')

diff --git a/libstagefrighthw/SecHardwareRenderer.cpp b/libstagefrighthw/SecHardwareRenderer.cpp
index f534b10..cb9e8e8 100644
--- a/libstagefrighthw/SecHardwareRenderer.cpp
+++ b/libstagefrighthw/SecHardwareRenderer.cpp
@@ -85,11 +85,14 @@ SecHardwareRenderer::SecHardwareRenderer(
                 mDecodedWidth, mDecodedHeight,
                 HAL_PIXEL_FORMAT_CUSTOM_YCbCr_420_SP, orientation);
         mCustomFormat = true;
-    } else
+    }
 #else
-    ref = mISurface->createOverlay(
-            mDecodedWidth, mDecodedHeight, HAL_PIXEL_FORMAT_YCbCr_420_P,
-            orientation);
+    else
+    {
+        ref = mISurface->createOverlay(
+                mDecodedWidth, mDecodedHeight, HAL_PIXEL_FORMAT_YCbCr_420_P,
+                orientation);
+    }
 #endif
 
     if (ref.get() == NULL) {
-- 
cgit v1.1