From 976e03f7ed3d46f4ebbab4056625947b7190433d Mon Sep 17 00:00:00 2001 From: Kyle Repinski Date: Fri, 6 Nov 2015 13:40:00 +0530 Subject: Fix RIL_Init ending unexpectedly when passed unknown args When libsec-ril receives an unknown argument, RIL_Init completely aborts early. With Android 5.0 and up, a "client id" argument is passed (via '-c' param), but libsec-ril's getopt call uses "p:d:s:", and anything not '-p' '-d' or '-s' jumps to the end of RIL_Init. By passing '--' before '-c', getopt ignores what's left and signals it's done. Currently there's no extra args passed after rild.libargs other than '-c', but even if that were to change in the future this change would still be required for RIL_Init to work. Change-Id: I7bd4d74cb23ff1624016ae3a1178407a885758d4 --- system.prop | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/system.prop b/system.prop index 8624d11..809dfe4 100644 --- a/system.prop +++ b/system.prop @@ -2,7 +2,7 @@ # system.prop for espresso10 # rild.libpath=/system/lib/libsec-ril.so -rild.libargs=-d /dev/ttyGS0 +rild.libargs=-d /dev/ttyGS0 -- telephony.lteOnCdmaDevice=0 ro.ril.hsxpa=1 ro.ril.gprsclass=10 -- cgit v1.1