From 6d7d35fa7630dde930c4647af41b3d8d76987f45 Mon Sep 17 00:00:00 2001 From: Steffen Pankratz Date: Mon, 29 Feb 2016 18:39:21 +0100 Subject: - fixed memory leak Memory allocated by 'new[]' should be deallocated by 'delete[]'. --- heimdall-frontend/source/mainwindow.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'heimdall-frontend/source/mainwindow.cpp') diff --git a/heimdall-frontend/source/mainwindow.cpp b/heimdall-frontend/source/mainwindow.cpp index e110d69..8167e5a 100644 --- a/heimdall-frontend/source/mainwindow.cpp +++ b/heimdall-frontend/source/mainwindow.cpp @@ -131,7 +131,7 @@ bool MainWindow::ReadPit(QFile *file) file->close(); bool success = currentPitData.Unpack(buffer); - delete buffer; + delete[] buffer; if (!success) currentPitData.Clear(); -- cgit v1.1 From 34c4636ee0a8ef9857b23e2257b670d14b2dfb8a Mon Sep 17 00:00:00 2001 From: Steffen Pankratz Date: Mon, 29 Feb 2016 19:50:53 +0100 Subject: - fixed possible null pointer access --- heimdall-frontend/source/mainwindow.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'heimdall-frontend/source/mainwindow.cpp') diff --git a/heimdall-frontend/source/mainwindow.cpp b/heimdall-frontend/source/mainwindow.cpp index 8167e5a..f06fb4e 100644 --- a/heimdall-frontend/source/mainwindow.cpp +++ b/heimdall-frontend/source/mainwindow.cpp @@ -659,7 +659,7 @@ void MainWindow::SelectPartitionName(int index) partitionFileGroup->setTitle(title); - if (!fileInfo.GetFilename().isEmpty()) + if (pitEntry && !fileInfo.GetFilename().isEmpty()) { QString partitionFilename = pitEntry->GetFlashFilename(); int lastPeriod = partitionFilename.lastIndexOf(QChar('.')); -- cgit v1.1