diff options
| author | Simon Busch <morphis@gravedo.de> | 2012-09-05 09:53:36 +0200 |
|---|---|---|
| committer | Simon Busch <morphis@gravedo.de> | 2012-09-09 12:23:21 +0200 |
| commit | 3a9c878ca37442aca10917306fffb625c46b0ec4 (patch) | |
| tree | 0d60e6b6ab27f6e8e7746b3b1abb6f7097f1dc59 /samsung-ipc/device/aries | |
| parent | db180081a182a2cd5652f9b1c147b974bae54811 (diff) | |
| download | external_libsamsung-ipc-3a9c878ca37442aca10917306fffb625c46b0ec4.zip external_libsamsung-ipc-3a9c878ca37442aca10917306fffb625c46b0ec4.tar.gz external_libsamsung-ipc-3a9c878ca37442aca10917306fffb625c46b0ec4.tar.bz2 | |
ipc: refactor ipc_client_gprs_get_iface method to return iface name instead of using a parameter
Allocating memory and setting a pointer to it for the user via a parameter is kind of
unnecessary. It's better to return the pointer instead.
Diffstat (limited to 'samsung-ipc/device/aries')
| -rw-r--r-- | samsung-ipc/device/aries/aries_ipc.c | 9 |
1 files changed, 4 insertions, 5 deletions
diff --git a/samsung-ipc/device/aries/aries_ipc.c b/samsung-ipc/device/aries/aries_ipc.c index 4860724..d987822 100644 --- a/samsung-ipc/device/aries/aries_ipc.c +++ b/samsung-ipc/device/aries/aries_ipc.c @@ -835,9 +835,10 @@ int aries_ipc_gprs_deactivate(void *data) return 0; } -int aries_ipc_gprs_get_iface(char **iface, int cid) +char* aries_ipc_gprs_get_iface(int cid) { struct ifreq ifr; + char *iface; int fd; int rc; int i; @@ -854,13 +855,11 @@ int aries_ipc_gprs_get_iface(char **iface, int cid) continue; } else { asprintf(iface, "%s%d", GPRS_IFACE_PREFIX, i); - return 0; + return iface; } } - *iface = NULL; - - return -1; + return NULL; } int aries_ipc_gprs_get_capabilities(struct ipc_client_gprs_capabilities *cap) |