diff options
author | Paul Kocialkowski <contact@paulk.fr> | 2014-02-15 20:16:19 +0100 |
---|---|---|
committer | Paul Kocialkowski <contact@paulk.fr> | 2014-02-15 20:58:20 +0100 |
commit | 005645221f3d4dd432970f8f28d9092d66d61213 (patch) | |
tree | 6ff93168ae04da425313ada33631fee507cfd7da /samsung-ipc/devices/n7100 | |
parent | ec82c3a5350b8747e1c0a7a0393ab0374dd9fbd5 (diff) | |
download | external_libsamsung-ipc-005645221f3d4dd432970f8f28d9092d66d61213.zip external_libsamsung-ipc-005645221f3d4dd432970f8f28d9092d66d61213.tar.gz external_libsamsung-ipc-005645221f3d4dd432970f8f28d9092d66d61213.tar.bz2 |
ipc: Consistent coding style and major cleanup
Signed-off-by: Paul Kocialkowski <contact@paulk.fr>
Diffstat (limited to 'samsung-ipc/devices/n7100')
-rw-r--r-- | samsung-ipc/devices/n7100/n7100.c (renamed from samsung-ipc/devices/n7100/n7100_ipc.c) | 141 | ||||
-rw-r--r-- | samsung-ipc/devices/n7100/n7100.h (renamed from samsung-ipc/devices/n7100/n7100_ipc.h) | 16 |
2 files changed, 64 insertions, 93 deletions
diff --git a/samsung-ipc/devices/n7100/n7100_ipc.c b/samsung-ipc/devices/n7100/n7100.c index ad118da..c72dcdd 100644 --- a/samsung-ipc/devices/n7100/n7100_ipc.c +++ b/samsung-ipc/devices/n7100/n7100.c @@ -1,7 +1,7 @@ /* * This file is part of libsamsung-ipc. * - * Copyright (C) 2013 Paul Kocialkowski <contact@paulk.fr> + * Copyright (C) 2013-2014 Paul Kocialkowski <contact@paulk.fr> * * libsamsung-ipc is free software: you can redistribute it and/or modify * it under the terms of the GNU General Public License as published by @@ -29,22 +29,21 @@ #include "xmm6260.h" #include "xmm6260_hsic.h" #include "xmm6260_sec_modem.h" -#include "n7100_ipc.h" +#include "n7100.h" -int n7100_ipc_bootstrap(struct ipc_client *client) +int n7100_boot(struct ipc_client *client) { void *modem_image_data = NULL; int modem_image_fd = -1; int modem_boot_fd = -1; int modem_link_fd = -1; - unsigned char *p; int rc; if (client == NULL) return -1; - ipc_client_log(client, "Starting n7100 modem bootstrap"); + ipc_client_log(client, "Starting n7100 modem boot"); modem_image_fd = open(N7100_MODEM_IMAGE_DEVICE, O_RDONLY); if (modem_image_fd < 0) { @@ -224,106 +223,88 @@ complete: return rc; } - -int n7100_ipc_fmt_send(struct ipc_client *client, struct ipc_message_info *request) -{ - return xmm6260_sec_modem_ipc_fmt_send(client, request); -} - -int n7100_ipc_fmt_recv(struct ipc_client *client, struct ipc_message_info *response) -{ - return xmm6260_sec_modem_ipc_fmt_recv(client, response); -} - -int n7100_ipc_rfs_send(struct ipc_client *client, struct ipc_message_info *request) -{ - return xmm6260_sec_modem_ipc_rfs_send(client, request); -} - -int n7100_ipc_rfs_recv(struct ipc_client *client, struct ipc_message_info *response) -{ - return xmm6260_sec_modem_ipc_rfs_recv(client, response); -} - -int n7100_ipc_open(void *data, int type) +int n7100_open(void *data, int type) { - struct n7100_ipc_transport_data *transport_data; + struct n7100_transport_data *transport_data; if (data == NULL) return -1; - transport_data = (struct n7100_ipc_transport_data *) data; + transport_data = (struct n7100_transport_data *) data; - transport_data->fd = xmm6260_sec_modem_ipc_open(type); + transport_data->fd = xmm6260_sec_modem_open(type); if (transport_data->fd < 0) return -1; return 0; } -int n7100_ipc_close(void *data) +int n7100_close(void *data) { - struct n7100_ipc_transport_data *transport_data; + struct n7100_transport_data *transport_data; if (data == NULL) return -1; - transport_data = (struct n7100_ipc_transport_data *) data; + transport_data = (struct n7100_transport_data *) data; - xmm6260_sec_modem_ipc_close(transport_data->fd); + xmm6260_sec_modem_close(transport_data->fd); transport_data->fd = -1; return 0; } -int n7100_ipc_read(void *data, void *buffer, unsigned int length) +int n7100_read(void *data, void *buffer, size_t length) { - struct n7100_ipc_transport_data *transport_data; + struct n7100_transport_data *transport_data; int rc; if (data == NULL) return -1; - transport_data = (struct n7100_ipc_transport_data *) data; + transport_data = (struct n7100_transport_data *) data; + + rc = xmm6260_sec_modem_read(transport_data->fd, buffer, length); - rc = xmm6260_sec_modem_ipc_read(transport_data->fd, buffer, length); return rc; } -int n7100_ipc_write(void *data, void *buffer, unsigned int length) +int n7100_write(void *data, const void *buffer, size_t length) { - struct n7100_ipc_transport_data *transport_data; + struct n7100_transport_data *transport_data; int rc; if (data == NULL) return -1; - transport_data = (struct n7100_ipc_transport_data *) data; + transport_data = (struct n7100_transport_data *) data; + + rc = xmm6260_sec_modem_write(transport_data->fd, buffer, length); - rc = xmm6260_sec_modem_ipc_write(transport_data->fd, buffer, length); return rc; } -int n7100_ipc_poll(void *data, struct timeval *timeout) +int n7100_poll(void *data, struct timeval *timeout) { - struct n7100_ipc_transport_data *transport_data; + struct n7100_transport_data *transport_data; int rc; if (data == NULL) return -1; - transport_data = (struct n7100_ipc_transport_data *) data; + transport_data = (struct n7100_transport_data *) data; + + rc = xmm6260_sec_modem_poll(transport_data->fd, timeout); - rc = xmm6260_sec_modem_ipc_poll(transport_data->fd, timeout); return rc; } -int n7100_ipc_power_on(void *data) +int n7100_power_on(void *data) { return 0; } -int n7100_ipc_power_off(void *data) +int n7100_power_off(void *data) { int fd; int rc; @@ -342,18 +323,19 @@ int n7100_ipc_power_off(void *data) return 0; } -int n7100_ipc_data_create(void **transport_data, void **power_data, void **gprs_data) +int n7100_data_create(void **transport_data, void **power_data, + void **gprs_data) { if (transport_data == NULL) return -1; - *transport_data = (void *) malloc(sizeof(struct n7100_ipc_transport_data)); - memset(*transport_data, 0, sizeof(struct n7100_ipc_transport_data)); + *transport_data = calloc(1, sizeof(struct n7100_transport_data)); return 0; } -int n7100_ipc_data_destroy(void *transport_data, void *power_data, void *gprs_data) +int n7100_data_destroy(void *transport_data, void *power_data, + void *gprs_data) { if (transport_data == NULL) return -1; @@ -363,52 +345,41 @@ int n7100_ipc_data_destroy(void *transport_data, void *power_data, void *gprs_da return 0; } -char *n7100_ipc_gprs_get_iface(int cid) -{ - return xmm6260_sec_modem_ipc_gprs_get_iface(cid); -} - - -int n7100_ipc_gprs_get_capabilities(struct ipc_client_gprs_capabilities *capabilities) -{ - return xmm6260_sec_modem_ipc_gprs_get_capabilities(capabilities); -} - -struct ipc_ops n7100_ipc_fmt_ops = { - .bootstrap = n7100_ipc_bootstrap, - .send = n7100_ipc_fmt_send, - .recv = n7100_ipc_fmt_recv, +struct ipc_client_ops n7100_fmt_ops = { + .boot = n7100_boot, + .send = xmm6260_sec_modem_fmt_send, + .recv = xmm6260_sec_modem_fmt_recv, }; -struct ipc_ops n7100_ipc_rfs_ops = { - .bootstrap = NULL, - .send = n7100_ipc_rfs_send, - .recv = n7100_ipc_rfs_recv, +struct ipc_client_ops n7100_rfs_ops = { + .boot = NULL, + .send = xmm6260_sec_modem_rfs_send, + .recv = xmm6260_sec_modem_rfs_recv, }; -struct ipc_handlers n7100_ipc_handlers = { - .read = n7100_ipc_read, - .write = n7100_ipc_write, - .open = n7100_ipc_open, - .close = n7100_ipc_close, - .poll = n7100_ipc_poll, +struct ipc_client_handlers n7100_handlers = { + .read = n7100_read, + .write = n7100_write, + .open = n7100_open, + .close = n7100_close, + .poll = n7100_poll, .transport_data = NULL, - .power_on = n7100_ipc_power_on, - .power_off = n7100_ipc_power_off, + .power_on = n7100_power_on, + .power_off = n7100_power_off, .power_data = NULL, .gprs_activate = NULL, .gprs_deactivate = NULL, .gprs_data = NULL, - .data_create = n7100_ipc_data_create, - .data_destroy = n7100_ipc_data_destroy, + .data_create = n7100_data_create, + .data_destroy = n7100_data_destroy, }; -struct ipc_gprs_specs n7100_ipc_gprs_specs = { - .gprs_get_iface = n7100_ipc_gprs_get_iface, - .gprs_get_capabilities = n7100_ipc_gprs_get_capabilities, +struct ipc_client_gprs_specs n7100_gprs_specs = { + .gprs_get_iface = xmm6260_sec_modem_gprs_get_iface, + .gprs_get_capabilities = xmm6260_sec_modem_gprs_get_capabilities, }; -struct ipc_nv_data_specs n7100_ipc_nv_data_specs = { +struct ipc_client_nv_data_specs n7100_nv_data_specs = { .nv_data_path = XMM6260_NV_DATA_PATH, .nv_data_md5_path = XMM6260_NV_DATA_MD5_PATH, .nv_data_backup_path = XMM6260_NV_DATA_BACKUP_PATH, diff --git a/samsung-ipc/devices/n7100/n7100_ipc.h b/samsung-ipc/devices/n7100/n7100.h index 0008627..5ffd353 100644 --- a/samsung-ipc/devices/n7100/n7100_ipc.h +++ b/samsung-ipc/devices/n7100/n7100.h @@ -17,8 +17,8 @@ * along with libsamsung-ipc. If not, see <http://www.gnu.org/licenses/>. */ -#ifndef __N7100_IPC_H__ -#define __N7100_IPC_H__ +#ifndef __N7100_H__ +#define __N7100_H__ #define N7100_MODEM_IMAGE_SIZE 0x1000000 #define N7100_PSI_OFFSET 0x1000 @@ -34,15 +34,15 @@ #define N7100_MODEM_IMAGE_DEVICE "/dev/block/mmcblk0p10" -struct n7100_ipc_transport_data { +struct n7100_transport_data { int fd; }; -extern struct ipc_ops n7100_ipc_fmt_ops; -extern struct ipc_ops n7100_ipc_rfs_ops; -extern struct ipc_handlers n7100_ipc_handlers; -extern struct ipc_gprs_specs n7100_ipc_gprs_specs; -extern struct ipc_nv_data_specs n7100_ipc_nv_data_specs; +extern struct ipc_client_ops n7100_fmt_ops; +extern struct ipc_client_ops n7100_rfs_ops; +extern struct ipc_client_handlers n7100_handlers; +extern struct ipc_client_gprs_specs n7100_gprs_specs; +extern struct ipc_client_nv_data_specs n7100_nv_data_specs; #endif |