diff options
| author | Chris Lattner <sabre@nondot.org> | 2009-11-23 17:07:35 +0000 |
|---|---|---|
| committer | Chris Lattner <sabre@nondot.org> | 2009-11-23 17:07:35 +0000 |
| commit | 4abfe40a9e41146760e8fdc2270abf60540b1e90 (patch) | |
| tree | 91e389f410a13731b4481fe156acd9a446fa3ba7 /lib/Analysis/BasicAliasAnalysis.cpp | |
| parent | 913c8adf87bf3584d4c9d2fd7ad8beb19e3fcf11 (diff) | |
| download | external_llvm-4abfe40a9e41146760e8fdc2270abf60540b1e90.zip external_llvm-4abfe40a9e41146760e8fdc2270abf60540b1e90.tar.gz external_llvm-4abfe40a9e41146760e8fdc2270abf60540b1e90.tar.bz2 | |
fix comment, thanks all :)
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@89666 91177308-0d34-0410-b5e6-96231b3b80d8
Diffstat (limited to 'lib/Analysis/BasicAliasAnalysis.cpp')
| -rw-r--r-- | lib/Analysis/BasicAliasAnalysis.cpp | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/lib/Analysis/BasicAliasAnalysis.cpp b/lib/Analysis/BasicAliasAnalysis.cpp index 32ca911..ff65e33 100644 --- a/lib/Analysis/BasicAliasAnalysis.cpp +++ b/lib/Analysis/BasicAliasAnalysis.cpp @@ -263,7 +263,9 @@ ImmutablePass *llvm::createBasicAliasAnalysisPass() { bool BasicAliasAnalysis::pointsToConstantMemory(const Value *P) { if (const GlobalVariable *GV = dyn_cast<GlobalVariable>(P->getUnderlyingObject())) - // FIXME: shouldn't this require GV to be "ODR"? + // Note: this doesn't require GV to be "ODR" because it isn't legal for a + // global to be marked constant in some modules and non-constant in others. + // GV may even be a declaration, not a definition. return GV->isConstant(); return false; } |