diff options
| author | Bill Wendling <isanbard@gmail.com> | 2013-08-06 22:52:42 +0000 |
|---|---|---|
| committer | Bill Wendling <isanbard@gmail.com> | 2013-08-06 22:52:42 +0000 |
| commit | 55a1a590bf0cadf88dfbef2aab6948ffec35c1c3 (patch) | |
| tree | c8d7a3fb9a7689831f8851c4675f675417e9dbd8 /test/Instrumentation/AddressSanitizer | |
| parent | 47cfec02842f885b46ea0d3c812793e660691640 (diff) | |
| download | external_llvm-55a1a590bf0cadf88dfbef2aab6948ffec35c1c3.zip external_llvm-55a1a590bf0cadf88dfbef2aab6948ffec35c1c3.tar.gz external_llvm-55a1a590bf0cadf88dfbef2aab6948ffec35c1c3.tar.bz2 | |
Change the linkage of these global values to 'internal'.
The globals being generated here were given the 'private' linkage type. However,
this caused them to end up in different sections with the wrong prefix. E.g.,
they would be in the __TEXT,__const section with an 'L' prefix instead of an 'l'
(lowercase ell) prefix.
The problem is that the linker will eat a literal label with 'L'. If a weak
symbol is then placed into the __TEXT,__const section near that literal, then it
cannot distinguish between the literal and the weak symbol.
Part of the problems here was introduced because the address sanitizer converted
some C strings into constant initializers with trailing nuls. (Thus putting them
in the __const section with the wrong prefix.) The others were variables that
the address sanitizer created but simply had the wrong linkage type.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@187827 91177308-0d34-0410-b5e6-96231b3b80d8
Diffstat (limited to 'test/Instrumentation/AddressSanitizer')
| -rw-r--r-- | test/Instrumentation/AddressSanitizer/do-not-instrument-internal-globals.ll | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/test/Instrumentation/AddressSanitizer/do-not-instrument-internal-globals.ll b/test/Instrumentation/AddressSanitizer/do-not-instrument-internal-globals.ll index 0928c49..d4fd93c 100644 --- a/test/Instrumentation/AddressSanitizer/do-not-instrument-internal-globals.ll +++ b/test/Instrumentation/AddressSanitizer/do-not-instrument-internal-globals.ll @@ -16,5 +16,5 @@ declare void @_Z3fooPi(i32*) ; We create one global string constant for the stack frame above. ; It should have unnamed_addr and align 1. ; Make sure we don't create any other global constants. -; CHECK: = private unnamed_addr constant{{.*}}align 1 -; CHECK-NOT: = private unnamed_addr constant +; CHECK: = internal unnamed_addr constant{{.*}}align 1 +; CHECK-NOT: = internal unnamed_addr constant |