aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
-rw-r--r--include/llvm/Support/BranchProbability.h28
-rw-r--r--unittests/Support/BlockFrequencyTest.cpp9
2 files changed, 27 insertions, 10 deletions
diff --git a/include/llvm/Support/BranchProbability.h b/include/llvm/Support/BranchProbability.h
index 6b83159..4b5d904 100644
--- a/include/llvm/Support/BranchProbability.h
+++ b/include/llvm/Support/BranchProbability.h
@@ -29,10 +29,6 @@ class BranchProbability {
// Denominator
uint32_t D;
- int64_t compare(BranchProbability RHS) const {
- return (uint64_t)N * RHS.D - (uint64_t)D * RHS.N;
- }
-
public:
BranchProbability(uint32_t n, uint32_t d) : N(n), D(d) {
assert(d > 0 && "Denomiator cannot be 0!");
@@ -54,12 +50,24 @@ public:
void dump() const;
- bool operator==(BranchProbability RHS) const { return compare(RHS) == 0; }
- bool operator!=(BranchProbability RHS) const { return compare(RHS) != 0; }
- bool operator< (BranchProbability RHS) const { return compare(RHS) < 0; }
- bool operator> (BranchProbability RHS) const { return compare(RHS) > 0; }
- bool operator<=(BranchProbability RHS) const { return compare(RHS) <= 0; }
- bool operator>=(BranchProbability RHS) const { return compare(RHS) >= 0; }
+ bool operator==(BranchProbability RHS) const {
+ return (uint64_t)N * RHS.D == (uint64_t)D * RHS.N;
+ }
+ bool operator!=(BranchProbability RHS) const {
+ return !(*this == RHS);
+ }
+ bool operator<(BranchProbability RHS) const {
+ return (uint64_t)N * RHS.D < (uint64_t)D * RHS.N;
+ }
+ bool operator>(BranchProbability RHS) const {
+ return RHS < *this;
+ }
+ bool operator<=(BranchProbability RHS) const {
+ return (uint64_t)N * RHS.D <= (uint64_t)D * RHS.N;
+ }
+ bool operator>=(BranchProbability RHS) const {
+ return RHS <= *this;
+ }
};
raw_ostream &operator<<(raw_ostream &OS, const BranchProbability &Prob);
diff --git a/unittests/Support/BlockFrequencyTest.cpp b/unittests/Support/BlockFrequencyTest.cpp
index ac3cedf..df25642 100644
--- a/unittests/Support/BlockFrequencyTest.cpp
+++ b/unittests/Support/BlockFrequencyTest.cpp
@@ -71,6 +71,15 @@ TEST(BlockFrequencyTest, ProbabilityCompare) {
EXPECT_TRUE(B > C);
EXPECT_FALSE(B <= C);
EXPECT_TRUE(B >= C);
+
+ BranchProbability BigZero(0, UINT32_MAX);
+ BranchProbability BigOne(UINT32_MAX, UINT32_MAX);
+ EXPECT_FALSE(BigZero == BigOne);
+ EXPECT_TRUE(BigZero != BigOne);
+ EXPECT_TRUE(BigZero < BigOne);
+ EXPECT_FALSE(BigZero > BigOne);
+ EXPECT_TRUE(BigZero <= BigOne);
+ EXPECT_FALSE(BigZero >= BigOne);
}
}