diff options
| -rw-r--r-- | lib/Target/SystemZ/SystemZInstrFormats.td | 18 | ||||
| -rw-r--r-- | lib/Target/SystemZ/SystemZInstrInfo.td | 6 | ||||
| -rw-r--r-- | test/CodeGen/SystemZ/and-01.ll | 3 | ||||
| -rw-r--r-- | test/CodeGen/SystemZ/and-07.ll | 21 | ||||
| -rw-r--r-- | test/CodeGen/SystemZ/atomicrmw-and-03.ll | 2 | ||||
| -rw-r--r-- | test/CodeGen/SystemZ/atomicrmw-nand-03.ll | 2 | ||||
| -rw-r--r-- | test/CodeGen/SystemZ/atomicrmw-or-03.ll | 2 | ||||
| -rw-r--r-- | test/CodeGen/SystemZ/atomicrmw-xor-03.ll | 2 | ||||
| -rw-r--r-- | test/CodeGen/SystemZ/or-01.ll | 3 | ||||
| -rw-r--r-- | test/CodeGen/SystemZ/or-07.ll | 21 | ||||
| -rw-r--r-- | test/CodeGen/SystemZ/xor-01.ll | 3 | ||||
| -rw-r--r-- | test/CodeGen/SystemZ/xor-07.ll | 21 | ||||
| -rw-r--r-- | test/MC/Disassembler/SystemZ/insns.txt | 18 | ||||
| -rw-r--r-- | test/MC/SystemZ/insn-bad.s | 15 | ||||
| -rw-r--r-- | test/MC/SystemZ/insn-good-z196.s | 36 |
15 files changed, 163 insertions, 10 deletions
diff --git a/lib/Target/SystemZ/SystemZInstrFormats.td b/lib/Target/SystemZ/SystemZInstrFormats.td index b030182..24f86bc 100644 --- a/lib/Target/SystemZ/SystemZInstrFormats.td +++ b/lib/Target/SystemZ/SystemZInstrFormats.td @@ -729,6 +729,24 @@ class BinaryRRF<string mnemonic, bits<16> opcode, SDPatternOperator operator, let OpType = "reg"; } +class BinaryRRFK<string mnemonic, bits<16> opcode, SDPatternOperator operator, + RegisterOperand cls1, RegisterOperand cls2> + : InstRRF<opcode, (outs cls1:$R1), (ins cls1:$R2, cls2:$R3), + mnemonic#"rk\t$R1, $R2, $R3", + [(set cls1:$R1, (operator cls1:$R2, cls2:$R3))]>; + +multiclass BinaryRRAndK<string mnemonic, bits<8> opcode1, bits<16> opcode2, + SDPatternOperator operator, RegisterOperand cls1, + RegisterOperand cls2> { + let NumOpsKey = mnemonic in { + let NumOpsValue = "3" in + def K : BinaryRRFK<mnemonic, opcode2, null_frag, cls1, cls2>, + Requires<[FeatureDistinctOps]>; + let NumOpsValue = "2", isConvertibleToThreeAddress = 1 in + def "" : BinaryRR<mnemonic, opcode1, operator, cls1, cls2>; + } +} + class BinaryRI<string mnemonic, bits<12> opcode, SDPatternOperator operator, RegisterOperand cls, Immediate imm> : InstRI<opcode, (outs cls:$R1), (ins cls:$R1src, imm:$I2), diff --git a/lib/Target/SystemZ/SystemZInstrInfo.td b/lib/Target/SystemZ/SystemZInstrInfo.td index 4670156..94b8a3e 100644 --- a/lib/Target/SystemZ/SystemZInstrInfo.td +++ b/lib/Target/SystemZ/SystemZInstrInfo.td @@ -648,7 +648,7 @@ let Defs = [CC], Uses = [CC] in { let Defs = [CC] in { // ANDs of a register. let isCommutable = 1 in { - def NR : BinaryRR <"n", 0x14, and, GR32, GR32>; + defm NR : BinaryRRAndK<"n", 0x14, 0xB9F4, and, GR32, GR32>; def NGR : BinaryRRE<"ng", 0xB980, and, GR64, GR64>; } @@ -685,7 +685,7 @@ defm : RMWIByte<and, bdaddr20pair, NIY>; let Defs = [CC] in { // ORs of a register. let isCommutable = 1 in { - def OR : BinaryRR <"o", 0x16, or, GR32, GR32>; + defm OR : BinaryRRAndK<"o", 0x16, 0xB9F6, or, GR32, GR32>; def OGR : BinaryRRE<"og", 0xB981, or, GR64, GR64>; } @@ -722,7 +722,7 @@ defm : RMWIByte<or, bdaddr20pair, OIY>; let Defs = [CC] in { // XORs of a register. let isCommutable = 1 in { - def XR : BinaryRR <"x", 0x17, xor, GR32, GR32>; + defm XR : BinaryRRAndK<"x", 0x17, 0xB9F7, xor, GR32, GR32>; def XGR : BinaryRRE<"xg", 0xB982, xor, GR64, GR64>; } diff --git a/test/CodeGen/SystemZ/and-01.ll b/test/CodeGen/SystemZ/and-01.ll index f893148..3b230ba 100644 --- a/test/CodeGen/SystemZ/and-01.ll +++ b/test/CodeGen/SystemZ/and-01.ll @@ -1,6 +1,7 @@ ; Test 32-bit ANDs in which the second operand is variable. ; -; RUN: llc < %s -mtriple=s390x-linux-gnu | FileCheck %s +; RUN: llc < %s -mtriple=s390x-linux-gnu -mcpu=z10 | FileCheck %s +; RUN: llc < %s -mtriple=s390x-linux-gnu -mcpu=z196 | FileCheck %s declare i32 @foo() diff --git a/test/CodeGen/SystemZ/and-07.ll b/test/CodeGen/SystemZ/and-07.ll new file mode 100644 index 0000000..2bdf97d --- /dev/null +++ b/test/CodeGen/SystemZ/and-07.ll @@ -0,0 +1,21 @@ +; Test the three-operand forms of AND. +; +; RUN: llc < %s -mtriple=s390x-linux-gnu -mcpu=z196 | FileCheck %s + +; Check NRK. +define i32 @f1(i32 %a, i32 %b, i32 %c) { +; CHECK-LABEL: f1: +; CHECK: nrk %r2, %r3, %r4 +; CHECK: br %r14 + %and = and i32 %b, %c + ret i32 %and +} + +; Check that we can still use NR in obvious cases. +define i32 @f2(i32 %a, i32 %b) { +; CHECK-LABEL: f2: +; CHECK: nr %r2, %r3 +; CHECK: br %r14 + %and = and i32 %a, %b + ret i32 %and +} diff --git a/test/CodeGen/SystemZ/atomicrmw-and-03.ll b/test/CodeGen/SystemZ/atomicrmw-and-03.ll index dd02828..6c7ba23 100644 --- a/test/CodeGen/SystemZ/atomicrmw-and-03.ll +++ b/test/CodeGen/SystemZ/atomicrmw-and-03.ll @@ -1,6 +1,6 @@ ; Test 32-bit atomic ANDs. ; -; RUN: llc < %s -mtriple=s390x-linux-gnu | FileCheck %s +; RUN: llc < %s -mtriple=s390x-linux-gnu -mcpu=z10 | FileCheck %s ; Check ANDs of a variable. define i32 @f1(i32 %dummy, i32 *%src, i32 %b) { diff --git a/test/CodeGen/SystemZ/atomicrmw-nand-03.ll b/test/CodeGen/SystemZ/atomicrmw-nand-03.ll index be306a2..c511bd6 100644 --- a/test/CodeGen/SystemZ/atomicrmw-nand-03.ll +++ b/test/CodeGen/SystemZ/atomicrmw-nand-03.ll @@ -1,6 +1,6 @@ ; Test 32-bit atomic NANDs. ; -; RUN: llc < %s -mtriple=s390x-linux-gnu | FileCheck %s +; RUN: llc < %s -mtriple=s390x-linux-gnu -mcpu=z10 | FileCheck %s ; Check NANDs of a variable. define i32 @f1(i32 %dummy, i32 *%src, i32 %b) { diff --git a/test/CodeGen/SystemZ/atomicrmw-or-03.ll b/test/CodeGen/SystemZ/atomicrmw-or-03.ll index 6386847..692b11c 100644 --- a/test/CodeGen/SystemZ/atomicrmw-or-03.ll +++ b/test/CodeGen/SystemZ/atomicrmw-or-03.ll @@ -1,6 +1,6 @@ ; Test 32-bit atomic ORs. ; -; RUN: llc < %s -mtriple=s390x-linux-gnu | FileCheck %s +; RUN: llc < %s -mtriple=s390x-linux-gnu -mcpu=z10 | FileCheck %s ; Check ORs of a variable. define i32 @f1(i32 %dummy, i32 *%src, i32 %b) { diff --git a/test/CodeGen/SystemZ/atomicrmw-xor-03.ll b/test/CodeGen/SystemZ/atomicrmw-xor-03.ll index 292de36..05754e7 100644 --- a/test/CodeGen/SystemZ/atomicrmw-xor-03.ll +++ b/test/CodeGen/SystemZ/atomicrmw-xor-03.ll @@ -1,6 +1,6 @@ ; Test 32-bit atomic XORs. ; -; RUN: llc < %s -mtriple=s390x-linux-gnu | FileCheck %s +; RUN: llc < %s -mtriple=s390x-linux-gnu -mcpu=z10 | FileCheck %s ; Check XORs of a variable. define i32 @f1(i32 %dummy, i32 *%src, i32 %b) { diff --git a/test/CodeGen/SystemZ/or-01.ll b/test/CodeGen/SystemZ/or-01.ll index ee0a392..23946d3 100644 --- a/test/CodeGen/SystemZ/or-01.ll +++ b/test/CodeGen/SystemZ/or-01.ll @@ -1,6 +1,7 @@ ; Test 32-bit ORs in which the second operand is variable. ; -; RUN: llc < %s -mtriple=s390x-linux-gnu | FileCheck %s +; RUN: llc < %s -mtriple=s390x-linux-gnu -mcpu=z10 | FileCheck %s +; RUN: llc < %s -mtriple=s390x-linux-gnu -mcpu=z196 | FileCheck %s declare i32 @foo() diff --git a/test/CodeGen/SystemZ/or-07.ll b/test/CodeGen/SystemZ/or-07.ll new file mode 100644 index 0000000..f6848a1 --- /dev/null +++ b/test/CodeGen/SystemZ/or-07.ll @@ -0,0 +1,21 @@ +; Test the three-operand forms of OR. +; +; RUN: llc < %s -mtriple=s390x-linux-gnu -mcpu=z196 | FileCheck %s + +; Check XRK. +define i32 @f1(i32 %a, i32 %b, i32 %c) { +; CHECK-LABEL: f1: +; CHECK: ork %r2, %r3, %r4 +; CHECK: br %r14 + %or = or i32 %b, %c + ret i32 %or +} + +; Check that we can still use OR in obvious cases. +define i32 @f2(i32 %a, i32 %b) { +; CHECK-LABEL: f2: +; CHECK: or %r2, %r3 +; CHECK: br %r14 + %or = or i32 %a, %b + ret i32 %or +} diff --git a/test/CodeGen/SystemZ/xor-01.ll b/test/CodeGen/SystemZ/xor-01.ll index f9ba2eb..185d6bb 100644 --- a/test/CodeGen/SystemZ/xor-01.ll +++ b/test/CodeGen/SystemZ/xor-01.ll @@ -1,6 +1,7 @@ ; Test 32-bit XORs in which the second operand is variable. ; -; RUN: llc < %s -mtriple=s390x-linux-gnu | FileCheck %s +; RUN: llc < %s -mtriple=s390x-linux-gnu -mcpu=z10 | FileCheck %s +; RUN: llc < %s -mtriple=s390x-linux-gnu -mcpu=z196 | FileCheck %s declare i32 @foo() diff --git a/test/CodeGen/SystemZ/xor-07.ll b/test/CodeGen/SystemZ/xor-07.ll new file mode 100644 index 0000000..22deef6 --- /dev/null +++ b/test/CodeGen/SystemZ/xor-07.ll @@ -0,0 +1,21 @@ +; Test the three-operand forms of XOR. +; +; RUN: llc < %s -mtriple=s390x-linux-gnu -mcpu=z196 | FileCheck %s + +; Check XRK. +define i32 @f1(i32 %a, i32 %b, i32 %c) { +; CHECK-LABEL: f1: +; CHECK: xrk %r2, %r3, %r4 +; CHECK: br %r14 + %xor = xor i32 %b, %c + ret i32 %xor +} + +; Check that we can still use XR in obvious cases. +define i32 @f2(i32 %a, i32 %b) { +; CHECK-LABEL: f2: +; CHECK: xr %r2, %r3 +; CHECK: br %r14 + %xor = xor i32 %a, %b + ret i32 %xor +} diff --git a/test/MC/Disassembler/SystemZ/insns.txt b/test/MC/Disassembler/SystemZ/insns.txt index 6f5e332..68d585a 100644 --- a/test/MC/Disassembler/SystemZ/insns.txt +++ b/test/MC/Disassembler/SystemZ/insns.txt @@ -4363,6 +4363,12 @@ # CHECK: nr %r7, %r8 0x14 0x78 +# CHECK: nrk %r0, %r0, %r0 +0xb9 0xf4 0x00 0x00 + +# CHECK: nrk %r2, %r3, %r4 +0xb9 0xf4 0x40 0x23 + # CHECK: n %r0, 0 0x54 0x00 0x00 0x00 @@ -4585,6 +4591,12 @@ # CHECK: or %r7, %r8 0x16 0x78 +# CHECK: ork %r0, %r0, %r0 +0xb9 0xf6 0x00 0x00 + +# CHECK: ork %r2, %r3, %r4 +0xb9 0xf6 0x40 0x23 + # CHECK: o %r0, 0 0x56 0x00 0x00 0x00 @@ -6190,6 +6202,12 @@ # CHECK: xr %r7, %r8 0x17 0x78 +# CHECK: xrk %r0, %r0, %r0 +0xb9 0xf7 0x00 0x00 + +# CHECK: xrk %r2, %r3, %r4 +0xb9 0xf7 0x40 0x23 + # CHECK: x %r0, 0 0x57 0x00 0x00 0x00 diff --git a/test/MC/SystemZ/insn-bad.s b/test/MC/SystemZ/insn-bad.s index 7c0f23a..ccc778d 100644 --- a/test/MC/SystemZ/insn-bad.s +++ b/test/MC/SystemZ/insn-bad.s @@ -1982,6 +1982,11 @@ niy 0, -1 niy 0, 256 +#CHECK: error: {{(instruction requires: distinct-ops)?}} +#CHECK: nrk %r2,%r3,%r4 + + nrk %r2,%r3,%r4 + #CHECK: error: invalid operand #CHECK: ny %r0, -524289 #CHECK: error: invalid operand @@ -2088,6 +2093,11 @@ oiy 0, -1 oiy 0, 256 +#CHECK: error: {{(instruction requires: distinct-ops)?}} +#CHECK: ork %r2,%r3,%r4 + + ork %r2,%r3,%r4 + #CHECK: error: invalid operand #CHECK: oy %r0, -524289 #CHECK: error: invalid operand @@ -2686,6 +2696,11 @@ xiy 0, -1 xiy 0, 256 +#CHECK: error: {{(instruction requires: distinct-ops)?}} +#CHECK: xrk %r2,%r3,%r4 + + xrk %r2,%r3,%r4 + #CHECK: error: invalid operand #CHECK: xy %r0, -524289 #CHECK: error: invalid operand diff --git a/test/MC/SystemZ/insn-good-z196.s b/test/MC/SystemZ/insn-good-z196.s index 28de0ee..9d64670 100644 --- a/test/MC/SystemZ/insn-good-z196.s +++ b/test/MC/SystemZ/insn-good-z196.s @@ -1,6 +1,30 @@ # For z196 and above. # RUN: llvm-mc -triple s390x-linux-gnu -mcpu=z196 -show-encoding %s | FileCheck %s +#CHECK: nrk %r0, %r0, %r0 # encoding: [0xb9,0xf4,0x00,0x00] +#CHECK: nrk %r0, %r0, %r15 # encoding: [0xb9,0xf4,0xf0,0x00] +#CHECK: nrk %r0, %r15, %r0 # encoding: [0xb9,0xf4,0x00,0x0f] +#CHECK: nrk %r15, %r0, %r0 # encoding: [0xb9,0xf4,0x00,0xf0] +#CHECK: nrk %r7, %r8, %r9 # encoding: [0xb9,0xf4,0x90,0x78] + + nrk %r0,%r0,%r0 + nrk %r0,%r0,%r15 + nrk %r0,%r15,%r0 + nrk %r15,%r0,%r0 + nrk %r7,%r8,%r9 + +#CHECK: ork %r0, %r0, %r0 # encoding: [0xb9,0xf6,0x00,0x00] +#CHECK: ork %r0, %r0, %r15 # encoding: [0xb9,0xf6,0xf0,0x00] +#CHECK: ork %r0, %r15, %r0 # encoding: [0xb9,0xf6,0x00,0x0f] +#CHECK: ork %r15, %r0, %r0 # encoding: [0xb9,0xf6,0x00,0xf0] +#CHECK: ork %r7, %r8, %r9 # encoding: [0xb9,0xf6,0x90,0x78] + + ork %r0,%r0,%r0 + ork %r0,%r0,%r15 + ork %r0,%r15,%r0 + ork %r15,%r0,%r0 + ork %r7,%r8,%r9 + #CHECK: sllk %r0, %r0, 0 # encoding: [0xeb,0x00,0x00,0x00,0x00,0xdf] #CHECK: sllk %r15, %r1, 0 # encoding: [0xeb,0xf1,0x00,0x00,0x00,0xdf] #CHECK: sllk %r1, %r15, 0 # encoding: [0xeb,0x1f,0x00,0x00,0x00,0xdf] @@ -78,3 +102,15 @@ srlk %r0,%r0,0(%r15) srlk %r0,%r0,524287(%r1) srlk %r0,%r0,524287(%r15) + +#CHECK: xrk %r0, %r0, %r0 # encoding: [0xb9,0xf7,0x00,0x00] +#CHECK: xrk %r0, %r0, %r15 # encoding: [0xb9,0xf7,0xf0,0x00] +#CHECK: xrk %r0, %r15, %r0 # encoding: [0xb9,0xf7,0x00,0x0f] +#CHECK: xrk %r15, %r0, %r0 # encoding: [0xb9,0xf7,0x00,0xf0] +#CHECK: xrk %r7, %r8, %r9 # encoding: [0xb9,0xf7,0x90,0x78] + + xrk %r0,%r0,%r0 + xrk %r0,%r0,%r15 + xrk %r0,%r15,%r0 + xrk %r15,%r0,%r0 + xrk %r7,%r8,%r9 |
