From 9a3d293cf3f72b3c0ed5d4474fc5d4d12fd36be2 Mon Sep 17 00:00:00 2001 From: Devang Patel Date: Tue, 17 Jan 2012 19:08:07 +0000 Subject: Intel syntax: Do not unncessarily create plus expression for memory operand displacement. git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@148321 91177308-0d34-0410-b5e6-96231b3b80d8 --- lib/Target/X86/AsmParser/X86AsmParser.cpp | 3 +-- test/MC/X86/intel-syntax.s | 2 ++ 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/lib/Target/X86/AsmParser/X86AsmParser.cpp b/lib/Target/X86/AsmParser/X86AsmParser.cpp index d974069..c3f6563 100644 --- a/lib/Target/X86/AsmParser/X86AsmParser.cpp +++ b/lib/Target/X86/AsmParser/X86AsmParser.cpp @@ -634,8 +634,7 @@ X86Operand *X86AsmParser::ParseIntelBracExpression(unsigned Size) { Scale = Val; } else if (getLexer().is(AsmToken::RBrac)) { const MCExpr *ValExpr = MCConstantExpr::Create(Val, getContext()); - Disp = isPlus ? MCUnaryExpr::CreatePlus(ValExpr, getContext()) : - MCUnaryExpr::CreateMinus(ValExpr, getContext()); + Disp = isPlus ? ValExpr : MCUnaryExpr::CreateMinus(ValExpr, getContext()); } else return ErrorOperand(PlusLoc, "unexpected token after +"); } diff --git a/test/MC/X86/intel-syntax.s b/test/MC/X86/intel-syntax.s index 2a54b32..2966dd7 100644 --- a/test/MC/X86/intel-syntax.s +++ b/test/MC/X86/intel-syntax.s @@ -7,6 +7,8 @@ _test: _main: // CHECK: movl $257, -4(%rsp) mov DWORD PTR [RSP - 4], 257 +// CHECK: movl $258, 4(%rsp) + mov DWORD PTR [RSP + 4], 258 // CHECK: movq $123, -16(%rsp) mov QWORD PTR [RSP - 16], 123 // CHECK: movb $97, -17(%rsp) -- cgit v1.1