From c09324483cf8c8904b7250f072d8f64e9b00656e Mon Sep 17 00:00:00 2001 From: Richard Trieu Date: Fri, 28 Jun 2013 21:54:25 +0000 Subject: Fix broken asserts that never fire. Change assert("text") to assert(0 && "text"). The first case is a const char * to bool conversion, which always evaluates to true, never triggering the assert. The second case will always trigger the assert. git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@185227 91177308-0d34-0410-b5e6-96231b3b80d8 --- include/llvm/TableGen/Record.h | 4 ++-- lib/Target/Hexagon/InstPrinter/HexagonInstPrinter.cpp | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/include/llvm/TableGen/Record.h b/include/llvm/TableGen/Record.h index a07898a..5bf4f4f 100644 --- a/include/llvm/TableGen/Record.h +++ b/include/llvm/TableGen/Record.h @@ -1799,9 +1799,9 @@ struct LessRecordRegister { unsigned LHSVal, RHSVal; if (LHSPart.second.getAsInteger(10, LHSVal)) - assert("Unable to convert LHS to integer."); + assert(0 && "Unable to convert LHS to integer."); if (RHSPart.second.getAsInteger(10, RHSVal)) - assert("Unable to convert RHS to integer."); + assert(0 && "Unable to convert RHS to integer."); if (LHSVal != RHSVal) return LHSVal < RHSVal; } diff --git a/lib/Target/Hexagon/InstPrinter/HexagonInstPrinter.cpp b/lib/Target/Hexagon/InstPrinter/HexagonInstPrinter.cpp index 36da6df..3105665 100644 --- a/lib/Target/Hexagon/InstPrinter/HexagonInstPrinter.cpp +++ b/lib/Target/Hexagon/InstPrinter/HexagonInstPrinter.cpp @@ -179,7 +179,7 @@ void HexagonInstPrinter::printBranchOperand(const MCInst *MI, unsigned OpNo, raw_ostream &O) const { // Branches can take an immediate operand. This is used by the branch // selection pass to print $+8, an eight byte displacement from the PC. - assert("Unknown branch operand."); + assert(0 && "Unknown branch operand."); } void HexagonInstPrinter::printCallOperand(const MCInst *MI, unsigned OpNo, @@ -203,7 +203,7 @@ void HexagonInstPrinter::printSymbol(const MCInst *MI, unsigned OpNo, O << '#'; printOperand(MI, OpNo, O); } else { - assert("Unknown symbol operand"); + assert(0 && "Unknown symbol operand"); printOperand(MI, OpNo, O); } O << ')'; -- cgit v1.1