From 6c6237f8dce6787e550a3e243e22a085a2859fe8 Mon Sep 17 00:00:00 2001 From: Jim Grosbach Date: Wed, 22 Aug 2012 22:19:40 +0000 Subject: MCInstFragment constructor should take by-reference MCInst. The MCInst is immediately passed to the copy-constructor for local storage, so there's no need for the parameter itself to be by-value. git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@162404 91177308-0d34-0410-b5e6-96231b3b80d8 --- include/llvm/MC/MCAssembler.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'include/llvm/MC/MCAssembler.h') diff --git a/include/llvm/MC/MCAssembler.h b/include/llvm/MC/MCAssembler.h index b7b2d66..6965e34 100644 --- a/include/llvm/MC/MCAssembler.h +++ b/include/llvm/MC/MCAssembler.h @@ -176,7 +176,7 @@ public: typedef SmallVectorImpl::iterator fixup_iterator; public: - MCInstFragment(MCInst _Inst, MCSectionData *SD = 0) + MCInstFragment(const MCInst &_Inst, MCSectionData *SD = 0) : MCFragment(FT_Inst, SD), Inst(_Inst) { } -- cgit v1.1 From 1df46c36b6142d50acfa21063a6e682e7f055e8e Mon Sep 17 00:00:00 2001 From: Lang Hames Date: Thu, 23 Aug 2012 07:00:48 +0000 Subject: Make the setInst method take its MCInst parameter by reference, a la Jim's change in r162404. git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@162431 91177308-0d34-0410-b5e6-96231b3b80d8 --- include/llvm/MC/MCAssembler.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'include/llvm/MC/MCAssembler.h') diff --git a/include/llvm/MC/MCAssembler.h b/include/llvm/MC/MCAssembler.h index 6965e34..d2b5c80 100644 --- a/include/llvm/MC/MCAssembler.h +++ b/include/llvm/MC/MCAssembler.h @@ -191,7 +191,7 @@ public: MCInst &getInst() { return Inst; } const MCInst &getInst() const { return Inst; } - void setInst(MCInst Value) { Inst = Value; } + void setInst(const MCInst& Value) { Inst = Value; } /// @} /// @name Fixup Access -- cgit v1.1 From 1f7210e808373fa92be3a2d4fa653a6f79d5088b Mon Sep 17 00:00:00 2001 From: Craig Topper Date: Wed, 29 Aug 2012 06:28:46 +0000 Subject: Make use of the LLVM_DELETED_FUNCTION macro. git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@162828 91177308-0d34-0410-b5e6-96231b3b80d8 --- include/llvm/MC/MCAssembler.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'include/llvm/MC/MCAssembler.h') diff --git a/include/llvm/MC/MCAssembler.h b/include/llvm/MC/MCAssembler.h index d2b5c80..ac0ee18 100644 --- a/include/llvm/MC/MCAssembler.h +++ b/include/llvm/MC/MCAssembler.h @@ -40,8 +40,8 @@ class MCAsmBackend; class MCFragment : public ilist_node { friend class MCAsmLayout; - MCFragment(const MCFragment&); // DO NOT IMPLEMENT - void operator=(const MCFragment&); // DO NOT IMPLEMENT + MCFragment(const MCFragment&) LLVM_DELETED_FUNCTION; + void operator=(const MCFragment&) LLVM_DELETED_FUNCTION; public: enum FragmentType { -- cgit v1.1