From 539a4bf4b587e7aa334888bfb1145f1c7adf63f3 Mon Sep 17 00:00:00 2001 From: Chris Lattner Date: Fri, 7 Sep 2001 16:29:18 +0000 Subject: You no longer have to delete constants! They are located in a global constant pool instead of in local ones. Change bool handling to prevent modification of bool values git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@436 91177308-0d34-0410-b5e6-96231b3b80d8 --- lib/VMCore/ConstantFolding.h | 30 +++++++++++------------------- 1 file changed, 11 insertions(+), 19 deletions(-) (limited to 'lib/VMCore/ConstantFolding.h') diff --git a/lib/VMCore/ConstantFolding.h b/lib/VMCore/ConstantFolding.h index 501f726..453c3e8 100644 --- a/lib/VMCore/ConstantFolding.h +++ b/lib/VMCore/ConstantFolding.h @@ -12,10 +12,8 @@ // //===----------------------------------------------------------------------===// // -// WARNING: These operators return pointers to newly 'new'd objects. You MUST -// make sure to free them if you don't want them hanging around. Also, -// note that these may return a null object if I don't know how to -// perform those operations on the specified constant types. +// WARNING: These operators may return a null object if I don't know how to +// perform the specified operation on the specified constant types. // //===----------------------------------------------------------------------===// // @@ -42,13 +40,18 @@ namespace opt { //===----------------------------------------------------------------------===// -// Implement == directly... +// Implement == and != directly... //===----------------------------------------------------------------------===// inline ConstPoolBool *operator==(const ConstPoolVal &V1, const ConstPoolVal &V2) { assert(V1.getType() == V2.getType() && "Constant types must be identical!"); - return new ConstPoolBool(V1.equals(&V2)); + return ConstPoolBool::get(&V1 == &V2); +} + +inline ConstPoolBool *operator!=(const ConstPoolVal &V1, + const ConstPoolVal &V2) { + return ConstPoolBool::get(&V1 != &V2); } //===----------------------------------------------------------------------===// @@ -156,25 +159,14 @@ inline ConstPoolBool *operator>(const ConstPoolVal &V1, return V2 < V1; } -inline ConstPoolBool *operator!=(const ConstPoolVal &V1, - const ConstPoolVal &V2) { - ConstPoolBool *Result = V1 == V2; - Result->setValue(!Result->getValue()); // Invert value - return Result; // !(V1 == V2) -} - inline ConstPoolBool *operator>=(const ConstPoolVal &V1, const ConstPoolVal &V2) { - ConstPoolBool *Result = V1 < V2; - Result->setValue(!Result->getValue()); // Invert value - return Result; // !(V1 < V2) + return (V1 < V2)->inverted(); // !(V1 < V2) } inline ConstPoolBool *operator<=(const ConstPoolVal &V1, const ConstPoolVal &V2) { - ConstPoolBool *Result = V1 > V2; - Result->setValue(!Result->getValue()); // Invert value - return Result; // !(V1 > V2) + return (V1 > V2)->inverted(); // !(V1 > V2) } -- cgit v1.1