From 2f9c3b002d3cb465fefc5f4b2535ca994c5e9283 Mon Sep 17 00:00:00 2001 From: Devang Patel Date: Thu, 23 Jul 2009 02:00:51 +0000 Subject: MDString - Rename member function size(). New name is length(). - Store string beginning and length. Earlier it used to store string end. git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@76841 91177308-0d34-0410-b5e6-96231b3b80d8 --- lib/VMCore/AsmWriter.cpp | 4 ++-- lib/VMCore/LLVMContext.cpp | 6 +++--- lib/VMCore/LLVMContextImpl.cpp | 11 ++++++----- lib/VMCore/LLVMContextImpl.h | 2 +- 4 files changed, 12 insertions(+), 11 deletions(-) (limited to 'lib/VMCore') diff --git a/lib/VMCore/AsmWriter.cpp b/lib/VMCore/AsmWriter.cpp index ae55d5b..73310a3 100644 --- a/lib/VMCore/AsmWriter.cpp +++ b/lib/VMCore/AsmWriter.cpp @@ -1139,7 +1139,7 @@ static void WriteAsOperandInternal(raw_ostream &Out, const Value *V, if (const MDString *MDS = dyn_cast(V)) { Out << "!\""; - PrintEscapedString(MDS->begin(), MDS->size(), Out); + PrintEscapedString(MDS->begin(), MDS->length(), Out); Out << '"'; return; } @@ -1983,7 +1983,7 @@ void Value::print(raw_ostream &OS, AssemblyAnnotationWriter *AAW) const { TypePrinter.print(MDS->getType(), OS); OS << ' '; OS << "!\""; - PrintEscapedString(MDS->begin(), MDS->size(), OS); + PrintEscapedString(MDS->begin(), MDS->length(), OS); OS << '"'; } else if (const MDNode *N = dyn_cast(this)) { SlotTracker SlotTable(N); diff --git a/lib/VMCore/LLVMContext.cpp b/lib/VMCore/LLVMContext.cpp index c88ecba..d0abb2d 100644 --- a/lib/VMCore/LLVMContext.cpp +++ b/lib/VMCore/LLVMContext.cpp @@ -551,12 +551,12 @@ MDNode* LLVMContext::getMDNode(Value* const* Vals, unsigned NumVals) { } // MDString accessors -MDString* LLVMContext::getMDString(const char *StrBegin, const char *StrEnd) { - return pImpl->getMDString(StrBegin, StrEnd); +MDString* LLVMContext::getMDString(const char *StrBegin, unsigned StrLength) { + return pImpl->getMDString(StrBegin, StrLength); } MDString* LLVMContext::getMDString(const std::string &Str) { - return getMDString(Str.data(), Str.data()+Str.size()); + return getMDString(Str.data(), Str.size()); } // FunctionType accessors diff --git a/lib/VMCore/LLVMContextImpl.cpp b/lib/VMCore/LLVMContextImpl.cpp index 8ad46a0..79b33c1 100644 --- a/lib/VMCore/LLVMContextImpl.cpp +++ b/lib/VMCore/LLVMContextImpl.cpp @@ -394,13 +394,13 @@ ConstantFP *LLVMContextImpl::getConstantFP(const APFloat &V) { } MDString *LLVMContextImpl::getMDString(const char *StrBegin, - const char *StrEnd) { + unsigned StrLength) { sys::SmartScopedWriter Writer(ConstantsLock); - StringMapEntry &Entry = MDStringCache.GetOrCreateValue( - StrBegin, StrEnd); + StringMapEntry &Entry = + MDStringCache.GetOrCreateValue(StrBegin, StrBegin + StrLength); MDString *&S = Entry.getValue(); if (!S) S = new MDString(Entry.getKeyData(), - Entry.getKeyData() + Entry.getKeyLength()); + Entry.getKeyLength()); return S; } @@ -460,7 +460,8 @@ Constant *LLVMContextImpl::getConstantArray(const ArrayType *Ty, void LLVMContextImpl::erase(MDString *M) { sys::SmartScopedWriter Writer(ConstantsLock); - MDStringCache.erase(MDStringCache.find(M->StrBegin, M->StrEnd)); + MDStringCache.erase(MDStringCache.find(M->StrBegin, + M->StrBegin + M->length())); } void LLVMContextImpl::erase(MDNode *M) { diff --git a/lib/VMCore/LLVMContextImpl.h b/lib/VMCore/LLVMContextImpl.h index 03f0e7b..392e500 100644 --- a/lib/VMCore/LLVMContextImpl.h +++ b/lib/VMCore/LLVMContextImpl.h @@ -133,7 +133,7 @@ public: ConstantFP *getConstantFP(const APFloat &V); - MDString *getMDString(const char *StrBegin, const char *StrEnd); + MDString *getMDString(const char *StrBegin, unsigned StrLength); MDNode *getMDNode(Value*const* Vals, unsigned NumVals); -- cgit v1.1