From a7b7a7d629c3101f6f6c87e6848e865734e0238c Mon Sep 17 00:00:00 2001 From: Reid Kleckner Date: Mon, 18 Nov 2013 23:08:12 +0000 Subject: Revert "COFF: Emit all MCSymbols rather than filtering out some of them" This reverts commit r190888, to fix PR17967. The original change wasn't the right way to get @feat.00 into the object file. The right fix is to make @feat.00 be a global symbol. git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@195053 91177308-0d34-0410-b5e6-96231b3b80d8 --- test/MC/COFF/alias.s | 11 +---------- test/MC/COFF/feat00.s | 1 + test/MC/COFF/lset0.s | 12 ++++++++++++ 3 files changed, 14 insertions(+), 10 deletions(-) create mode 100755 test/MC/COFF/lset0.s (limited to 'test/MC') diff --git a/test/MC/COFF/alias.s b/test/MC/COFF/alias.s index 98ef7e5..f6f6d46 100644 --- a/test/MC/COFF/alias.s +++ b/test/MC/COFF/alias.s @@ -45,15 +45,6 @@ weak_aliased_to_external = external2 // CHECK-NEXT: AuxSymbolCount: 0 // CHECK-NEXT: } // CHECK-NEXT: Symbol { -// CHECK-NEXT: Name: external_aliased_to_local -// CHECK-NEXT: Value: 0 -// CHECK-NEXT: Section: .text (1) -// CHECK-NEXT: BaseType: Null (0x0) -// CHECK-NEXT: ComplexType: Null (0x0) -// CHECK-NEXT: StorageClass: Static (0x3) -// CHECK-NEXT: AuxSymbolCount: 0 -// CHECK-NEXT: } -// CHECK-NEXT: Symbol { // CHECK-NEXT: Name: global_aliased_to_external // CHECK-NEXT: Value: 0 // CHECK-NEXT: Section: (0) @@ -98,7 +89,7 @@ weak_aliased_to_external = external2 // CHECK-NEXT: StorageClass: WeakExternal (0x69) // CHECK-NEXT: AuxSymbolCount: 1 // CHECK-NEXT: AuxWeakExternal { -// CHECK-NEXT: Linked: external2 (10) +// CHECK-NEXT: Linked: external2 (9) // CHECK-NEXT: Search: Library (0x2) // CHECK-NEXT: Unused: (00 00 00 00 00 00 00 00 00 00) // CHECK-NEXT: } diff --git a/test/MC/COFF/feat00.s b/test/MC/COFF/feat00.s index b8862de..d08f407 100644 --- a/test/MC/COFF/feat00.s +++ b/test/MC/COFF/feat00.s @@ -1,6 +1,7 @@ // RUN: llvm-mc -filetype=obj -triple i686-pc-win32 %s -o - | llvm-readobj -t | FileCheck %s "@feat.00" = 123 +.globl @feat.00 // CHECK: Symbol { // CHECK: Name: @feat.00 diff --git a/test/MC/COFF/lset0.s b/test/MC/COFF/lset0.s new file mode 100755 index 0000000..f5020c8 --- /dev/null +++ b/test/MC/COFF/lset0.s @@ -0,0 +1,12 @@ +// RUN: llvm-mc -filetype=obj -triple i686-pc-win32 %s -o - | llvm-nm | FileCheck %s + +not_global = 123 +global = 456 +.globl global +.Llocal = 789 + +// CHECK-NOT: not_global +// CHECK-NOT: Llocal +// CHECK: global +// CHECK-NOT: not_global +// CHECK-NOT: Llocal -- cgit v1.1