From 16e4ed5879da57502ea3686c79c63f86994fbe75 Mon Sep 17 00:00:00 2001 From: Matt Arsenault Date: Wed, 31 Jul 2013 17:49:08 +0000 Subject: Reject bitcasts between address spaces with different sizes git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@187506 91177308-0d34-0410-b5e6-96231b3b80d8 --- .../bitcast-address-space-nested-global-cycle.ll | 8 ++++++++ test/Verifier/bitcast-address-space-nested-global.ll | 11 +++++++++++ ...-through-constant-inttoptr-inside-gep-instruction.ll | 10 ++++++++++ .../bitcast-address-space-through-constant-inttoptr.ll | 11 +++++++++++ test/Verifier/bitcast-address-space-through-gep-2.ll | 17 +++++++++++++++++ test/Verifier/bitcast-address-space-through-gep.ll | 13 +++++++++++++ test/Verifier/bitcast-address-space-through-inttoptr.ll | 9 +++++++++ test/Verifier/bitcast-address-spaces.ll | 9 +++++++++ test/Verifier/bitcast-vector-pointer-as.ll | 9 +++++++++ 9 files changed, 97 insertions(+) create mode 100644 test/Verifier/bitcast-address-space-nested-global-cycle.ll create mode 100644 test/Verifier/bitcast-address-space-nested-global.ll create mode 100644 test/Verifier/bitcast-address-space-through-constant-inttoptr-inside-gep-instruction.ll create mode 100644 test/Verifier/bitcast-address-space-through-constant-inttoptr.ll create mode 100644 test/Verifier/bitcast-address-space-through-gep-2.ll create mode 100644 test/Verifier/bitcast-address-space-through-gep.ll create mode 100644 test/Verifier/bitcast-address-space-through-inttoptr.ll create mode 100644 test/Verifier/bitcast-address-spaces.ll create mode 100644 test/Verifier/bitcast-vector-pointer-as.ll (limited to 'test/Verifier') diff --git a/test/Verifier/bitcast-address-space-nested-global-cycle.ll b/test/Verifier/bitcast-address-space-nested-global-cycle.ll new file mode 100644 index 0000000..0cee726 --- /dev/null +++ b/test/Verifier/bitcast-address-space-nested-global-cycle.ll @@ -0,0 +1,8 @@ +; RUN: not llvm-as -verify -disable-output %s + +target datalayout = "e-p:32:32:32-p1:16:16:16-p2:8:8:8-i1:8:32-i8:8:32-i16:16:32-i32:32:32-i64:32:64-f32:32:32-f64:32:64-v64:32:64-v128:32:128-a0:0:32-n8:16:32" + +%struct.Self1 = type { %struct.Self1 addrspace(1)* } + +@cycle1 = addrspace(1) constant %struct.Self1 { %struct.Self1 addrspace(1)* bitcast (%struct.Self1 addrspace(0)* @cycle0 to %struct.Self1 addrspace(1)*) } +@cycle0 = addrspace(0) constant %struct.Self1 { %struct.Self1 addrspace(1)* @cycle1 } diff --git a/test/Verifier/bitcast-address-space-nested-global.ll b/test/Verifier/bitcast-address-space-nested-global.ll new file mode 100644 index 0000000..abe9d94 --- /dev/null +++ b/test/Verifier/bitcast-address-space-nested-global.ll @@ -0,0 +1,11 @@ +; RUN: not llvm-as -verify -disable-output %s + +target datalayout = "e-p:32:32:32-p1:16:16:16-p2:8:8:8-i1:8:32-i8:8:32-i16:16:32-i32:32:32-i64:32:64-f32:32:32-f64:32:64-v64:32:64-v128:32:128-a0:0:32-n8:16:32" + + +%struct.Self1 = type { %struct.Self1 addrspace(1)* } + +@nestedD = constant %struct.Self1 { %struct.Self1 addrspace(1)* bitcast (%struct.Self1 addrspace(0)* @nestedC to %struct.Self1 addrspace(1)*) } +@nestedC = constant %struct.Self1 { %struct.Self1 addrspace(1)* bitcast (%struct.Self1 addrspace(0)* @nestedB to %struct.Self1 addrspace(1)*) } +@nestedB = constant %struct.Self1 { %struct.Self1 addrspace(1)* bitcast (%struct.Self1 addrspace(0)* @nestedA to %struct.Self1 addrspace(1)*) } +@nestedA = constant %struct.Self1 { %struct.Self1 addrspace(1)* null } diff --git a/test/Verifier/bitcast-address-space-through-constant-inttoptr-inside-gep-instruction.ll b/test/Verifier/bitcast-address-space-through-constant-inttoptr-inside-gep-instruction.ll new file mode 100644 index 0000000..ed71afa --- /dev/null +++ b/test/Verifier/bitcast-address-space-through-constant-inttoptr-inside-gep-instruction.ll @@ -0,0 +1,10 @@ +; RUN: not llvm-as -verify -disable-output < %s +target datalayout = "e-p:32:32:32-p1:16:16:16-p2:8:8:8-i1:8:32-i8:8:32-i16:16:32-i32:32:32-i64:32:64-f32:32:32-f64:32:64-v64:32:64-v128:32:128-a0:0:32-n8:16:32" + +; Check that we can find inttoptr -> illegal bitcasts when hidden +; inside constantexpr pointer operands +define i32 addrspace(2)* @illegal_bitcast_inttoptr_as_1_to_2_inside_gep() { + %cast = getelementptr i32 addrspace(2)* bitcast (i32 addrspace(1)* inttoptr (i32 1234 to i32 addrspace(1)*) to i32 addrspace(2)*), i32 3 + ret i32 addrspace(2)* %cast +} + diff --git a/test/Verifier/bitcast-address-space-through-constant-inttoptr.ll b/test/Verifier/bitcast-address-space-through-constant-inttoptr.ll new file mode 100644 index 0000000..e65c71e --- /dev/null +++ b/test/Verifier/bitcast-address-space-through-constant-inttoptr.ll @@ -0,0 +1,11 @@ +; RUN: not llvm-as -verify -disable-output %s + +target datalayout = "e-p:32:32:32-p1:16:16:16-p2:8:8:8-i1:8:32-i8:8:32-i16:16:32-i32:32:32-i64:32:64-f32:32:32-f64:32:64-v64:32:64-v128:32:128-a0:0:32-n8:16:32" + + +%struct.Foo = type { i32 addrspace(1)* } + +; Make sure we still reject the bitcast when the source is a inttoptr (constant int) in a global initializer +@bitcast_after_constant_inttoptr_initializer = global %struct.Foo { i32 addrspace(1)* bitcast (i32 addrspace(2)* inttoptr (i8 7 to i32 addrspace(2)*) to i32 addrspace(1)*) } + + diff --git a/test/Verifier/bitcast-address-space-through-gep-2.ll b/test/Verifier/bitcast-address-space-through-gep-2.ll new file mode 100644 index 0000000..3b77d9a --- /dev/null +++ b/test/Verifier/bitcast-address-space-through-gep-2.ll @@ -0,0 +1,17 @@ +; RUN: not llvm-as -verify -disable-output %s + +target datalayout = "e-p:32:32:32-p1:16:16:16-p2:8:8:8-p3:8:8:8-i1:8:32-i8:8:32-i16:16:32-i32:32:32-i64:32:64-f32:32:32-f64:32:64-v64:32:64-v128:32:128-a0:0:32-n8:16:32" + + +%struct.Foo1 = type { i32 addrspace(1)* } + +@as2_array = addrspace(2) global [32 x i32] zeroinitializer + +; gep -> legal bitcast (2 -> 3) -> gep -> illegal bitcast (3 -> 1) +@bitcast_after_gep_bitcast_gep = + global %struct.Foo1 { i32 addrspace(1)* bitcast + (i32 addrspace(3)* getelementptr + (i32 addrspace(3)* bitcast + (i32 addrspace(2)* getelementptr + ([32 x i32] addrspace(2)* @as2_array, i32 0, i32 8) to i32 addrspace(3)*), i32 3) to i32 addrspace(1)*) } + diff --git a/test/Verifier/bitcast-address-space-through-gep.ll b/test/Verifier/bitcast-address-space-through-gep.ll new file mode 100644 index 0000000..8e950dc --- /dev/null +++ b/test/Verifier/bitcast-address-space-through-gep.ll @@ -0,0 +1,13 @@ +; RUN: not llvm-as -verify -disable-output %s + +target datalayout = "e-p:32:32:32-p1:16:16:16-p2:8:8:8-i1:8:32-i8:8:32-i16:16:32-i32:32:32-i64:32:64-f32:32:32-f64:32:64-v64:32:64-v128:32:128-a0:0:32-n8:16:32" + +%struct.Foo = type { i32 addrspace(1)* } + + +@as2_array = addrspace(2) global [32 x i32] zeroinitializer + +; Make sure we still reject the bitcast after the value is accessed through a GEP +@bitcast_after_gep = global %struct.Foo { i32 addrspace(1)* bitcast (i32 addrspace(2)* getelementptr ([32 x i32] addrspace(2)* @as2_array, i32 0, i32 8) to i32 addrspace(1)*) } + + diff --git a/test/Verifier/bitcast-address-space-through-inttoptr.ll b/test/Verifier/bitcast-address-space-through-inttoptr.ll new file mode 100644 index 0000000..bec4048 --- /dev/null +++ b/test/Verifier/bitcast-address-space-through-inttoptr.ll @@ -0,0 +1,9 @@ +; RUN: not llvm-as -verify -disable-output %s + +target datalayout = "e-p:32:32:32-p1:16:16:16-p2:8:8:8-i1:8:32-i8:8:32-i16:16:32-i32:32:32-i64:32:64-f32:32:32-f64:32:64-v64:32:64-v128:32:128-a0:0:32-n8:16:32" + +define i32 addrspace(2)* @illegal_bitcast_as_1_to_2_inttoptr() { + %cast = bitcast i32 addrspace(1)* inttoptr (i32 5 to i32 addrspace(1)*) to i32 addrspace(2)* + ret i32 addrspace(2)* %cast +} + diff --git a/test/Verifier/bitcast-address-spaces.ll b/test/Verifier/bitcast-address-spaces.ll new file mode 100644 index 0000000..4508417 --- /dev/null +++ b/test/Verifier/bitcast-address-spaces.ll @@ -0,0 +1,9 @@ +; RUN: not llvm-as -verify -disable-output %s + +target datalayout = "e-p:32:32:32-p1:16:16:16-p2:32:32:32-i1:8:32-i8:8:32-i16:16:32-i32:32:32-i64:32:64-f32:32:32-f64:32:64-v64:32:64-v128:32:128-a0:0:32-n8:16:32" + +define i32 addrspace(1)* @illegal_bitcast_as_0_to_1(i32 addrspace(0) *%p) { + %cast = bitcast i32 addrspace(0)* %p to i32 addrspace(1)* + ret i32 addrspace(1)* %cast +} + diff --git a/test/Verifier/bitcast-vector-pointer-as.ll b/test/Verifier/bitcast-vector-pointer-as.ll new file mode 100644 index 0000000..89070e5 --- /dev/null +++ b/test/Verifier/bitcast-vector-pointer-as.ll @@ -0,0 +1,9 @@ +; RUN: not llvm-as -verify -disable-output %s + +target datalayout = "e-p:32:32:32-p1:16:16:16-p2:32:32:32-i1:8:32-i8:8:32-i16:16:32-i32:32:32-i64:32:64-f32:32:32-f64:32:64-v64:32:64-v128:32:128-a0:0:32-n8:16:32" + +define <4 x i32 addrspace(1)*> @vector_illegal_bitcast_as_0_to_1(<4 x i32 addrspace(0)*> %p) { + %cast = bitcast <4 x i32 addrspace(0)*> %p to <4 x i32 addrspace(1)*> + ret <4 x i32 addrspace(1)*> %cast +} + -- cgit v1.1