From ae94e594164b193236002516970aeec4c4574768 Mon Sep 17 00:00:00 2001 From: Evan Cheng Date: Fri, 5 Dec 2008 01:06:39 +0000 Subject: Re-did 60519. It turns out Darwin's handling of hidden visibility symbols are a bit more complicate than I expected. Both declarations and weak definitions still need a stub indirection. However, the stubs are in data section and they contain the addresses of the actual symbols. git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@60571 91177308-0d34-0410-b5e6-96231b3b80d8 --- test/CodeGen/PowerPC/hidden-vis-2.ll | 12 ++++++++++++ test/CodeGen/PowerPC/hidden-vis.ll | 9 +++++++++ test/CodeGen/X86/hidden-vis-2.ll | 1 - test/CodeGen/X86/hidden-vis-3.ll | 15 +++++++++++++++ test/CodeGen/X86/hidden-vis-4.ll | 11 +++++++++++ 5 files changed, 47 insertions(+), 1 deletion(-) create mode 100644 test/CodeGen/PowerPC/hidden-vis-2.ll create mode 100644 test/CodeGen/PowerPC/hidden-vis.ll create mode 100644 test/CodeGen/X86/hidden-vis-3.ll create mode 100644 test/CodeGen/X86/hidden-vis-4.ll (limited to 'test') diff --git a/test/CodeGen/PowerPC/hidden-vis-2.ll b/test/CodeGen/PowerPC/hidden-vis-2.ll new file mode 100644 index 0000000..4c9ae55 --- /dev/null +++ b/test/CodeGen/PowerPC/hidden-vis-2.ll @@ -0,0 +1,12 @@ +; RUN: llvm-as < %s | llc -mtriple=powerpc-apple-darwin9 | grep non_lazy_ptr | count 6 + +@x = external hidden global i32 ; [#uses=1] +@y = extern_weak hidden global i32 ; [#uses=1] + +define i32 @t() nounwind readonly { +entry: + %0 = load i32* @x, align 4 ; [#uses=1] + %1 = load i32* @y, align 4 ; [#uses=1] + %2 = add i32 %1, %0 ; [#uses=1] + ret i32 %2 +} diff --git a/test/CodeGen/PowerPC/hidden-vis.ll b/test/CodeGen/PowerPC/hidden-vis.ll new file mode 100644 index 0000000..e04c89a --- /dev/null +++ b/test/CodeGen/PowerPC/hidden-vis.ll @@ -0,0 +1,9 @@ +; RUN: llvm-as < %s | llc -mtriple=powerpc-apple-darwin9 | not grep non_lazy_ptr + +@x = weak hidden global i32 0 ; [#uses=1] + +define i32 @t() nounwind readonly { +entry: + %0 = load i32* @x, align 4 ; [#uses=1] + ret i32 %0 +} diff --git a/test/CodeGen/X86/hidden-vis-2.ll b/test/CodeGen/X86/hidden-vis-2.ll index 4df1c1c..e000547 100644 --- a/test/CodeGen/X86/hidden-vis-2.ll +++ b/test/CodeGen/X86/hidden-vis-2.ll @@ -1,6 +1,5 @@ ; RUN: llvm-as < %s | llc -mtriple=i386-apple-darwin9 | grep mov | count 1 ; RUN: llvm-as < %s | llc -mtriple=x86_64-apple-darwin9 | not grep GOT -; XFAIL: * @x = weak hidden global i32 0 ; [#uses=1] diff --git a/test/CodeGen/X86/hidden-vis-3.ll b/test/CodeGen/X86/hidden-vis-3.ll new file mode 100644 index 0000000..81dc76e --- /dev/null +++ b/test/CodeGen/X86/hidden-vis-3.ll @@ -0,0 +1,15 @@ +; RUN: llvm-as < %s | llc -mtriple=i386-apple-darwin9 | grep mov | count 3 +; RUN: llvm-as < %s | llc -mtriple=i386-apple-darwin9 | grep non_lazy_ptr +; RUN: llvm-as < %s | llc -mtriple=i386-apple-darwin9 | grep long | count 2 +; RUN: llvm-as < %s | llc -mtriple=x86_64-apple-darwin9 | not grep GOT + +@x = external hidden global i32 ; [#uses=1] +@y = extern_weak hidden global i32 ; [#uses=1] + +define i32 @t() nounwind readonly { +entry: + %0 = load i32* @x, align 4 ; [#uses=1] + %1 = load i32* @y, align 4 ; [#uses=1] + %2 = add i32 %1, %0 ; [#uses=1] + ret i32 %2 +} diff --git a/test/CodeGen/X86/hidden-vis-4.ll b/test/CodeGen/X86/hidden-vis-4.ll new file mode 100644 index 0000000..e6936de --- /dev/null +++ b/test/CodeGen/X86/hidden-vis-4.ll @@ -0,0 +1,11 @@ +; RUN: llvm-as < %s | llc -mtriple=i386-apple-darwin9 | grep non_lazy_ptr +; RUN: llvm-as < %s | llc -mtriple=i386-apple-darwin9 | grep long +; RUN: llvm-as < %s | llc -mtriple=i386-apple-darwin9 | grep comm + +@x = common hidden global i32 0 ; [#uses=1] + +define i32 @t() nounwind readonly { +entry: + %0 = load i32* @x, align 4 ; [#uses=1] + ret i32 %0 +} -- cgit v1.1