From b7f27824fb63210a67040affd43a82890b6784fb Mon Sep 17 00:00:00 2001 From: Chandler Carruth Date: Wed, 24 Jul 2013 12:12:17 +0000 Subject: Fix a problem I introduced in r187029 where we would over-eagerly schedule an alloca for another iteration in SROA. This only showed up with a mixture of promotable and unpromotable selects and phis. Added a test case for this. git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@187031 91177308-0d34-0410-b5e6-96231b3b80d8 --- test/Transforms/SROA/phi-and-select.ll | 37 ++++++++++++++++++++++++++++++++++ 1 file changed, 37 insertions(+) (limited to 'test') diff --git a/test/Transforms/SROA/phi-and-select.ll b/test/Transforms/SROA/phi-and-select.ll index 9f2b191..8d82964 100644 --- a/test/Transforms/SROA/phi-and-select.ll +++ b/test/Transforms/SROA/phi-and-select.ll @@ -346,6 +346,43 @@ exit: ret i32 %load } +define i32 @test14(i1 %b1, i1 %b2, i32* %ptr) { +; Check for problems when there are both selects and phis and one is +; speculatable toward promotion but the other is not. That should block all of +; the speculation. +; CHECK-LABEL: @test14( +; CHECK: alloca +; CHECK: alloca +; CHECK: select +; CHECK: phi +; CHECK: phi +; CHECK: select +; CHECK: ret i32 + +entry: + %f = alloca i32 + %g = alloca i32 + store i32 0, i32* %f + store i32 0, i32* %g + %f.select = select i1 %b1, i32* %f, i32* %ptr + br i1 %b2, label %then, label %else + +then: + br label %exit + +else: + br label %exit + +exit: + %f.phi = phi i32* [ %f, %then ], [ %f.select, %else ] + %g.phi = phi i32* [ %g, %then ], [ %ptr, %else ] + %f.loaded = load i32* %f.phi + %g.select = select i1 %b1, i32* %g, i32* %g.phi + %g.loaded = load i32* %g.select + %result = add i32 %f.loaded, %g.loaded + ret i32 %result +} + define i32 @PR13905() { ; Check a pattern where we have a chain of dead phi nodes to ensure they are ; deleted and promotion can proceed. -- cgit v1.1