From 2ab0ca36c155cc77e3d5c950270c70a24efee3d3 Mon Sep 17 00:00:00 2001 From: Brian Paul Date: Tue, 26 May 2015 11:30:22 -0600 Subject: docs: add information about reviewing patches Reviewed-by: Matt Turner --- docs/devinfo.html | 25 +++++++++++++++++++++++++ 1 file changed, 25 insertions(+) (limited to 'docs/devinfo.html') diff --git a/docs/devinfo.html b/docs/devinfo.html index f5113b0..eb3aba1 100644 --- a/docs/devinfo.html +++ b/docs/devinfo.html @@ -266,6 +266,31 @@ re-sending the whole series). Using --in-reply-to makes it harder for reviewers to accidentally review old patches.

+

Reviewing Patches

+ +

+When you've reviewed a patch on the mailing list, please be unambiguous +about your review. That is, state either +

+    Reviewed-by: Joe Hacker <jhacker@foo.com>
+
+or +
+    Acked-by: Joe Hacker <jhacker@foo.com>
+
+Rather than saying just "LGTM" or "Seems OK". +

+ +

+If small changes are suggested, it's OK to say something like: +

+   With the above fixes, Reviewed-by: Joe Hacker <jhacker@foo.com>
+
+which tells the patch author that the patch can be committed, as long +as the issues are resolved first. +

+ +

Marking a commit as a candidate for a stable branch

-- cgit v1.1