aboutsummaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* [PFW] Fix display error when using getConfigurationParameter with ↵Frédéric Boisnard2014-02-121-3/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | BooleanParameters BZ: 96140 When using getConfigurationParameter on a BooleanParameter, the displayed value is duplicated on the output if the configuration is applicable. The method CParameterMgr::accessConfigurationValue() accesses the element twice when the configuration is the last one applied (in order to update the parameter value in both the configuration blackboard and the main blackboard). The output result is managed using a string passed as reference to ParameterMgr::accessValue() and then to CBooleanParameterType::fromBlackboard(). In the latest method, the boolean value is appended to the output string, however no check is performed to make sure that the string is empty before being used. As the method is called twice with the same output string, we end up with a dupplicated output. This fix updates CBooleanParameterType::fromBlackboard() in order to make sure that the output string is overwritten with the current result. Change-Id: I394366910b1ddc0c8bbe570aa357e007745613db Signed-off-by: Frédéric Boisnard <fredericx.boisnard@intel.com> Reviewed-on: http://android.intel.com:8080/98648 Reviewed-by: cactus <cactus@intel.com> Reviewed-by: Denneulin, Guillaume <guillaume.denneulin@intel.com> Reviewed-by: Benavoli, Patrick <patrick.benavoli@intel.com> Reviewed-by: Gonzalve, Sebastien <sebastien.gonzalve@intel.com> Tested-by: Barthes, FabienX <fabienx.barthes@intel.com> Reviewed-by: buildbot <buildbot@intel.com> Tested-by: buildbot <buildbot@intel.com>
* [PFW] Fix issue when setting a parameter of a configuration not applicableFrédéric Boisnard2014-02-123-14/+35
| | | | | | | | | | | | | | | | | | | | | BZ: 93374 This patch aims to fix an issue when using the command setConfigurationParameter to update the value of a parameter of a configuration. The autosync shall be turned off when updating the value of a parameter in a configuration that is not currently applicable. Change-Id: I12f9d37e544dc7b54f1bed0470783fdfc8568b7c Signed-off-by: Frédéric Boisnard <fredericx.boisnard@intel.com> Reviewed-on: http://android.intel.com:8080/96832 Reviewed-by: cactus <cactus@intel.com> Reviewed-by: Gonzalve, Sebastien <sebastien.gonzalve@intel.com> Reviewed-by: Denneulin, Guillaume <guillaume.denneulin@intel.com> Reviewed-by: De Chivre, Renaud <renaud.de.chivre@intel.com> Reviewed-by: Benavoli, Patrick <patrick.benavoli@intel.com> Tested-by: Dixon, CharlesX <charlesx.dixon@intel.com> Reviewed-by: buildbot <buildbot@intel.com> Tested-by: buildbot <buildbot@intel.com>
* PFW: Define generic __unused macroKevin Rocard2014-02-121-0/+28
| | | | | | | | | | | | | BZ: 83641 Change-Id: Ifb809946e955de50e50949506dff2f83ff34f568 Signed-off-by: Kevin Rocard <kevinx.rocard@intel.com> Reviewed-on: http://android.intel.com:8080/95601 Reviewed-by: Gonzalve, Sebastien <sebastien.gonzalve@intel.com> Reviewed-by: cactus <cactus@intel.com> Tested-by: Dixon, CharlesX <charlesx.dixon@intel.com> Reviewed-by: buildbot <buildbot@intel.com> Tested-by: buildbot <buildbot@intel.com>
* [PFW] Access Configurations directlyFrédéric Boisnard2014-02-1210-11/+257
| | | | | | | | | | | | | | | | | | | | | BZ: 88357 This patch aims to enable direct access to Configurations without using the main blackboard. 2 additional commands are available: - getConfigurationParameter <domain> <configuration> <param path>: Get value for parameter at given path from configuration. - setConfigurationParameter <domain> <configuration> <param path> <value> Set value for parameter at given path to configuration. Change-Id: I9357ba5141feee558fa3f7c10f62db14406433b6 Signed-off-by: Frédéric Boisnard <fredericx.boisnard@intel.com> Reviewed-on: http://android.intel.com:8080/92325 Reviewed-by: cactus <cactus@intel.com> Reviewed-by: Gonzalve, Sebastien <sebastien.gonzalve@intel.com> Tested-by: Dixon, CharlesX <charlesx.dixon@intel.com> Reviewed-by: buildbot <buildbot@intel.com> Tested-by: buildbot <buildbot@intel.com>
* [PFW] Take into account base offset when accessing value of parametersFrédéric Boisnard2014-02-128-34/+37
| | | | | | | | | | | | | | | | | | | BZ: 88357 This patch aims to offer the possibility of accessing the value of parameters from a Configuration blackboard instead of Main blackboard. The read/write operation is now relative to the base offset of the ancestor element associated to the Configuration. The base offset is stored in the ParameterAccessContext. Change-Id: I158df63d2ef3bd8cbacb84b7d2f51723ed1074f5 Signed-off-by: Frédéric Boisnard <fredericx.boisnard@intel.com> Reviewed-on: http://android.intel.com:8080/93671 Reviewed-by: cactus <cactus@intel.com> Reviewed-by: Dixon, CharlesX <charlesx.dixon@intel.com> Tested-by: Dixon, CharlesX <charlesx.dixon@intel.com> Reviewed-by: buildbot <buildbot@intel.com> Tested-by: buildbot <buildbot@intel.com>
* PFW: [coverage] Support new log syntax & error handlingKevin Rocard2014-02-121-43/+62
| | | | | | | | | | | | | | | | | | | | BZ: 86781 Support of last change criterion syntax log, - old log line: Selection criterion changed event: (.*) = (.*) - new log line: Selection criterion changed event: Criterion name: (.*), current state: (.*) Change-Id: I626ca7e5dd6deb34fda041a6e9448012b7db62e1 Signed-off-by: Kevin Rocard <kevinx.rocard@intel.com> Reviewed-on: http://android.intel.com:8080/91820 Reviewed-by: Wagner, David <david.wagner@intel.com> Reviewed-by: Gonzalve, Sebastien <sebastien.gonzalve@intel.com> Tested-by: Barthes, FabienX <fabienx.barthes@intel.com> Reviewed-by: buildbot <buildbot@intel.com> Tested-by: buildbot <buildbot@intel.com>
* Exposes API to dump inclusive criteriaFrancois Gaffie2014-02-122-1/+2
| | | | | | | | | | | | | | | | | | | | BZ: 83285 To avoid implement in route manager an helper function to dump inclusive criteria, expose an already existing API through the CriterionTypeInterface. Signed-off-by: Francois Gaffie <francois.gaffie@intel.com> Change-Id: Ib500f23872fd4da47c5d17666f75708e1627f749 Reviewed-on: http://android.intel.com:8080/90783 Reviewed-by: Gaffie, Francois <francois.gaffie@intel.com> Reviewed-by: Denneulin, Guillaume <guillaume.denneulin@intel.com> Reviewed-by: Centelles, Sylvain <sylvain.centelles@intel.com> Reviewed-by: Rocard, KevinX <kevinx.rocard@intel.com> Tested-by: Dixon, CharlesX <charlesx.dixon@intel.com> Reviewed-by: buildbot <buildbot@intel.com> Tested-by: buildbot <buildbot@intel.com>
* PFW: Support .pfw argument in lightRoutingUpdate.shKevin Rocard2014-02-121-16/+30
| | | | | | | | | | | | | | | | BZ: 86003 Adding an argument to lightRoutingUpdate.sh will overwrite the environement variable "PFWtest_DomainFile". Change-Id: Ia7447b9cb0d774bd91ec310874c0e6531ec0ea38 Signed-off-by: Kevin Rocard <kevinx.rocard@intel.com> Reviewed-on: http://android.intel.com:8080/90087 Reviewed-by: Gonzalve, Sebastien <sebastien.gonzalve@intel.com> Reviewed-by: cactus <cactus@intel.com> Tested-by: Dixon, CharlesX <charlesx.dixon@intel.com> Reviewed-by: buildbot <buildbot@intel.com> Tested-by: buildbot <buildbot@intel.com>
* PFW: Correct log level coverage scriptKevin Rocard2014-02-121-13/+31
| | | | | | | | | | | | | | BZ: 85983 Restrict debug log print to debug log level. Change-Id: I78bb79909502035247f410e9900a560190ee0ad5 Signed-off-by: Kevin Rocard <kevinx.rocard@intel.com> Reviewed-on: http://android.intel.com:8080/90085 Reviewed-by: Centelles, Sylvain <sylvain.centelles@intel.com> Tested-by: Dixon, CharlesX <charlesx.dixon@intel.com> Reviewed-by: buildbot <buildbot@intel.com> Tested-by: buildbot <buildbot@intel.com>
* PFW: Correct truncated criterion logKevin Rocard2014-02-123-4/+16
| | | | | | | | | | | | | | | | | | | | | | BZ: 85746 Create a log fonction to log a string table. Use it to call the log function for each criterion. Context: When the PFW starts, it logs the criteria, their states and possible values. All criterion logs where concatenate in a string and logged. But if there is a lot of criteria, the 512 chars long log buffer might be overfload and the log is truncated. Change-Id: I72c89b25de9314b714763b3ac71a7d0cb9698910 Signed-off-by: Kevin Rocard <kevinx.rocard@intel.com> Reviewed-on: http://android.intel.com:8080/90089 Reviewed-by: Gonzalve, Sebastien <sebastien.gonzalve@intel.com> Tested-by: Dixon, CharlesX <charlesx.dixon@intel.com> Reviewed-by: buildbot <buildbot@intel.com> Tested-by: buildbot <buildbot@intel.com>
* sortAsound.conf.sh do not handle spacesFrédéric Boisnard2014-02-121-1/+1
| | | | | | | | | | | | | | | | | | BZ: 85879 This patch fixes a small bug in the sortAsound.conf.sh script, now it is allowed to have multiple spaces around the property 'value' for a hook in the asound.conf file. Change-Id: Iad3e51d4d56c371b5f7d57f333013f23d840a645 Signed-off-by: Frédéric Boisnard <fredericx.boisnard@intel.com> Reviewed-on: http://android.intel.com:8080/90959 Reviewed-by: cactus <cactus@intel.com> Reviewed-by: Denneulin, Guillaume <guillaume.denneulin@intel.com> Reviewed-by: Rocard, KevinX <kevinx.rocard@intel.com> Reviewed-by: Gonzalve, Sebastien <sebastien.gonzalve@intel.com> Tested-by: Dixon, CharlesX <charlesx.dixon@intel.com> Reviewed-by: buildbot <buildbot@intel.com> Tested-by: buildbot <buildbot@intel.com>
* PFW: Add licence header in coverage toolKevin Rocard2014-02-121-0/+20
| | | | | | | | | | | | | | | | | | | | BZ: 85983 Add a copyright header to the xml coverage generator script, coverage.py : INTEL CONFIDENTIAL Copyright 2013 Intel Corporation All Rights Reserved. ... Change-Id: I8a5efd67fd3a0603c50a05318f7aec8277689630 Signed-off-by: Kevin Rocard <kevinx.rocard@intel.com> Reviewed-on: http://android.intel.com:8080/91036 Reviewed-by: Gonzalve, Sebastien <sebastien.gonzalve@intel.com> Reviewed-by: cactus <cactus@intel.com> Tested-by: Dixon, CharlesX <charlesx.dixon@intel.com> Reviewed-by: buildbot <buildbot@intel.com> Tested-by: buildbot <buildbot@intel.com>
* PFW: Wrong rule order in generated xml fileKevin Rocard2014-02-121-10/+12
| | | | | | | | | | | | | | | | | | | | BZ: 85553 The xml generator was inverting inherited rule, this patch corrects it. Rules are now ordered in the inheritance order. Rule inherited from high level element are now at the beginning of the rule list. It is only a cosmetic change a functional change. Change-Id: I5c718a93d24c64ec690377915a98404823cf8fba Signed-off-by: Kevin Rocard <kevinx.rocard@intel.com> Reviewed-on: http://android.intel.com:8080/90354 Reviewed-by: cactus <cactus@intel.com> Reviewed-by: Centelles, Sylvain <sylvain.centelles@intel.com> Reviewed-by: Denneulin, Guillaume <guillaume.denneulin@intel.com> Tested-by: Dixon, CharlesX <charlesx.dixon@intel.com> Reviewed-by: buildbot <buildbot@intel.com> Tested-by: buildbot <buildbot@intel.com>
* Add a getter for belonging subsystem in subsystem objectsGuillaume Denneulin2014-02-122-0/+9
| | | | | | | | | | | | | | | BZ: 66692 Sometimes, subsystem object need to know their belonging subsystem. Change-Id: Ia1b8c8c3756179a87b542fc0fe52f6f0097299b6 Signed-off-by: Guillaume Denneulin <guillaume.denneulin@intel.com> Reviewed-on: http://android.intel.com:8080/87951 Reviewed-by: Soulard, Mathieu <mathieu.soulard@intel.com> Reviewed-by: Centelles, Sylvain <sylvain.centelles@intel.com> Tested-by: Dixon, CharlesX <charlesx.dixon@intel.com> Reviewed-by: buildbot <buildbot@intel.com> Tested-by: buildbot <buildbot@intel.com>
* PFW: Test scripts & XML generator scriptsKevin Rocard2014-02-127-0/+1850
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | BZ: 80506 This patch adds scripts to generate and test PFW domain XML. tools/xmlGenerator provides script to generate PFW domains from XML: - updateRoutageDomains.sh update the domains of the connected board with the provided .pfw file. - lightRoutingUpdate.sh is a light version of updateRoutageDomains.sh it does not need test-platform but needs a board with a properly configure PFW (typicaly the hal pfw). - analyse provide script to convert asound.conf to domains test/test-scripts provides scripts to instanciate a test platform (virtal hal) and simulate the route manager routing steps: - */*_envsetup.sh is a list of environement configation file. Source the file corresponding to your situation. - test-routing.sh allow the user to simulate different routing use cases. Change-Id: I00931a3b0868496c36ba1ad298ed89e07582dd61 Signed-off-by: Kevin Rocard <kevinx.rocard@intel.com> Reviewed-on: http://android.intel.com:8080/67268 Reviewed-by: Boisnard, FredericX <fredericx.boisnard@intel.com> Reviewed-by: De Chivre, Renaud <renaud.de.chivre@intel.com> Tested-by: Dixon, CharlesX <charlesx.dixon@intel.com> Reviewed-by: buildbot <buildbot@intel.com> Tested-by: buildbot <buildbot@intel.com>
* PFW: Back synchronisation no longer failsKevin Rocard2014-02-126-14/+7
| | | | | | | | | | | | | | | | | | | | | | BZ: 80500 As forward synchronisation, back synchronisation no longer return false if a syncer fails to backsynchronise. On subsystem restart, it will be resynchronise, so the back synchronisation failure is a warning not an error. As a result this patch also prevents PFW initialisation failure in case of unavailable subsystem. Change-Id: I21fe05747153a63cb77ed784532f3cbbf184d820 Signed-off-by: Kevin Rocard <kevinx.rocard@intel.com> Reviewed-on: http://android.intel.com:8080/87779 Reviewed-by: De Chivre, Renaud <renaud.de.chivre@intel.com> Tested-by: Dixon, CharlesX <charlesx.dixon@intel.com> Reviewed-by: Benavoli, Patrick <patrick.benavoli@intel.com> Reviewed-by: cactus <cactus@intel.com> Tested-by: cactus <cactus@intel.com>
* PFW: XML coverage tool for domains and criterionsKevin Rocard2014-02-121-0/+913
| | | | | | | | | | | | | | | BZ: 77959 Add a python3 script to generate a PFW setting/configuration/citerion coverage report in XML from the PFW log. Change-Id: I013b033aa8414431d892bc953d9584f78ff44cd0 Reviewed-on: http://android.intel.com:8080/81831 Reviewed-by: Rocard, KevinX <kevinx.rocard@intel.com> Reviewed-by: Centelles, Sylvain <sylvain.centelles@intel.com> Tested-by: Dixon, CharlesX <charlesx.dixon@intel.com> Reviewed-by: cactus <cactus@intel.com> Tested-by: cactus <cactus@intel.com>
* PFW: Revert "PFW: Add log on criterion creation"Kevin Rocard2014-02-121-6/+0
| | | | | | | | | | | | | | | | BZ: 77959 This reverts commit with change-Id: I76c5cb596df1d20af48f0df03015c4be90cd5d96. Logging the criterion should be done on PFW start. If not it requires the criterion type not to change until start. Change-Id: If3d6faeffe72938bc920e28f6dfccccb530a1dee Signed-off-by: Kevin Rocard <kevinx.rocard@intel.com> Reviewed-on: http://android.intel.com:8080/81830 Reviewed-by: Centelles, Sylvain <sylvain.centelles@intel.com> Tested-by: Dixon, CharlesX <charlesx.dixon@intel.com> Reviewed-by: cactus <cactus@intel.com> Tested-by: cactus <cactus@intel.com>
* PFW: Log criterion state at PFW startKevin Rocard2014-02-128-33/+76
| | | | | | | | | | | | | | | BZ: 77959 The PFW will log criterion patch state at start before appling configuration. Change-Id: I4ac3676b9ba685c1e226a8495ffdbe98f0c08219 Signed-off-by: Kevin Rocard <kevinx.rocard@intel.com> Reviewed-on: http://android.intel.com:8080/79965 Reviewed-by: De Chivre, Renaud <renaud.de.chivre@intel.com> Tested-by: Dixon, CharlesX <charlesx.dixon@intel.com> Reviewed-by: cactus <cactus@intel.com> Tested-by: cactus <cactus@intel.com>
* PFW: Add resync mechanism if a subsystem needs resyncGuillaume Denneulin2014-02-1213-50/+136
| | | | | | | | | | | | | | | | | | | BZ: 76267 In the case of a hw subsystems reset, it's possible that its parameter managed by the PFW may not be aligned with the PFW blackboard. A re-synchronization mechanism is implemented to ensure that the subsystem is re-synchronized on the next configurations application. Change-Id: I032150955d25a7020cf494e69456897b4c157916 Signed-off-by: Guillaume Denneulin <guillaume.denneulin@intel.com> Reviewed-on: http://android.intel.com:8080/83015 Reviewed-by: Rocard, KevinX <kevinx.rocard@intel.com> Reviewed-by: Centelles, Sylvain <sylvain.centelles@intel.com> Tested-by: Dixon, CharlesX <charlesx.dixon@intel.com> Reviewed-by: cactus <cactus@intel.com> Tested-by: cactus <cactus@intel.com>
* PFW: Do not stop on hard sync errorsKevin Rocard2014-02-1234-171/+317
| | | | | | | | | | | | | | | | BZ: 76263 When synchronization fails, the parameter-framework should log a warning and continue synchronization instead of stopping Change-Id: Ic12d8798ea25584db714ee26e644fac793c28881 Signed-off-by: Kevin Rocard <kevinx.rocard@intel.com> Reviewed-on: http://android.intel.com:8080/81825 Reviewed-by: Centelles, Sylvain <sylvain.centelles@intel.com> Reviewed-by: Denneulin, Guillaume <guillaume.denneulin@intel.com> Tested-by: Dixon, CharlesX <charlesx.dixon@intel.com> Reviewed-by: cactus <cactus@intel.com> Tested-by: cactus <cactus@intel.com>
* PFW: Improve login in PFW core and amixer pluginKevin Rocard2014-02-124-44/+56
| | | | | | | | | | | | | | | | | | | | BZ: 71914 Autolog adds a nesting log level. It is not always needed. For example in a Debug context a lot of log can be expected, so this level is useful but not otherwise. Autolog nesting is now optional. Add log during PFW structure loading. Change-Id: I24e1f615e3032c70a3b8b85a1cc1804dc49b631c Origin-Change-Id: I1f2c6c843e17595d4a81c1d2dfbff30d4187cdf8 Signed-off-by: Kevin Rocard <kevinx.rocard@intel.com> Reviewed-on: http://android.intel.com:8080/81269 Reviewed-by: Barthes, FabienX <fabienx.barthes@intel.com> Tested-by: Barthes, FabienX <fabienx.barthes@intel.com> Reviewed-by: cactus <cactus@intel.com> Tested-by: cactus <cactus@intel.com>
* PFW: Add log on criterion creationKevin Rocard2014-02-121-0/+6
| | | | | | | | | | | | | | | | BZ: 71914 Initial criterion state and posible values are needed for criterion coverage. Change-Id: Id6058376fc64eb4e523fe0badffc09a7f4238f6c Origin-Change-Id: I76c5cb596df1d20af48f0df03015c4be90cd5d96 Signed-off-by: Kevin Rocard <kevinx.rocard@intel.com> Reviewed-on: http://android.intel.com:8080/81268 Reviewed-by: Barthes, FabienX <fabienx.barthes@intel.com> Tested-by: Barthes, FabienX <fabienx.barthes@intel.com> Reviewed-by: cactus <cactus@intel.com> Tested-by: cactus <cactus@intel.com>
* PFW: Correct test-platform compilationKevin Rocard2014-02-122-12/+14
| | | | | | | | | | | | | | | | | | BZ: 67916 Add libstlport in test-plaform's Android.mk. Add a Android.mk that includes test-plaform/Android.mk in the test directory be able to compile test-platform from the source root (m test-platform). Change-Id: I878c4010aa8be4f9de0c4dd6666b9f512e26a309 Origin-Change-Id: Ieeb3bc7e908a2b35f0e0603917b80343a75259e8 Signed-off-by: Kevin Rocard <kevinx.rocard@intel.com> Reviewed-on: http://android.intel.com:8080/76889 Reviewed-by: Barthes, FabienX <fabienx.barthes@intel.com> Tested-by: Barthes, FabienX <fabienx.barthes@intel.com> Reviewed-by: cactus <cactus@intel.com> Tested-by: cactus <cactus@intel.com>
* PFW: Prevent crash if subsystem structure missingFrédéric Boisnard2014-02-124-3/+27
| | | | | | | | | | | | | | | | | | | BZ: 62524 If the XML file defining a subsystem is missing, the PFW crashes without any message. This patch fixes this issue. Change-Id: Ibc0e9d195a8207d41d25613f56d1c9740bf6c784 Signed-off-by: Frédéric Boisnard <fredericx.boisnard@intel.com> Reviewed-on: http://android.intel.com:8080/70698 Reviewed-by: Denneulin, Guillaume <guillaume.denneulin@intel.com> Reviewed-by: Rocard, KevinX <kevinx.rocard@intel.com> Reviewed-by: Centelles, Sylvain <sylvain.centelles@intel.com> Reviewed-by: Baron, Georges-henriX <georges-henrix.baron@intel.com> Tested-by: Dixon, CharlesX <charlesx.dixon@intel.com> Reviewed-by: buildbot <buildbot@intel.com> Tested-by: buildbot <buildbot@intel.com>
* PFW: Report error for unknown element in settingsGeorges-Henri Baron2014-02-121-4/+2
| | | | | | | | | | | | | | | | | BZ: 62872 Report error if an element that doesn't exist is part of the settings xml description. Change-Id: I936519a0f28a2fd7a3b9e089c08ec12f0fe6c641 Signed-off-by: Georges-Henri Baron <georges-henrix.baron@intel.com> Signed-off-by: Frédéric Boisnard <fredericx.boisnard@intel.com> Reviewed-on: http://android.intel.com:8080/70474 Reviewed-by: Denneulin, Guillaume <guillaume.denneulin@intel.com> Reviewed-by: De Chivre, Renaud <renaud.de.chivre@intel.com> Tested-by: Dixon, CharlesX <charlesx.dixon@intel.com> Reviewed-by: buildbot <buildbot@intel.com> Tested-by: buildbot <buildbot@intel.com>
* PFW: Do not check data sign when access blackboardFrédéric Boisnard2014-02-121-24/+0
| | | | | | | | | | | | | | | | | BZ: 61532 In the toBlackboard() and fromBlackboard() methods of the class CIntegerParameterType, checks are performed to ensure that the requested kind of data is the same as the kind of data stored. A client should be allowed to retrieve a signed integer as an unsigned integer. Change-Id: Iabc018dd74dedc6e959d7e976afbea043b327ac8 Signed-off-by: Frédéric Boisnard <fredericx.boisnard@intel.com> Reviewed-on: http://android.intel.com:8080/69640 Reviewed-by: Benavoli, Patrick <patrick.benavoli@intel.com> Reviewed-by: De Chivre, Renaud <renaud.de.chivre@intel.com> Tested-by: Dixon, CharlesX <charlesx.dixon@intel.com> Tested-by: Barthes, FabienX <fabienx.barthes@intel.com> Reviewed-by: buildbot <buildbot@intel.com> Tested-by: buildbot <buildbot@intel.com>
* Allow 64bits bitParameterBlocksGuillaume Denneulin2014-02-128-35/+50
| | | | | | | | | | | | | | | BZ: 59348 bitParameterBlocks are limited to 32 bits, extend it to 64 bits. This change includes: - PFW code change - XML schema update Change-Id: I9861cea0538a17fcba77fa7d573faae36d8731e0 Signed-off-by: Guillaume Denneulin <guillaume.denneulin@intel.com> Reviewed-on: http://android.intel.com:8080/68189 Reviewed-by: Gozalvez Herrero, Juan AntonioX <juan.antoniox.gozalvez.herrero@intel.com> Tested-by: Gozalvez Herrero, Juan AntonioX <juan.antoniox.gozalvez.herrero@intel.com>
* PFW: Show pending configurations in status commandFrédéric Boisnard2014-02-124-6/+44
| | | | | | | | | | | | | | | | | | | | | BZ: 56118 Update the "status" command of the PFW to display the current pending configurations for all domains, that is to say configurations that are waiting the next call to "applyConfiguration()" to be applied. This improvement will help developers to better understand the current state of the PFW, in particular when dealing with HAL modifications. Change-Id: I6300620ad8cedcb534fb2859b57b7ab2988fa618 Signed-off-by: Frédéric Boisnard <fredericx.boisnard@intel.com> Reviewed-on: http://android.intel.com:8080/64796 Reviewed-by: De Chivre, Renaud <renaud.de.chivre@intel.com> Reviewed-by: Benavoli, Patrick <patrick.benavoli@intel.com> Reviewed-by: Rocard, KevinX <kevinx.rocard@intel.com> Tested-by: Barthes, FabienX <fabienx.barthes@intel.com> Reviewed-by: buildbot <buildbot@intel.com> Tested-by: buildbot <buildbot@intel.com>
* PFW: Display warning messages to help userFrédéric Boisnard2014-02-127-3/+62
| | | | | | | | | | | | | | | | | | | | BZ: 54512 Display a warning message when a configuration cannot be applied because the TuningMode is on, in order to help user to identify potential issues. Display a warning message when a criterion change doesn't lead to a configuration application (a check is performed each time a criterion is changed). Change-Id: Id872655c92770d1f6f1b01b20db2fde3db826ceb Signed-off-by: Frédéric Boisnard <fredericx.boisnard@intel.com> Reviewed-on: http://android.intel.com:8080/63845 Reviewed-by: Rocard, KevinX <kevinx.rocard@intel.com> Reviewed-by: De Chivre, Renaud <renaud.de.chivre@intel.com> Reviewed-by: Denneulin, Guillaume <guillaume.denneulin@intel.com> Tested-by: Barthes, FabienX <fabienx.barthes@intel.com> Reviewed-by: buildbot <buildbot@intel.com> Tested-by: buildbot <buildbot@intel.com>
* PFW: Allow custom port number in test-platformFrédéric Boisnard2014-02-123-5/+8
| | | | | | | | | | | | | | | | | | BZ: 56440 This patch aims to allow custom port number in test-platform: test-platform <file path> [port number, default 5001] Change-Id: Ia617507045a58d0e79a5dc1df83b0173c968853a Signed-off-by: Frédéric Boisnard <fredericx.boisnard@intel.com> Reviewed-on: http://android.intel.com:8080/65412 Reviewed-by: Denneulin, Guillaume <guillaume.denneulin@intel.com> Reviewed-by: Rocard, KevinX <kevinx.rocard@intel.com> Reviewed-by: De Chivre, Renaud <renaud.de.chivre@intel.com> Tested-by: Mendi, EduardoX <eduardox.mendi@intel.com> Reviewed-by: buildbot <buildbot@intel.com> Tested-by: buildbot <buildbot@intel.com>
* PFW: setCriterionState now support lexical stateKevin Rocard2014-02-122-1/+82
| | | | | | | | | | | | | | | | | | | | | | | | BZ: 54174 If the test-platform setCriterionState command is unable to convert the supply state to integer, it tries to consider it as a lexical state. Before setCriterionState SelectedOutputDevice 0x3 After setCriterionState SelectedOutputDevice IHF Headset Change-Id: Ib981eb955afd2acfa6e3d60d11828fcc4fc8860a Signed-off-by: Kevin Rocard <kevinx.rocard@intel.com> Reviewed-on: http://android.intel.com:8080/63478 Reviewed-by: Baron, Georges-henriX <georges-henrix.baron@intel.com> Reviewed-by: Boisnard, FredericX <fredericx.boisnard@intel.com> Reviewed-by: Benavoli, Patrick <patrick.benavoli@intel.com> Reviewed-by: Denneulin, Guillaume <guillaume.denneulin@intel.com> Reviewed-by: De Chivre, Renaud <renaud.de.chivre@intel.com> Tested-by: Barthes, FabienX <fabienx.barthes@intel.com> Reviewed-by: buildbot <buildbot@intel.com> Tested-by: buildbot <buildbot@intel.com>
* PFW: Add two commands to print xml settings and structureGeorges-Henri Baron2014-02-1241-323/+898
| | | | | | | | | | | | | | | | | | | | | BZ: 44910 Creates two commands that can be called through the command line of the parameter-framework. First command getDomainXML returns a string containing the xml structure of the domains, configurations and settings. Second command getSystemClassXML returns a string containing the xml structure of all the instantiated parameter with their attributes. Change-Id: I9a35333802049a2177b8fc416754fdb67e6efff0 Signed-off-by: Georges-Henri Baron <georges-henrix.baron@intel.com> Reviewed-on: http://android.intel.com:8080/55155 Reviewed-by: Rocard, KevinX <kevinx.rocard@intel.com> Reviewed-by: Centelles, Sylvain <sylvain.centelles@intel.com> Tested-by: Mendi, EduardoX <eduardox.mendi@intel.com> Reviewed-by: buildbot <buildbot@intel.com> Tested-by: buildbot <buildbot@intel.com>
* PFW: Check if value provided is exactly an integerFrédéric Boisnard2014-02-122-21/+42
| | | | | | | | | | | | | | | | | | | | BZ: 50802 Previously, if a fixed point value was provided for an integer parameter, there was no error. This was due to the results of strtol/strtoll which was not correctly checked (it would only fail if no digit was provided, but would succeed even if letters were appended after/before the digits). So for fixed point values, only the first part of the string was fetched, giving the impression of a truncation at the '.' character . Now the whole string shall be completly parsed for the conversion to succeed. Change-Id: Ia907e8cc05e5639e9a8bbd7204f46df5bdfa394a Signed-off-by: Frédéric Boisnard <fredericx.boisnard@intel.com> Reviewed-on: http://android.intel.com:8080/60743 Reviewed-by: Rocard, KevinX <kevinx.rocard@intel.com> Reviewed-by: Benavoli, Patrick <patrick.benavoli@intel.com> Reviewed-by: De Chivre, Renaud <renaud.de.chivre@intel.com> Tested-by: Mendi, EduardoX <eduardox.mendi@intel.com> Reviewed-by: buildbot <buildbot@intel.com> Tested-by: buildbot <buildbot@intel.com>
* PFW: Verification of Enum size compatibilityFrédéric Boisnard2014-02-122-9/+50
| | | | | | | | | | | | | | | | | BZ: 30283 No verification is made on the compatibility of the numerical Enum with the declared size. This patch aims to fix this issue. Change-Id: I03dea88d1b3e482eecb92a92169537d51c44c2a7 Signed-off-by: Frédéric Boisnard <fredericx.boisnard@intel.com> Reviewed-on: http://android.intel.com:8080/59242 Reviewed-by: Rocard, KevinX <kevinx.rocard@intel.com> Reviewed-by: Benavoli, Patrick <patrick.benavoli@intel.com> Reviewed-by: De Chivre, Renaud <renaud.de.chivre@intel.com> Tested-by: Mendi, EduardoX <eduardox.mendi@intel.com> Reviewed-by: buildbot <buildbot@intel.com> Tested-by: buildbot <buildbot@intel.com>
* PFW: BitParameter not allowed in settings by xsdKevin Rocard2014-02-121-85/+88
| | | | | | | | | | | | | | BZ: 43719 BitParameter defined in the settings area of a configurable domain will no more raise an error during schema (xsd) checking. Change-Id: I9e8bb63911d8865a185fd72be88c2555c48cf4e9 Signed-off-by: Kevin Rocard <kevinx.rocard@intel.com> Reviewed-on: http://android.intel.com:8080/59574 Reviewed-by: Mendi, EduardoX <eduardox.mendi@intel.com> Tested-by: Mendi, EduardoX <eduardox.mendi@intel.com> Reviewed-by: buildbot <buildbot@intel.com> Tested-by: buildbot <buildbot@intel.com>
* PFW: Mapping values are not truncated after ':'Kevin Rocard2014-02-121-3/+19
| | | | | | | | | | | | | | | | | | | | | | | | BZ: 49228 When an mapping value contains a ':', anything after is no longer ignored. Example : <Component Name="STATE" Type="SYSFS_FILE" Mapping="Directory:/sys/bus/pci/devices/00 00:00:06.6/"/> the PFW used to consider the mapping field as: "Directory:/sys/bus/pci/devices/0000" but now it is consided entirely: "Directory:/sys/bus/pci/devices/00 00:00:06.6/" Change-Id: I95711fb4e4ee7d10739e6393717a08627192bb00 Signed-off-by: Kevin Rocard <kevinx.rocard@intel.com> Reviewed-on: http://android.intel.com:8080/59569 Reviewed-by: Becker, VincentX <vincentx.becker@intel.com> Reviewed-by: Mendi, EduardoX <eduardox.mendi@intel.com> Tested-by: Mendi, EduardoX <eduardox.mendi@intel.com> Reviewed-by: buildbot <buildbot@intel.com> Tested-by: buildbot <buildbot@intel.com>
* PFW: KlocWork Severe issues fix on Parameter FrameworkJhinX Lee2014-02-1211-0/+27
| | | | | | | | | | | | | | | BZ: 46220 Added dummy copy constructors Change-Id: I2b79900a5d0d9173084aa89d77cc90fef1f94f14 Orig-Change-Id: I040e4d2fd8d77ac04bf2fb78a190a39aadd0b0f3 Signed-off-by: JhinX Lee <jhinx.lee@intel.com> Reviewed-on: http://android.intel.com:8080/60268 Reviewed-by: Mendi, EduardoX <eduardox.mendi@intel.com> Tested-by: Mendi, EduardoX <eduardox.mendi@intel.com> Reviewed-by: buildbot <buildbot@intel.com> Tested-by: buildbot <buildbot@intel.com>
* PFW: Remove names from PFW license headerKevin Rocard2014-02-12205-1432/+205
| | | | | | | | | | | | | | | BZ: 47701 As parameter framework code is proprietary, it should not be signed (patrick Benavoli name inside the header). Change-Id: I198f2851ee2a6cffed64a552fa399b072a0cbd3e orig-Change-Id: I335ecce2fa22ad11d6fa24f57c7cbbae3423bf1e Signed-off-by: Kevin Rocard <kevinx.rocard@intel.com> Reviewed-on: http://android.intel.com:8080/59560 Reviewed-by: Mendi, EduardoX <eduardox.mendi@intel.com> Tested-by: Mendi, EduardoX <eduardox.mendi@intel.com> Reviewed-by: buildbot <buildbot@intel.com> Tested-by: buildbot <buildbot@intel.com>
* PFW: Fixed bug on BitParameterTypesFrédéric Boisnard2014-02-1214-33/+178
| | | | | | | | | | | | | | | | | BZ: 44148 The save and restore operation would not work correctly when BitParameters of a BitParameterBlock were used in more than a single Domain. This patch aims to fixup this bug and introduces a new class: BitwiseAreaConfiguration. Change-Id: I0aaccd57cf1cce33400f94a8879565171d283425 Orig-Change-Id: I7107f7db9f01cfff3c38cbac606a8c1e9bca8b5e Signed-off-by: Frédéric Boisnard <fredericx.boisnard@intel.com> Reviewed-on: http://android.intel.com:8080/58363 Reviewed-by: Mendi, EduardoX <eduardox.mendi@intel.com> Tested-by: Mendi, EduardoX <eduardox.mendi@intel.com> Reviewed-by: buildbot <buildbot@intel.com> Tested-by: buildbot <buildbot@intel.com>
* PFW: overflow not detected for int parametersFrederic Boisnard2014-02-128-89/+199
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | BZ: 26285 The following errors were not detected by the PFW when setting parameters of type (U)INT8, (U)INT16, (U)INT32: - When setting a value out of the int32 range (ex: 999999999999999), the strtol/strtoul functions return the value -1 which was then assumed correct by the PFW. Now the errno value is checked to ensure that no range error was encountered by strtol/strtoul. - When the input string does not contain any digits, the strtol/strtoul functions return 0 which was assumed correct by the PFW. Now the endptr argument is checked to make sure that at least a part of the string was parsed. In any case an error message is displayed and the original value is not updated. Made the change compliant to 64-bit OSes. Applied the same corrections to Enum and FixedPoint types. Change-Id: I135538def791208a6eb6143444a3fc30337137e1 Orig-Change-Id: I1519dbf798228a9be579aaf612f456d5eb1b41b5 Signed-off-by: Frederic Boisnard <fredericx.boisnard@intel.com> Reviewed-on: http://android.intel.com:8080/55443 Reviewed-by: Mendi, EduardoX <eduardox.mendi@intel.com> Tested-by: Mendi, EduardoX <eduardox.mendi@intel.com> Reviewed-by: buildbot <buildbot@intel.com> Tested-by: buildbot <buildbot@intel.com>
* PFW: Add a command to delete all domainsKevin Rocard2014-02-124-0/+33
| | | | | | | | | | | | | | BZ: 42432 This command is useful to reset all PFW settings. Signed-off-by: Kevin Rocard <kevinx.rocard@intel.com> Change-Id: I23b74c45205739aeca71278979699b6b88f3111e Reviewed-on: http://android.intel.com:8080/53332 Reviewed-by: De Chivre, Renaud <renaud.de.chivre@intel.com> Tested-by: Mendi, EduardoX <eduardox.mendi@intel.com> Reviewed-by: buildbot <buildbot@intel.com> Tested-by: buildbot <buildbot@intel.com>
* PFW: Allow multiple 0 in XML array parametersFrederic Boisnard2014-02-121-5/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | BZ: 29913 Updated the patterns of the ParameterSettings.xsd in order to allow multiple 0 in arrays. Updated the ParameterSettings.xsd concerning the FixedPointParameters: - Enabled trailing zeros, - Enabled negative values, - Enabled 0 in fixed point arrays, - Disabled trailing whitespace in hexa values, - Enabled scientific notation in fixed points Signed-off-by: Frederic Boisnard <fredericx.boisnard@intel.com> Change-Id: I1cf4223587a650efbd05d674e96ebd6c40d46927 Reviewed-on: http://android.intel.com:8080/41892 Reviewed-by: Boisnard, FredericX <fredericx.boisnard@intel.com> Reviewed-by: Benavoli, Patrick <patrick.benavoli@intel.com> Reviewed-by: Wagner, DavidX <davidx.wagner@intel.com> Reviewed-by: De Chivre, Renaud <renaud.de.chivre@intel.com> Tested-by: Mendi, EduardoX <eduardox.mendi@intel.com> Reviewed-by: buildbot <buildbot@intel.com> Tested-by: buildbot <buildbot@intel.com>
* PFW: Fix precision error on FixedPointParametersFrédéric Boisnard2014-02-121-1/+3
| | | | | | | | | | | | | | | | | | | | | | | BZ: 36789 When exporting the settings to an XML file and importing this file right after, an error occurs on some fixed point parameters. The values of these parameters are incorrectly saved into the output file. This bug is due to a precision error when converting the raw value from the blackboard. The setprecision() manipulator rounds the result instead of truncating it, sometimes leading to an overflow. The fix consists in performing a truncation after the last significant digit. Change-Id: I70c59bffabfd61f1ce95a8fb4cef33273a326eaf Signed-off-by: Frédéric Boisnard <fredericx.boisnard@intel.com> Reviewed-on: http://android.intel.com:8080/50935 Reviewed-by: Benavoli, Patrick <patrick.benavoli@intel.com> Reviewed-by: Centelles, Sylvain <sylvain.centelles@intel.com> Reviewed-by: Denneulin, Guillaume <guillaume.denneulin@intel.com> Tested-by: Mendi, EduardoX <eduardox.mendi@intel.com> Reviewed-by: buildbot <buildbot@intel.com> Tested-by: buildbot <buildbot@intel.com>
* PFW: Make test-platform run on androidKevin Rocard2014-02-121-0/+38
| | | | | | | | | | | | | | | BZ: 34880 For routing testing purpose, the PFW test program : test-platform needs to run on the target. Change-Id: Iab8d8baf42a5db99550e1cba921f80fdb0a69374 Signed-off-by: Kevin Rocard <kevinx.rocard@intel.com> Reviewed-on: http://android.intel.com:8080/47500 Reviewed-by: De Chivre, Renaud <renaud.de.chivre@intel.com> Tested-by: Mendi, EduardoX <eduardox.mendi@intel.com> Reviewed-by: buildbot <buildbot@intel.com> Tested-by: buildbot <buildbot@intel.com>
* PFW: Add CriterionFromStateList to test-platformKevin Rocard2014-02-122-0/+88
| | | | | | | | | | | | | | | | | | BZ: 34881 Add commands : createExclusiveSelectionCriterionFromStateList and createInclusiveSelectionCriterionFromStateList For routing testing purpose, the PFW test program "test-platform" need commands to create criterion from a state list, so that each criterion state could have a specific name. Change-Id: Ibf4214723e085069ea9513efb099034478fa3b73 Signed-off-by: Kevin Rocard <kevinx.rocard@intel.com> Reviewed-on: http://android.intel.com:8080/47499 Reviewed-by: De Chivre, Renaud <renaud.de.chivre@intel.com> Tested-by: Mendi, EduardoX <eduardox.mendi@intel.com> Reviewed-by: buildbot <buildbot@intel.com> Tested-by: buildbot <buildbot@intel.com>
* PFW: Fixed ParameterMgr destructorFrederic Boisnard2014-02-121-0/+1
| | | | | | | | | | | | | | | | BZ: 33745 The destructor of ParameterMgr did not destroy the instance of CCommandHandler. This issue is fixed by this patch. Change-Id: Ied23c7a094bb1cc528723a79e001cd6defa556d8 Signed-off-by: Frederic Boisnard <fredericx.boisnard@intel.com> Reviewed-on: http://android.intel.com:8080/46429 Reviewed-by: Centelles, Sylvain <sylvain.centelles@intel.com> Reviewed-by: Benavoli, Patrick <patrick.benavoli@intel.com> Tested-by: Mendi, EduardoX <eduardox.mendi@intel.com> Reviewed-by: buildbot <buildbot@intel.com> Tested-by: buildbot <buildbot@intel.com>
* gcc4.6: Fix incompatible type casts for 4.6 toolchain.Pavel Chupin2014-02-121-3/+3
| | | | | | | | | | | | | | | BZ: 33304 Change-Id: I6a13f95b0c5636591f76e7f123c0813608d50c73 Signed-off-by: Pavel Chupin <pavel.v.chupin@intel.com> Reviewed-on: http://android.intel.com:8080/45958 Reviewed-by: Lu, Hongjiu <hongjiu.lu@intel.com> Reviewed-by: Beare, Bruce J <bruce.j.beare@intel.com> Reviewed-by: Yin, Fengwei <fengwei.yin@intel.com> Reviewed-by: Li, XiaojingX <xiaojingx.li@intel.com> Tested-by: Li, XiaojingX <xiaojingx.li@intel.com> Reviewed-by: buildbot <buildbot@intel.com> Tested-by: buildbot <buildbot@intel.com>
* PFW: Fixed bug on fixed point parameter typesFrederic Boisnard2014-02-121-1/+6
| | | | | | | | | | | | | | | | | | | | | | | | BZ: 29464 When reading from the blackboard a value of type fixed point parameter (size < 32 bits), the sign extend was not taken into account: - Added a call to signExtend() before the conversion, - Updated the display as well (precision support), - Set up the notation type (fixed) to prevent the scientific notation display. Compilation on target would fail because of the use of an ambigous function : log10. Changed the notation of the number to double for the parameter of this function to force binding to: double log10(double). Change-Id: Ibb77259b84db33e00971ba662600547522cf9bb1 Signed-off-by: Frederic Boisnard <fredericx.boisnard@intel.com> Reviewed-on: http://android.intel.com:8080/41649 Reviewed-by: De Chivre, RenaudX <renaudx.de.chivre@intel.com> Reviewed-by: Centelles, Sylvain <sylvain.centelles@intel.com> Tested-by: Barthes, FabienX <fabienx.barthes@intel.com> Reviewed-by: Benavoli, PatrickX <patrickx.benavoli@intel.com> Reviewed-by: buildbot <buildbot@intel.com> Tested-by: buildbot <buildbot@intel.com>
* PFW: Allow multiple amend in mapping fieldPatrick Benavoli2014-02-121-2/+8
| | | | | | | | | | | | | | | BZ: 25744 The fonction that amends is now able to handle multiple amends. Change-Id: Ia4f62d6fee32f401e4ce90f5e75a150771d1921d Signed-off-by: Frédéric Boisnard <fredericx.boisnard@intel.com> Reviewed-on: http://android.intel.com:8080/37733 Reviewed-by: De Chivre, RenaudX <renaudx.de.chivre@intel.com> Reviewed-by: M, Arulselvan <arulselvan.m@intel.com> Tested-by: M, Arulselvan <arulselvan.m@intel.com> Reviewed-by: buildbot <buildbot@intel.com> Tested-by: buildbot <buildbot@intel.com>
generated by cgit v1.1 at 2025-07-07 16:31:54 +0000