aboutsummaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Inconsistent name of variable in RuleParserSebastien Gonzalve2015-04-241-14/+14
| | | | | | | | Remove misleading hungarian notation of variable name in CRuleParser::iterate() that was making the code hard to read/maintain. Change-Id: I7a034d7999f419263551c3ed9a7c26cda38e3818 Signed-off-by: Sebastien Gonzalve <sebastien.gonzalve@intel.com>
* Type mismatch corrections (Windows 64 bits)Patrick Benavoli2015-04-2441-166/+226
| | | | | | | | This patch removes the type mismatch warnings revealed by Windows 64 compiler. Wherever necessary, used size_t type for size related data. Change-Id: Ie045ce95940cd83fe8d681168ac9526fc6028d43 Signed-off-by: Patrick Benavoli <patrick.benavoli@intel.com>
* CXmlFileIncluderElement constructor cleanupPatrick Benavoli2015-04-241-3/+2
| | | | | | | | Made _bValidateSchemasOnStart attribute initialized as part of the constructor's initializer list. Change-Id: I8f345b5c17f33e012b69005e01dc31a270e41778 Signed-off-by: Patrick Benavoli <patrick.benavoli@intel.com>
* Change blackboard write/readString prototypeSebastien Gonzalve2015-04-243-16/+9
| | | | | | | | | | | | | | Those functions are used in one place and let the caller transform a std::string to a char * which makes the use of alloca necessary. Moreover, the readString cannot know if the pointer given in input points to a buffer with enough space, making it dangerous. This patch reworks the API so that write/readString() get std::string and lets the implementation play with char *. This also allows to get rid of alloca() use which is quite dangerous. Change-Id: I973e4987278289bb914c4e194b86e924a1c88a6d Signed-off-by: Sebastien Gonzalve <sebastien.gonzalve@intel.com>
* Make line endings consistent in schemas filesSebastien Gonzalve2015-04-245-354/+354
| | | | | | | Some xsd files did not have linux style line endings. Change-Id: Id2ec46bf740679e5736bd7283377c610f7c320f9 Signed-off-by: Sebastien Gonzalve <sebastien.gonzalve@intel.com>
* Removal of unnecessary execution modeSebastien Gonzalve2015-04-242-0/+0
| | | | | | | | | Spurious execution mode removed from files: - parameter/Element.cpp - utility/convert.hpp Change-Id: I5d47d505e8c3d9f55ad975c34b51d7caa4905ab9 Signed-off-by: Sebastien Gonzalve <sebastien.gonzalve@intel.com>
* Removed spurious ";" after function definitionSebastien Gonzalve2015-04-241-1/+1
| | | | | | | | CElementBuilder constructor had a ";" right after its defintion. This patch removes it. Change-Id: I60551bf9610b1760181d9b206a98f566cef78f0b Signed-off-by: Sebastien Gonzalve <sebastien.gonzalve@intel.com>
* Remove deprecated project file for Dev-Cpp IDESebastien Gonzalve2015-04-244-448/+0
| | | | | | | File removed from remote-process folder Change-Id: Iec37d2581fd424e7cfd891224813e57a56caa2a6 Signed-off-by: Sebastien Gonzalve <sebastien.gonzalve@intel.com>
* Prevent multiple inclusions of NativeTokenizer headerSebastien Gonzalve2015-04-241-0/+2
| | | | | | | Added #pragma once on top of the file to prevent multiple inclusion. Change-Id: I351ada48e16bf6bfe84b546da5581b1aa6bce03e Signed-off-by: Sebastien Gonzalve <sebastien.gonzalve@intel.com>
* Utility.h multiple inclusions directive harmonizedSebastien Gonzalve2015-04-241-3/+1
| | | | | | | Replace #ifdef and #define wth #pragma once Change-Id: I60fe1e74a7481be38d9b8e44952e533d7ae80857 Signed-off-by: Sebastien Gonzalve <sebastien.gonzalve@intel.com>
* Require PTHREAD using cmake canonic wayKevin Rocard2015-04-241-6/+2
| | | | | | | | | | Pthread was required by included directly findPthread.cmake then testing for success. Use the find_package command and require success with the REQUIRED option. Signed-off-by: Kevin Rocard <kevin.rocard@intel.com>
* Remove explicit server stopKevin Rocard2015-04-241-3/+0
| | | | | | | | | | | | | | Stopping the remote-processor in the stop command has two side effect: - stopping the remote-processor thread will fail as it is not possible to join a thread to itself. This leads to the leak of all the thread object (destructor not called). - the server will not return the exit command status as it has been stopped during it's execution. Remove the remote-processor stop as it will be called during it's destruction. Signed-off-by: Kevin Rocard <kevinx.rocard@intel.com>
* [coverage] Correct line number msgKevin Rocard2015-04-241-1/+1
| | | | | | | | | | | | | | | When an error occurs during input parsing, the line number was incorrectly displayed. In python, enumerating an iterable will yield an pair of index and a value. This index starts at 0: next(enumerate([""])) == (0, "") This index was displayed as the line number. Add one to the index to get the line number. Signed-off-by: Kevin Rocard <kevin.rocard@intel.com>
* [coverage]Quote user value in error msgsKevin Rocard2015-04-241-3/+3
| | | | | | | | | | | | | Some pfw bug induce empty criterion value, when log it is dificult to see the the empty value. Add quotes around values. before: Error in criterion After : Error in criterion "" Signed-off-by: Kevin Rocard <kevin.rocard@intel.com>
* functional-tests: remove dumpElement test caseDavid Wagner2015-04-242-136/+0
| | | | | | | This test is failing (on travis only) for strange reasons. As we can not trust it, let's remove it for now. Signed-off-by: David Wagner <david.wagner@intel.com>
* Add functionnal tests to the pfw.Adrien M2015-04-2451-187/+999
| | | | | | | | | | | | | | | | This patch adds functionnal test to the PFW. The execution of these tests needs the test-subsystem to be compiled. The tests can be launch with 'make test'. We set the environment vars in the cmake. Then we launch ACTCampaignEngine.py. Temporary files like build time conf files are placed on the build directory. Next steps : - Test-subsystem needs to be reworked (with binding python). Signed-off-by: Adrien M <adrienx.martin@intel.com>
* Dissociate 'make test' & 'make install'Adrien M2015-04-245-3/+33
| | | | | | | Possibility to run the test without having to lunch the 'make install' command. Signed-off-by: Adrien M <adrienx.martin@intel.com>
* Fix tUINT32_ARRAY index overflow testJules Clero2015-04-241-1/+1
| | | | | | This test was using the wrong array size. It leads to false positive. Signed-off-by: Jules Clero <julesx.clero@intel.com>
* Fix tSTRING_128 parenthesis errorJules Clero2015-04-241-2/+10
| | | | | | | | | This test was trying to set string parameter containing parenthesis through remote-process without escaped them. This patch introduces the escaped value in order to correctly use the remote-process command through bash. Signed-off-by: Jules Clero <julesx.clero@intel.com>
* Fix tRAW test comparison errorJules Clero2015-04-241-1/+2
| | | | | | | | | This test is comparing lower case hexadecimal to upper case hexadecimal number. The test was failing because 0xFF is not 0xff when we compare string. As 0xff is read back from filesystem, we now compare it to the right value. Signed-off-by: Jules Clero <julesx.clero@intel.com>
* Fix Configuration test to take account of pending configurationsJules Clero2015-04-241-1/+1
| | | | | | | Parameter-framework in now displaying pending configurations, we need to take this in account in our test. Signed-off-by: Jules Clero <julesx.clero@intel.com>
* Parameter-Framework functional tests initial commitJules Clero2015-04-2468-0/+15220
| | | | | | | | | | Import of parameter-framework tests. Simplified test engine and use of python test discovery. Signed-off-by: Herve Garanto <hervex.garanto@intel.com> Signed-off-by: Sylvère Billout <sylverex.billout@intel.com> Signed-off-by: Philippe Colonges <philippeX.colonges@intel.com> Signed-off-by: Jules Clero <julesx.clero@intel.com>
* Fix "|" display artifact on inclusive criterion typeFrancois Gaffie2015-04-241-1/+4
| | | | | | | | | | | | When translating a numerical value to literal for an inclusive criterion type, if the numerical value is not found into the map of pairs, it appends anyway the "|". This patch removes this artifacts display if the numerical value is not part of the acceptable values of this criterion type. Change-Id: I2ff4ee1ae6e6e3ac87c94c596bae3ae534f173c4 Signed-off-by: Francois Gaffie <francois.gaffie@intel.com>
* Install c parameter-framework bindingsKevin Rocard2015-04-241-0/+2
| | | | | | | | C bindings were compiled and tested but never installed. Add the missing install command. Signed-off-by: Kevin Rocard <kevin.rocard@intel.com>
* Version 2.4.2David Wagner2015-04-241-1/+1
| | | | Signed-off-by: David Wagner <david.wagner@intel.com>
* Add license boilerplates for AndroidDavid Wagner2015-04-243-1/+32
| | | | | | Some Android release scripts seem to need these files. Signed-off-by: David Wagner <david.wagner@intel.com>
* Re-implement the Tokenizer class from scratchDavid Wagner2015-04-243-181/+150
| | | | | | | | | | | | It didn't have a license header. Even though we received explicit authorization to use it, it wasn't a comfortable situation. This is an original implementation that only keeps the APIs we use in the parameter-framework and keep them identical (except for a small exception). The behaviour is also exactly the same. Change-Id: I85a69c76027ee026a693d79cd19edd3b86796f9d Signed-off-by: David Wagner <david.wagner@intel.com>
* Add unit tests for the Tokenizer classDavid Wagner2015-04-243-0/+165
| | | | Signed-off-by: David Wagner <david.wagner@intel.com>
* travis: run 'ldconfig' after 'sudo make install'David Wagner2015-04-241-4/+7
| | | | | | | | | | | | In 327b1a48e2fe539c0ca5414ce9c98b2405536a09 we changed the installation prefix to /usr because we witnessed errors during unit tests using the python bindings. We initially thought that /usr/local/lib wasn't in the loader's default paths but it turns out it is. In fact, it only is the loader's cache that was outdated and needed to be regenerated. That's what ldconfig does. Signed-off-by: David Wagner <david.wagner@intel.com>
* fixed-point-tests: remove some code duplicationDavid Wagner2015-04-241-23/+13
| | | | Signed-off-by: David Wagner <david.wagner@intel.com>
* fixed point tests: some high-precision tests are failingDavid Wagner2015-04-241-1/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Testing slightly-out-of-range values is failing (i.e. the value seems to be wrongfully accepted by the parameter-framework) starting from high precisions, e.g. q0.16. The cause is: 1) When converting strings to fixed-points, the parameter-framework first parses the input string as double. Doubles have 52 fraction bits and there for 15 decimal-digits-precision (52 * log10(2) == 15). 2) When displaying Qn.m numbers, we decided to display all representable digits (i.e. m digits) instead of only displaying significant digits because that would cause unpredictable behaviour. See d299108157ee4d0eadb7683b2fa6a6635bc63d95 and 59cc1e33810c55e6fa1e3bd320e1cf29e24d23be for more information. 3) However, the precision for a Qn.m fixed-point number isn't m but m * log10(2). This is guaranteed to be less than the precision of a double but the tests mentioned at the beginning were written as if the precision was m, which may be larger than the precision of a double. This is what caused the test failures. The tests are adapted to try and set a value of which the last significant digit is one-off too far outside of the allowed range. For lower-precision number, other less-far-off values could be correctly rejected by the parameter-framework but that's only because of the underlying implementation (using doubles as intermediate values) and it seems hardly relevant to check. Signed-off-by: David Wagner <david.wagner@intel.com>
* fixed-point-tests: abort if a getParameter failsDavid Wagner2015-04-241-3/+8
| | | | | | | | We used to drop errors during "get" operation because it is unlikely to fail and not in the scope of the fixed-point tests. However, we should catch such error and abort immediately. Signed-off-by: David Wagner <david.wagner@intel.com>
* fixed point tests: use the python module instead of remote-processDavid Wagner2015-04-241-48/+39
| | | | | | | Using the python bindings is much faster and easier than using the network interface. Signed-off-by: David Wagner <david.wagner@intel.com>
* fixed point tests: remove trailing zeros from valuesDavid Wagner2015-04-241-0/+3
| | | | | | | The fixed-point tests are user-input tests. Since a user isn't likely to input any trailing zeros, let's remove them. Signed-off-by: David Wagner <david.wagner@intel.com>
* fixed point tests: return 1 in case of failureDavid Wagner2015-04-241-3/+15
| | | | | | | The fixed-point tests did not return any error code even upon failure. This lead to believing that they were passing. Signed-off-by: David Wagner <david.wagner@intel.com>
* python bindings: install modules to the dist-packages directoryDavid Wagner2015-04-241-2/+14
| | | | | | | | Use python to get the OS's directory name for dist-packages. The python bindings (low-level shared library and python proxy class) are then installed to that path, prefixed by the cmake install prefix. Signed-off-by: David Wagner <david.wagner@intel.com>
* cmake/python bindings: reorganize include_directories() instructionsDavid Wagner2015-04-241-4/+2
| | | | | | | | | | 1) PYTHON_INCLUDE_PATH is deprecated in favor of PYTHON_INCLUDE_DIRS 2) adding the current source directory to the include dirs is useless since it is implicit. 3) group all include_directories() instructions to the same place in the makefile. Signed-off-by: David Wagner <david.wagner@intel.com>
* cmake/python bindings: remove duplicated PythonLibs inclusionDavid Wagner2015-04-241-6/+1
| | | | | | | | It was included by both find_package() and include(); the success of the inclusion was then checked manually. Instead, find_pacakge(PythonLibs REQUIRED) does the inclusion and the checking automatically. Signed-off-by: David Wagner <david.wagner@intel.com>
* C pfw bindingsKevin Rocard2015-04-246-0/+1143
| | | | | | | | | The pfw can not currently be used from c code. Add an c api. It does not target a perfect one/one mapping with the c++ one, but rather aim ease of use and type safety (as far as possible in c). Signed-off-by: Kevin Rocard <kevin.rocard@intel.com>
* Android/xmlGenerator: Fix domainGenerator.py's dependenciesDavid Wagner2015-04-241-1/+1
| | | | | | | | | | | | | 32bit target names are postfixed with "_32". This was missed in the list "required modules" for domainGenerator.py" which caused _PyPfw.so not being compiled when needed. Android only contains a 32bit version of prebuilt python. Fix LOCAL_REQUIRED_MODULES for domainGenerator.py Change-Id: Ieda460d0c4785bc2d1c2c14e38f5a73c66672497 Signed-off-by: David Wagner <david.wagner@intel.com>
* domainGenerator.py: more flexible argumentsDavid Wagner2015-04-241-2/+3
| | | | | | | | | | Allow optional arguments (initial settings, single domains, EDDs) to be passed with an empty list of files. This will make it a lot easier to write helper scripts. Change-Id: I99527376b25d607616a3e73f6b62d556b79a90d2 Signed-off-by: David Wagner <david.wagner@intel.com>
* travis: set the installation prefix to /usrDavid Wagner2015-04-241-3/+3
| | | | | | | | | | | | CMake defaults to /usr/local which results in libraries being installed in /usr/local/lib. Unfortunately, this path isn't in the loader's default locations. The canonical installation path is /usr. /usr/local is recommended for stuff not handled by the package manager but in the context of the CI, this isn't relevant. Signed-off-by: David Wagner <david.wagner@intel.com>
* Fail build if test are enabled but can not be builtKevin Rocard2015-04-241-5/+3
| | | | | | | | | | The fix point parameter test used to display a warning if it could not be run. Transform it to an errors if the tests are explicitly activated through the BUILD_TESTING option. BUILD_TESTING is declared by ctest. Signed-off-by: Kevin Rocard <kevin.rocard@intel.com>
* Modularise build using cmake optionsKevin Rocard2015-04-243-3/+16
| | | | | | | | | | | | | | | | | The parameter framework can build lots of components including but not limited to core c++ lib, c api, python api, bash completion... All those modules are not always wanted, especially if they have external dependencies as it force the builder to install them. Conditionally define non core build modules. The builder can disable feature by providing -D <FEATURE>=OFF to deactivate them. The following options are available: - PYTHON_BINDINGS: Break swig dependencies - BASH_COMPLETION: If the target does not have bash - COVERAGE: Default to off, set to on to build c/c++ with coverage flags. Signed-off-by: Kevin Rocard <kevin.rocard@intel.com>
* Use ctest for testingKevin Rocard2015-04-243-6/+21
| | | | | | | | | | | | | Test were enabled with the enable_testing command. Nevertheless this method is very basic. Include CTest, as this cmake utility enables automatic build + test + coverage generation + memchek test (valgrind) + sending report in one command: ```make Experimental``` There are far more features added by this utility, see: http://www.cmake.org/Wiki/CMake/Testing_With_CTest#Dashboards Signed-off-by: Kevin Rocard <kevin.rocard@intel.com>
* Reformat .travis.yml test commandsKevin Rocard2015-04-241-4/+8
| | | | | | | | Do not execute tests if the build fails. Indent the commands for readability. Signed-off-by: Kevin Rocard <kevin.rocard@intel.com>
* Print test output if the test failsKevin Rocard2015-04-241-1/+1
| | | | | | | | ctest by default put all logs in a file and never display it even if a test fails. Add the relevant option to output on failure. Signed-off-by: Kevin Rocard <kevin.rocard@intel.com>
* Install a recent gcc, gcov, cmake and ctest versionKevin Rocard2015-04-241-2/+10
| | | | | | | | | | | | | | The c pfw interface (following patch) needs a recent gcc to compile. Gcc and gcov version need to be align, thus gcov is updated too. Ctest analyse the gcov output, as a result it must be align with it (gcov 2.7 changed it's report format). Ctest, and cmake are packaged together. Conclusion: update cmake and gcc packages. Unfortunatly ubuntu backport does not provide a recent enough version, that is why ppa were used instead. Signed-off-by: Kevin Rocard <kevin.rocard@intel.com>
* Remove dead getRoot member function from elementJules Clero2015-04-242-20/+0
| | | | Signed-off-by: Jules Clero <julesx.clero@intel.com>
* Handle config path without slashKevin Rocard2015-04-241-5/+7
| | | | | | | | | If the parameter configuration file path does not contain a "/" it used to assert as it could not find it's folder. Use "." this case. Signed-off-by: Kevin Rocard <kevinx.rocard@intel.com>
generated by cgit v1.1 at 2025-01-07 20:08:05 +0000