| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
| |
Some public methods returned a "CCommandHandler" enum value type, which is
intended to be used in the remote tuning methods only. Primitive bools must be
used instead.
Change-Id: Iac7a565f701c65875b3f1dd0896bf31d7d843d72
Signed-off-by: David Wagner <david.wagner@intel.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
These methods are:
- renameDomain
- setSequenceAwareness
- getSequenceAwareness
- renameConfiguration
- setElementSequence
- setApplicationRule
- getApplicationRule
- clearApplicationRule
The "remote tuning" methods are also modified to use them instead of directly
accessing inner objects and the tuning mode checking is moved to the public C++
method when applicable.
Change-Id: I9cdd0abbacb76232cd746878dca9ab619e8b6b58
Signed-off-by: David Wagner <david.wagner@intel.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The command is used as follows:
importDomainWithSettingsXML <file path> [overwrite]
It reads the file given as first argument (path must be absolute) and imports
the domain found in it.
It does not check whether it overlaps with another domain (same elements in two
domains). It does, however, check if there is an existing domain with the same
name as the one being imported. If so and if the (optional) second argument
is "overwrite", it will first delete the existing domain; if not it will refuse
to import the new domain.
Change-Id: I7aaa225f2f1a296f52dc8a97f55e1ff70c06d567
Signed-off-by: David Wagner <david.wagner@intel.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The command is used as follows:
getDomainWithSettingsXML <domain>
and outputs the requested domain to the standard output.
In that end, the const version of CConfigurableDomains::findConfigurableDomain
is made public. This somewhat breaks encapsulation but since the returned
domain is const, this has limited impact.
Change-Id: I9b854040a5d59913b9b405c8e38d29a3018a6079
Signed-off-by: David Wagner <david.wagner@intel.com>
|
|
|
|
|
|
|
|
|
|
| |
This allows diminishing the dependency on the parent element when creating a
Domain element from an XML document: the parent was used to get a handle to the
system class in order to check the existence of ConfigurableElements included
in the Domain.
Change-Id: Icba7c3c4db2b9728c0fb7c6840a254de9775f6a4
Signed-off-by: David Wagner <david.wagner@intel.com>
|
|
|
|
|
|
|
|
|
|
|
|
| |
Import and Export of ConfigurableDomains have different context needs: e.g. the
value representation is only used for export; auto-validation is only
meaningful for import whereas the "with settings" context is common to both.
We create two new classes, derived from XmlDomainSerializingContext and move
most of its content to each class it belongs to.
Change-Id: I56589cdb3a8ea417e11d2ed98ccd055d7cdead67
Signed-off-by: David Wagner <david.wagner@intel.com>
|
|
|
|
|
|
|
|
| |
This is done in preparation for future work making it possible to export/import
domains in standalone and separate files.
Change-Id: I35ae66361d18e2de603cedee6b1701defcc9d357
Signed-off-by: David Wagner <david.wagner@intel.com>
|
|
|
|
|
|
|
|
| |
Implement the non-const method of findConfigurableDomain by calling the const
version, as described in Effective C++ Item 3.
Change-Id: Ib7b58100dc817d02092299923edf2e6c7ce2f117
Signed-off-by: David Wagner <david.wagner@intel.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The toXml method has a default implementation that recursively calls toXml on
the children and set their "Name" attribute.
With this approach, the toplevel element's name isn't set unless its overrided
implementation explicitly does so.
A first approach for fixing that is to set the XmlElement's name and
recursively call toXml on children (without setting their name because it will
be done by their toXml method). However, the "CXmlElement" being created may or
may not be the object on which the toXml method is called, in which case the
name will be set on the wrong XmlElement.
Instead, in CElement::toXml, we set the XmlElement's name and call a new
virtual method, childrenToXml which only recursively call toXml on children.
This gives full flexibility to elements to choose how they want to serialize
themselves and how they want to serialize their children.
CConfigurableDomain::toXml is modified to take that change into account.
Change-Id: Id12a1023e91cb000e55c242c13643b1db7d46871
Signed-off-by: David Wagner <david.wagner@intel.com>
|
|
|
|
|
|
|
| |
It's been a long time we haven't changed this version number. We will start
making releases and this one is the first of a series.
Signed-off-by: David Wagner <david.wagner@intel.com>
|
|\
| |
| | |
Schemas readme fixes
|
| |
| |
| |
| |
| |
| |
| | |
The scope of this readme is widened to document the hierarchy of configuration
files and details on the content of each of them.
Signed-off-by: David Wagner <david.wagner@intel.com>
|
|/
|
|
|
|
|
| |
There is no such "TuningMode" attribute; it was a mistake and the attribute
described in this documentation corresponds to "TuningAllowed".
Signed-off-by: David Wagner <david.wagner@intel.com>
|
|\
| |
| | |
Fix fixed point test
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
This only makes sense on the Android build system. However, these tests are
broken on Android because libremote-processor is compiled as
"libremote-processor_host.so" on Android whereas libparameter will only try to
load "libremote-processor.so" anyway.
For now, let's ignore the Android build system and only care about how we do it
with CMake: CMake builds libremote-processor.so, test-platform and
remote-process so let's remove the "_host" suffixes that were added for
compatibility with the output of the Android makefiles.
Signed-off-by: David Wagner <david.wagner@intel.com>
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
A lot of parameters were duplicated because we had one parameter for each size
(8, 16 and 32) and for each integral/fractional combination. However, they were
all at the root of the subsystem and a lot overlapped, e.g., q1.2 for 32bits
and q1.2 for 16 bits.
We fix this by:
- Adding a ParameterBlock for each size
- Modifying the tests to account for the change in the parameter paths
- Run the tests for 8, 16 and 32 bits
Signed-off-by: David Wagner <david.wagner@intel.com>
|
|\ \
| | |
| | | |
Remove libxml2-schemas target since it is now covered by the aosp
|
| |/
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
BZ: 218524
The "Schemas" feature is enabled in Android-L,
so there is no need for this out-of-tree compilation
anymore.
So this patch deletes its compilation in
parameter-framework project.
Change-Id: I111afa3e12fa80c2871bae475d550bc49c4440cc
Signed-off-by: pafonsoX <philippex.afonso@intel.com>
Signed-off-by: David Wagner <david.wagner@intel.com>
|
|\ \
| | |
| | | |
Update .pfw gedit syntax grammar
|
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Add the new Extended Domain Description keywords to
gedit syntax grammar.
Signed-off-by: Kevin Rocard <kevinx.rocard@intel.com>
|
|\ \ \
| |_|/
|/| | |
Clarify the "Non accessible element" error
|
|/ /
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
This error happens, among others, when trying to set an element as if it was a
parameter. The error message was not very helpful.
Previous error message:
Non accessible element
New error message:
Can't set /A/b/c because it is not a parameter
Signed-off-by: David Wagner <david.wagner@intel.com>
|
|\ \
| | |
| | | |
Remove flood debug trace on xml generation error
|
| |/
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
The patch 0b3ff88 "Add log in case of failure"
added system process and network log on failure.
It was planed to be used to debug a tricky socket
error bug.
The bug was since fixed and the traces now only
flood build log, making xml generation
error root cause spotting a lot harder.
Remove extra debug message (netstat and ps invocation)
on error.
Signed-off-by: Kevin Rocard <kevinx.rocard@intel.com>
|
|\ \
| | |
| | | |
hostDomainGenerator: Fix the stripping of the temporary directory name
|
| |/
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
We didn't properly remove the name of the temporary directory in the generated
files which caused two generation from identical sources result in different
generated files.
We know the full name of the temporary directory so we can simply completly
remove it from the generated file.
Issue: GMINL-1953
Change-Id: I1f360cea249328d30318a24643b524c87424475e
Signed-off-by: David Wagner <david.wagner@intel.com>
|
|\ \
| | |
| | | |
Fix a use-after-free issue
|
| |/
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
In CBinaryStream, a member gets used after it has been destroyed. This was
caught by a static code analyser.
Issue: GMINL-1702
Change-Id: I5c93855f12a8f392e1f4249a15048816fb0f13ce
Signed-off-by: David Wagner <david.wagner@intel.com>
Reviewed-on: https://android.intel.com/278483
Reviewed-by: cactus <cactus@intel.com>
Tested-by: cactus <cactus@intel.com>
Reviewed-by: Beatty, Robert M <robert.m.beatty@intel.com>
Tested-by: Beatty, Robert M <robert.m.beatty@intel.com>
|
|\ \
| | |
| | | |
Remove non ascii char
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Some comments representing a file tree were
using non ASCII characters.
They are not readable on many editors leading to
incoherent display.
Replace them by plain ASCII characters.
Signed-off-by: Kevin Rocard <kevinx.rocard@intel.com>
|
| |/
| |
| |
| |
| |
| |
| |
| |
| | |
Some string printed in log were containing Non-breaking spaces
leading to terminal corruption.
Replace them with normal ASCII spaces.
Signed-off-by: Kevin Rocard <kevinx.rocard@intel.com>
|
|\ \
| | |
| | | |
Fix build issues bis
|
| | |
| | |
| | |
| | |
| | |
| | | |
It does not compile yet; this issue will have to be tackled.
Signed-off-by: David Wagner <david.wagner@intel.com>
|
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
The unicode library in AOSP's master branch has moved. libxml2 has been updated
and xmlserializer needs to be too.
Signed-off-by: David Wagner <david.wagner@intel.com>
|
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
This seems to be mandatory.
Change-Id: Idba8c7a3ec9e2f05b28ee593d1d15a420a0bd9ed
Signed-off-by: David Wagner <david.wagner@intel.com>
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
According to the sem_init(3) manpage, we must pass the -pthread flag at
link-time when using it. When using pthread_join(3), this flag must also be
passed at compile time.
The flags were wrong for libremote-processor and were missing for
test-platform_host.
Change-Id: Iec2797592d6d25297c87ceb2983e87e75624a576
Signed-off-by: David Wagner <david.wagner@intel.com>
|
| |/
| |
| |
| |
| |
| |
| |
| |
| | |
LOCAL_MODULE_PATH is deprecated and in this case, useless.
Change-Id: I72054e3a5c70c2779d170f07f24734d75fdf48f8
Signed-off-by: Qiming Shi <qiming.shi@intel.com>
Reviewed-on: https://android.intel.com/211229
Reviewed-by: cactus <cactus@intel.com>
|
|\ \
| | |
| | | |
some C++ cleanup
|
| | |
| | |
| | |
| | |
| | | |
This is a bad practice to have using in headers because it pollutes the
namespace of any user of that header.
|
| |/
| |
| |
| |
| | |
Those files are empty or almost empty, put remaining stuff in header if
necessary.
|
|\ \
| |/
|/| |
Allow the plugin libraries to have empty path for location
|
|/
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
If the xml defines the path of plugin library as empty, as a
slash is always added between the folder path and the library name,
the parameter framework will look for the library at the root of the
file system.
This patch prevents from adding the slash except if the path
is not empty.
Issue: GMINL-1748
Change-Id: I14ed5a5ddbef7e0305300479f4fd44bf611f3442
Signed-off-by: Louis Le Gall <louis.le.gall@intel.com>
|
|
|
|
|
|
|
| |
- More details in the root README.md file; add a nice diagram
- Add a lot of README files in subdirectories
Signed-off-by: David Wagner <david.wagner@intel.com>
|
|\
| |
| | |
Realign from internal tree
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
BZ: 207083
License headers were missing in CMake makefiles.
This patch adds the 3-clause BSD license header to each CMakeLists.txt.
Change-Id: Ia4da92e139e02d6348d655d0d88a16166d8431ca
Signed-off-by: Mattijs Korpershoek <mattijsx.korpershoek@intel.com>
|
|/
|
|
|
|
|
|
|
|
|
|
|
|
| |
BZ: 207083
According to libstlport.mk, to use stlport for a given target, we shall
"include external/stlport/libstlport.mk" in the target.
This was not done in the parameter-framework's makefiles.
This patch change all targets which require stlport to include it in the
correct way.
Change-Id: Ie9b75af6269f172ad6a6c753e15efd0c7baafdd9
Signed-off-by: Mattijs Korpershoek <mattijsx.korpershoek@intel.com>
|
|\
| |
| | |
Xml validator script
|
|/
|
|
|
|
|
|
|
|
|
|
| |
This tool can be used to validate a set of xml files against w3c
schemas.
It scans a directory recursively and checks for .xml files in it.
For each file, it extracts the current schema file based on a convention
(the corresponding schema file must have the same name as the root node)
which is used in the parameter-framework.
Change-Id: I27e32028e39a450ed18f86cb095348f73d59ade5
|
|\
| |
| | |
Added cmake rules for installing tools in bin dir
|
|/
|
|
|
|
|
|
|
| |
When performing the tutorials, I wanted to use the
tools/xmlGenerator/hostDomainGenerator.sh script.
In order to do that, i had to copy manually my scripts files
to the pfwInstalledDir/bin directory.
This patchs completes the install target by copying the needed files
|