aboutsummaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* [coverage] Add flags to ignore errorsKevin Rocard2014-02-121-6/+51
| | | | | | | | | | | | | | | | | | | | | | | | | | | BZ: 115218 2 errors can be raised when parsing PFW logs: - criterion that change their state that is not allowed. The PFW allows an exclusive criterion to be in the none state. - configuration not applicable according to the criterion states that are however applied. It happens in case of log corruption (log lines missing). The user should be able to ignore those 2 errors if low coverage accuracy is allowed. Add the flags: --ignore-incoherent-criterion-state --ignore-ineligible-configuration-application Change-Id: I1a25b47a05e974d711b735e344f9352904c8771b Signed-off-by: Kevin Rocard <kevinx.rocard@intel.com> Reviewed-on: http://android.intel.com:8080/112714 Reviewed-by: Denneulin, Guillaume <guillaume.denneulin@intel.com> Reviewed-by: Gonzalve, Sebastien <sebastien.gonzalve@intel.com> Reviewed-by: cactus <cactus@intel.com> Tested-by: Dixon, CharlesX <charlesx.dixon@intel.com> Reviewed-by: buildbot <buildbot@intel.com> Tested-by: buildbot <buildbot@intel.com>
* [Coverage] Reset criterion on it's recreationKevin Rocard2014-02-121-1/+11
| | | | | | | | | | | | | | | | | | BZ: 115218 The script was not handling criterion recreation (usually on PFW restart). Reset criterion on it's recreation. Change-Id: I169717c1c62f89ce81b21909f3ee4b981d5e91d8 Signed-off-by: Kevin Rocard <kevinx.rocard@intel.com> Reviewed-on: http://android.intel.com:8080/112713 Reviewed-by: Denneulin, Guillaume <guillaume.denneulin@intel.com> Reviewed-by: Gonzalve, Sebastien <sebastien.gonzalve@intel.com> Reviewed-by: cactus <cactus@intel.com> Tested-by: Dixon, CharlesX <charlesx.dixon@intel.com> Reviewed-by: buildbot <buildbot@intel.com> Tested-by: buildbot <buildbot@intel.com>
* [Coverage] Raise duplicated criterion specialised exceptionKevin Rocard2014-02-121-1/+4
| | | | | | | | | | | | | | | | | | | | | | | BZ: 115218 When an element is requested to adopt multiple times the same element, the "DuplicatedChildError" exception is raised. However, in case of PFW restart, existing criteria are recreated, which is throwing the generic "DuplicatedChildError" exception. As such event need to be detected, specialise the "DuplicatedChildError" exception in "DuplicatedCriterionError" in order to catch the event easily. Change-Id: Ib0cca1d318233ca0b2f69fd277740ce8f5a550ad Signed-off-by: Kevin Rocard <kevinx.rocard@intel.com> Reviewed-on: http://android.intel.com:8080/112712 Reviewed-by: Denneulin, Guillaume <guillaume.denneulin@intel.com> Reviewed-by: Gonzalve, Sebastien <sebastien.gonzalve@intel.com> Reviewed-by: cactus <cactus@intel.com> Tested-by: Dixon, CharlesX <charlesx.dixon@intel.com> Reviewed-by: buildbot <buildbot@intel.com> Tested-by: buildbot <buildbot@intel.com>
* [Coverage] Support criterion incoherent stateKevin Rocard2014-02-121-11/+30
| | | | | | | | | | | | | | | | | | | | BZ: 115218 In case of incoherent log (corrupted), some transitions described in the log are not permitted by the internal criterion state machine. Resulting in raising an exception and stopping the program. Add an optional parameter to ignore integrity. Change-Id: I288c0e482b223aa0023e09fb158036b39d0ed8bf Signed-off-by: Kevin Rocard <kevinx.rocard@intel.com> Reviewed-on: http://android.intel.com:8080/112711 Reviewed-by: Denneulin, Guillaume <guillaume.denneulin@intel.com> Reviewed-by: Gonzalve, Sebastien <sebastien.gonzalve@intel.com> Reviewed-by: cactus <cactus@intel.com> Tested-by: Dixon, CharlesX <charlesx.dixon@intel.com> Reviewed-by: buildbot <buildbot@intel.com> Tested-by: buildbot <buildbot@intel.com>
* [Coverage] Move exception class in the relevant classKevin Rocard2014-02-121-13/+17
| | | | | | | | | | | | | | | | | | | BZ: 115218 Some exceptions were raised only by a particular class. As a result they were polluting the global namespace. Nested the exception class. Change-Id: Icde35d8d2f551a638b97d94bc0a770f70787c723 Signed-off-by: Kevin Rocard <kevinx.rocard@intel.com> Reviewed-on: http://android.intel.com:8080/112710 Reviewed-by: Denneulin, Guillaume <guillaume.denneulin@intel.com> Reviewed-by: Gonzalve, Sebastien <sebastien.gonzalve@intel.com> Reviewed-by: cactus <cactus@intel.com> Tested-by: Dixon, CharlesX <charlesx.dixon@intel.com> Reviewed-by: buildbot <buildbot@intel.com> Tested-by: buildbot <buildbot@intel.com>
* [Coverage] Delete dangerous assert, raise exceptionKevin Rocard2014-02-121-2/+0
| | | | | | | | | | | | | | | | | | | | BZ: 115218 An assert was checking function input parameters that came from an input file. As a result an corrupted file would stop the program without the opportunity to catch the error. Remove the assert and let the function raise the appropriate exception. Change-Id: Ic8d8d318ca191040c546e354c0911d56670b1030 Signed-off-by: Kevin Rocard <kevinx.rocard@intel.com> Reviewed-on: http://android.intel.com:8080/112709 Reviewed-by: Denneulin, Guillaume <guillaume.denneulin@intel.com> Reviewed-by: Gonzalve, Sebastien <sebastien.gonzalve@intel.com> Reviewed-by: cactus <cactus@intel.com> Tested-by: Dixon, CharlesX <charlesx.dixon@intel.com> Reviewed-by: buildbot <buildbot@intel.com> Tested-by: buildbot <buildbot@intel.com>
* [Coverage] Delete useless bracketsKevin Rocard2014-02-121-4/+2
| | | | | | | | | | | | | | | | | | | BZ: 115218 Some brackets around return value were used to wrap lines that did not need to be wrapped. Unwrap lines and delete the brackets. Change-Id: I7583deff42b8b4db1ef7dbb61f24329dec908ec3 Signed-off-by: Kevin Rocard <kevinx.rocard@intel.com> Reviewed-on: http://android.intel.com:8080/112708 Reviewed-by: Denneulin, Guillaume <guillaume.denneulin@intel.com> Reviewed-by: Gonzalve, Sebastien <sebastien.gonzalve@intel.com> Reviewed-by: cactus <cactus@intel.com> Tested-by: Dixon, CharlesX <charlesx.dixon@intel.com> Reviewed-by: buildbot <buildbot@intel.com> Tested-by: buildbot <buildbot@intel.com>
* [Makefile] Fix useless CFLAGSKevin Rocard2014-02-125-19/+0
| | | | | | | | | | | | | | | | | | | BZ: 115743 The patch e2c35a01 deleted -Wno-non-virtual-dtor flags by deleting the common_cflags definition but it was still used in the rest of the makefiles. Delete the common_cflags occurrences. Change-Id: If4301a774c45594b36962ce5b82ae5656c6a5bb1 Signed-off-by: Kevin Rocard <kevinx.rocard@intel.com> Reviewed-on: http://android.intel.com:8080/115292 Reviewed-by: Denneulin, Guillaume <guillaume.denneulin@intel.com> Reviewed-by: De Chivre, Renaud <renaud.de.chivre@intel.com> Tested-by: Dixon, CharlesX <charlesx.dixon@intel.com> Reviewed-by: buildbot <buildbot@intel.com> Tested-by: buildbot <buildbot@intel.com>
* [Makefile] Format variables to lower_snake_caseKevin Rocard2014-02-126-108/+108
| | | | | | | | | | | | | | | | | BZ: 115743 Some variables where not formatted as requested by the coding style. Format them to lower_snake_case. Change-Id: I31c152f161cde469bcd4c00953e95274c60868ca Signed-off-by: Kevin Rocard <kevinx.rocard@intel.com> Reviewed-on: http://android.intel.com:8080/115175 Reviewed-by: Denneulin, Guillaume <guillaume.denneulin@intel.com> Reviewed-by: De Chivre, Renaud <renaud.de.chivre@intel.com> Tested-by: Dixon, CharlesX <charlesx.dixon@intel.com> Reviewed-by: buildbot <buildbot@intel.com> Tested-by: buildbot <buildbot@intel.com>
* [Makefile] Append "_host" to host modules namesKevin Rocard2014-02-126-10/+12
| | | | | | | | | | | | | | | | | | | | | BZ: 115743 In some parameter framework makefiles, host and target modules (with the same name) are defined in the same file. External prebuilt framework properly handle this case when modules are defined in different Android.mk, but there is a limitation when modules are defined in same Android.mk. Append _host to all host modules. Change-Id: Ib594dabd86617cc40993066338f095b49afb2ea2 Signed-off-by: Kevin Rocard <kevinx.rocard@intel.com> Reviewed-on: http://android.intel.com:8080/113537 Reviewed-by: Denneulin, Guillaume <guillaume.denneulin@intel.com> Reviewed-by: De Chivre, Renaud <renaud.de.chivre@intel.com> Tested-by: Dixon, CharlesX <charlesx.dixon@intel.com> Reviewed-by: buildbot <buildbot@intel.com> Tested-by: buildbot <buildbot@intel.com>
* Update the PFW version due to api changeKevin Rocard2014-02-121-1/+1
| | | | | | | | | | | | | | | | | | | BZ: 116973 As, the PFW public api changed (deprecated commands), external tools must be aware of it. Increment the PFW version number to let users detect api version. Change-Id: I61860b651c2559242c5eb32ec5d8afaf9bc6b0c6 Signed-off-by: Kevin Rocard <kevinx.rocard@intel.com> Reviewed-on: http://android.intel.com:8080/114688 Reviewed-by: cactus <cactus@intel.com> Reviewed-by: Denneulin, Guillaume <guillaume.denneulin@intel.com> Reviewed-by: Gonzalve, Sebastien <sebastien.gonzalve@intel.com> Tested-by: Dixon, CharlesX <charlesx.dixon@intel.com> Reviewed-by: buildbot <buildbot@intel.com> Tested-by: buildbot <buildbot@intel.com>
* Mark the getDomainsXML command as deprecatedKevin Rocard2014-02-121-1/+5
| | | | | | | | | | | | | | | | | | | | | | BZ: 116973 The patch 15db1a7d renamed the command getDomainsXML to getDomainsWithSettingsXML. This changes the PFW API and breaks the PFW backward compatibility. Put the command back marked as deprecated. Both getDomainsXML and getDomainsWithSettingsXML are now supported. getDomainsXML output an deprecated message when used. Change-Id: Id838b6e02f003c789bb9cbe7a534e4985a4b348f Signed-off-by: Kevin Rocard <kevinx.rocard@intel.com> Reviewed-on: http://android.intel.com:8080/114071 Reviewed-by: cactus <cactus@intel.com> Reviewed-by: Denneulin, Guillaume <guillaume.denneulin@intel.com> Reviewed-by: De Chivre, Renaud <renaud.de.chivre@intel.com> Tested-by: Dixon, CharlesX <charlesx.dixon@intel.com> Reviewed-by: buildbot <buildbot@intel.com> Tested-by: buildbot <buildbot@intel.com>
* PFW: Add setDomainsXML command to import domains from stringGeorges-Henri Baron2014-02-1221-293/+856
| | | | | | | | | | | | | | | | | | | | | BZ: 55694 Unable possibility to import the configurable domains from a string Create one command that can be called through the command line of the parameter-framework. The command setDomainXML allows to import configurable domains with settings from a string provided as first argument containing the xml description. Change-Id: I6db7ccb8ba61b5e4c8ba81579a68f40e887d1534 Signed-off-by: Georges-Henri Baron <georges-henrix.baron@intel.com> Reviewed-on: http://android.intel.com:8080/65408 Reviewed-by: cactus <cactus@intel.com> Reviewed-by: Dixon, CharlesX <charlesx.dixon@intel.com> Reviewed-by: Rocard, KevinX <kevinx.rocard@intel.com> Tested-by: Dixon, CharlesX <charlesx.dixon@intel.com> Reviewed-by: buildbot <buildbot@intel.com> Tested-by: buildbot <buildbot@intel.com>
* Remove no-non-virtual-dtor flagSebastien Gonzalve2014-02-1222-14/+40
| | | | | | | | | | | | | | BZ: 111473 The warning non-virtual-dtor should not be ignored for the whole project, but only in the few cases where it it necessary. Change-Id: I0ede82a30f2cd055b789f7fb56104fb227934e6f Signed-off-by: Sebastien Gonzalve <sebastien.gonzalve@intel.com> Signed-off-by: Guilhem IMBERTON <guilhem.imberton@intel.com> Reviewed-on: http://android.intel.com:8080/110191 Reviewed-by: buildbot <buildbot@intel.com> Tested-by: buildbot <buildbot@intel.com>
* [Parameter] Move public header to include dirKevin Rocard2014-02-126-5/+6
| | | | | | | | | | | | | | | | | | | | | | | | BZ: 107991 The parameter-framework core public headers were mixed up with all other private headers. Making it dificult for other components to include PFW public headers. Move public headers - ParameterHandle - ParameterMgrPlatformConnector - SelectionCriterionInterface - SelectionCriterionTypeInterface to the "include" dir. Change-Id: I3a4840345a26ec9bd848179bdd4966d44d97bede Signed-off-by: Kevin Rocard <kevinx.rocard@intel.com> Reviewed-on: http://android.intel.com:8080/109757 Reviewed-by: cactus <cactus@intel.com> Reviewed-by: Gonzalve, Sebastien <sebastien.gonzalve@intel.com> Tested-by: Dixon, CharlesX <charlesx.dixon@intel.com> Reviewed-by: buildbot <buildbot@intel.com> Tested-by: buildbot <buildbot@intel.com>
* Change TARGET_ERROR_FLAGS to LOCAL_CFLAGSKevin Rocard2014-02-125-15/+15
| | | | | | | | | | | | | | | | | | BZ: 107991 All plugin Android.mk were copy pasted resulting in use of TARGET_ERROR_FLAGS instead of LOCAL_CFLAGS. Change TARGET_ERROR_FLAGS to LOCAL_CFLAGS Change-Id: I792164e8c056be5dbfee35d07e7dd21b3137f4f6 Signed-off-by: Kevin Rocard <kevinx.rocard@intel.com> Reviewed-on: http://android.intel.com:8080/109723 Reviewed-by: cactus <cactus@intel.com> Reviewed-by: Gonzalve, Sebastien <sebastien.gonzalve@intel.com> Tested-by: Dixon, CharlesX <charlesx.dixon@intel.com> Reviewed-by: buildbot <buildbot@intel.com> Tested-by: buildbot <buildbot@intel.com>
* PFW: Delete useless libstdc++ includesKevin Rocard2014-02-125-5/+0
| | | | | | | | | | | | | | | | | | BZ: 107991 All plugin Android.mk were copy pasted resulting in duplicated useless libstdc++ includes. Delete the useless makefiles libstdc++ includes. Change-Id: I42bd991c261cd9fe1287b572668c677c42baad8e Signed-off-by: Kevin Rocard <kevinx.rocard@intel.com> Reviewed-on: http://android.intel.com:8080/109279 Reviewed-by: cactus <cactus@intel.com> Reviewed-by: Gonzalve, Sebastien <sebastien.gonzalve@intel.com> Tested-by: Dixon, CharlesX <charlesx.dixon@intel.com> Reviewed-by: buildbot <buildbot@intel.com> Tested-by: buildbot <buildbot@intel.com>
* [xml serializer] Make xmlserializer lib staticKevin Rocard2014-02-122-4/+4
| | | | | | | | | | | | | | | | | | BZ: 107991 The lib xmlserializer is used only in the PFW. As a result it is useless to have it dynamic. Make the lib static. Change-Id: I5fe91509485781136ecd2a85338f2229c1aebace Signed-off-by: Kevin Rocard <kevinx.rocard@intel.com> Reviewed-on: http://android.intel.com:8080/107597 Reviewed-by: cactus <cactus@intel.com> Reviewed-by: Gonzalve, Sebastien <sebastien.gonzalve@intel.com> Tested-by: Dixon, CharlesX <charlesx.dixon@intel.com> Reviewed-by: buildbot <buildbot@intel.com> Tested-by: buildbot <buildbot@intel.com>
* [test-platform] Add support for host buildKevin Rocard2014-02-121-17/+43
| | | | | | | | | | | | | | | | | | BZ: 107991 In order to generate setting xml at build time, one need to build and run PFW environement on host. Add an host compilation target. Change-Id: I8f736652f34c412dab20c185098abb4319bb001f Signed-off-by: Kevin Rocard <kevinx.rocard@intel.com> Reviewed-on: http://android.intel.com:8080/107406 Reviewed-by: cactus <cactus@intel.com> Reviewed-by: Gonzalve, Sebastien <sebastien.gonzalve@intel.com> Tested-by: Dixon, CharlesX <charlesx.dixon@intel.com> Reviewed-by: buildbot <buildbot@intel.com> Tested-by: buildbot <buildbot@intel.com>
* [PFW core] Add support for host buildKevin Rocard2014-02-121-19/+59
| | | | | | | | | | | | | | | | | | BZ: 107991 In order to generate setting xml at build time, one need to build and run PFW environement on host. Add an host compilation target. Change-Id: I7e3c9731ba855585b9d85e96400ace0a861910e1 Signed-off-by: Kevin Rocard <kevinx.rocard@intel.com> Reviewed-on: http://android.intel.com:8080/107272 Reviewed-by: cactus <cactus@intel.com> Reviewed-by: Gonzalve, Sebastien <sebastien.gonzalve@intel.com> Tested-by: Dixon, CharlesX <charlesx.dixon@intel.com> Reviewed-by: buildbot <buildbot@intel.com> Tested-by: buildbot <buildbot@intel.com>
* [utility] Add support for host buildKevin Rocard2014-02-121-13/+22
| | | | | | | | | | | | | | | | | | BZ: 107991 In order to generate setting xml at build time, one need to build and run PFW environement on host. Add an host compilation target. Change-Id: I3a8a2b8d0826bcabf76ce6f52f5482044623d87f Signed-off-by: Kevin Rocard <kevinx.rocard@intel.com> Reviewed-on: http://android.intel.com:8080/107271 Reviewed-by: cactus <cactus@intel.com> Reviewed-by: Gonzalve, Sebastien <sebastien.gonzalve@intel.com> Tested-by: Dixon, CharlesX <charlesx.dixon@intel.com> Reviewed-by: buildbot <buildbot@intel.com> Tested-by: buildbot <buildbot@intel.com>
* [remote-process] Add support for host buildKevin Rocard2014-02-121-16/+43
| | | | | | | | | | | | | | | | | | BZ: 107991 In order to generate setting xml at build time, one need to build and run PFW environement on host. Add an host compilation target. Change-Id: Id3e94c799b98d3414969a184ab8487051d2c2c60 Signed-off-by: Kevin Rocard <kevinx.rocard@intel.com> Reviewed-on: http://android.intel.com:8080/107270 Reviewed-by: cactus <cactus@intel.com> Reviewed-by: Gonzalve, Sebastien <sebastien.gonzalve@intel.com> Tested-by: Dixon, CharlesX <charlesx.dixon@intel.com> Reviewed-by: buildbot <buildbot@intel.com> Tested-by: buildbot <buildbot@intel.com>
* [remote-processor] Add support for host buildKevin Rocard2014-02-121-16/+37
| | | | | | | | | | | | | | | | | | BZ: 107991 In order to generate setting xml at build time, one need to build and run PFW environement on host. Add an host compilation target. Change-Id: I50b4ed0d33597db2e485c45cf2229d62b63c805e Signed-off-by: Kevin Rocard <kevinx.rocard@intel.com> Reviewed-on: http://android.intel.com:8080/107269 Reviewed-by: cactus <cactus@intel.com> Reviewed-by: Gonzalve, Sebastien <sebastien.gonzalve@intel.com> Tested-by: Dixon, CharlesX <charlesx.dixon@intel.com> Reviewed-by: buildbot <buildbot@intel.com> Tested-by: buildbot <buildbot@intel.com>
* [xml serializer] Add support for host buildKevin Rocard2014-02-121-18/+53
| | | | | | | | | | | | | | | | | | BZ: 107991 In order to generate setting xml at build time, one need to build and run PFW environement on host. Add an host compilation target. Change-Id: I0684b40c9264f18c573d646857afded6c0d4e376 Signed-off-by: Kevin Rocard <kevinx.rocard@intel.com> Reviewed-on: http://android.intel.com:8080/107268 Reviewed-by: cactus <cactus@intel.com> Reviewed-by: Gonzalve, Sebastien <sebastien.gonzalve@intel.com> Tested-by: Dixon, CharlesX <charlesx.dixon@intel.com> Reviewed-by: buildbot <buildbot@intel.com> Tested-by: buildbot <buildbot@intel.com>
* PFW: Fix missing space before := in makefilesKevin Rocard2014-02-125-22/+22
| | | | | | | | | | | | | | | | | | BZ: 107991 Some makefile were missing a space before := in makefiles Add a space before := Change-Id: Ie04cd85e3b21a0628f612a374b5c3d294fd724db Signed-off-by: Kevin Rocard <kevinx.rocard@intel.com> Reviewed-on: http://android.intel.com:8080/109305 Reviewed-by: Denneulin, Guillaume <guillaume.denneulin@intel.com> Reviewed-by: Gonzalve, Sebastien <sebastien.gonzalve@intel.com> Reviewed-by: cactus <cactus@intel.com> Tested-by: Dixon, CharlesX <charlesx.dixon@intel.com> Reviewed-by: buildbot <buildbot@intel.com> Tested-by: buildbot <buildbot@intel.com>
* Wrap command table linesKevin Rocard2014-02-121-57/+133
| | | | | | | | | | | | | | | | | | BZ: 101806 The coding style request all lines to be shorter than 100 caracters. Wrap modified table lines. Change-Id: Ib3ec331a162fff11f41ad82eedb9e84656dde2f7 Signed-off-by: Kevin Rocard <kevinx.rocard@intel.com> Reviewed-on: http://android.intel.com:8080/109776 Reviewed-by: cactus <cactus@intel.com> Reviewed-by: Gonzalve, Sebastien <sebastien.gonzalve@intel.com> Reviewed-by: Denneulin, Guillaume <guillaume.denneulin@intel.com> Tested-by: Dixon, CharlesX <charlesx.dixon@intel.com> Reviewed-by: buildbot <buildbot@intel.com> Tested-by: buildbot <buildbot@intel.com>
* Add an optional csv flag to the listCriteria commandKevin Rocard2014-02-121-3/+15
| | | | | | | | | | | | | | | | | | | | | | | | | | | BZ: 101806 The listCriteria command output is very dificult to parse. The default output format contains a lot of useless formating character: $ listCriteria BandRinging: ============ Possible states (Exclusive): {NetworkGenerated, PhoneGenerated} Current state = <none> Add a optional csv flag. With this flag, each criterion info fits in one line, with each field separated by commas: $ listCriteria csv Criterion name: BandRinging, type kind: exclusive, current state: <none>, states: {NetworkGenerated, PhoneGenerated} Change-Id: I7f2b0a86405846b03cab7f4a3023503b69c6e29b Signed-off-by: Kevin Rocard <kevinx.rocard@intel.com> Reviewed-on: http://android.intel.com:8080/102724 Reviewed-by: cactus <cactus@intel.com> Reviewed-by: Denneulin, Guillaume <guillaume.denneulin@intel.com> Reviewed-by: Gonzalve, Sebastien <sebastien.gonzalve@intel.com> Tested-by: Dixon, CharlesX <charlesx.dixon@intel.com> Reviewed-by: buildbot <buildbot@intel.com> Tested-by: buildbot <buildbot@intel.com>
* PFW: avoid warning in SubsystemObjectAndrei V. FOMITCHEV2014-02-121-3/+4
| | | | | | | | | | | | | | | | | | BZ: 103961 In current implementation of PFW, if a subsytem does not implement full interface of SubsystemObject, a warning message is logged. The purpose of this patch is to change the default behaviour and do not more log a warning. Change-Id: I51bc61a418956553d3c880aafa622ca6c2f68520 Signed-off-by: Andrei V. FOMITCHEV <andreix.fomitchev@intel.com> Reviewed-on: http://android.intel.com:8080/106320 Reviewed-by: Barthes, FabienX <fabienx.barthes@intel.com> Tested-by: Dixon, CharlesX <charlesx.dixon@intel.com> Reviewed-by: buildbot <buildbot@intel.com> Tested-by: buildbot <buildbot@intel.com>
* PFW: Remove useless export date on top of settings XML fileGuillaume Denneulin2014-02-122-20/+0
| | | | | | | | | | | | | | | | | | | | BZ: 105122 On line 3 of configurable domains xml files, a comment was added to specify date of files creation. This date makes all trivial merges on this file to fail, making rebases a harder task. Remove this comment as this kind of files are changed very often and as all modifications to this file are tracked with git. Change-Id: I4e8aedf95bbdea03137709f91242179d6acab5f3 Signed-off-by: Guillaume Denneulin <guillaume.denneulin@intel.com> Reviewed-on: http://android.intel.com:8080/105823 Reviewed-by: Rocard, KevinX <kevinx.rocard@intel.com> Reviewed-by: Gonzalve, Sebastien <sebastien.gonzalve@intel.com> Tested-by: Dixon, CharlesX <charlesx.dixon@intel.com> Reviewed-by: buildbot <buildbot@intel.com> Tested-by: buildbot <buildbot@intel.com>
* PFW: [xml generation] Change send command methodKevin Rocard2014-02-121-48/+57
| | | | | | | | | | | | | | | | | | | | BZ: 97960 The lightRoutingUpdate.sh script had bugs using adb shell commands. Push the generated script of board, then execute it remotly. Remove support for environement define pfw file and add support for multiple argument files. Change-Id: Ie43e1e2a4d3bc207a8704e7ca1a254dad74c9139 Signed-off-by: Kevin Rocard <kevinx.rocard@intel.com> Reviewed-on: http://android.intel.com:8080/93371 Reviewed-by: cactus <cactus@intel.com> Reviewed-by: Wagner, David <david.wagner@intel.com> Reviewed-by: De Chivre, Renaud <renaud.de.chivre@intel.com> Tested-by: Dixon, CharlesX <charlesx.dixon@intel.com> Reviewed-by: buildbot <buildbot@intel.com> Tested-by: buildbot <buildbot@intel.com>
* Fix incorect use of tabs, replace by spacesKevin Rocard2014-02-121-10/+10
| | | | | | | | | | | | | | | | | | BZ: 97960 Incorect use of tabs Replace by spaces Change-Id: I44e4b374e7f79ad268366a00b80b3409ab676cc2 Signed-off-by: Kevin Rocard <kevinx.rocard@intel.com> Reviewed-on: http://android.intel.com:8080/102855 Reviewed-by: Gonzalve, Sebastien <sebastien.gonzalve@intel.com> Reviewed-by: cactus <cactus@intel.com> Reviewed-by: Denneulin, Guillaume <guillaume.denneulin@intel.com> Tested-by: Dixon, CharlesX <charlesx.dixon@intel.com> Reviewed-by: buildbot <buildbot@intel.com> Tested-by: buildbot <buildbot@intel.com>
* [remote-process] Change usage messageKevin Rocard2014-02-121-2/+2
| | | | | | | | | | | | | | | | | BZ: 97960 The old usage message was not a clasic unix command usage message. Change it to "hostname port command [argument[s]]" Change-Id: I40f18e6ac81ef05e634fc5f78c8d19a202bb7a84 Signed-off-by: Kevin Rocard <kevinx.rocard@intel.com> Reviewed-on: http://android.intel.com:8080/102657 Reviewed-by: cactus <cactus@intel.com> Reviewed-by: Gonzalve, Sebastien <sebastien.gonzalve@intel.com> Tested-by: Dixon, CharlesX <charlesx.dixon@intel.com> Reviewed-by: buildbot <buildbot@intel.com> Tested-by: buildbot <buildbot@intel.com>
* PFW: [pfw parsor] Fix the useless quote added in rule commandsKevin Rocard2014-02-121-2/+2
| | | | | | | | | | | | | | | | | | | BZ: 97960 The ' in PFW rule command is useless. Delete it in script generator. Change-Id: Ifee9badbff1d6b0e1a564ed90e3a0e60cbf7b343 Signed-off-by: Kevin Rocard <kevinx.rocard@intel.com> Reviewed-on: http://android.intel.com:8080/98368 Reviewed-by: cactus <cactus@intel.com> Reviewed-by: De Chivre, Renaud <renaud.de.chivre@intel.com> Reviewed-by: Wagner, David <david.wagner@intel.com> Reviewed-by: Denneulin, Guillaume <guillaume.denneulin@intel.com> Tested-by: Dixon, CharlesX <charlesx.dixon@intel.com> Reviewed-by: buildbot <buildbot@intel.com> Tested-by: buildbot <buildbot@intel.com>
* Reduce parameter-framework log on startKevin Rocard2014-02-122-5/+1
| | | | | | | | | | | | | | | | | | BZ: 102528 The PFW used to make a lot of useless log during init. Delete those useless logs. Change-Id: I9e4cf6461d4eb643444443ea57e90f97f79571a3 Signed-off-by: Kevin Rocard <kevinx.rocard@intel.com> Reviewed-on: http://android.intel.com:8080/103882 Reviewed-by: cactus <cactus@intel.com> Reviewed-by: Gonzalve, Sebastien <sebastien.gonzalve@intel.com> Reviewed-by: Denneulin, Guillaume <guillaume.denneulin@intel.com> Tested-by: Dixon, CharlesX <charlesx.dixon@intel.com> Reviewed-by: buildbot <buildbot@intel.com> Tested-by: buildbot <buildbot@intel.com>
* PFW: Fix the useless subsystem resync on PFW loadKevin Rocard2014-02-123-2/+29
| | | | | | | | | | | | | | | | | | | | BZ: 97808 The PFW used to resynchronise some subsystems at start before back/forward syncronisation. Which was useless. Reset subsystems 'needToResync' flag during PFW start before sync to avoid this dummy resync. Change-Id: Id0c0bb786f10e2724222fc18f2085164e95f963f Signed-off-by: Kevin Rocard <kevinx.rocard@intel.com> Reviewed-on: http://android.intel.com:8080/98452 Reviewed-by: cactus <cactus@intel.com> Reviewed-by: Denneulin, Guillaume <guillaume.denneulin@intel.com> Reviewed-by: De Chivre, Renaud <renaud.de.chivre@intel.com> Tested-by: Dixon, CharlesX <charlesx.dixon@intel.com> Reviewed-by: buildbot <buildbot@intel.com> Tested-by: buildbot <buildbot@intel.com>
* PFW: [Klockwork issue] Fix const operator=Kevin Rocard2014-02-122-2/+2
| | | | | | | | | | | | | | | | | | BZ: 92744 Klockwork issue. operator = should not return a const value. Change-Id: I6525e7969295866b8d3defe1f0d38ad774edb9b9 Signed-off-by: Kevin Rocard <kevinx.rocard@intel.com> Reviewed-on: http://android.intel.com:8080/100072 Reviewed-by: Denneulin, Guillaume <guillaume.denneulin@intel.com> Reviewed-by: Gonzalve, Sebastien <sebastien.gonzalve@intel.com> Reviewed-by: Boisnard, FredericX <fredericx.boisnard@intel.com> Tested-by: Dixon, CharlesX <charlesx.dixon@intel.com> Reviewed-by: buildbot <buildbot@intel.com> Tested-by: buildbot <buildbot@intel.com>
* PFW: Coding style violation correctionKevin Rocard2014-02-123-11/+32
| | | | | | | | | | | | | | | | | | BZ: 98166 Some code is not following the coding style. Wrap too long lines according to coding style, add doxygen annotations. Change-Id: I1c160c5f2b4bedab159baadc034042ec9956cd0e Signed-off-by: Kevin Rocard <kevinx.rocard@intel.com> Reviewed-on: http://android.intel.com:8080/99545 Reviewed-by: Gonzalve, Sebastien <sebastien.gonzalve@intel.com> Reviewed-by: cactus <cactus@intel.com> Tested-by: Dixon, CharlesX <charlesx.dixon@intel.com> Reviewed-by: buildbot <buildbot@intel.com> Tested-by: buildbot <buildbot@intel.com>
* PFW: Parameter bloc can handle any mapping depthKevin Rocard2014-02-124-52/+99
| | | | | | | | | | | | | | | | | | | BZ: 85878 Needed for subsystem object definition enhancement. In a PFW structure file, if a parameter bloc is defined in another parameter bloc with context mapping only (no instanciable mapping), the PFW will no longer stop diving on the first parameter bloc. Change-Id: If4f704f01e20eb348d931c0baab1b85936fc75a4 Signed-off-by: Kevin Rocard <kevinx.rocard@intel.com> Reviewed-on: http://android.intel.com:8080/88959 Reviewed-by: Dixon, CharlesX <charlesx.dixon@intel.com> Tested-by: Dixon, CharlesX <charlesx.dixon@intel.com> Reviewed-by: Boisnard, FredericX <fredericx.boisnard@intel.com> Reviewed-by: buildbot <buildbot@intel.com> Tested-by: buildbot <buildbot@intel.com>
* PFW: [PFW script generator] Rename sup* to *GroupKevin Rocard2014-02-121-3/+2
| | | | | | | | | | | | | | | | | | BZ: 97797 Need to support the new tags for supDomains and supConf Add domainGroup, confGroup and confType in corresponding match rules. Change-Id: Ia975e77dcd8f4e9c4f8d1a48e124ecdea0647375 Signed-off-by: Kevin Rocard <kevinx.rocard@intel.com> Reviewed-on: http://android.intel.com:8080/99542 Reviewed-by: Wagner, David <david.wagner@intel.com> Reviewed-by: cactus <cactus@intel.com> Reviewed-by: Gonzalve, Sebastien <sebastien.gonzalve@intel.com> Tested-by: Dixon, CharlesX <charlesx.dixon@intel.com> Reviewed-by: buildbot <buildbot@intel.com> Tested-by: buildbot <buildbot@intel.com>
* [PFW] Fix display error when using getConfigurationParameter with ↵Frédéric Boisnard2014-02-121-3/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | BooleanParameters BZ: 96140 When using getConfigurationParameter on a BooleanParameter, the displayed value is duplicated on the output if the configuration is applicable. The method CParameterMgr::accessConfigurationValue() accesses the element twice when the configuration is the last one applied (in order to update the parameter value in both the configuration blackboard and the main blackboard). The output result is managed using a string passed as reference to ParameterMgr::accessValue() and then to CBooleanParameterType::fromBlackboard(). In the latest method, the boolean value is appended to the output string, however no check is performed to make sure that the string is empty before being used. As the method is called twice with the same output string, we end up with a dupplicated output. This fix updates CBooleanParameterType::fromBlackboard() in order to make sure that the output string is overwritten with the current result. Change-Id: I394366910b1ddc0c8bbe570aa357e007745613db Signed-off-by: Frédéric Boisnard <fredericx.boisnard@intel.com> Reviewed-on: http://android.intel.com:8080/98648 Reviewed-by: cactus <cactus@intel.com> Reviewed-by: Denneulin, Guillaume <guillaume.denneulin@intel.com> Reviewed-by: Benavoli, Patrick <patrick.benavoli@intel.com> Reviewed-by: Gonzalve, Sebastien <sebastien.gonzalve@intel.com> Tested-by: Barthes, FabienX <fabienx.barthes@intel.com> Reviewed-by: buildbot <buildbot@intel.com> Tested-by: buildbot <buildbot@intel.com>
* [PFW] Fix issue when setting a parameter of a configuration not applicableFrédéric Boisnard2014-02-123-14/+35
| | | | | | | | | | | | | | | | | | | | | BZ: 93374 This patch aims to fix an issue when using the command setConfigurationParameter to update the value of a parameter of a configuration. The autosync shall be turned off when updating the value of a parameter in a configuration that is not currently applicable. Change-Id: I12f9d37e544dc7b54f1bed0470783fdfc8568b7c Signed-off-by: Frédéric Boisnard <fredericx.boisnard@intel.com> Reviewed-on: http://android.intel.com:8080/96832 Reviewed-by: cactus <cactus@intel.com> Reviewed-by: Gonzalve, Sebastien <sebastien.gonzalve@intel.com> Reviewed-by: Denneulin, Guillaume <guillaume.denneulin@intel.com> Reviewed-by: De Chivre, Renaud <renaud.de.chivre@intel.com> Reviewed-by: Benavoli, Patrick <patrick.benavoli@intel.com> Tested-by: Dixon, CharlesX <charlesx.dixon@intel.com> Reviewed-by: buildbot <buildbot@intel.com> Tested-by: buildbot <buildbot@intel.com>
* PFW: Define generic __unused macroKevin Rocard2014-02-121-0/+28
| | | | | | | | | | | | | BZ: 83641 Change-Id: Ifb809946e955de50e50949506dff2f83ff34f568 Signed-off-by: Kevin Rocard <kevinx.rocard@intel.com> Reviewed-on: http://android.intel.com:8080/95601 Reviewed-by: Gonzalve, Sebastien <sebastien.gonzalve@intel.com> Reviewed-by: cactus <cactus@intel.com> Tested-by: Dixon, CharlesX <charlesx.dixon@intel.com> Reviewed-by: buildbot <buildbot@intel.com> Tested-by: buildbot <buildbot@intel.com>
* [PFW] Access Configurations directlyFrédéric Boisnard2014-02-1210-11/+257
| | | | | | | | | | | | | | | | | | | | | BZ: 88357 This patch aims to enable direct access to Configurations without using the main blackboard. 2 additional commands are available: - getConfigurationParameter <domain> <configuration> <param path>: Get value for parameter at given path from configuration. - setConfigurationParameter <domain> <configuration> <param path> <value> Set value for parameter at given path to configuration. Change-Id: I9357ba5141feee558fa3f7c10f62db14406433b6 Signed-off-by: Frédéric Boisnard <fredericx.boisnard@intel.com> Reviewed-on: http://android.intel.com:8080/92325 Reviewed-by: cactus <cactus@intel.com> Reviewed-by: Gonzalve, Sebastien <sebastien.gonzalve@intel.com> Tested-by: Dixon, CharlesX <charlesx.dixon@intel.com> Reviewed-by: buildbot <buildbot@intel.com> Tested-by: buildbot <buildbot@intel.com>
* [PFW] Take into account base offset when accessing value of parametersFrédéric Boisnard2014-02-128-34/+37
| | | | | | | | | | | | | | | | | | | BZ: 88357 This patch aims to offer the possibility of accessing the value of parameters from a Configuration blackboard instead of Main blackboard. The read/write operation is now relative to the base offset of the ancestor element associated to the Configuration. The base offset is stored in the ParameterAccessContext. Change-Id: I158df63d2ef3bd8cbacb84b7d2f51723ed1074f5 Signed-off-by: Frédéric Boisnard <fredericx.boisnard@intel.com> Reviewed-on: http://android.intel.com:8080/93671 Reviewed-by: cactus <cactus@intel.com> Reviewed-by: Dixon, CharlesX <charlesx.dixon@intel.com> Tested-by: Dixon, CharlesX <charlesx.dixon@intel.com> Reviewed-by: buildbot <buildbot@intel.com> Tested-by: buildbot <buildbot@intel.com>
* PFW: [coverage] Support new log syntax & error handlingKevin Rocard2014-02-121-43/+62
| | | | | | | | | | | | | | | | | | | | BZ: 86781 Support of last change criterion syntax log, - old log line: Selection criterion changed event: (.*) = (.*) - new log line: Selection criterion changed event: Criterion name: (.*), current state: (.*) Change-Id: I626ca7e5dd6deb34fda041a6e9448012b7db62e1 Signed-off-by: Kevin Rocard <kevinx.rocard@intel.com> Reviewed-on: http://android.intel.com:8080/91820 Reviewed-by: Wagner, David <david.wagner@intel.com> Reviewed-by: Gonzalve, Sebastien <sebastien.gonzalve@intel.com> Tested-by: Barthes, FabienX <fabienx.barthes@intel.com> Reviewed-by: buildbot <buildbot@intel.com> Tested-by: buildbot <buildbot@intel.com>
* Exposes API to dump inclusive criteriaFrancois Gaffie2014-02-122-1/+2
| | | | | | | | | | | | | | | | | | | | BZ: 83285 To avoid implement in route manager an helper function to dump inclusive criteria, expose an already existing API through the CriterionTypeInterface. Signed-off-by: Francois Gaffie <francois.gaffie@intel.com> Change-Id: Ib500f23872fd4da47c5d17666f75708e1627f749 Reviewed-on: http://android.intel.com:8080/90783 Reviewed-by: Gaffie, Francois <francois.gaffie@intel.com> Reviewed-by: Denneulin, Guillaume <guillaume.denneulin@intel.com> Reviewed-by: Centelles, Sylvain <sylvain.centelles@intel.com> Reviewed-by: Rocard, KevinX <kevinx.rocard@intel.com> Tested-by: Dixon, CharlesX <charlesx.dixon@intel.com> Reviewed-by: buildbot <buildbot@intel.com> Tested-by: buildbot <buildbot@intel.com>
* PFW: Support .pfw argument in lightRoutingUpdate.shKevin Rocard2014-02-121-16/+30
| | | | | | | | | | | | | | | | BZ: 86003 Adding an argument to lightRoutingUpdate.sh will overwrite the environement variable "PFWtest_DomainFile". Change-Id: Ia7447b9cb0d774bd91ec310874c0e6531ec0ea38 Signed-off-by: Kevin Rocard <kevinx.rocard@intel.com> Reviewed-on: http://android.intel.com:8080/90087 Reviewed-by: Gonzalve, Sebastien <sebastien.gonzalve@intel.com> Reviewed-by: cactus <cactus@intel.com> Tested-by: Dixon, CharlesX <charlesx.dixon@intel.com> Reviewed-by: buildbot <buildbot@intel.com> Tested-by: buildbot <buildbot@intel.com>
* PFW: Correct log level coverage scriptKevin Rocard2014-02-121-13/+31
| | | | | | | | | | | | | | BZ: 85983 Restrict debug log print to debug log level. Change-Id: I78bb79909502035247f410e9900a560190ee0ad5 Signed-off-by: Kevin Rocard <kevinx.rocard@intel.com> Reviewed-on: http://android.intel.com:8080/90085 Reviewed-by: Centelles, Sylvain <sylvain.centelles@intel.com> Tested-by: Dixon, CharlesX <charlesx.dixon@intel.com> Reviewed-by: buildbot <buildbot@intel.com> Tested-by: buildbot <buildbot@intel.com>
* PFW: Correct truncated criterion logKevin Rocard2014-02-123-4/+16
| | | | | | | | | | | | | | | | | | | | | | BZ: 85746 Create a log fonction to log a string table. Use it to call the log function for each criterion. Context: When the PFW starts, it logs the criteria, their states and possible values. All criterion logs where concatenate in a string and logged. But if there is a lot of criteria, the 512 chars long log buffer might be overfload and the log is truncated. Change-Id: I72c89b25de9314b714763b3ac71a7d0cb9698910 Signed-off-by: Kevin Rocard <kevinx.rocard@intel.com> Reviewed-on: http://android.intel.com:8080/90089 Reviewed-by: Gonzalve, Sebastien <sebastien.gonzalve@intel.com> Tested-by: Dixon, CharlesX <charlesx.dixon@intel.com> Reviewed-by: buildbot <buildbot@intel.com> Tested-by: buildbot <buildbot@intel.com>
* sortAsound.conf.sh do not handle spacesFrédéric Boisnard2014-02-121-1/+1
| | | | | | | | | | | | | | | | | | BZ: 85879 This patch fixes a small bug in the sortAsound.conf.sh script, now it is allowed to have multiple spaces around the property 'value' for a hook in the asound.conf file. Change-Id: Iad3e51d4d56c371b5f7d57f333013f23d840a645 Signed-off-by: Frédéric Boisnard <fredericx.boisnard@intel.com> Reviewed-on: http://android.intel.com:8080/90959 Reviewed-by: cactus <cactus@intel.com> Reviewed-by: Denneulin, Guillaume <guillaume.denneulin@intel.com> Reviewed-by: Rocard, KevinX <kevinx.rocard@intel.com> Reviewed-by: Gonzalve, Sebastien <sebastien.gonzalve@intel.com> Tested-by: Dixon, CharlesX <charlesx.dixon@intel.com> Reviewed-by: buildbot <buildbot@intel.com> Tested-by: buildbot <buildbot@intel.com>
generated by cgit v1.1 at 2025-07-25 06:59:18 +0000