aboutsummaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Add getbitposition API for bitfieldFrancois Gaffie2014-02-121-0/+8
| | | | | | | | | | | | | | | | | | | BZ: 99956 Bitfield parameter type does not allow to retrieve the position of the bit. This patch introduces a new API to retrieve the bit position in the bitfield Change-Id: I54bf8a446e7bd53bed6acda274d32966a737c877 Signed-off-by: Francois Gaffie <francois.gaffie@intel.com> Reviewed-on: http://android.intel.com:8080/138517 Reviewed-by: Quintero, Jorge <jorge.quintero@intel.com> Reviewed-by: Centelles, Sylvain <sylvain.centelles@intel.com> Tested-by: Barthes, FabienX <fabienx.barthes@intel.com> Reviewed-by: Balestriere, VianneyX <vianneyx.balestriere@intel.com> Tested-by: Balestriere, VianneyX <vianneyx.balestriere@intel.com>
* Allow component in parameter block in xsd schemasKevin Rocard2014-02-124-9/+8
| | | | | | | | | | | | | | | | | | BZ: 154054 Components are now allowed in parameter block since the patch 140555. Reflect that in xsd schemas. Change-Id: I43c03d6fd7754096b4e19d7fa5d10dce6bb2b10e Signed-off-by: Kevin Rocard <kevinx.rocard@intel.com> Reviewed-on: http://android.intel.com:8080/146241 Reviewed-by: cactus <cactus@intel.com> Reviewed-by: Denneulin, Guillaume <guillaume.denneulin@intel.com> Reviewed-by: De Chivre, Renaud <renaud.de.chivre@intel.com> Tested-by: Barthes, FabienX <fabienx.barthes@intel.com> Reviewed-by: Balestriere, VianneyX <vianneyx.balestriere@intel.com> Tested-by: Balestriere, VianneyX <vianneyx.balestriere@intel.com>
* fix build errorJin Wei2014-02-122-2/+2
| | | | | | | host version of lib libicuuc has changed to libicuuc-host Change-Id: I936a8e196d01d8cacf4ce0d64370b9cddccd8b3a Signed-off-by: Jin Wei <wei.a.jin@intel.com>
* fix the build errorXiaokang Qin2014-02-121-0/+1
| | | | | Change-Id: Ide3521a161a3e0903531b2093c87679a80b5870c Signed-off-by: Xiaokang Qin <xiaokang.qin@intel.com>
* Fix typo in PFW when loading pluginsFrédéric Boisnard2014-02-122-2/+2
| | | | | | | | | | | | BZ: 151782 There is a typo in the error message when a plugin is not found (folowings instead of following). This patch updates the error message. Change-Id: Ifdb749fd90d646d0c04522874e879a329520de0f Signed-off-by: Frédéric Boisnard <fredericx.boisnard@intel.com>
* [xml generation] Ignore errors in clean upKevin Rocard2014-02-121-4/+7
| | | | | | | | | | | | BZ: 152121 As the hostDomainGenerator clean up function can be called after any command, some clean commands were sometime irrelevant. Clean commands should not fail. Change-Id: I0e472919cd77abe393bca090a95d1c72cf77d58c Signed-off-by: Kevin Rocard <kevinx.rocard@intel.com>
* Avoid integer overflow while calculating max valuesDmitry Shkurko2014-02-123-4/+12
| | | | | | | | | | | | BZ: 134249 The behavior is undefined in the case of signed integer overflow for enum and fixed point parameter types. Modify the behavior to handle correctly the signed integers. Change-Id: Idbd0798a39f826853ae1afcd05cebd897675b9a8 Signed-off-by: Dmitry Shkurko <Dmitry.V.Shkurko@intel.com>
* Export lightRoutingUpdate for external buildKevin Rocard2014-02-121-0/+8
| | | | | | | | | | | | | | BZ: 145379 As the lightRoutingUpdate.sh script is in private, it is not exported for external release. As a result external clients can not use lightRoutingUpdate to generate xml from .pfw. Export lightRoutingUpdate to make it available in $ANDROID_HOST_OUT/system/bin after compilation. Change-Id: Id174ddb4dd0e31a7c5ede66e91b0db341745ff21 Signed-off-by: Kevin Rocard <kevinx.rocard@intel.com>
* hostDomainGenerator.sh: fix lock permissionsFrédéric Boisnard2014-02-121-1/+10
| | | | | | | | | | | | | | | | BZ: 149851 The hostDomainGenerator.sh script uses a lockfile to protect some operations from concurrent execution. This mechanism uses a file that is created if it does not already exist. In this case, the file permissions are too stricts, and other users are unable to run the script anymore. This patch changes the permission on the lockfile, allowing other users to access it. Change-Id: Iec250a4022cb8f97973fa92020b27dc0e83890c6 Signed-off-by: Frédéric Boisnard <fredericx.boisnard@intel.com>
* Fix hostDomainGenerator socket-checking mechanism for Ubuntu 13.04Frédéric Boisnard2014-02-121-1/+1
| | | | | | | | | | | | | | | | | | BZ: 148729 The script hostDomainGenerator.sh doesn't work fine on Ubuntu 13.04. The processing is based on the external tool "ss" to monitor opened sockets, in order to check if existing instances of test-platform are currently started. It appears that the behavior of this tool is different in the latest Ubuntu release: requests of opened sockets always return multiple false results. In consequence, the script cannot find any available port to start a new test-platform instance. This patch updates the way opened sockets are checked, using "grep" instead of the "ss" filter mechanism. Change-Id: I2e1245c524d021d99389a0ec028105ed1f706666 Signed-off-by: Frédéric Boisnard <fredericx.boisnard@intel.com>
* [PFW] Add possibility to put mapping info in component nodesKevin Rocard2014-02-121-2/+0
| | | | | | | | | | | | | BZ: 147490 Components did not support instantiation mapping (mapping that instantiate subsystem objects) which leaded to artificial parameter bloc use, ie a useless level. Treat the components as parameter block as for instantiation mappings. Change-Id: I64834dbdcbda9ab32a29d6c70dc12da5b5fe6d35 Signed-off-by: Georges-Henri Baron <georges-henrix.baron@intel.com>
* Allow concurent generation of XML routing filesFrédéric Boisnard2014-02-121-0/+19
| | | | | | | | | | | | | | | | | | BZ: 145938 XML generation is impossible when multiple instances of the script hostDomainGeneration are run (this is typically the case with the current Android Make process). This is because the way the ports used to communicate with test-platform and parameter-framework are chosen is not protected agains concurrent executions. This patch protects the initialization of the test-platform and parameter-framework agains concurrent executions using a flock. In particular, it ensures that the ports chosen are reserved to a specific process. Change-Id: I3d8fee2b20313814c79f5390851ad57dc696cc28 Signed-off-by: Frédéric Boisnard <fredericx.boisnard@intel.com>
* HostDomainGenerator: Do not try to use port if already in useKevin Rocard2014-02-121-0/+13
| | | | | | | | | | | | | | | | | | BZ: 144262 Currently, the hostDomainGenerator script doesn't check if the port used by the testPlatform is already used. This patch adds this new check. Change-Id: I323575f97f7437c01ce4e2d0b127aa658639af06 Signed-off-by: Kevin Rocard <kevinx.rocard@intel.com> Reviewed-on: http://android.intel.com:8080/136085 Reviewed-by: Boisnard, FredericX <fredericx.boisnard@intel.com> Reviewed-by: De Chivre, Renaud <renaud.de.chivre@intel.com> Tested-by: Barthes, FabienX <fabienx.barthes@intel.com> Reviewed-by: cactus <cactus@intel.com> Tested-by: cactus <cactus@intel.com>
* HostDomainGenerator: Fix relative linkKevin Rocard2014-02-121-2/+2
| | | | | | | | | | | | | | | | | | | | BZ: 144262 Currently, the hostDomainGenrator doesn't handle well some relative links. This patch fixes the issue. Change-Id: I7289b98c4e367a880ce0eac9238693f80c540a3c Signed-off-by: Kevin Rocard <kevinx.rocard@intel.com> Reviewed-on: http://android.intel.com:8080/135931 Reviewed-by: Boisnard, FredericX <fredericx.boisnard@intel.com> Reviewed-by: Denneulin, Guillaume <guillaume.denneulin@intel.com> Reviewed-by: Gaio, MiguelX <miguelx.gaio@intel.com> Reviewed-by: De Chivre, Renaud <renaud.de.chivre@intel.com> Tested-by: Barthes, FabienX <fabienx.barthes@intel.com> Reviewed-by: cactus <cactus@intel.com> Tested-by: cactus <cactus@intel.com>
* Handle key names in mapping contextRenaud de Chivre2014-02-124-10/+56
| | | | | | | | | | | | | | | | | | | | | BZ: 126002 Mapping context only allows to retrieve a mapping value from its corresponding key ID. We also want to do the same using its key as a string. This patch adds key name handling in context mapping. It also adds an API to retieve a mapping value from its corresponding key name. Note: it also removes an unused argument from handleMappingContext function. Change-Id: I5a18ad624a69272ea2796090692f2bfa8b373a52 Signed-off-by: Renaud de Chivre <renaud.de.chivre@intel.com> Reviewed-on: http://android.intel.com:8080/131571 Tested-by: Dixon, CharlesX <charlesx.dixon@intel.com> Reviewed-by: cactus <cactus@intel.com> Tested-by: cactus <cactus@intel.com>
* Add debug symbols in host buildRenaud de Chivre2014-02-121-1/+1
| | | | | | | | | | | | | | | | BZ: 126002 Host build is used for testing and debugging purpose. It shall contain debug symbols and shall no be optimized. This patch add required compilation flags to achieve this. Change-Id: I6dec6166ca4c705a3ccc7a9ddd6f5a955a91f910 Signed-off-by: Renaud de Chivre <renaud.de.chivre@intel.com> Reviewed-on: http://android.intel.com:8080/131570 Tested-by: Dixon, CharlesX <charlesx.dixon@intel.com> Reviewed-by: cactus <cactus@intel.com> Tested-by: cactus <cactus@intel.com>
* [Workaround] Force execution rightKevin Rocard2014-02-121-0/+7
| | | | | | | | | | | | | | | | BZ: 122982 The build system does not preserve execution right in external prebuild Add the execution rights witch chmod on executables. Change-Id: Ieac44050e80df0e0f83e1a6b947edc432ef00260 Signed-off-by: Kevin Rocard <kevinx.rocard@intel.com> Reviewed-on: http://android.intel.com:8080/134359 Reviewed-by: Gonzalve, Sebastien <sebastien.gonzalve@intel.com> Tested-by: Barthes, FabienX <fabienx.barthes@intel.com> Reviewed-by: cactus <cactus@intel.com> Tested-by: cactus <cactus@intel.com>
* xml generation host script and makefileKevin Rocard2014-02-123-0/+242
| | | | | | | | | | | | | | | | | BZ: 122982 In order to generate the xml at build time, make has to launch an executable (bash script here) that will take care of all the process. This patch adds this script and the corresponding makefile. Change-Id: Ifb2a6374afd4c73283e3d2371548b069c1fa72a6 Signed-off-by: Kevin Rocard <kevinx.rocard@intel.com> Reviewed-on: http://android.intel.com:8080/119957 Reviewed-by: Gonzalve, Sebastien <sebastien.gonzalve@intel.com> Tested-by: Barthes, FabienX <fabienx.barthes@intel.com> Reviewed-by: cactus <cactus@intel.com> Tested-by: cactus <cactus@intel.com>
* XML generation pfw config file formatKevin Rocard2014-02-122-0/+89
| | | | | | | | | | | | | | | | | | BZ: 122982 In order to generate the xml at build time, pfw configuration file must be formated for simulation. This patch adds this script and the corresponding makefile. Change-Id: Ice404ec151b379dfd34d3a5c0b8a57f27d017356 Signed-off-by: Kevin Rocard <kevinx.rocard@intel.com> Reviewed-on: http://android.intel.com:8080/132851 Reviewed-by: Denneulin, Guillaume <guillaume.denneulin@intel.com> Reviewed-by: Centelles, Sylvain <sylvain.centelles@intel.com> Tested-by: Barthes, FabienX <fabienx.barthes@intel.com> Reviewed-by: cactus <cactus@intel.com> Tested-by: cactus <cactus@intel.com>
* Clean useless extern "C" and wrong documentationKevin Rocard2014-02-122-14/+4
| | | | | | | | | | | | | | | | | BZ: 122982 Doxygen documentation was wrongly formated. An extern "C" was useless. Fix it. Change-Id: I1c144af30c692dc124bda90058f8caff1090ae3d Signed-off-by: Kevin Rocard <kevinx.rocard@intel.com> Reviewed-on: http://android.intel.com:8080/130520 Reviewed-by: Centelles, Sylvain <sylvain.centelles@intel.com> Tested-by: Barthes, FabienX <fabienx.barthes@intel.com> Reviewed-by: cactus <cactus@intel.com> Tested-by: cactus <cactus@intel.com>
* Convert PFWScriptGenerator.py to python2Kevin Rocard2014-02-121-21/+23
| | | | | | | | | | | | | | | | | BZ: 122982 As python3 is not included in android build dependancy, PFWScriptGenerator.py could not be executed in the build process. Convert it to python2. Change-Id: I0e946534bde321d0a6567270b35a80ff3b38a551 Signed-off-by: Kevin Rocard <kevinx.rocard@intel.com> Reviewed-on: http://android.intel.com:8080/130256 Reviewed-by: Centelles, Sylvain <sylvain.centelles@intel.com> Tested-by: Barthes, FabienX <fabienx.barthes@intel.com> Reviewed-by: cactus <cactus@intel.com> Tested-by: cactus <cactus@intel.com>
* Add the setFailureOnFailedSettingsLoad commandKevin Rocard2014-02-122-19/+47
| | | | | | | | | | | | | | | | | | | BZ: 122982 The failure on failed settings load option was added by the previous patch (Ifd3cd859ad0eaef266be4c9245ebd28c9e9c0a74) but not expose in test-platform. Create command to expose the boolean getters and setters of the ParameterMgrConector in a generic way. Change-Id: I438ab36c2d1141dc139d528f83b570f4d5078d19 Signed-off-by: Kevin Rocard <kevinx.rocard@intel.com> Reviewed-on: http://android.intel.com:8080/119925 Reviewed-by: Centelles, Sylvain <sylvain.centelles@intel.com> Tested-by: Barthes, FabienX <fabienx.barthes@intel.com> Reviewed-by: cactus <cactus@intel.com> Tested-by: cactus <cactus@intel.com>
* Add an option to continue on failed setting loadKevin Rocard2014-02-124-5/+89
| | | | | | | | | | | | | | | | | BZ: 122982 When the PFW starts it loads the configurable domains, if the load fails, it used to abort the parameterMgr global load. Add an option to continue on failed setting load, as if there were none. Change-Id: Ifd3cd859ad0eaef266be4c9245ebd28c9e9c0a74 Signed-off-by: Kevin Rocard <kevinx.rocard@intel.com> Reviewed-on: http://android.intel.com:8080/119924 Reviewed-by: Centelles, Sylvain <sylvain.centelles@intel.com> Tested-by: Barthes, FabienX <fabienx.barthes@intel.com> Reviewed-by: cactus <cactus@intel.com> Tested-by: cactus <cactus@intel.com>
* Wrap lines too longs and add doxygenKevin Rocard2014-02-123-51/+117
| | | | | | | | | | | | | | | | BZ: 122982 Some lines were not compliant with the coding style. Wrap them and add doxigen. Change-Id: I5271b78b1e879a39914a4405a58d7366148b6972 Signed-off-by: Kevin Rocard <kevinx.rocard@intel.com> Reviewed-on: http://android.intel.com:8080/119424 Reviewed-by: Centelles, Sylvain <sylvain.centelles@intel.com> Tested-by: Barthes, FabienX <fabienx.barthes@intel.com> Reviewed-by: cactus <cactus@intel.com> Tested-by: cactus <cactus@intel.com>
* Add a command to set missing subsystem policyKevin Rocard2014-02-124-4/+70
| | | | | | | | | | | | | | | | | | | BZ: 122982 When the PFW starts, it loads subsystems using their corresponding plugins. If a requested plugin is not found, the start fails. This is a problem, as for host, plugins are not compiled. Add a command in test platform to use the feature continue load on missing subsystem. Change-Id: Ib533123683b860bfbe0fea069f4bb3c1cc1ef2d0 Signed-off-by: Kevin Rocard <kevinx.rocard@intel.com> Reviewed-on: http://android.intel.com:8080/119305 Reviewed-by: Centelles, Sylvain <sylvain.centelles@intel.com> Tested-by: Barthes, FabienX <fabienx.barthes@intel.com> Reviewed-by: cactus <cactus@intel.com> Tested-by: cactus <cactus@intel.com>
* Add missing subsystem policyKevin Rocard2014-02-124-8/+79
| | | | | | | | | | | | | | | | | | BZ: 122982 When the PFW starts it loads subsystems using there corresponding plugin. If the requested plugin is not found, the start fails. This is a problem, as for host, the plugins are not compiled. Add a command in the public API to ignore missing subsystem. Change-Id: I7597e3fef33466638191ff70b76e7faa9f979418 Signed-off-by: Kevin Rocard <kevinx.rocard@intel.com> Reviewed-on: http://android.intel.com:8080/118039 Reviewed-by: Centelles, Sylvain <sylvain.centelles@intel.com> Tested-by: Barthes, FabienX <fabienx.barthes@intel.com> Reviewed-by: cactus <cactus@intel.com> Tested-by: cactus <cactus@intel.com>
* Split subsystems loadingKevin Rocard2014-02-122-25/+55
| | | | | | | | | | | | | | | | BZ: 122982 The CSystemClass::loadSubsystems was too long. Create a subfunction to load subsystems defined in shared libraries. Change-Id: I8f40ee271f25d0996e1976d8ee2ef6c12581d1d4 Signed-off-by: Kevin Rocard <kevinx.rocard@intel.com> Reviewed-on: http://android.intel.com:8080/118192 Reviewed-by: Centelles, Sylvain <sylvain.centelles@intel.com> Tested-by: Barthes, FabienX <fabienx.barthes@intel.com> Reviewed-by: cactus <cactus@intel.com> Tested-by: cactus <cactus@intel.com>
* Optional fallback on virtual subsystemKevin Rocard2014-02-122-60/+66
| | | | | | | | | | | | | | | | | | | BZ: 122982 When the PFW starts, it loads subsystems using their corresponding plugins. If a requested plugin is not found, the start fails. This is a problem, as for host, plugins are not compiled. Add an option to fallback on virtual subsystem if a plugin is not found during load. Change-Id: Id408873fdc904612c0c741524b33025d7d199fe9 Signed-off-by: Kevin Rocard <kevinx.rocard@intel.com> Reviewed-on: http://android.intel.com:8080/117709 Reviewed-by: Centelles, Sylvain <sylvain.centelles@intel.com> Tested-by: Barthes, FabienX <fabienx.barthes@intel.com> Reviewed-by: cactus <cactus@intel.com> Tested-by: cactus <cactus@intel.com>
* Add default element fallbackKevin Rocard2014-02-125-23/+106
| | | | | | | | | | | | | | | | | | | BZ: 122982 The element library class is a factory that receives an xml node and instanciates the corresponding element. In some case, it would be usefull not to fail if no matching builder is found but use a default one. Add a setDefaultElementBuilder method to set the default builder to fallback to, in case no matching builder is found. Change-Id: I58f0ada3450195a3ca7d878e4b666b0a9359b499 Signed-off-by: Kevin Rocard <kevinx.rocard@intel.com> Reviewed-on: http://android.intel.com:8080/118042 Reviewed-by: Centelles, Sylvain <sylvain.centelles@intel.com> Tested-by: Barthes, FabienX <fabienx.barthes@intel.com> Reviewed-by: cactus <cactus@intel.com> Tested-by: cactus <cactus@intel.com>
* Change the element builder semanticKevin Rocard2014-02-1211-82/+45
| | | | | | | | | | | | | | | | | | | | BZ: 122982 To parse XML, the PFW uses factories containing a map of XML tags and their associated builder builder. The builders used to contain the XML tag of the XML element that it will use in the context of the factory. A builder and an XML tag are already linked by the factory, thus the tag member in the builder is redundant. Remove the XML tag builder attribute and provide it on factory filling. Change-Id: I827c3b34dffb23bc850316d0b092b31c21987ac2 Signed-off-by: Kevin Rocard <kevinx.rocard@intel.com> Reviewed-on: http://android.intel.com:8080/124214 Reviewed-by: Centelles, Sylvain <sylvain.centelles@intel.com> Tested-by: Barthes, FabienX <fabienx.barthes@intel.com> Reviewed-by: cactus <cactus@intel.com> Tested-by: cactus <cactus@intel.com>
* Fix issue in PFW when loading host librariesFrédéric Boisnard2014-02-121-13/+18
| | | | | | | | | | | | | | | | | | | | | BZ: 127874 Default entry point for plugins libraries must follow the pattern "lib*-subsystem.so". However, when compiling on host, the plugins are named "lib*-subsystem_host.so", so the PFW is unable to load them. This patch modifies the way plugins symbols are detected, so that host libraries can be loaded successfully. Change-Id: I079162c3e47a975641b3d7cb1fc054f95c86028e Signed-off-by: Frédéric Boisnard <fredericx.boisnard@intel.com> Reviewed-on: http://android.intel.com:8080/122812 Reviewed-by: Rocard, KevinX <kevinx.rocard@intel.com> Reviewed-by: Gonzalve, Sebastien <sebastien.gonzalve@intel.com> Tested-by: Dixon, CharlesX <charlesx.dixon@intel.com> Reviewed-by: cactus <cactus@intel.com> Tested-by: cactus <cactus@intel.com>
* Fix bug when retrieving a boolean through a handleFrédéric Boisnard2014-02-122-2/+11
| | | | | | | | | | | | | | | | | | | | | BZ: 127872 There is a bug in the CParameterHandle::getAsBoolean() method: instead of accepting a reference to a bool in argument, it takes a copy of the boolean. The fix consists in accepting a reference as parameter. Change-Id: Id1078534620b4cd37b81efa28471ecf8f7e644b5 Signed-off-by: Frédéric Boisnard <fredericx.boisnard@intel.com> Reviewed-on: http://android.intel.com:8080/122811 Reviewed-by: buildbot <buildbot@intel.com> Reviewed-by: Rocard, KevinX <kevinx.rocard@intel.com> Reviewed-by: De Chivre, Renaud <renaud.de.chivre@intel.com> Reviewed-by: Denneulin, Guillaume <guillaume.denneulin@intel.com> Tested-by: Dixon, CharlesX <charlesx.dixon@intel.com> Reviewed-by: cactus <cactus@intel.com> Tested-by: cactus <cactus@intel.com>
* PFW: Update CFLAGS to add Wall, Werror, Wextra everywhereFrédéric Boisnard2014-02-125-0/+49
| | | | | | | | | | | | | | | | | | | BZ: 129048 Some Makefiles of the PFW projects are missing the regular CFLAGS -Wall, -Werror and -Wextra. This patch aims to update the CLFAGS of these Makefiles. Some source code had to be updated because warnings are now considered as errors. Change-Id: Icc91f7bdc649118f822411d9b4693776a84037e9 Signed-off-by: Frédéric Boisnard <fredericx.boisnard@intel.com> Reviewed-on: http://android.intel.com:8080/123977 Reviewed-by: Rocard, KevinX <kevinx.rocard@intel.com> Reviewed-by: De Chivre, Renaud <renaud.de.chivre@intel.com> Tested-by: Dixon, CharlesX <charlesx.dixon@intel.com> Reviewed-by: cactus <cactus@intel.com> Tested-by: cactus <cactus@intel.com>
* [PFW] Fix typo in the naming of the SubsystemBuilder APIFrédéric Boisnard2014-02-123-10/+10
| | | | | | | | | | | | | | | | | | BZ: 124779 There is a typo in the naming of the SubsystemBuilder API, "Susbystem" is used instead of "Subsystem". This patch replaces all occurences of "Susbystem" with "Subsystem". Change-Id: Ic132bdc685013257a138465545b99d001c46535a Signed-off-by: Frédéric Boisnard <fredericx.boisnard@intel.com> Reviewed-on: http://android.intel.com:8080/120166 Reviewed-by: Denneulin, Guillaume <guillaume.denneulin@intel.com> Reviewed-by: De Chivre, Renaud <renaud.de.chivre@intel.com> Tested-by: Barthes, FabienX <fabienx.barthes@intel.com> Reviewed-by: buildbot <buildbot@intel.com> Tested-by: buildbot <buildbot@intel.com>
* Add showMapping command to the PFWFrederic Boisnard2014-02-1214-96/+652
| | | | | | | | | | | | | | | | | | | | BZ: 99822 Developers often need to get the mapping corresponding to a specific parameter. However, the PFW doesn't provide a command to achieve this goal. This patch aims to add the showMapping command to the PFW. Change-Id: I05af64a408abe4ceb7f5d177a0ff5fa0461034d0 Signed-off-by: Frédéric Boisnard <fredericx.boisnard@intel.com> Reviewed-on: http://android.intel.com:8080/105145 Reviewed-by: Benavoli, Patrick <patrick.benavoli@intel.com> Reviewed-by: Denneulin, Guillaume <guillaume.denneulin@intel.com> Reviewed-by: Gonzalve, Sebastien <sebastien.gonzalve@intel.com> Tested-by: Barthes, FabienX <fabienx.barthes@intel.com> Reviewed-by: buildbot <buildbot@intel.com> Tested-by: buildbot <buildbot@intel.com>
* [PFW] Add getFormattedMapping for InstanceConfigurableElementsFrederic Boisnard2014-02-1213-21/+150
| | | | | | | | | | | | | | | | | | | | | BZ: 99822 The mapping data need to be printed, however helper methods are missing to achieve this easily. This patch aims to add a new method "getFormattedMapping()" for CMappingData, allowing to format the mapping data as a string. Change-Id: Ia030c6b88905fcb7591ad45339712051eb88d1c1 Signed-off-by: Frederic Boisnard <fredericx.boisnard@intel.com> Reviewed-on: http://android.intel.com:8080/109301 Reviewed-by: Benavoli, Patrick <patrick.benavoli@intel.com> Reviewed-by: De Chivre, Renaud <renaud.de.chivre@intel.com> Reviewed-by: Rocard, KevinX <kevinx.rocard@intel.com> Reviewed-by: Denneulin, Guillaume <guillaume.denneulin@intel.com> Tested-by: Barthes, FabienX <fabienx.barthes@intel.com> Reviewed-by: buildbot <buildbot@intel.com> Tested-by: buildbot <buildbot@intel.com>
* parameter-framework: Remove the hardcoding from TOP of treeChetan Rao2014-02-126-10/+10
| | | | | | | | | | | | | | | | | | | BZ: 120651 Remove the hard coding of path from TOP of android build tree. pathmap_INCL has been extended to add AOSP include dirs used by parameter framework. Need to use the MACRO include-path-for defined in build/core/pathmap.mk to include the AOSP paths Change-Id: Ic7c9eb4bcf39db5e31d14c785d8d2e37ab53af78 Signed-off-by: Chetan Rao <chetan.rao@intel.com> Reviewed-on: http://android.intel.com:8080/105311 Reviewed-by: Dixon, CharlesX <charlesx.dixon@intel.com> Tested-by: Barthes, FabienX <fabienx.barthes@intel.com> Reviewed-by: Rocard, KevinX <kevinx.rocard@intel.com> Reviewed-by: buildbot <buildbot@intel.com> Tested-by: buildbot <buildbot@intel.com>
* [xml generation] Update import commandKevin Rocard2014-02-121-1/+9
| | | | | | | | | | | | | | | | | | | | BZ: 116653 The command getDomainsXML was renamed to getDomainsWithSettingsXML. Use getDomainsWithSettingsXML instead of getDomainsXML as the default import command. Fallback on deprecated command getDomainsXML if the new command getDomainsWithSettingsXML does not exist. Change-Id: Ie16d7d5a27d998248cfefc628d3b99f83e64076a Signed-off-by: Kevin Rocard <kevinx.rocard@intel.com> Reviewed-on: http://android.intel.com:8080/113883 Reviewed-by: cactus <cactus@intel.com> Reviewed-by: Denneulin, Guillaume <guillaume.denneulin@intel.com> Reviewed-by: De Chivre, Renaud <renaud.de.chivre@intel.com> Tested-by: Dixon, CharlesX <charlesx.dixon@intel.com> Reviewed-by: buildbot <buildbot@intel.com> Tested-by: buildbot <buildbot@intel.com>
* [coverage] Generate report from aplogsKevin Rocard2014-02-121-0/+121
| | | | | | | | | | | | | | | | | | | | | BZ: 115218 To generate a domain coverage report, one need to order the aplog in chronological order, parse them with coverage.py, giving the right options and generate the html report. Do all of those tasks in a simple-to-use script. Command example: ./aplog2coverage.sh -d domains.xml -eRouteManager aplog* -f -o report.html Change-Id: I6640f988b20c7115af91757ed83aa8febbcbd31f Signed-off-by: Kevin Rocard <kevinx.rocard@intel.com> Reviewed-on: http://android.intel.com:8080/114668 Reviewed-by: cactus <cactus@intel.com> Reviewed-by: Gonzalve, Sebastien <sebastien.gonzalve@intel.com> Tested-by: Dixon, CharlesX <charlesx.dixon@intel.com> Reviewed-by: buildbot <buildbot@intel.com> Tested-by: buildbot <buildbot@intel.com>
* [coverage] Add a coverage translation to html xslt scriptKevin Rocard2014-02-121-0/+329
| | | | | | | | | | | | | | | | | | BZ: 115218 The coverage report generated is in xml, hard to read, file. Add an xslt script (and a css) to convert it to html in this new folder. Change-Id: Ic55a72e717c6b8bafa9d6a2e5e82af0d00317d0f Signed-off-by: Kevin Rocard <kevinx.rocard@intel.com> Reviewed-on: http://android.intel.com:8080/112825 Reviewed-by: Graulle, JeremieX <jeremiex.graulle@intel.com> Reviewed-by: De Chivre, Renaud <renaud.de.chivre@intel.com> Reviewed-by: cactus <cactus@intel.com> Tested-by: Dixon, CharlesX <charlesx.dixon@intel.com> Reviewed-by: buildbot <buildbot@intel.com> Tested-by: buildbot <buildbot@intel.com>
* [coverage] Remplace tabulation indentation by spacesKevin Rocard2014-02-121-726/+726
| | | | | | | | | | | | | | | | | | | BZ: 115218 The coding style request that file should be indented with spaces not tabs. Replaces each tab by 4 spaces. Change-Id: I15c665bf9a4feeff5512fba9e8c883c378f106a7 Signed-off-by: Kevin Rocard <kevinx.rocard@intel.com> Reviewed-on: http://android.intel.com:8080/115316 Reviewed-by: Denneulin, Guillaume <guillaume.denneulin@intel.com> Reviewed-by: De Chivre, Renaud <renaud.de.chivre@intel.com> Reviewed-by: cactus <cactus@intel.com> Tested-by: Dixon, CharlesX <charlesx.dixon@intel.com> Reviewed-by: buildbot <buildbot@intel.com> Tested-by: buildbot <buildbot@intel.com>
* [coverage] Move coverage generator in it's own folderKevin Rocard2014-02-121-0/+0
| | | | | | | | | | | | | | | | | | | | BZ: 115218 The coverage report generated script was in the tools folder. Other files will be used for coverage reports. Create a coverage folder in order to contain all coverage report utilities. Change-Id: I23ed75fb109cd4a5f6804398ef17d99e046fd49d Signed-off-by: Kevin Rocard <kevinx.rocard@intel.com> Reviewed-on: http://android.intel.com:8080/114667 Reviewed-by: Denneulin, Guillaume <guillaume.denneulin@intel.com> Reviewed-by: Gonzalve, Sebastien <sebastien.gonzalve@intel.com> Reviewed-by: cactus <cactus@intel.com> Tested-by: Dixon, CharlesX <charlesx.dixon@intel.com> Reviewed-by: buildbot <buildbot@intel.com> Tested-by: buildbot <buildbot@intel.com>
* [coverage] Create a root element with coverage attributesKevin Rocard2014-02-121-9/+8
| | | | | | | | | | | | | | | | | | | | BZ: 115218 The exported xml coverage report root element did not contain any attributes thus the total coverage was not outputted. Use the base export to xml - modified to use an existing node - to export the root element. Change-Id: I706a45159ae0af5a1b353f7776f62dab3c64f3f5 Signed-off-by: Kevin Rocard <kevinx.rocard@intel.com> Reviewed-on: http://android.intel.com:8080/114695 Reviewed-by: Denneulin, Guillaume <guillaume.denneulin@intel.com> Reviewed-by: De Chivre, Renaud <renaud.de.chivre@intel.com> Reviewed-by: cactus <cactus@intel.com> Tested-by: Dixon, CharlesX <charlesx.dixon@intel.com> Reviewed-by: buildbot <buildbot@intel.com> Tested-by: buildbot <buildbot@intel.com>
* [coverage] Lazy rule evaluationKevin Rocard2014-02-121-4/+7
| | | | | | | | | | | | | | | | | | BZ: 115218 The all and any rule were not lazy. This was a mismatch with the PFW. Make all and any compound rules lazy. Change-Id: If29e3b3f888be40ebf4027d318ae6017396d4d7b Signed-off-by: Kevin Rocard <kevinx.rocard@intel.com> Reviewed-on: http://android.intel.com:8080/114694 Reviewed-by: Denneulin, Guillaume <guillaume.denneulin@intel.com> Reviewed-by: De Chivre, Renaud <renaud.de.chivre@intel.com> Reviewed-by: cactus <cactus@intel.com> Tested-by: Dixon, CharlesX <charlesx.dixon@intel.com> Reviewed-by: buildbot <buildbot@intel.com> Tested-by: buildbot <buildbot@intel.com>
* [Coverage] Change coverage calculation algorithmKevin Rocard2014-02-121-10/+14
| | | | | | | | | | | | | | | | | | | | | BZ: 115218 The coverage was the number of children used divided by the number of children. This was a mistake as a child could have been used despite that all it's descendants might not have been. With this patch the coverage of an element is the coverage children average. Change-Id: I52c9990bec0ed006c70a27aa174898b96829baf5 Signed-off-by: Kevin Rocard <kevinx.rocard@intel.com> Reviewed-on: http://android.intel.com:8080/114693 Reviewed-by: Denneulin, Guillaume <guillaume.denneulin@intel.com> Reviewed-by: De Chivre, Renaud <renaud.de.chivre@intel.com> Reviewed-by: cactus <cactus@intel.com> Tested-by: Dixon, CharlesX <charlesx.dixon@intel.com> Reviewed-by: buildbot <buildbot@intel.com> Tested-by: buildbot <buildbot@intel.com>
* [coverage] Delete useless log message to gain performanceKevin Rocard2014-02-121-6/+1
| | | | | | | | | | | | | | | | | | | | | BZ: 115218 The __eq__ function is very used (1M time in my test), but cProfile showed that it was one of the most slow functions (in cumulate time). Delete useless log in the function in order to gain 90% performance (10s to 1s in cumulate time). Change-Id: I1ece15186cb30947f2c2af277cd0b326ea72c7ea Signed-off-by: Kevin Rocard <kevinx.rocard@intel.com> Reviewed-on: http://android.intel.com:8080/112933 Reviewed-by: Denneulin, Guillaume <guillaume.denneulin@intel.com> Reviewed-by: Gonzalve, Sebastien <sebastien.gonzalve@intel.com> Reviewed-by: cactus <cactus@intel.com> Tested-by: Dixon, CharlesX <charlesx.dixon@intel.com> Reviewed-by: buildbot <buildbot@intel.com> Tested-by: buildbot <buildbot@intel.com>
* [coverage] Set the default error filter level to errorKevin Rocard2014-02-121-3/+3
| | | | | | | | | | | | | | | | | | | BZ: 115218 The default log filter level was set to warning or info, depending on the libraries availables. Set it always to error. Change-Id: I939165f881095798eea874c2c268cfffcf6187fe Signed-off-by: Kevin Rocard <kevinx.rocard@intel.com> Reviewed-on: http://android.intel.com:8080/112715 Reviewed-by: Denneulin, Guillaume <guillaume.denneulin@intel.com> Reviewed-by: Gonzalve, Sebastien <sebastien.gonzalve@intel.com> Reviewed-by: cactus <cactus@intel.com> Tested-by: Dixon, CharlesX <charlesx.dixon@intel.com> Reviewed-by: buildbot <buildbot@intel.com> Tested-by: buildbot <buildbot@intel.com>
* [coverage] Add flags to ignore errorsKevin Rocard2014-02-121-6/+51
| | | | | | | | | | | | | | | | | | | | | | | | | | | BZ: 115218 2 errors can be raised when parsing PFW logs: - criterion that change their state that is not allowed. The PFW allows an exclusive criterion to be in the none state. - configuration not applicable according to the criterion states that are however applied. It happens in case of log corruption (log lines missing). The user should be able to ignore those 2 errors if low coverage accuracy is allowed. Add the flags: --ignore-incoherent-criterion-state --ignore-ineligible-configuration-application Change-Id: I1a25b47a05e974d711b735e344f9352904c8771b Signed-off-by: Kevin Rocard <kevinx.rocard@intel.com> Reviewed-on: http://android.intel.com:8080/112714 Reviewed-by: Denneulin, Guillaume <guillaume.denneulin@intel.com> Reviewed-by: Gonzalve, Sebastien <sebastien.gonzalve@intel.com> Reviewed-by: cactus <cactus@intel.com> Tested-by: Dixon, CharlesX <charlesx.dixon@intel.com> Reviewed-by: buildbot <buildbot@intel.com> Tested-by: buildbot <buildbot@intel.com>
* [Coverage] Reset criterion on it's recreationKevin Rocard2014-02-121-1/+11
| | | | | | | | | | | | | | | | | | BZ: 115218 The script was not handling criterion recreation (usually on PFW restart). Reset criterion on it's recreation. Change-Id: I169717c1c62f89ce81b21909f3ee4b981d5e91d8 Signed-off-by: Kevin Rocard <kevinx.rocard@intel.com> Reviewed-on: http://android.intel.com:8080/112713 Reviewed-by: Denneulin, Guillaume <guillaume.denneulin@intel.com> Reviewed-by: Gonzalve, Sebastien <sebastien.gonzalve@intel.com> Reviewed-by: cactus <cactus@intel.com> Tested-by: Dixon, CharlesX <charlesx.dixon@intel.com> Reviewed-by: buildbot <buildbot@intel.com> Tested-by: buildbot <buildbot@intel.com>
* [Coverage] Raise duplicated criterion specialised exceptionKevin Rocard2014-02-121-1/+4
| | | | | | | | | | | | | | | | | | | | | | | BZ: 115218 When an element is requested to adopt multiple times the same element, the "DuplicatedChildError" exception is raised. However, in case of PFW restart, existing criteria are recreated, which is throwing the generic "DuplicatedChildError" exception. As such event need to be detected, specialise the "DuplicatedChildError" exception in "DuplicatedCriterionError" in order to catch the event easily. Change-Id: Ib0cca1d318233ca0b2f69fd277740ce8f5a550ad Signed-off-by: Kevin Rocard <kevinx.rocard@intel.com> Reviewed-on: http://android.intel.com:8080/112712 Reviewed-by: Denneulin, Guillaume <guillaume.denneulin@intel.com> Reviewed-by: Gonzalve, Sebastien <sebastien.gonzalve@intel.com> Reviewed-by: cactus <cactus@intel.com> Tested-by: Dixon, CharlesX <charlesx.dixon@intel.com> Reviewed-by: buildbot <buildbot@intel.com> Tested-by: buildbot <buildbot@intel.com>
generated by cgit v1.1 at 2024-12-23 23:05:12 +0000