aboutsummaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
...
* XML generation pfw config file formatKevin Rocard2014-02-122-0/+89
| | | | | | | | | | | | | | | | | | BZ: 122982 In order to generate the xml at build time, pfw configuration file must be formated for simulation. This patch adds this script and the corresponding makefile. Change-Id: Ice404ec151b379dfd34d3a5c0b8a57f27d017356 Signed-off-by: Kevin Rocard <kevinx.rocard@intel.com> Reviewed-on: http://android.intel.com:8080/132851 Reviewed-by: Denneulin, Guillaume <guillaume.denneulin@intel.com> Reviewed-by: Centelles, Sylvain <sylvain.centelles@intel.com> Tested-by: Barthes, FabienX <fabienx.barthes@intel.com> Reviewed-by: cactus <cactus@intel.com> Tested-by: cactus <cactus@intel.com>
* Clean useless extern "C" and wrong documentationKevin Rocard2014-02-122-14/+4
| | | | | | | | | | | | | | | | | BZ: 122982 Doxygen documentation was wrongly formated. An extern "C" was useless. Fix it. Change-Id: I1c144af30c692dc124bda90058f8caff1090ae3d Signed-off-by: Kevin Rocard <kevinx.rocard@intel.com> Reviewed-on: http://android.intel.com:8080/130520 Reviewed-by: Centelles, Sylvain <sylvain.centelles@intel.com> Tested-by: Barthes, FabienX <fabienx.barthes@intel.com> Reviewed-by: cactus <cactus@intel.com> Tested-by: cactus <cactus@intel.com>
* Convert PFWScriptGenerator.py to python2Kevin Rocard2014-02-121-21/+23
| | | | | | | | | | | | | | | | | BZ: 122982 As python3 is not included in android build dependancy, PFWScriptGenerator.py could not be executed in the build process. Convert it to python2. Change-Id: I0e946534bde321d0a6567270b35a80ff3b38a551 Signed-off-by: Kevin Rocard <kevinx.rocard@intel.com> Reviewed-on: http://android.intel.com:8080/130256 Reviewed-by: Centelles, Sylvain <sylvain.centelles@intel.com> Tested-by: Barthes, FabienX <fabienx.barthes@intel.com> Reviewed-by: cactus <cactus@intel.com> Tested-by: cactus <cactus@intel.com>
* Add the setFailureOnFailedSettingsLoad commandKevin Rocard2014-02-122-19/+47
| | | | | | | | | | | | | | | | | | | BZ: 122982 The failure on failed settings load option was added by the previous patch (Ifd3cd859ad0eaef266be4c9245ebd28c9e9c0a74) but not expose in test-platform. Create command to expose the boolean getters and setters of the ParameterMgrConector in a generic way. Change-Id: I438ab36c2d1141dc139d528f83b570f4d5078d19 Signed-off-by: Kevin Rocard <kevinx.rocard@intel.com> Reviewed-on: http://android.intel.com:8080/119925 Reviewed-by: Centelles, Sylvain <sylvain.centelles@intel.com> Tested-by: Barthes, FabienX <fabienx.barthes@intel.com> Reviewed-by: cactus <cactus@intel.com> Tested-by: cactus <cactus@intel.com>
* Add an option to continue on failed setting loadKevin Rocard2014-02-124-5/+89
| | | | | | | | | | | | | | | | | BZ: 122982 When the PFW starts it loads the configurable domains, if the load fails, it used to abort the parameterMgr global load. Add an option to continue on failed setting load, as if there were none. Change-Id: Ifd3cd859ad0eaef266be4c9245ebd28c9e9c0a74 Signed-off-by: Kevin Rocard <kevinx.rocard@intel.com> Reviewed-on: http://android.intel.com:8080/119924 Reviewed-by: Centelles, Sylvain <sylvain.centelles@intel.com> Tested-by: Barthes, FabienX <fabienx.barthes@intel.com> Reviewed-by: cactus <cactus@intel.com> Tested-by: cactus <cactus@intel.com>
* Wrap lines too longs and add doxygenKevin Rocard2014-02-123-51/+117
| | | | | | | | | | | | | | | | BZ: 122982 Some lines were not compliant with the coding style. Wrap them and add doxigen. Change-Id: I5271b78b1e879a39914a4405a58d7366148b6972 Signed-off-by: Kevin Rocard <kevinx.rocard@intel.com> Reviewed-on: http://android.intel.com:8080/119424 Reviewed-by: Centelles, Sylvain <sylvain.centelles@intel.com> Tested-by: Barthes, FabienX <fabienx.barthes@intel.com> Reviewed-by: cactus <cactus@intel.com> Tested-by: cactus <cactus@intel.com>
* Add a command to set missing subsystem policyKevin Rocard2014-02-124-4/+70
| | | | | | | | | | | | | | | | | | | BZ: 122982 When the PFW starts, it loads subsystems using their corresponding plugins. If a requested plugin is not found, the start fails. This is a problem, as for host, plugins are not compiled. Add a command in test platform to use the feature continue load on missing subsystem. Change-Id: Ib533123683b860bfbe0fea069f4bb3c1cc1ef2d0 Signed-off-by: Kevin Rocard <kevinx.rocard@intel.com> Reviewed-on: http://android.intel.com:8080/119305 Reviewed-by: Centelles, Sylvain <sylvain.centelles@intel.com> Tested-by: Barthes, FabienX <fabienx.barthes@intel.com> Reviewed-by: cactus <cactus@intel.com> Tested-by: cactus <cactus@intel.com>
* Add missing subsystem policyKevin Rocard2014-02-124-8/+79
| | | | | | | | | | | | | | | | | | BZ: 122982 When the PFW starts it loads subsystems using there corresponding plugin. If the requested plugin is not found, the start fails. This is a problem, as for host, the plugins are not compiled. Add a command in the public API to ignore missing subsystem. Change-Id: I7597e3fef33466638191ff70b76e7faa9f979418 Signed-off-by: Kevin Rocard <kevinx.rocard@intel.com> Reviewed-on: http://android.intel.com:8080/118039 Reviewed-by: Centelles, Sylvain <sylvain.centelles@intel.com> Tested-by: Barthes, FabienX <fabienx.barthes@intel.com> Reviewed-by: cactus <cactus@intel.com> Tested-by: cactus <cactus@intel.com>
* Split subsystems loadingKevin Rocard2014-02-122-25/+55
| | | | | | | | | | | | | | | | BZ: 122982 The CSystemClass::loadSubsystems was too long. Create a subfunction to load subsystems defined in shared libraries. Change-Id: I8f40ee271f25d0996e1976d8ee2ef6c12581d1d4 Signed-off-by: Kevin Rocard <kevinx.rocard@intel.com> Reviewed-on: http://android.intel.com:8080/118192 Reviewed-by: Centelles, Sylvain <sylvain.centelles@intel.com> Tested-by: Barthes, FabienX <fabienx.barthes@intel.com> Reviewed-by: cactus <cactus@intel.com> Tested-by: cactus <cactus@intel.com>
* Optional fallback on virtual subsystemKevin Rocard2014-02-122-60/+66
| | | | | | | | | | | | | | | | | | | BZ: 122982 When the PFW starts, it loads subsystems using their corresponding plugins. If a requested plugin is not found, the start fails. This is a problem, as for host, plugins are not compiled. Add an option to fallback on virtual subsystem if a plugin is not found during load. Change-Id: Id408873fdc904612c0c741524b33025d7d199fe9 Signed-off-by: Kevin Rocard <kevinx.rocard@intel.com> Reviewed-on: http://android.intel.com:8080/117709 Reviewed-by: Centelles, Sylvain <sylvain.centelles@intel.com> Tested-by: Barthes, FabienX <fabienx.barthes@intel.com> Reviewed-by: cactus <cactus@intel.com> Tested-by: cactus <cactus@intel.com>
* Add default element fallbackKevin Rocard2014-02-125-23/+106
| | | | | | | | | | | | | | | | | | | BZ: 122982 The element library class is a factory that receives an xml node and instanciates the corresponding element. In some case, it would be usefull not to fail if no matching builder is found but use a default one. Add a setDefaultElementBuilder method to set the default builder to fallback to, in case no matching builder is found. Change-Id: I58f0ada3450195a3ca7d878e4b666b0a9359b499 Signed-off-by: Kevin Rocard <kevinx.rocard@intel.com> Reviewed-on: http://android.intel.com:8080/118042 Reviewed-by: Centelles, Sylvain <sylvain.centelles@intel.com> Tested-by: Barthes, FabienX <fabienx.barthes@intel.com> Reviewed-by: cactus <cactus@intel.com> Tested-by: cactus <cactus@intel.com>
* Change the element builder semanticKevin Rocard2014-02-1211-82/+45
| | | | | | | | | | | | | | | | | | | | BZ: 122982 To parse XML, the PFW uses factories containing a map of XML tags and their associated builder builder. The builders used to contain the XML tag of the XML element that it will use in the context of the factory. A builder and an XML tag are already linked by the factory, thus the tag member in the builder is redundant. Remove the XML tag builder attribute and provide it on factory filling. Change-Id: I827c3b34dffb23bc850316d0b092b31c21987ac2 Signed-off-by: Kevin Rocard <kevinx.rocard@intel.com> Reviewed-on: http://android.intel.com:8080/124214 Reviewed-by: Centelles, Sylvain <sylvain.centelles@intel.com> Tested-by: Barthes, FabienX <fabienx.barthes@intel.com> Reviewed-by: cactus <cactus@intel.com> Tested-by: cactus <cactus@intel.com>
* Fix issue in PFW when loading host librariesFrédéric Boisnard2014-02-121-13/+18
| | | | | | | | | | | | | | | | | | | | | BZ: 127874 Default entry point for plugins libraries must follow the pattern "lib*-subsystem.so". However, when compiling on host, the plugins are named "lib*-subsystem_host.so", so the PFW is unable to load them. This patch modifies the way plugins symbols are detected, so that host libraries can be loaded successfully. Change-Id: I079162c3e47a975641b3d7cb1fc054f95c86028e Signed-off-by: Frédéric Boisnard <fredericx.boisnard@intel.com> Reviewed-on: http://android.intel.com:8080/122812 Reviewed-by: Rocard, KevinX <kevinx.rocard@intel.com> Reviewed-by: Gonzalve, Sebastien <sebastien.gonzalve@intel.com> Tested-by: Dixon, CharlesX <charlesx.dixon@intel.com> Reviewed-by: cactus <cactus@intel.com> Tested-by: cactus <cactus@intel.com>
* Fix bug when retrieving a boolean through a handleFrédéric Boisnard2014-02-122-2/+11
| | | | | | | | | | | | | | | | | | | | | BZ: 127872 There is a bug in the CParameterHandle::getAsBoolean() method: instead of accepting a reference to a bool in argument, it takes a copy of the boolean. The fix consists in accepting a reference as parameter. Change-Id: Id1078534620b4cd37b81efa28471ecf8f7e644b5 Signed-off-by: Frédéric Boisnard <fredericx.boisnard@intel.com> Reviewed-on: http://android.intel.com:8080/122811 Reviewed-by: buildbot <buildbot@intel.com> Reviewed-by: Rocard, KevinX <kevinx.rocard@intel.com> Reviewed-by: De Chivre, Renaud <renaud.de.chivre@intel.com> Reviewed-by: Denneulin, Guillaume <guillaume.denneulin@intel.com> Tested-by: Dixon, CharlesX <charlesx.dixon@intel.com> Reviewed-by: cactus <cactus@intel.com> Tested-by: cactus <cactus@intel.com>
* PFW: Update CFLAGS to add Wall, Werror, Wextra everywhereFrédéric Boisnard2014-02-125-0/+49
| | | | | | | | | | | | | | | | | | | BZ: 129048 Some Makefiles of the PFW projects are missing the regular CFLAGS -Wall, -Werror and -Wextra. This patch aims to update the CLFAGS of these Makefiles. Some source code had to be updated because warnings are now considered as errors. Change-Id: Icc91f7bdc649118f822411d9b4693776a84037e9 Signed-off-by: Frédéric Boisnard <fredericx.boisnard@intel.com> Reviewed-on: http://android.intel.com:8080/123977 Reviewed-by: Rocard, KevinX <kevinx.rocard@intel.com> Reviewed-by: De Chivre, Renaud <renaud.de.chivre@intel.com> Tested-by: Dixon, CharlesX <charlesx.dixon@intel.com> Reviewed-by: cactus <cactus@intel.com> Tested-by: cactus <cactus@intel.com>
* [PFW] Fix typo in the naming of the SubsystemBuilder APIFrédéric Boisnard2014-02-123-10/+10
| | | | | | | | | | | | | | | | | | BZ: 124779 There is a typo in the naming of the SubsystemBuilder API, "Susbystem" is used instead of "Subsystem". This patch replaces all occurences of "Susbystem" with "Subsystem". Change-Id: Ic132bdc685013257a138465545b99d001c46535a Signed-off-by: Frédéric Boisnard <fredericx.boisnard@intel.com> Reviewed-on: http://android.intel.com:8080/120166 Reviewed-by: Denneulin, Guillaume <guillaume.denneulin@intel.com> Reviewed-by: De Chivre, Renaud <renaud.de.chivre@intel.com> Tested-by: Barthes, FabienX <fabienx.barthes@intel.com> Reviewed-by: buildbot <buildbot@intel.com> Tested-by: buildbot <buildbot@intel.com>
* Add showMapping command to the PFWFrederic Boisnard2014-02-1214-96/+652
| | | | | | | | | | | | | | | | | | | | BZ: 99822 Developers often need to get the mapping corresponding to a specific parameter. However, the PFW doesn't provide a command to achieve this goal. This patch aims to add the showMapping command to the PFW. Change-Id: I05af64a408abe4ceb7f5d177a0ff5fa0461034d0 Signed-off-by: Frédéric Boisnard <fredericx.boisnard@intel.com> Reviewed-on: http://android.intel.com:8080/105145 Reviewed-by: Benavoli, Patrick <patrick.benavoli@intel.com> Reviewed-by: Denneulin, Guillaume <guillaume.denneulin@intel.com> Reviewed-by: Gonzalve, Sebastien <sebastien.gonzalve@intel.com> Tested-by: Barthes, FabienX <fabienx.barthes@intel.com> Reviewed-by: buildbot <buildbot@intel.com> Tested-by: buildbot <buildbot@intel.com>
* [PFW] Add getFormattedMapping for InstanceConfigurableElementsFrederic Boisnard2014-02-1213-21/+150
| | | | | | | | | | | | | | | | | | | | | BZ: 99822 The mapping data need to be printed, however helper methods are missing to achieve this easily. This patch aims to add a new method "getFormattedMapping()" for CMappingData, allowing to format the mapping data as a string. Change-Id: Ia030c6b88905fcb7591ad45339712051eb88d1c1 Signed-off-by: Frederic Boisnard <fredericx.boisnard@intel.com> Reviewed-on: http://android.intel.com:8080/109301 Reviewed-by: Benavoli, Patrick <patrick.benavoli@intel.com> Reviewed-by: De Chivre, Renaud <renaud.de.chivre@intel.com> Reviewed-by: Rocard, KevinX <kevinx.rocard@intel.com> Reviewed-by: Denneulin, Guillaume <guillaume.denneulin@intel.com> Tested-by: Barthes, FabienX <fabienx.barthes@intel.com> Reviewed-by: buildbot <buildbot@intel.com> Tested-by: buildbot <buildbot@intel.com>
* parameter-framework: Remove the hardcoding from TOP of treeChetan Rao2014-02-126-10/+10
| | | | | | | | | | | | | | | | | | | BZ: 120651 Remove the hard coding of path from TOP of android build tree. pathmap_INCL has been extended to add AOSP include dirs used by parameter framework. Need to use the MACRO include-path-for defined in build/core/pathmap.mk to include the AOSP paths Change-Id: Ic7c9eb4bcf39db5e31d14c785d8d2e37ab53af78 Signed-off-by: Chetan Rao <chetan.rao@intel.com> Reviewed-on: http://android.intel.com:8080/105311 Reviewed-by: Dixon, CharlesX <charlesx.dixon@intel.com> Tested-by: Barthes, FabienX <fabienx.barthes@intel.com> Reviewed-by: Rocard, KevinX <kevinx.rocard@intel.com> Reviewed-by: buildbot <buildbot@intel.com> Tested-by: buildbot <buildbot@intel.com>
* [xml generation] Update import commandKevin Rocard2014-02-121-1/+9
| | | | | | | | | | | | | | | | | | | | BZ: 116653 The command getDomainsXML was renamed to getDomainsWithSettingsXML. Use getDomainsWithSettingsXML instead of getDomainsXML as the default import command. Fallback on deprecated command getDomainsXML if the new command getDomainsWithSettingsXML does not exist. Change-Id: Ie16d7d5a27d998248cfefc628d3b99f83e64076a Signed-off-by: Kevin Rocard <kevinx.rocard@intel.com> Reviewed-on: http://android.intel.com:8080/113883 Reviewed-by: cactus <cactus@intel.com> Reviewed-by: Denneulin, Guillaume <guillaume.denneulin@intel.com> Reviewed-by: De Chivre, Renaud <renaud.de.chivre@intel.com> Tested-by: Dixon, CharlesX <charlesx.dixon@intel.com> Reviewed-by: buildbot <buildbot@intel.com> Tested-by: buildbot <buildbot@intel.com>
* [coverage] Generate report from aplogsKevin Rocard2014-02-121-0/+121
| | | | | | | | | | | | | | | | | | | | | BZ: 115218 To generate a domain coverage report, one need to order the aplog in chronological order, parse them with coverage.py, giving the right options and generate the html report. Do all of those tasks in a simple-to-use script. Command example: ./aplog2coverage.sh -d domains.xml -eRouteManager aplog* -f -o report.html Change-Id: I6640f988b20c7115af91757ed83aa8febbcbd31f Signed-off-by: Kevin Rocard <kevinx.rocard@intel.com> Reviewed-on: http://android.intel.com:8080/114668 Reviewed-by: cactus <cactus@intel.com> Reviewed-by: Gonzalve, Sebastien <sebastien.gonzalve@intel.com> Tested-by: Dixon, CharlesX <charlesx.dixon@intel.com> Reviewed-by: buildbot <buildbot@intel.com> Tested-by: buildbot <buildbot@intel.com>
* [coverage] Add a coverage translation to html xslt scriptKevin Rocard2014-02-121-0/+329
| | | | | | | | | | | | | | | | | | BZ: 115218 The coverage report generated is in xml, hard to read, file. Add an xslt script (and a css) to convert it to html in this new folder. Change-Id: Ic55a72e717c6b8bafa9d6a2e5e82af0d00317d0f Signed-off-by: Kevin Rocard <kevinx.rocard@intel.com> Reviewed-on: http://android.intel.com:8080/112825 Reviewed-by: Graulle, JeremieX <jeremiex.graulle@intel.com> Reviewed-by: De Chivre, Renaud <renaud.de.chivre@intel.com> Reviewed-by: cactus <cactus@intel.com> Tested-by: Dixon, CharlesX <charlesx.dixon@intel.com> Reviewed-by: buildbot <buildbot@intel.com> Tested-by: buildbot <buildbot@intel.com>
* [coverage] Remplace tabulation indentation by spacesKevin Rocard2014-02-121-726/+726
| | | | | | | | | | | | | | | | | | | BZ: 115218 The coding style request that file should be indented with spaces not tabs. Replaces each tab by 4 spaces. Change-Id: I15c665bf9a4feeff5512fba9e8c883c378f106a7 Signed-off-by: Kevin Rocard <kevinx.rocard@intel.com> Reviewed-on: http://android.intel.com:8080/115316 Reviewed-by: Denneulin, Guillaume <guillaume.denneulin@intel.com> Reviewed-by: De Chivre, Renaud <renaud.de.chivre@intel.com> Reviewed-by: cactus <cactus@intel.com> Tested-by: Dixon, CharlesX <charlesx.dixon@intel.com> Reviewed-by: buildbot <buildbot@intel.com> Tested-by: buildbot <buildbot@intel.com>
* [coverage] Move coverage generator in it's own folderKevin Rocard2014-02-121-0/+0
| | | | | | | | | | | | | | | | | | | | BZ: 115218 The coverage report generated script was in the tools folder. Other files will be used for coverage reports. Create a coverage folder in order to contain all coverage report utilities. Change-Id: I23ed75fb109cd4a5f6804398ef17d99e046fd49d Signed-off-by: Kevin Rocard <kevinx.rocard@intel.com> Reviewed-on: http://android.intel.com:8080/114667 Reviewed-by: Denneulin, Guillaume <guillaume.denneulin@intel.com> Reviewed-by: Gonzalve, Sebastien <sebastien.gonzalve@intel.com> Reviewed-by: cactus <cactus@intel.com> Tested-by: Dixon, CharlesX <charlesx.dixon@intel.com> Reviewed-by: buildbot <buildbot@intel.com> Tested-by: buildbot <buildbot@intel.com>
* [coverage] Create a root element with coverage attributesKevin Rocard2014-02-121-9/+8
| | | | | | | | | | | | | | | | | | | | BZ: 115218 The exported xml coverage report root element did not contain any attributes thus the total coverage was not outputted. Use the base export to xml - modified to use an existing node - to export the root element. Change-Id: I706a45159ae0af5a1b353f7776f62dab3c64f3f5 Signed-off-by: Kevin Rocard <kevinx.rocard@intel.com> Reviewed-on: http://android.intel.com:8080/114695 Reviewed-by: Denneulin, Guillaume <guillaume.denneulin@intel.com> Reviewed-by: De Chivre, Renaud <renaud.de.chivre@intel.com> Reviewed-by: cactus <cactus@intel.com> Tested-by: Dixon, CharlesX <charlesx.dixon@intel.com> Reviewed-by: buildbot <buildbot@intel.com> Tested-by: buildbot <buildbot@intel.com>
* [coverage] Lazy rule evaluationKevin Rocard2014-02-121-4/+7
| | | | | | | | | | | | | | | | | | BZ: 115218 The all and any rule were not lazy. This was a mismatch with the PFW. Make all and any compound rules lazy. Change-Id: If29e3b3f888be40ebf4027d318ae6017396d4d7b Signed-off-by: Kevin Rocard <kevinx.rocard@intel.com> Reviewed-on: http://android.intel.com:8080/114694 Reviewed-by: Denneulin, Guillaume <guillaume.denneulin@intel.com> Reviewed-by: De Chivre, Renaud <renaud.de.chivre@intel.com> Reviewed-by: cactus <cactus@intel.com> Tested-by: Dixon, CharlesX <charlesx.dixon@intel.com> Reviewed-by: buildbot <buildbot@intel.com> Tested-by: buildbot <buildbot@intel.com>
* [Coverage] Change coverage calculation algorithmKevin Rocard2014-02-121-10/+14
| | | | | | | | | | | | | | | | | | | | | BZ: 115218 The coverage was the number of children used divided by the number of children. This was a mistake as a child could have been used despite that all it's descendants might not have been. With this patch the coverage of an element is the coverage children average. Change-Id: I52c9990bec0ed006c70a27aa174898b96829baf5 Signed-off-by: Kevin Rocard <kevinx.rocard@intel.com> Reviewed-on: http://android.intel.com:8080/114693 Reviewed-by: Denneulin, Guillaume <guillaume.denneulin@intel.com> Reviewed-by: De Chivre, Renaud <renaud.de.chivre@intel.com> Reviewed-by: cactus <cactus@intel.com> Tested-by: Dixon, CharlesX <charlesx.dixon@intel.com> Reviewed-by: buildbot <buildbot@intel.com> Tested-by: buildbot <buildbot@intel.com>
* [coverage] Delete useless log message to gain performanceKevin Rocard2014-02-121-6/+1
| | | | | | | | | | | | | | | | | | | | | BZ: 115218 The __eq__ function is very used (1M time in my test), but cProfile showed that it was one of the most slow functions (in cumulate time). Delete useless log in the function in order to gain 90% performance (10s to 1s in cumulate time). Change-Id: I1ece15186cb30947f2c2af277cd0b326ea72c7ea Signed-off-by: Kevin Rocard <kevinx.rocard@intel.com> Reviewed-on: http://android.intel.com:8080/112933 Reviewed-by: Denneulin, Guillaume <guillaume.denneulin@intel.com> Reviewed-by: Gonzalve, Sebastien <sebastien.gonzalve@intel.com> Reviewed-by: cactus <cactus@intel.com> Tested-by: Dixon, CharlesX <charlesx.dixon@intel.com> Reviewed-by: buildbot <buildbot@intel.com> Tested-by: buildbot <buildbot@intel.com>
* [coverage] Set the default error filter level to errorKevin Rocard2014-02-121-3/+3
| | | | | | | | | | | | | | | | | | | BZ: 115218 The default log filter level was set to warning or info, depending on the libraries availables. Set it always to error. Change-Id: I939165f881095798eea874c2c268cfffcf6187fe Signed-off-by: Kevin Rocard <kevinx.rocard@intel.com> Reviewed-on: http://android.intel.com:8080/112715 Reviewed-by: Denneulin, Guillaume <guillaume.denneulin@intel.com> Reviewed-by: Gonzalve, Sebastien <sebastien.gonzalve@intel.com> Reviewed-by: cactus <cactus@intel.com> Tested-by: Dixon, CharlesX <charlesx.dixon@intel.com> Reviewed-by: buildbot <buildbot@intel.com> Tested-by: buildbot <buildbot@intel.com>
* [coverage] Add flags to ignore errorsKevin Rocard2014-02-121-6/+51
| | | | | | | | | | | | | | | | | | | | | | | | | | | BZ: 115218 2 errors can be raised when parsing PFW logs: - criterion that change their state that is not allowed. The PFW allows an exclusive criterion to be in the none state. - configuration not applicable according to the criterion states that are however applied. It happens in case of log corruption (log lines missing). The user should be able to ignore those 2 errors if low coverage accuracy is allowed. Add the flags: --ignore-incoherent-criterion-state --ignore-ineligible-configuration-application Change-Id: I1a25b47a05e974d711b735e344f9352904c8771b Signed-off-by: Kevin Rocard <kevinx.rocard@intel.com> Reviewed-on: http://android.intel.com:8080/112714 Reviewed-by: Denneulin, Guillaume <guillaume.denneulin@intel.com> Reviewed-by: Gonzalve, Sebastien <sebastien.gonzalve@intel.com> Reviewed-by: cactus <cactus@intel.com> Tested-by: Dixon, CharlesX <charlesx.dixon@intel.com> Reviewed-by: buildbot <buildbot@intel.com> Tested-by: buildbot <buildbot@intel.com>
* [Coverage] Reset criterion on it's recreationKevin Rocard2014-02-121-1/+11
| | | | | | | | | | | | | | | | | | BZ: 115218 The script was not handling criterion recreation (usually on PFW restart). Reset criterion on it's recreation. Change-Id: I169717c1c62f89ce81b21909f3ee4b981d5e91d8 Signed-off-by: Kevin Rocard <kevinx.rocard@intel.com> Reviewed-on: http://android.intel.com:8080/112713 Reviewed-by: Denneulin, Guillaume <guillaume.denneulin@intel.com> Reviewed-by: Gonzalve, Sebastien <sebastien.gonzalve@intel.com> Reviewed-by: cactus <cactus@intel.com> Tested-by: Dixon, CharlesX <charlesx.dixon@intel.com> Reviewed-by: buildbot <buildbot@intel.com> Tested-by: buildbot <buildbot@intel.com>
* [Coverage] Raise duplicated criterion specialised exceptionKevin Rocard2014-02-121-1/+4
| | | | | | | | | | | | | | | | | | | | | | | BZ: 115218 When an element is requested to adopt multiple times the same element, the "DuplicatedChildError" exception is raised. However, in case of PFW restart, existing criteria are recreated, which is throwing the generic "DuplicatedChildError" exception. As such event need to be detected, specialise the "DuplicatedChildError" exception in "DuplicatedCriterionError" in order to catch the event easily. Change-Id: Ib0cca1d318233ca0b2f69fd277740ce8f5a550ad Signed-off-by: Kevin Rocard <kevinx.rocard@intel.com> Reviewed-on: http://android.intel.com:8080/112712 Reviewed-by: Denneulin, Guillaume <guillaume.denneulin@intel.com> Reviewed-by: Gonzalve, Sebastien <sebastien.gonzalve@intel.com> Reviewed-by: cactus <cactus@intel.com> Tested-by: Dixon, CharlesX <charlesx.dixon@intel.com> Reviewed-by: buildbot <buildbot@intel.com> Tested-by: buildbot <buildbot@intel.com>
* [Coverage] Support criterion incoherent stateKevin Rocard2014-02-121-11/+30
| | | | | | | | | | | | | | | | | | | | BZ: 115218 In case of incoherent log (corrupted), some transitions described in the log are not permitted by the internal criterion state machine. Resulting in raising an exception and stopping the program. Add an optional parameter to ignore integrity. Change-Id: I288c0e482b223aa0023e09fb158036b39d0ed8bf Signed-off-by: Kevin Rocard <kevinx.rocard@intel.com> Reviewed-on: http://android.intel.com:8080/112711 Reviewed-by: Denneulin, Guillaume <guillaume.denneulin@intel.com> Reviewed-by: Gonzalve, Sebastien <sebastien.gonzalve@intel.com> Reviewed-by: cactus <cactus@intel.com> Tested-by: Dixon, CharlesX <charlesx.dixon@intel.com> Reviewed-by: buildbot <buildbot@intel.com> Tested-by: buildbot <buildbot@intel.com>
* [Coverage] Move exception class in the relevant classKevin Rocard2014-02-121-13/+17
| | | | | | | | | | | | | | | | | | | BZ: 115218 Some exceptions were raised only by a particular class. As a result they were polluting the global namespace. Nested the exception class. Change-Id: Icde35d8d2f551a638b97d94bc0a770f70787c723 Signed-off-by: Kevin Rocard <kevinx.rocard@intel.com> Reviewed-on: http://android.intel.com:8080/112710 Reviewed-by: Denneulin, Guillaume <guillaume.denneulin@intel.com> Reviewed-by: Gonzalve, Sebastien <sebastien.gonzalve@intel.com> Reviewed-by: cactus <cactus@intel.com> Tested-by: Dixon, CharlesX <charlesx.dixon@intel.com> Reviewed-by: buildbot <buildbot@intel.com> Tested-by: buildbot <buildbot@intel.com>
* [Coverage] Delete dangerous assert, raise exceptionKevin Rocard2014-02-121-2/+0
| | | | | | | | | | | | | | | | | | | | BZ: 115218 An assert was checking function input parameters that came from an input file. As a result an corrupted file would stop the program without the opportunity to catch the error. Remove the assert and let the function raise the appropriate exception. Change-Id: Ic8d8d318ca191040c546e354c0911d56670b1030 Signed-off-by: Kevin Rocard <kevinx.rocard@intel.com> Reviewed-on: http://android.intel.com:8080/112709 Reviewed-by: Denneulin, Guillaume <guillaume.denneulin@intel.com> Reviewed-by: Gonzalve, Sebastien <sebastien.gonzalve@intel.com> Reviewed-by: cactus <cactus@intel.com> Tested-by: Dixon, CharlesX <charlesx.dixon@intel.com> Reviewed-by: buildbot <buildbot@intel.com> Tested-by: buildbot <buildbot@intel.com>
* [Coverage] Delete useless bracketsKevin Rocard2014-02-121-4/+2
| | | | | | | | | | | | | | | | | | | BZ: 115218 Some brackets around return value were used to wrap lines that did not need to be wrapped. Unwrap lines and delete the brackets. Change-Id: I7583deff42b8b4db1ef7dbb61f24329dec908ec3 Signed-off-by: Kevin Rocard <kevinx.rocard@intel.com> Reviewed-on: http://android.intel.com:8080/112708 Reviewed-by: Denneulin, Guillaume <guillaume.denneulin@intel.com> Reviewed-by: Gonzalve, Sebastien <sebastien.gonzalve@intel.com> Reviewed-by: cactus <cactus@intel.com> Tested-by: Dixon, CharlesX <charlesx.dixon@intel.com> Reviewed-by: buildbot <buildbot@intel.com> Tested-by: buildbot <buildbot@intel.com>
* [Makefile] Fix useless CFLAGSKevin Rocard2014-02-125-19/+0
| | | | | | | | | | | | | | | | | | | BZ: 115743 The patch e2c35a01 deleted -Wno-non-virtual-dtor flags by deleting the common_cflags definition but it was still used in the rest of the makefiles. Delete the common_cflags occurrences. Change-Id: If4301a774c45594b36962ce5b82ae5656c6a5bb1 Signed-off-by: Kevin Rocard <kevinx.rocard@intel.com> Reviewed-on: http://android.intel.com:8080/115292 Reviewed-by: Denneulin, Guillaume <guillaume.denneulin@intel.com> Reviewed-by: De Chivre, Renaud <renaud.de.chivre@intel.com> Tested-by: Dixon, CharlesX <charlesx.dixon@intel.com> Reviewed-by: buildbot <buildbot@intel.com> Tested-by: buildbot <buildbot@intel.com>
* [Makefile] Format variables to lower_snake_caseKevin Rocard2014-02-126-108/+108
| | | | | | | | | | | | | | | | | BZ: 115743 Some variables where not formatted as requested by the coding style. Format them to lower_snake_case. Change-Id: I31c152f161cde469bcd4c00953e95274c60868ca Signed-off-by: Kevin Rocard <kevinx.rocard@intel.com> Reviewed-on: http://android.intel.com:8080/115175 Reviewed-by: Denneulin, Guillaume <guillaume.denneulin@intel.com> Reviewed-by: De Chivre, Renaud <renaud.de.chivre@intel.com> Tested-by: Dixon, CharlesX <charlesx.dixon@intel.com> Reviewed-by: buildbot <buildbot@intel.com> Tested-by: buildbot <buildbot@intel.com>
* [Makefile] Append "_host" to host modules namesKevin Rocard2014-02-126-10/+12
| | | | | | | | | | | | | | | | | | | | | BZ: 115743 In some parameter framework makefiles, host and target modules (with the same name) are defined in the same file. External prebuilt framework properly handle this case when modules are defined in different Android.mk, but there is a limitation when modules are defined in same Android.mk. Append _host to all host modules. Change-Id: Ib594dabd86617cc40993066338f095b49afb2ea2 Signed-off-by: Kevin Rocard <kevinx.rocard@intel.com> Reviewed-on: http://android.intel.com:8080/113537 Reviewed-by: Denneulin, Guillaume <guillaume.denneulin@intel.com> Reviewed-by: De Chivre, Renaud <renaud.de.chivre@intel.com> Tested-by: Dixon, CharlesX <charlesx.dixon@intel.com> Reviewed-by: buildbot <buildbot@intel.com> Tested-by: buildbot <buildbot@intel.com>
* Update the PFW version due to api changeKevin Rocard2014-02-121-1/+1
| | | | | | | | | | | | | | | | | | | BZ: 116973 As, the PFW public api changed (deprecated commands), external tools must be aware of it. Increment the PFW version number to let users detect api version. Change-Id: I61860b651c2559242c5eb32ec5d8afaf9bc6b0c6 Signed-off-by: Kevin Rocard <kevinx.rocard@intel.com> Reviewed-on: http://android.intel.com:8080/114688 Reviewed-by: cactus <cactus@intel.com> Reviewed-by: Denneulin, Guillaume <guillaume.denneulin@intel.com> Reviewed-by: Gonzalve, Sebastien <sebastien.gonzalve@intel.com> Tested-by: Dixon, CharlesX <charlesx.dixon@intel.com> Reviewed-by: buildbot <buildbot@intel.com> Tested-by: buildbot <buildbot@intel.com>
* Mark the getDomainsXML command as deprecatedKevin Rocard2014-02-121-1/+5
| | | | | | | | | | | | | | | | | | | | | | BZ: 116973 The patch 15db1a7d renamed the command getDomainsXML to getDomainsWithSettingsXML. This changes the PFW API and breaks the PFW backward compatibility. Put the command back marked as deprecated. Both getDomainsXML and getDomainsWithSettingsXML are now supported. getDomainsXML output an deprecated message when used. Change-Id: Id838b6e02f003c789bb9cbe7a534e4985a4b348f Signed-off-by: Kevin Rocard <kevinx.rocard@intel.com> Reviewed-on: http://android.intel.com:8080/114071 Reviewed-by: cactus <cactus@intel.com> Reviewed-by: Denneulin, Guillaume <guillaume.denneulin@intel.com> Reviewed-by: De Chivre, Renaud <renaud.de.chivre@intel.com> Tested-by: Dixon, CharlesX <charlesx.dixon@intel.com> Reviewed-by: buildbot <buildbot@intel.com> Tested-by: buildbot <buildbot@intel.com>
* PFW: Add setDomainsXML command to import domains from stringGeorges-Henri Baron2014-02-1221-293/+856
| | | | | | | | | | | | | | | | | | | | | BZ: 55694 Unable possibility to import the configurable domains from a string Create one command that can be called through the command line of the parameter-framework. The command setDomainXML allows to import configurable domains with settings from a string provided as first argument containing the xml description. Change-Id: I6db7ccb8ba61b5e4c8ba81579a68f40e887d1534 Signed-off-by: Georges-Henri Baron <georges-henrix.baron@intel.com> Reviewed-on: http://android.intel.com:8080/65408 Reviewed-by: cactus <cactus@intel.com> Reviewed-by: Dixon, CharlesX <charlesx.dixon@intel.com> Reviewed-by: Rocard, KevinX <kevinx.rocard@intel.com> Tested-by: Dixon, CharlesX <charlesx.dixon@intel.com> Reviewed-by: buildbot <buildbot@intel.com> Tested-by: buildbot <buildbot@intel.com>
* Remove no-non-virtual-dtor flagSebastien Gonzalve2014-02-1222-14/+40
| | | | | | | | | | | | | | BZ: 111473 The warning non-virtual-dtor should not be ignored for the whole project, but only in the few cases where it it necessary. Change-Id: I0ede82a30f2cd055b789f7fb56104fb227934e6f Signed-off-by: Sebastien Gonzalve <sebastien.gonzalve@intel.com> Signed-off-by: Guilhem IMBERTON <guilhem.imberton@intel.com> Reviewed-on: http://android.intel.com:8080/110191 Reviewed-by: buildbot <buildbot@intel.com> Tested-by: buildbot <buildbot@intel.com>
* [Parameter] Move public header to include dirKevin Rocard2014-02-126-5/+6
| | | | | | | | | | | | | | | | | | | | | | | | BZ: 107991 The parameter-framework core public headers were mixed up with all other private headers. Making it dificult for other components to include PFW public headers. Move public headers - ParameterHandle - ParameterMgrPlatformConnector - SelectionCriterionInterface - SelectionCriterionTypeInterface to the "include" dir. Change-Id: I3a4840345a26ec9bd848179bdd4966d44d97bede Signed-off-by: Kevin Rocard <kevinx.rocard@intel.com> Reviewed-on: http://android.intel.com:8080/109757 Reviewed-by: cactus <cactus@intel.com> Reviewed-by: Gonzalve, Sebastien <sebastien.gonzalve@intel.com> Tested-by: Dixon, CharlesX <charlesx.dixon@intel.com> Reviewed-by: buildbot <buildbot@intel.com> Tested-by: buildbot <buildbot@intel.com>
* Change TARGET_ERROR_FLAGS to LOCAL_CFLAGSKevin Rocard2014-02-125-15/+15
| | | | | | | | | | | | | | | | | | BZ: 107991 All plugin Android.mk were copy pasted resulting in use of TARGET_ERROR_FLAGS instead of LOCAL_CFLAGS. Change TARGET_ERROR_FLAGS to LOCAL_CFLAGS Change-Id: I792164e8c056be5dbfee35d07e7dd21b3137f4f6 Signed-off-by: Kevin Rocard <kevinx.rocard@intel.com> Reviewed-on: http://android.intel.com:8080/109723 Reviewed-by: cactus <cactus@intel.com> Reviewed-by: Gonzalve, Sebastien <sebastien.gonzalve@intel.com> Tested-by: Dixon, CharlesX <charlesx.dixon@intel.com> Reviewed-by: buildbot <buildbot@intel.com> Tested-by: buildbot <buildbot@intel.com>
* PFW: Delete useless libstdc++ includesKevin Rocard2014-02-125-5/+0
| | | | | | | | | | | | | | | | | | BZ: 107991 All plugin Android.mk were copy pasted resulting in duplicated useless libstdc++ includes. Delete the useless makefiles libstdc++ includes. Change-Id: I42bd991c261cd9fe1287b572668c677c42baad8e Signed-off-by: Kevin Rocard <kevinx.rocard@intel.com> Reviewed-on: http://android.intel.com:8080/109279 Reviewed-by: cactus <cactus@intel.com> Reviewed-by: Gonzalve, Sebastien <sebastien.gonzalve@intel.com> Tested-by: Dixon, CharlesX <charlesx.dixon@intel.com> Reviewed-by: buildbot <buildbot@intel.com> Tested-by: buildbot <buildbot@intel.com>
* [xml serializer] Make xmlserializer lib staticKevin Rocard2014-02-122-4/+4
| | | | | | | | | | | | | | | | | | BZ: 107991 The lib xmlserializer is used only in the PFW. As a result it is useless to have it dynamic. Make the lib static. Change-Id: I5fe91509485781136ecd2a85338f2229c1aebace Signed-off-by: Kevin Rocard <kevinx.rocard@intel.com> Reviewed-on: http://android.intel.com:8080/107597 Reviewed-by: cactus <cactus@intel.com> Reviewed-by: Gonzalve, Sebastien <sebastien.gonzalve@intel.com> Tested-by: Dixon, CharlesX <charlesx.dixon@intel.com> Reviewed-by: buildbot <buildbot@intel.com> Tested-by: buildbot <buildbot@intel.com>
* [test-platform] Add support for host buildKevin Rocard2014-02-121-17/+43
| | | | | | | | | | | | | | | | | | BZ: 107991 In order to generate setting xml at build time, one need to build and run PFW environement on host. Add an host compilation target. Change-Id: I8f736652f34c412dab20c185098abb4319bb001f Signed-off-by: Kevin Rocard <kevinx.rocard@intel.com> Reviewed-on: http://android.intel.com:8080/107406 Reviewed-by: cactus <cactus@intel.com> Reviewed-by: Gonzalve, Sebastien <sebastien.gonzalve@intel.com> Tested-by: Dixon, CharlesX <charlesx.dixon@intel.com> Reviewed-by: buildbot <buildbot@intel.com> Tested-by: buildbot <buildbot@intel.com>
* [PFW core] Add support for host buildKevin Rocard2014-02-121-19/+59
| | | | | | | | | | | | | | | | | | BZ: 107991 In order to generate setting xml at build time, one need to build and run PFW environement on host. Add an host compilation target. Change-Id: I7e3c9731ba855585b9d85e96400ace0a861910e1 Signed-off-by: Kevin Rocard <kevinx.rocard@intel.com> Reviewed-on: http://android.intel.com:8080/107272 Reviewed-by: cactus <cactus@intel.com> Reviewed-by: Gonzalve, Sebastien <sebastien.gonzalve@intel.com> Tested-by: Dixon, CharlesX <charlesx.dixon@intel.com> Reviewed-by: buildbot <buildbot@intel.com> Tested-by: buildbot <buildbot@intel.com>
* [utility] Add support for host buildKevin Rocard2014-02-121-13/+22
| | | | | | | | | | | | | | | | | | BZ: 107991 In order to generate setting xml at build time, one need to build and run PFW environement on host. Add an host compilation target. Change-Id: I3a8a2b8d0826bcabf76ce6f52f5482044623d87f Signed-off-by: Kevin Rocard <kevinx.rocard@intel.com> Reviewed-on: http://android.intel.com:8080/107271 Reviewed-by: cactus <cactus@intel.com> Reviewed-by: Gonzalve, Sebastien <sebastien.gonzalve@intel.com> Tested-by: Dixon, CharlesX <charlesx.dixon@intel.com> Reviewed-by: buildbot <buildbot@intel.com> Tested-by: buildbot <buildbot@intel.com>
generated by cgit v1.1 at 2025-09-14 13:26:32 +0000