aboutsummaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
...
* [remote-process] Add support for host buildKevin Rocard2014-02-121-16/+43
| | | | | | | | | | | | | | | | | | BZ: 107991 In order to generate setting xml at build time, one need to build and run PFW environement on host. Add an host compilation target. Change-Id: Id3e94c799b98d3414969a184ab8487051d2c2c60 Signed-off-by: Kevin Rocard <kevinx.rocard@intel.com> Reviewed-on: http://android.intel.com:8080/107270 Reviewed-by: cactus <cactus@intel.com> Reviewed-by: Gonzalve, Sebastien <sebastien.gonzalve@intel.com> Tested-by: Dixon, CharlesX <charlesx.dixon@intel.com> Reviewed-by: buildbot <buildbot@intel.com> Tested-by: buildbot <buildbot@intel.com>
* [remote-processor] Add support for host buildKevin Rocard2014-02-121-16/+37
| | | | | | | | | | | | | | | | | | BZ: 107991 In order to generate setting xml at build time, one need to build and run PFW environement on host. Add an host compilation target. Change-Id: I50b4ed0d33597db2e485c45cf2229d62b63c805e Signed-off-by: Kevin Rocard <kevinx.rocard@intel.com> Reviewed-on: http://android.intel.com:8080/107269 Reviewed-by: cactus <cactus@intel.com> Reviewed-by: Gonzalve, Sebastien <sebastien.gonzalve@intel.com> Tested-by: Dixon, CharlesX <charlesx.dixon@intel.com> Reviewed-by: buildbot <buildbot@intel.com> Tested-by: buildbot <buildbot@intel.com>
* [xml serializer] Add support for host buildKevin Rocard2014-02-121-18/+53
| | | | | | | | | | | | | | | | | | BZ: 107991 In order to generate setting xml at build time, one need to build and run PFW environement on host. Add an host compilation target. Change-Id: I0684b40c9264f18c573d646857afded6c0d4e376 Signed-off-by: Kevin Rocard <kevinx.rocard@intel.com> Reviewed-on: http://android.intel.com:8080/107268 Reviewed-by: cactus <cactus@intel.com> Reviewed-by: Gonzalve, Sebastien <sebastien.gonzalve@intel.com> Tested-by: Dixon, CharlesX <charlesx.dixon@intel.com> Reviewed-by: buildbot <buildbot@intel.com> Tested-by: buildbot <buildbot@intel.com>
* PFW: Fix missing space before := in makefilesKevin Rocard2014-02-125-22/+22
| | | | | | | | | | | | | | | | | | BZ: 107991 Some makefile were missing a space before := in makefiles Add a space before := Change-Id: Ie04cd85e3b21a0628f612a374b5c3d294fd724db Signed-off-by: Kevin Rocard <kevinx.rocard@intel.com> Reviewed-on: http://android.intel.com:8080/109305 Reviewed-by: Denneulin, Guillaume <guillaume.denneulin@intel.com> Reviewed-by: Gonzalve, Sebastien <sebastien.gonzalve@intel.com> Reviewed-by: cactus <cactus@intel.com> Tested-by: Dixon, CharlesX <charlesx.dixon@intel.com> Reviewed-by: buildbot <buildbot@intel.com> Tested-by: buildbot <buildbot@intel.com>
* Wrap command table linesKevin Rocard2014-02-121-57/+133
| | | | | | | | | | | | | | | | | | BZ: 101806 The coding style request all lines to be shorter than 100 caracters. Wrap modified table lines. Change-Id: Ib3ec331a162fff11f41ad82eedb9e84656dde2f7 Signed-off-by: Kevin Rocard <kevinx.rocard@intel.com> Reviewed-on: http://android.intel.com:8080/109776 Reviewed-by: cactus <cactus@intel.com> Reviewed-by: Gonzalve, Sebastien <sebastien.gonzalve@intel.com> Reviewed-by: Denneulin, Guillaume <guillaume.denneulin@intel.com> Tested-by: Dixon, CharlesX <charlesx.dixon@intel.com> Reviewed-by: buildbot <buildbot@intel.com> Tested-by: buildbot <buildbot@intel.com>
* Add an optional csv flag to the listCriteria commandKevin Rocard2014-02-121-3/+15
| | | | | | | | | | | | | | | | | | | | | | | | | | | BZ: 101806 The listCriteria command output is very dificult to parse. The default output format contains a lot of useless formating character: $ listCriteria BandRinging: ============ Possible states (Exclusive): {NetworkGenerated, PhoneGenerated} Current state = <none> Add a optional csv flag. With this flag, each criterion info fits in one line, with each field separated by commas: $ listCriteria csv Criterion name: BandRinging, type kind: exclusive, current state: <none>, states: {NetworkGenerated, PhoneGenerated} Change-Id: I7f2b0a86405846b03cab7f4a3023503b69c6e29b Signed-off-by: Kevin Rocard <kevinx.rocard@intel.com> Reviewed-on: http://android.intel.com:8080/102724 Reviewed-by: cactus <cactus@intel.com> Reviewed-by: Denneulin, Guillaume <guillaume.denneulin@intel.com> Reviewed-by: Gonzalve, Sebastien <sebastien.gonzalve@intel.com> Tested-by: Dixon, CharlesX <charlesx.dixon@intel.com> Reviewed-by: buildbot <buildbot@intel.com> Tested-by: buildbot <buildbot@intel.com>
* PFW: avoid warning in SubsystemObjectAndrei V. FOMITCHEV2014-02-121-3/+4
| | | | | | | | | | | | | | | | | | BZ: 103961 In current implementation of PFW, if a subsytem does not implement full interface of SubsystemObject, a warning message is logged. The purpose of this patch is to change the default behaviour and do not more log a warning. Change-Id: I51bc61a418956553d3c880aafa622ca6c2f68520 Signed-off-by: Andrei V. FOMITCHEV <andreix.fomitchev@intel.com> Reviewed-on: http://android.intel.com:8080/106320 Reviewed-by: Barthes, FabienX <fabienx.barthes@intel.com> Tested-by: Dixon, CharlesX <charlesx.dixon@intel.com> Reviewed-by: buildbot <buildbot@intel.com> Tested-by: buildbot <buildbot@intel.com>
* PFW: Remove useless export date on top of settings XML fileGuillaume Denneulin2014-02-122-20/+0
| | | | | | | | | | | | | | | | | | | | BZ: 105122 On line 3 of configurable domains xml files, a comment was added to specify date of files creation. This date makes all trivial merges on this file to fail, making rebases a harder task. Remove this comment as this kind of files are changed very often and as all modifications to this file are tracked with git. Change-Id: I4e8aedf95bbdea03137709f91242179d6acab5f3 Signed-off-by: Guillaume Denneulin <guillaume.denneulin@intel.com> Reviewed-on: http://android.intel.com:8080/105823 Reviewed-by: Rocard, KevinX <kevinx.rocard@intel.com> Reviewed-by: Gonzalve, Sebastien <sebastien.gonzalve@intel.com> Tested-by: Dixon, CharlesX <charlesx.dixon@intel.com> Reviewed-by: buildbot <buildbot@intel.com> Tested-by: buildbot <buildbot@intel.com>
* PFW: [xml generation] Change send command methodKevin Rocard2014-02-121-48/+57
| | | | | | | | | | | | | | | | | | | | BZ: 97960 The lightRoutingUpdate.sh script had bugs using adb shell commands. Push the generated script of board, then execute it remotly. Remove support for environement define pfw file and add support for multiple argument files. Change-Id: Ie43e1e2a4d3bc207a8704e7ca1a254dad74c9139 Signed-off-by: Kevin Rocard <kevinx.rocard@intel.com> Reviewed-on: http://android.intel.com:8080/93371 Reviewed-by: cactus <cactus@intel.com> Reviewed-by: Wagner, David <david.wagner@intel.com> Reviewed-by: De Chivre, Renaud <renaud.de.chivre@intel.com> Tested-by: Dixon, CharlesX <charlesx.dixon@intel.com> Reviewed-by: buildbot <buildbot@intel.com> Tested-by: buildbot <buildbot@intel.com>
* Fix incorect use of tabs, replace by spacesKevin Rocard2014-02-121-10/+10
| | | | | | | | | | | | | | | | | | BZ: 97960 Incorect use of tabs Replace by spaces Change-Id: I44e4b374e7f79ad268366a00b80b3409ab676cc2 Signed-off-by: Kevin Rocard <kevinx.rocard@intel.com> Reviewed-on: http://android.intel.com:8080/102855 Reviewed-by: Gonzalve, Sebastien <sebastien.gonzalve@intel.com> Reviewed-by: cactus <cactus@intel.com> Reviewed-by: Denneulin, Guillaume <guillaume.denneulin@intel.com> Tested-by: Dixon, CharlesX <charlesx.dixon@intel.com> Reviewed-by: buildbot <buildbot@intel.com> Tested-by: buildbot <buildbot@intel.com>
* [remote-process] Change usage messageKevin Rocard2014-02-121-2/+2
| | | | | | | | | | | | | | | | | BZ: 97960 The old usage message was not a clasic unix command usage message. Change it to "hostname port command [argument[s]]" Change-Id: I40f18e6ac81ef05e634fc5f78c8d19a202bb7a84 Signed-off-by: Kevin Rocard <kevinx.rocard@intel.com> Reviewed-on: http://android.intel.com:8080/102657 Reviewed-by: cactus <cactus@intel.com> Reviewed-by: Gonzalve, Sebastien <sebastien.gonzalve@intel.com> Tested-by: Dixon, CharlesX <charlesx.dixon@intel.com> Reviewed-by: buildbot <buildbot@intel.com> Tested-by: buildbot <buildbot@intel.com>
* PFW: [pfw parsor] Fix the useless quote added in rule commandsKevin Rocard2014-02-121-2/+2
| | | | | | | | | | | | | | | | | | | BZ: 97960 The ' in PFW rule command is useless. Delete it in script generator. Change-Id: Ifee9badbff1d6b0e1a564ed90e3a0e60cbf7b343 Signed-off-by: Kevin Rocard <kevinx.rocard@intel.com> Reviewed-on: http://android.intel.com:8080/98368 Reviewed-by: cactus <cactus@intel.com> Reviewed-by: De Chivre, Renaud <renaud.de.chivre@intel.com> Reviewed-by: Wagner, David <david.wagner@intel.com> Reviewed-by: Denneulin, Guillaume <guillaume.denneulin@intel.com> Tested-by: Dixon, CharlesX <charlesx.dixon@intel.com> Reviewed-by: buildbot <buildbot@intel.com> Tested-by: buildbot <buildbot@intel.com>
* Reduce parameter-framework log on startKevin Rocard2014-02-122-5/+1
| | | | | | | | | | | | | | | | | | BZ: 102528 The PFW used to make a lot of useless log during init. Delete those useless logs. Change-Id: I9e4cf6461d4eb643444443ea57e90f97f79571a3 Signed-off-by: Kevin Rocard <kevinx.rocard@intel.com> Reviewed-on: http://android.intel.com:8080/103882 Reviewed-by: cactus <cactus@intel.com> Reviewed-by: Gonzalve, Sebastien <sebastien.gonzalve@intel.com> Reviewed-by: Denneulin, Guillaume <guillaume.denneulin@intel.com> Tested-by: Dixon, CharlesX <charlesx.dixon@intel.com> Reviewed-by: buildbot <buildbot@intel.com> Tested-by: buildbot <buildbot@intel.com>
* PFW: Fix the useless subsystem resync on PFW loadKevin Rocard2014-02-123-2/+29
| | | | | | | | | | | | | | | | | | | | BZ: 97808 The PFW used to resynchronise some subsystems at start before back/forward syncronisation. Which was useless. Reset subsystems 'needToResync' flag during PFW start before sync to avoid this dummy resync. Change-Id: Id0c0bb786f10e2724222fc18f2085164e95f963f Signed-off-by: Kevin Rocard <kevinx.rocard@intel.com> Reviewed-on: http://android.intel.com:8080/98452 Reviewed-by: cactus <cactus@intel.com> Reviewed-by: Denneulin, Guillaume <guillaume.denneulin@intel.com> Reviewed-by: De Chivre, Renaud <renaud.de.chivre@intel.com> Tested-by: Dixon, CharlesX <charlesx.dixon@intel.com> Reviewed-by: buildbot <buildbot@intel.com> Tested-by: buildbot <buildbot@intel.com>
* PFW: [Klockwork issue] Fix const operator=Kevin Rocard2014-02-122-2/+2
| | | | | | | | | | | | | | | | | | BZ: 92744 Klockwork issue. operator = should not return a const value. Change-Id: I6525e7969295866b8d3defe1f0d38ad774edb9b9 Signed-off-by: Kevin Rocard <kevinx.rocard@intel.com> Reviewed-on: http://android.intel.com:8080/100072 Reviewed-by: Denneulin, Guillaume <guillaume.denneulin@intel.com> Reviewed-by: Gonzalve, Sebastien <sebastien.gonzalve@intel.com> Reviewed-by: Boisnard, FredericX <fredericx.boisnard@intel.com> Tested-by: Dixon, CharlesX <charlesx.dixon@intel.com> Reviewed-by: buildbot <buildbot@intel.com> Tested-by: buildbot <buildbot@intel.com>
* PFW: Coding style violation correctionKevin Rocard2014-02-123-11/+32
| | | | | | | | | | | | | | | | | | BZ: 98166 Some code is not following the coding style. Wrap too long lines according to coding style, add doxygen annotations. Change-Id: I1c160c5f2b4bedab159baadc034042ec9956cd0e Signed-off-by: Kevin Rocard <kevinx.rocard@intel.com> Reviewed-on: http://android.intel.com:8080/99545 Reviewed-by: Gonzalve, Sebastien <sebastien.gonzalve@intel.com> Reviewed-by: cactus <cactus@intel.com> Tested-by: Dixon, CharlesX <charlesx.dixon@intel.com> Reviewed-by: buildbot <buildbot@intel.com> Tested-by: buildbot <buildbot@intel.com>
* PFW: Parameter bloc can handle any mapping depthKevin Rocard2014-02-124-52/+99
| | | | | | | | | | | | | | | | | | | BZ: 85878 Needed for subsystem object definition enhancement. In a PFW structure file, if a parameter bloc is defined in another parameter bloc with context mapping only (no instanciable mapping), the PFW will no longer stop diving on the first parameter bloc. Change-Id: If4f704f01e20eb348d931c0baab1b85936fc75a4 Signed-off-by: Kevin Rocard <kevinx.rocard@intel.com> Reviewed-on: http://android.intel.com:8080/88959 Reviewed-by: Dixon, CharlesX <charlesx.dixon@intel.com> Tested-by: Dixon, CharlesX <charlesx.dixon@intel.com> Reviewed-by: Boisnard, FredericX <fredericx.boisnard@intel.com> Reviewed-by: buildbot <buildbot@intel.com> Tested-by: buildbot <buildbot@intel.com>
* PFW: [PFW script generator] Rename sup* to *GroupKevin Rocard2014-02-121-3/+2
| | | | | | | | | | | | | | | | | | BZ: 97797 Need to support the new tags for supDomains and supConf Add domainGroup, confGroup and confType in corresponding match rules. Change-Id: Ia975e77dcd8f4e9c4f8d1a48e124ecdea0647375 Signed-off-by: Kevin Rocard <kevinx.rocard@intel.com> Reviewed-on: http://android.intel.com:8080/99542 Reviewed-by: Wagner, David <david.wagner@intel.com> Reviewed-by: cactus <cactus@intel.com> Reviewed-by: Gonzalve, Sebastien <sebastien.gonzalve@intel.com> Tested-by: Dixon, CharlesX <charlesx.dixon@intel.com> Reviewed-by: buildbot <buildbot@intel.com> Tested-by: buildbot <buildbot@intel.com>
* [PFW] Fix display error when using getConfigurationParameter with ↵Frédéric Boisnard2014-02-121-3/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | BooleanParameters BZ: 96140 When using getConfigurationParameter on a BooleanParameter, the displayed value is duplicated on the output if the configuration is applicable. The method CParameterMgr::accessConfigurationValue() accesses the element twice when the configuration is the last one applied (in order to update the parameter value in both the configuration blackboard and the main blackboard). The output result is managed using a string passed as reference to ParameterMgr::accessValue() and then to CBooleanParameterType::fromBlackboard(). In the latest method, the boolean value is appended to the output string, however no check is performed to make sure that the string is empty before being used. As the method is called twice with the same output string, we end up with a dupplicated output. This fix updates CBooleanParameterType::fromBlackboard() in order to make sure that the output string is overwritten with the current result. Change-Id: I394366910b1ddc0c8bbe570aa357e007745613db Signed-off-by: Frédéric Boisnard <fredericx.boisnard@intel.com> Reviewed-on: http://android.intel.com:8080/98648 Reviewed-by: cactus <cactus@intel.com> Reviewed-by: Denneulin, Guillaume <guillaume.denneulin@intel.com> Reviewed-by: Benavoli, Patrick <patrick.benavoli@intel.com> Reviewed-by: Gonzalve, Sebastien <sebastien.gonzalve@intel.com> Tested-by: Barthes, FabienX <fabienx.barthes@intel.com> Reviewed-by: buildbot <buildbot@intel.com> Tested-by: buildbot <buildbot@intel.com>
* [PFW] Fix issue when setting a parameter of a configuration not applicableFrédéric Boisnard2014-02-123-14/+35
| | | | | | | | | | | | | | | | | | | | | BZ: 93374 This patch aims to fix an issue when using the command setConfigurationParameter to update the value of a parameter of a configuration. The autosync shall be turned off when updating the value of a parameter in a configuration that is not currently applicable. Change-Id: I12f9d37e544dc7b54f1bed0470783fdfc8568b7c Signed-off-by: Frédéric Boisnard <fredericx.boisnard@intel.com> Reviewed-on: http://android.intel.com:8080/96832 Reviewed-by: cactus <cactus@intel.com> Reviewed-by: Gonzalve, Sebastien <sebastien.gonzalve@intel.com> Reviewed-by: Denneulin, Guillaume <guillaume.denneulin@intel.com> Reviewed-by: De Chivre, Renaud <renaud.de.chivre@intel.com> Reviewed-by: Benavoli, Patrick <patrick.benavoli@intel.com> Tested-by: Dixon, CharlesX <charlesx.dixon@intel.com> Reviewed-by: buildbot <buildbot@intel.com> Tested-by: buildbot <buildbot@intel.com>
* PFW: Define generic __unused macroKevin Rocard2014-02-121-0/+28
| | | | | | | | | | | | | BZ: 83641 Change-Id: Ifb809946e955de50e50949506dff2f83ff34f568 Signed-off-by: Kevin Rocard <kevinx.rocard@intel.com> Reviewed-on: http://android.intel.com:8080/95601 Reviewed-by: Gonzalve, Sebastien <sebastien.gonzalve@intel.com> Reviewed-by: cactus <cactus@intel.com> Tested-by: Dixon, CharlesX <charlesx.dixon@intel.com> Reviewed-by: buildbot <buildbot@intel.com> Tested-by: buildbot <buildbot@intel.com>
* [PFW] Access Configurations directlyFrédéric Boisnard2014-02-1210-11/+257
| | | | | | | | | | | | | | | | | | | | | BZ: 88357 This patch aims to enable direct access to Configurations without using the main blackboard. 2 additional commands are available: - getConfigurationParameter <domain> <configuration> <param path>: Get value for parameter at given path from configuration. - setConfigurationParameter <domain> <configuration> <param path> <value> Set value for parameter at given path to configuration. Change-Id: I9357ba5141feee558fa3f7c10f62db14406433b6 Signed-off-by: Frédéric Boisnard <fredericx.boisnard@intel.com> Reviewed-on: http://android.intel.com:8080/92325 Reviewed-by: cactus <cactus@intel.com> Reviewed-by: Gonzalve, Sebastien <sebastien.gonzalve@intel.com> Tested-by: Dixon, CharlesX <charlesx.dixon@intel.com> Reviewed-by: buildbot <buildbot@intel.com> Tested-by: buildbot <buildbot@intel.com>
* [PFW] Take into account base offset when accessing value of parametersFrédéric Boisnard2014-02-128-34/+37
| | | | | | | | | | | | | | | | | | | BZ: 88357 This patch aims to offer the possibility of accessing the value of parameters from a Configuration blackboard instead of Main blackboard. The read/write operation is now relative to the base offset of the ancestor element associated to the Configuration. The base offset is stored in the ParameterAccessContext. Change-Id: I158df63d2ef3bd8cbacb84b7d2f51723ed1074f5 Signed-off-by: Frédéric Boisnard <fredericx.boisnard@intel.com> Reviewed-on: http://android.intel.com:8080/93671 Reviewed-by: cactus <cactus@intel.com> Reviewed-by: Dixon, CharlesX <charlesx.dixon@intel.com> Tested-by: Dixon, CharlesX <charlesx.dixon@intel.com> Reviewed-by: buildbot <buildbot@intel.com> Tested-by: buildbot <buildbot@intel.com>
* PFW: [coverage] Support new log syntax & error handlingKevin Rocard2014-02-121-43/+62
| | | | | | | | | | | | | | | | | | | | BZ: 86781 Support of last change criterion syntax log, - old log line: Selection criterion changed event: (.*) = (.*) - new log line: Selection criterion changed event: Criterion name: (.*), current state: (.*) Change-Id: I626ca7e5dd6deb34fda041a6e9448012b7db62e1 Signed-off-by: Kevin Rocard <kevinx.rocard@intel.com> Reviewed-on: http://android.intel.com:8080/91820 Reviewed-by: Wagner, David <david.wagner@intel.com> Reviewed-by: Gonzalve, Sebastien <sebastien.gonzalve@intel.com> Tested-by: Barthes, FabienX <fabienx.barthes@intel.com> Reviewed-by: buildbot <buildbot@intel.com> Tested-by: buildbot <buildbot@intel.com>
* Exposes API to dump inclusive criteriaFrancois Gaffie2014-02-122-1/+2
| | | | | | | | | | | | | | | | | | | | BZ: 83285 To avoid implement in route manager an helper function to dump inclusive criteria, expose an already existing API through the CriterionTypeInterface. Signed-off-by: Francois Gaffie <francois.gaffie@intel.com> Change-Id: Ib500f23872fd4da47c5d17666f75708e1627f749 Reviewed-on: http://android.intel.com:8080/90783 Reviewed-by: Gaffie, Francois <francois.gaffie@intel.com> Reviewed-by: Denneulin, Guillaume <guillaume.denneulin@intel.com> Reviewed-by: Centelles, Sylvain <sylvain.centelles@intel.com> Reviewed-by: Rocard, KevinX <kevinx.rocard@intel.com> Tested-by: Dixon, CharlesX <charlesx.dixon@intel.com> Reviewed-by: buildbot <buildbot@intel.com> Tested-by: buildbot <buildbot@intel.com>
* PFW: Support .pfw argument in lightRoutingUpdate.shKevin Rocard2014-02-121-16/+30
| | | | | | | | | | | | | | | | BZ: 86003 Adding an argument to lightRoutingUpdate.sh will overwrite the environement variable "PFWtest_DomainFile". Change-Id: Ia7447b9cb0d774bd91ec310874c0e6531ec0ea38 Signed-off-by: Kevin Rocard <kevinx.rocard@intel.com> Reviewed-on: http://android.intel.com:8080/90087 Reviewed-by: Gonzalve, Sebastien <sebastien.gonzalve@intel.com> Reviewed-by: cactus <cactus@intel.com> Tested-by: Dixon, CharlesX <charlesx.dixon@intel.com> Reviewed-by: buildbot <buildbot@intel.com> Tested-by: buildbot <buildbot@intel.com>
* PFW: Correct log level coverage scriptKevin Rocard2014-02-121-13/+31
| | | | | | | | | | | | | | BZ: 85983 Restrict debug log print to debug log level. Change-Id: I78bb79909502035247f410e9900a560190ee0ad5 Signed-off-by: Kevin Rocard <kevinx.rocard@intel.com> Reviewed-on: http://android.intel.com:8080/90085 Reviewed-by: Centelles, Sylvain <sylvain.centelles@intel.com> Tested-by: Dixon, CharlesX <charlesx.dixon@intel.com> Reviewed-by: buildbot <buildbot@intel.com> Tested-by: buildbot <buildbot@intel.com>
* PFW: Correct truncated criterion logKevin Rocard2014-02-123-4/+16
| | | | | | | | | | | | | | | | | | | | | | BZ: 85746 Create a log fonction to log a string table. Use it to call the log function for each criterion. Context: When the PFW starts, it logs the criteria, their states and possible values. All criterion logs where concatenate in a string and logged. But if there is a lot of criteria, the 512 chars long log buffer might be overfload and the log is truncated. Change-Id: I72c89b25de9314b714763b3ac71a7d0cb9698910 Signed-off-by: Kevin Rocard <kevinx.rocard@intel.com> Reviewed-on: http://android.intel.com:8080/90089 Reviewed-by: Gonzalve, Sebastien <sebastien.gonzalve@intel.com> Tested-by: Dixon, CharlesX <charlesx.dixon@intel.com> Reviewed-by: buildbot <buildbot@intel.com> Tested-by: buildbot <buildbot@intel.com>
* sortAsound.conf.sh do not handle spacesFrédéric Boisnard2014-02-121-1/+1
| | | | | | | | | | | | | | | | | | BZ: 85879 This patch fixes a small bug in the sortAsound.conf.sh script, now it is allowed to have multiple spaces around the property 'value' for a hook in the asound.conf file. Change-Id: Iad3e51d4d56c371b5f7d57f333013f23d840a645 Signed-off-by: Frédéric Boisnard <fredericx.boisnard@intel.com> Reviewed-on: http://android.intel.com:8080/90959 Reviewed-by: cactus <cactus@intel.com> Reviewed-by: Denneulin, Guillaume <guillaume.denneulin@intel.com> Reviewed-by: Rocard, KevinX <kevinx.rocard@intel.com> Reviewed-by: Gonzalve, Sebastien <sebastien.gonzalve@intel.com> Tested-by: Dixon, CharlesX <charlesx.dixon@intel.com> Reviewed-by: buildbot <buildbot@intel.com> Tested-by: buildbot <buildbot@intel.com>
* PFW: Add licence header in coverage toolKevin Rocard2014-02-121-0/+20
| | | | | | | | | | | | | | | | | | | | BZ: 85983 Add a copyright header to the xml coverage generator script, coverage.py : INTEL CONFIDENTIAL Copyright 2013 Intel Corporation All Rights Reserved. ... Change-Id: I8a5efd67fd3a0603c50a05318f7aec8277689630 Signed-off-by: Kevin Rocard <kevinx.rocard@intel.com> Reviewed-on: http://android.intel.com:8080/91036 Reviewed-by: Gonzalve, Sebastien <sebastien.gonzalve@intel.com> Reviewed-by: cactus <cactus@intel.com> Tested-by: Dixon, CharlesX <charlesx.dixon@intel.com> Reviewed-by: buildbot <buildbot@intel.com> Tested-by: buildbot <buildbot@intel.com>
* PFW: Wrong rule order in generated xml fileKevin Rocard2014-02-121-10/+12
| | | | | | | | | | | | | | | | | | | | BZ: 85553 The xml generator was inverting inherited rule, this patch corrects it. Rules are now ordered in the inheritance order. Rule inherited from high level element are now at the beginning of the rule list. It is only a cosmetic change a functional change. Change-Id: I5c718a93d24c64ec690377915a98404823cf8fba Signed-off-by: Kevin Rocard <kevinx.rocard@intel.com> Reviewed-on: http://android.intel.com:8080/90354 Reviewed-by: cactus <cactus@intel.com> Reviewed-by: Centelles, Sylvain <sylvain.centelles@intel.com> Reviewed-by: Denneulin, Guillaume <guillaume.denneulin@intel.com> Tested-by: Dixon, CharlesX <charlesx.dixon@intel.com> Reviewed-by: buildbot <buildbot@intel.com> Tested-by: buildbot <buildbot@intel.com>
* Add a getter for belonging subsystem in subsystem objectsGuillaume Denneulin2014-02-122-0/+9
| | | | | | | | | | | | | | | BZ: 66692 Sometimes, subsystem object need to know their belonging subsystem. Change-Id: Ia1b8c8c3756179a87b542fc0fe52f6f0097299b6 Signed-off-by: Guillaume Denneulin <guillaume.denneulin@intel.com> Reviewed-on: http://android.intel.com:8080/87951 Reviewed-by: Soulard, Mathieu <mathieu.soulard@intel.com> Reviewed-by: Centelles, Sylvain <sylvain.centelles@intel.com> Tested-by: Dixon, CharlesX <charlesx.dixon@intel.com> Reviewed-by: buildbot <buildbot@intel.com> Tested-by: buildbot <buildbot@intel.com>
* PFW: Test scripts & XML generator scriptsKevin Rocard2014-02-127-0/+1850
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | BZ: 80506 This patch adds scripts to generate and test PFW domain XML. tools/xmlGenerator provides script to generate PFW domains from XML: - updateRoutageDomains.sh update the domains of the connected board with the provided .pfw file. - lightRoutingUpdate.sh is a light version of updateRoutageDomains.sh it does not need test-platform but needs a board with a properly configure PFW (typicaly the hal pfw). - analyse provide script to convert asound.conf to domains test/test-scripts provides scripts to instanciate a test platform (virtal hal) and simulate the route manager routing steps: - */*_envsetup.sh is a list of environement configation file. Source the file corresponding to your situation. - test-routing.sh allow the user to simulate different routing use cases. Change-Id: I00931a3b0868496c36ba1ad298ed89e07582dd61 Signed-off-by: Kevin Rocard <kevinx.rocard@intel.com> Reviewed-on: http://android.intel.com:8080/67268 Reviewed-by: Boisnard, FredericX <fredericx.boisnard@intel.com> Reviewed-by: De Chivre, Renaud <renaud.de.chivre@intel.com> Tested-by: Dixon, CharlesX <charlesx.dixon@intel.com> Reviewed-by: buildbot <buildbot@intel.com> Tested-by: buildbot <buildbot@intel.com>
* PFW: Back synchronisation no longer failsKevin Rocard2014-02-126-14/+7
| | | | | | | | | | | | | | | | | | | | | | BZ: 80500 As forward synchronisation, back synchronisation no longer return false if a syncer fails to backsynchronise. On subsystem restart, it will be resynchronise, so the back synchronisation failure is a warning not an error. As a result this patch also prevents PFW initialisation failure in case of unavailable subsystem. Change-Id: I21fe05747153a63cb77ed784532f3cbbf184d820 Signed-off-by: Kevin Rocard <kevinx.rocard@intel.com> Reviewed-on: http://android.intel.com:8080/87779 Reviewed-by: De Chivre, Renaud <renaud.de.chivre@intel.com> Tested-by: Dixon, CharlesX <charlesx.dixon@intel.com> Reviewed-by: Benavoli, Patrick <patrick.benavoli@intel.com> Reviewed-by: cactus <cactus@intel.com> Tested-by: cactus <cactus@intel.com>
* PFW: XML coverage tool for domains and criterionsKevin Rocard2014-02-121-0/+913
| | | | | | | | | | | | | | | BZ: 77959 Add a python3 script to generate a PFW setting/configuration/citerion coverage report in XML from the PFW log. Change-Id: I013b033aa8414431d892bc953d9584f78ff44cd0 Reviewed-on: http://android.intel.com:8080/81831 Reviewed-by: Rocard, KevinX <kevinx.rocard@intel.com> Reviewed-by: Centelles, Sylvain <sylvain.centelles@intel.com> Tested-by: Dixon, CharlesX <charlesx.dixon@intel.com> Reviewed-by: cactus <cactus@intel.com> Tested-by: cactus <cactus@intel.com>
* PFW: Revert "PFW: Add log on criterion creation"Kevin Rocard2014-02-121-6/+0
| | | | | | | | | | | | | | | | BZ: 77959 This reverts commit with change-Id: I76c5cb596df1d20af48f0df03015c4be90cd5d96. Logging the criterion should be done on PFW start. If not it requires the criterion type not to change until start. Change-Id: If3d6faeffe72938bc920e28f6dfccccb530a1dee Signed-off-by: Kevin Rocard <kevinx.rocard@intel.com> Reviewed-on: http://android.intel.com:8080/81830 Reviewed-by: Centelles, Sylvain <sylvain.centelles@intel.com> Tested-by: Dixon, CharlesX <charlesx.dixon@intel.com> Reviewed-by: cactus <cactus@intel.com> Tested-by: cactus <cactus@intel.com>
* PFW: Log criterion state at PFW startKevin Rocard2014-02-128-33/+76
| | | | | | | | | | | | | | | BZ: 77959 The PFW will log criterion patch state at start before appling configuration. Change-Id: I4ac3676b9ba685c1e226a8495ffdbe98f0c08219 Signed-off-by: Kevin Rocard <kevinx.rocard@intel.com> Reviewed-on: http://android.intel.com:8080/79965 Reviewed-by: De Chivre, Renaud <renaud.de.chivre@intel.com> Tested-by: Dixon, CharlesX <charlesx.dixon@intel.com> Reviewed-by: cactus <cactus@intel.com> Tested-by: cactus <cactus@intel.com>
* PFW: Add resync mechanism if a subsystem needs resyncGuillaume Denneulin2014-02-1213-50/+136
| | | | | | | | | | | | | | | | | | | BZ: 76267 In the case of a hw subsystems reset, it's possible that its parameter managed by the PFW may not be aligned with the PFW blackboard. A re-synchronization mechanism is implemented to ensure that the subsystem is re-synchronized on the next configurations application. Change-Id: I032150955d25a7020cf494e69456897b4c157916 Signed-off-by: Guillaume Denneulin <guillaume.denneulin@intel.com> Reviewed-on: http://android.intel.com:8080/83015 Reviewed-by: Rocard, KevinX <kevinx.rocard@intel.com> Reviewed-by: Centelles, Sylvain <sylvain.centelles@intel.com> Tested-by: Dixon, CharlesX <charlesx.dixon@intel.com> Reviewed-by: cactus <cactus@intel.com> Tested-by: cactus <cactus@intel.com>
* PFW: Do not stop on hard sync errorsKevin Rocard2014-02-1234-171/+317
| | | | | | | | | | | | | | | | BZ: 76263 When synchronization fails, the parameter-framework should log a warning and continue synchronization instead of stopping Change-Id: Ic12d8798ea25584db714ee26e644fac793c28881 Signed-off-by: Kevin Rocard <kevinx.rocard@intel.com> Reviewed-on: http://android.intel.com:8080/81825 Reviewed-by: Centelles, Sylvain <sylvain.centelles@intel.com> Reviewed-by: Denneulin, Guillaume <guillaume.denneulin@intel.com> Tested-by: Dixon, CharlesX <charlesx.dixon@intel.com> Reviewed-by: cactus <cactus@intel.com> Tested-by: cactus <cactus@intel.com>
* PFW: Improve login in PFW core and amixer pluginKevin Rocard2014-02-124-44/+56
| | | | | | | | | | | | | | | | | | | | BZ: 71914 Autolog adds a nesting log level. It is not always needed. For example in a Debug context a lot of log can be expected, so this level is useful but not otherwise. Autolog nesting is now optional. Add log during PFW structure loading. Change-Id: I24e1f615e3032c70a3b8b85a1cc1804dc49b631c Origin-Change-Id: I1f2c6c843e17595d4a81c1d2dfbff30d4187cdf8 Signed-off-by: Kevin Rocard <kevinx.rocard@intel.com> Reviewed-on: http://android.intel.com:8080/81269 Reviewed-by: Barthes, FabienX <fabienx.barthes@intel.com> Tested-by: Barthes, FabienX <fabienx.barthes@intel.com> Reviewed-by: cactus <cactus@intel.com> Tested-by: cactus <cactus@intel.com>
* PFW: Add log on criterion creationKevin Rocard2014-02-121-0/+6
| | | | | | | | | | | | | | | | BZ: 71914 Initial criterion state and posible values are needed for criterion coverage. Change-Id: Id6058376fc64eb4e523fe0badffc09a7f4238f6c Origin-Change-Id: I76c5cb596df1d20af48f0df03015c4be90cd5d96 Signed-off-by: Kevin Rocard <kevinx.rocard@intel.com> Reviewed-on: http://android.intel.com:8080/81268 Reviewed-by: Barthes, FabienX <fabienx.barthes@intel.com> Tested-by: Barthes, FabienX <fabienx.barthes@intel.com> Reviewed-by: cactus <cactus@intel.com> Tested-by: cactus <cactus@intel.com>
* PFW: Correct test-platform compilationKevin Rocard2014-02-122-12/+14
| | | | | | | | | | | | | | | | | | BZ: 67916 Add libstlport in test-plaform's Android.mk. Add a Android.mk that includes test-plaform/Android.mk in the test directory be able to compile test-platform from the source root (m test-platform). Change-Id: I878c4010aa8be4f9de0c4dd6666b9f512e26a309 Origin-Change-Id: Ieeb3bc7e908a2b35f0e0603917b80343a75259e8 Signed-off-by: Kevin Rocard <kevinx.rocard@intel.com> Reviewed-on: http://android.intel.com:8080/76889 Reviewed-by: Barthes, FabienX <fabienx.barthes@intel.com> Tested-by: Barthes, FabienX <fabienx.barthes@intel.com> Reviewed-by: cactus <cactus@intel.com> Tested-by: cactus <cactus@intel.com>
* PFW: Prevent crash if subsystem structure missingFrédéric Boisnard2014-02-124-3/+27
| | | | | | | | | | | | | | | | | | | BZ: 62524 If the XML file defining a subsystem is missing, the PFW crashes without any message. This patch fixes this issue. Change-Id: Ibc0e9d195a8207d41d25613f56d1c9740bf6c784 Signed-off-by: Frédéric Boisnard <fredericx.boisnard@intel.com> Reviewed-on: http://android.intel.com:8080/70698 Reviewed-by: Denneulin, Guillaume <guillaume.denneulin@intel.com> Reviewed-by: Rocard, KevinX <kevinx.rocard@intel.com> Reviewed-by: Centelles, Sylvain <sylvain.centelles@intel.com> Reviewed-by: Baron, Georges-henriX <georges-henrix.baron@intel.com> Tested-by: Dixon, CharlesX <charlesx.dixon@intel.com> Reviewed-by: buildbot <buildbot@intel.com> Tested-by: buildbot <buildbot@intel.com>
* PFW: Report error for unknown element in settingsGeorges-Henri Baron2014-02-121-4/+2
| | | | | | | | | | | | | | | | | BZ: 62872 Report error if an element that doesn't exist is part of the settings xml description. Change-Id: I936519a0f28a2fd7a3b9e089c08ec12f0fe6c641 Signed-off-by: Georges-Henri Baron <georges-henrix.baron@intel.com> Signed-off-by: Frédéric Boisnard <fredericx.boisnard@intel.com> Reviewed-on: http://android.intel.com:8080/70474 Reviewed-by: Denneulin, Guillaume <guillaume.denneulin@intel.com> Reviewed-by: De Chivre, Renaud <renaud.de.chivre@intel.com> Tested-by: Dixon, CharlesX <charlesx.dixon@intel.com> Reviewed-by: buildbot <buildbot@intel.com> Tested-by: buildbot <buildbot@intel.com>
* PFW: Do not check data sign when access blackboardFrédéric Boisnard2014-02-121-24/+0
| | | | | | | | | | | | | | | | | BZ: 61532 In the toBlackboard() and fromBlackboard() methods of the class CIntegerParameterType, checks are performed to ensure that the requested kind of data is the same as the kind of data stored. A client should be allowed to retrieve a signed integer as an unsigned integer. Change-Id: Iabc018dd74dedc6e959d7e976afbea043b327ac8 Signed-off-by: Frédéric Boisnard <fredericx.boisnard@intel.com> Reviewed-on: http://android.intel.com:8080/69640 Reviewed-by: Benavoli, Patrick <patrick.benavoli@intel.com> Reviewed-by: De Chivre, Renaud <renaud.de.chivre@intel.com> Tested-by: Dixon, CharlesX <charlesx.dixon@intel.com> Tested-by: Barthes, FabienX <fabienx.barthes@intel.com> Reviewed-by: buildbot <buildbot@intel.com> Tested-by: buildbot <buildbot@intel.com>
* Allow 64bits bitParameterBlocksGuillaume Denneulin2014-02-128-35/+50
| | | | | | | | | | | | | | | BZ: 59348 bitParameterBlocks are limited to 32 bits, extend it to 64 bits. This change includes: - PFW code change - XML schema update Change-Id: I9861cea0538a17fcba77fa7d573faae36d8731e0 Signed-off-by: Guillaume Denneulin <guillaume.denneulin@intel.com> Reviewed-on: http://android.intel.com:8080/68189 Reviewed-by: Gozalvez Herrero, Juan AntonioX <juan.antoniox.gozalvez.herrero@intel.com> Tested-by: Gozalvez Herrero, Juan AntonioX <juan.antoniox.gozalvez.herrero@intel.com>
* PFW: Show pending configurations in status commandFrédéric Boisnard2014-02-124-6/+44
| | | | | | | | | | | | | | | | | | | | | BZ: 56118 Update the "status" command of the PFW to display the current pending configurations for all domains, that is to say configurations that are waiting the next call to "applyConfiguration()" to be applied. This improvement will help developers to better understand the current state of the PFW, in particular when dealing with HAL modifications. Change-Id: I6300620ad8cedcb534fb2859b57b7ab2988fa618 Signed-off-by: Frédéric Boisnard <fredericx.boisnard@intel.com> Reviewed-on: http://android.intel.com:8080/64796 Reviewed-by: De Chivre, Renaud <renaud.de.chivre@intel.com> Reviewed-by: Benavoli, Patrick <patrick.benavoli@intel.com> Reviewed-by: Rocard, KevinX <kevinx.rocard@intel.com> Tested-by: Barthes, FabienX <fabienx.barthes@intel.com> Reviewed-by: buildbot <buildbot@intel.com> Tested-by: buildbot <buildbot@intel.com>
* PFW: Display warning messages to help userFrédéric Boisnard2014-02-127-3/+62
| | | | | | | | | | | | | | | | | | | | BZ: 54512 Display a warning message when a configuration cannot be applied because the TuningMode is on, in order to help user to identify potential issues. Display a warning message when a criterion change doesn't lead to a configuration application (a check is performed each time a criterion is changed). Change-Id: Id872655c92770d1f6f1b01b20db2fde3db826ceb Signed-off-by: Frédéric Boisnard <fredericx.boisnard@intel.com> Reviewed-on: http://android.intel.com:8080/63845 Reviewed-by: Rocard, KevinX <kevinx.rocard@intel.com> Reviewed-by: De Chivre, Renaud <renaud.de.chivre@intel.com> Reviewed-by: Denneulin, Guillaume <guillaume.denneulin@intel.com> Tested-by: Barthes, FabienX <fabienx.barthes@intel.com> Reviewed-by: buildbot <buildbot@intel.com> Tested-by: buildbot <buildbot@intel.com>
* PFW: Allow custom port number in test-platformFrédéric Boisnard2014-02-123-5/+8
| | | | | | | | | | | | | | | | | | BZ: 56440 This patch aims to allow custom port number in test-platform: test-platform <file path> [port number, default 5001] Change-Id: Ia617507045a58d0e79a5dc1df83b0173c968853a Signed-off-by: Frédéric Boisnard <fredericx.boisnard@intel.com> Reviewed-on: http://android.intel.com:8080/65412 Reviewed-by: Denneulin, Guillaume <guillaume.denneulin@intel.com> Reviewed-by: Rocard, KevinX <kevinx.rocard@intel.com> Reviewed-by: De Chivre, Renaud <renaud.de.chivre@intel.com> Tested-by: Mendi, EduardoX <eduardox.mendi@intel.com> Reviewed-by: buildbot <buildbot@intel.com> Tested-by: buildbot <buildbot@intel.com>
* PFW: setCriterionState now support lexical stateKevin Rocard2014-02-122-1/+82
| | | | | | | | | | | | | | | | | | | | | | | | BZ: 54174 If the test-platform setCriterionState command is unable to convert the supply state to integer, it tries to consider it as a lexical state. Before setCriterionState SelectedOutputDevice 0x3 After setCriterionState SelectedOutputDevice IHF Headset Change-Id: Ib981eb955afd2acfa6e3d60d11828fcc4fc8860a Signed-off-by: Kevin Rocard <kevinx.rocard@intel.com> Reviewed-on: http://android.intel.com:8080/63478 Reviewed-by: Baron, Georges-henriX <georges-henrix.baron@intel.com> Reviewed-by: Boisnard, FredericX <fredericx.boisnard@intel.com> Reviewed-by: Benavoli, Patrick <patrick.benavoli@intel.com> Reviewed-by: Denneulin, Guillaume <guillaume.denneulin@intel.com> Reviewed-by: De Chivre, Renaud <renaud.de.chivre@intel.com> Tested-by: Barthes, FabienX <fabienx.barthes@intel.com> Reviewed-by: buildbot <buildbot@intel.com> Tested-by: buildbot <buildbot@intel.com>