From a2d6452283924def8f9d46337ac7c2e2bcf6c352 Mon Sep 17 00:00:00 2001 From: Kevin Rocard Date: Tue, 11 Jun 2013 11:37:03 +0200 Subject: [coverage] Delete useless log message to gain performance BZ: 115218 The __eq__ function is very used (1M time in my test), but cProfile showed that it was one of the most slow functions (in cumulate time). Delete useless log in the function in order to gain 90% performance (10s to 1s in cumulate time). Change-Id: I1ece15186cb30947f2c2af277cd0b326ea72c7ea Signed-off-by: Kevin Rocard Reviewed-on: http://android.intel.com:8080/112933 Reviewed-by: Denneulin, Guillaume Reviewed-by: Gonzalve, Sebastien Reviewed-by: cactus Tested-by: Dixon, CharlesX Reviewed-by: buildbot Tested-by: buildbot --- tools/coverage.py | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) (limited to 'tools') diff --git a/tools/coverage.py b/tools/coverage.py index 7e7b801..0cd2a5d 100755 --- a/tools/coverage.py +++ b/tools/coverage.py @@ -76,12 +76,7 @@ class Element(): return "%s (%s)" % (self.name, self.tag) def __eq__(self, compared): - self.debug(lambda : "Comparing:\n%s" % self.dump()) - self.debug(lambda : "With:\n%s" % compared.dump()) - result = self.name == compared.name and self.children == compared.children - self.debug("Result is %s" % result) - return result - + return (self.name == compared.name) and (self.children == compared.children) def getName(self, default=""): return self.name or default -- cgit v1.1