| Commit message (Collapse) | Author | Age | Files | Lines |
|\
| |
| |
| |
| |
| |
| | |
unknownFieldData."
* commit 'ecb2c88b22ad898c088a81870f58adbf4e16d126':
Fix access around unknownFieldData.
|
| |\
| | |
| | |
| | |
| | | |
* commit '55ef21bca9802af2a9aadd593cc606706b13f8da':
Fix access around unknownFieldData.
|
| | |\
| | | |
| | | |
| | | |
| | | | |
* commit 'a88808d414308b5b567d3afaab56fc338ad80667':
Fix access around unknownFieldData.
|
| | | |\ |
|
| | | |/
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Instead of publishing its class I chose to encapsulate the troublesome
references in equals()/hashCode() in the generated code into superclass
methods in ExtendableMessageNano.
Changed a couple of java packages in the test suite to catch this issue
easier in the future.
Change-Id: I43f88411f63bb6f3ffc8d63361f2f77bebf6220a
|
|\ \ \ \
| |/ / /
| | | |
| | | |
| | | |
| | | |
| | | | |
values."
* commit '2e6d4ae02a955d33a75c0642b8ffead20e11fd9a':
Keep pointers to extension values.
|
| |\ \ \
| | |/ /
| | | |
| | | |
| | | | |
* commit 'f39998c2c5754ec6e2ff5ddfa529a079093b41e9':
Keep pointers to extension values.
|
| | |\ \
| | | |/
| | | |
| | | |
| | | | |
* commit 'daf638399bd42122306786e8062f392ddace4363':
Keep pointers to extension values.
|
| | | |\ |
|
| | | |/
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
The current implementation of getExtension deserialises the field from bytes
and returns a new object every time. This means that changes to those objects
are reflected when the messages is serialised unless setExtension is called. It
also means that every call to getExtension and setExtension is expensive.
This change introduces a FieldData class that contains everything that's known
about the field at the time. This can be all the tag/byte[] pairs associated
with a given field or an Extension and a value object. This is so that two
messages with a repeated extension can be compared even if the extension
has been deserialised in one of them but not the other.
This change also adds FieldArray class based on SparseArray from the Android
compatibility library. This is used in ExtendableMessageNano to make lookup
of FieldDatas by their field number faster.
Implications:
* calling getExtension multiple times deserialises the field only once and
returns the same object.
* calling setExtension doesn't cause the object to be serialised immediately,
that only happens when the container message is serialised.
* getExtension is no longer a read-only thread-safe operation. README.txt has
been updated to relfect that.
* comparison using equals and hashCode continues to work.
Bug: 10863158
Change-Id: I81c7cb0c73cc0611a1f7c1eabf5eed259738e8bc
|
|\ \ \ \
| |/ / /
| | | |
| | | |
| | | |
| | | | |
global WITH_DEXPREOPT
* commit 'cca3823db855ecbcad350332a274f253be7e9662':
|
| |\ \ \
| | |/ /
| | | |
| | | |
| | | |
| | | | |
WITH_DEXPREOPT
* commit '4c8e5262e3e739b850df6eac53b1a9ee7c8a4ba7':
|
|\ \ \ \
| |/ / /
| | | |
| | | |
| | | |
| | | | |
to 1fd235cbb5975e117909c73e5e3a579ae4c28dce
* commit '57e2ee788511ddc26e694cc783d3e95b52f0e0d4':
|
| |\ \ \
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
1fd235cbb5975e117909c73e5e3a579ae4c28dce
* commit 'f8b1f8314e84b8a174289c0ce492d154016fe7bd':
|
|\ \ \ \ \
| |/ / / /
| | | | |
| | | | |
| | | | |
| | | | | |
\'e887563a\' into fix-merge-conclict"" into klp-modular-dev-plus-aosp
* commit '1f8913765270e9d90ad7384156629e116236355d':
|
| |\ \ \ \
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
fix-merge-conclict"" into klp-modular-dev-plus-aosp
* commit 'f2750dcb61de785aee6aa75b7b002dac3f1581bb':
|
|\ \ \ \ \ \
| |/ / / / /
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
fix-merge-conclict"
* commit 'f13aadfb6dfc707520809dbf4502e3001fd1424b':
|
| |\ \ \ \ \
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
* commit 'd1439291d0a2d6558903205676d41410c319587e':
Revert "Merge commit 'e887563a' into fix-merge-conclict"
|
|\ \ \ \ \ \ \
| |/ / / / / /
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
58eb8e98: am d20f0a42: Merge "Fix NPE when clearing an extension in nano protos"
* commit 'a3ab4364c6bb266e8b5021913b22433d8401ec46':
|
| |\ \ \ \ \ \
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | | |
d20f0a42: Merge "Fix NPE when clearing an extension in nano protos"
* commit '67ebd315682b27dc0d2233eabe23bd8cbb481378':
|
|\ \ \ \ \ \ \ \
| |/ / / / / / /
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | | |
ddeaf256: Merge commit \'ba89934bdae7f4256c94a0a24992903a114e764f\' into HEAD
* commit 'd0f3ba6003b1c9430349043d7f979d600967dd2f':
|
| |\ \ \ \ \ \ \
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | | |
commit \'ba89934bdae7f4256c94a0a24992903a114e764f\' into HEAD
* commit '0e54db6b8ac292b4193a924176a939d4326e803b':
|
|\ \ \ \ \ \ \ \ \
| |/ / / / / / / /
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | | |
merge of 592b6078 to master
* commit '3656cc20c8a569964d0450ce3207b651c007c35c':
|
| |\ \ \ \ \ \ \ \
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | | |
592b6078 to master
* commit 'cd8a72c726b398e3bea5dfcc07c1c9c40386511d':
|
|\ \ \ \ \ \ \ \ \ \
| |/ / / / / / / / /
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | | |
829f6c01: Merge "Adds --ignore_service nano proto compiler flag"
* commit 'f613f9e7af780863acc441bd70b10e19bb61cc6e':
|
| |\ \ \ \ \ \ \ \ \
| | | | | | | | | | |
| | | | | | | | | | |
| | | | | | | | | | |
| | | | | | | | | | |
| | | | | | | | | | | |
--ignore_service nano proto compiler flag"
* commit '3af26f43dc55563842cee8604f1e802bf40a2585':
|
|\ \ \ \ \ \ \ \ \ \ \
| |/ / / / / / / / / /
| | | | | | | | | | |
| | | | | | | | | | |
| | | | | | | | | | |
| | | | | | | | | | | |
ea68d73c: Merge "Don\'t reset cachedSize to 0 in getSerializedSize"
* commit '61317c325de4a7736ea88e72ff4be4193583e1c3':
|
| |\ \ \ \ \ \ \ \ \ \
| | | | | | | | | | | |
| | | | | | | | | | | |
| | | | | | | | | | | |
| | | | | | | | | | | |
| | | | | | | | | | | | |
"Don\'t reset cachedSize to 0 in getSerializedSize"
* commit '90048528ee37be92be17cde8f351eb1b436cdc9e':
|
|\ \ \ \ \ \ \ \ \ \ \ \
| |/ / / / / / / / / / /
| | | | | | | | | | | |
| | | | | | | | | | | |
| | | | | | | | | | | |
| | | | | | | | | | | | |
ce2f5991: Merge "Revert "Don\'t reset cachedSize to 0 in getSerializedSize""
* commit '6eb7a51929ccbbd916a0da39514a4c5877b696d5':
|
| |\ \ \ \ \ \ \ \ \ \ \
| | | | | | | | | | | | |
| | | | | | | | | | | | |
| | | | | | | | | | | | |
| | | | | | | | | | | | |
| | | | | | | | | | | | | |
"Revert "Don\'t reset cachedSize to 0 in getSerializedSize""
* commit '16aad88f8a12afef0eea31709c8bc67f7c8bbdab':
|
|\ \ \ \ \ \ \ \ \ \ \ \ \
| |/ / / / / / / / / / / /
| | | | | | | | | | | | |
| | | | | | | | | | | | |
| | | | | | | | | | | | |
| | | | | | | | | | | | | |
fix-merge-conflict
* commit '390b6c4b7d6982bf2f0904fc2d44b4ebdce29e9e':
|
| |\ \ \ \ \ \ \ \ \ \ \ \
| | | | | | | | | | | | | |
| | | | | | | | | | | | | |
| | | | | | | | | | | | | | |
* commit '291f0484a489990b7d59a78b91792fa3d935eb5c':
|
|\ \ \ \ \ \ \ \ \ \ \ \ \ \
| |/ / / / / / / / / / / / /
| | | | | | | | | | | | | |
| | | | | | | | | | | | | |
| | | | | | | | | | | | | |
| | | | | | | | | | | | | | |
ec0b12c3: Merge "Don\'t reset cachedSize to 0 in getSerializedSize"
* commit '232698c44c5d0fec83030adcc4c2048964f2dc66':
|
| |\ \ \ \ \ \ \ \ \ \ \ \ \
| | | | | | | | | | | | | | |
| | | | | | | | | | | | | | |
| | | | | | | | | | | | | | |
| | | | | | | | | | | | | | |
| | | | | | | | | | | | | | | |
"Don\'t reset cachedSize to 0 in getSerializedSize"
* commit 'de6420aa3fef9f6f85e88fd8e0c7667230d81753':
|
|\ \ \ \ \ \ \ \ \ \ \ \ \ \ \
| |/ / / / / / / / / / / / / /
| | | | | | | | | | | | | | |
| | | | | | | | | | | | | | |
| | | | | | | | | | | | | | |
| | | | | | | | | | | | | | | |
51ef8f39: Merge "Fix compile error on mac 10.9"
* commit '0cb1a2f69a2a2099b3af052eaa2e573e59263b63':
|
| |\ \ \ \ \ \ \ \ \ \ \ \ \ \
| | | | | | | | | | | | | | | |
| | | | | | | | | | | | | | | |
| | | | | | | | | | | | | | | |
| | | | | | | | | | | | | | | |
| | | | | | | | | | | | | | | | |
compile error on mac 10.9"
* commit 'c8f69926325e0653ba4244dbd041c2d29b784194':
|
|\ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \
| |/ / / / / / / / / / / / / / /
| | | | | | | | | | | | | | | |
| | | | | | | | | | | | | | | |
| | | | | | | | | | | | | | | |
| | | | | | | | | | | | | | | | |
afc1553a: Merge "Extension overhaul."
* commit '67584f49159c3f677abb15c2c58a9c75bca5da2f':
|
| |\ \ \ \ \ \ \ \ \ \ \ \ \ \ \
| | | | | | | | | | | | | | | | |
| | | | | | | | | | | | | | | | |
| | | | | | | | | | | | | | | | |
| | | | | | | | | | | | | | | | |
| | | | | | | | | | | | | | | | | |
"Extension overhaul."
* commit '9de5297388d67b5ddefdb3cf4e1f13a50f0a9c10':
|
|\ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \
| |/ / / / / / / / / / / / / / / /
| | | | | | | | | | | | | | | | |
| | | | | | | | | | | | | | | | |
| | | | | | | | | | | | | | | | |
| | | | | | | | | | | | | | | | | |
447f664a: Merge changes I9fecff3c,I2c1eb07f
* commit '1b9cb7b25f9f7fd02fd0b69bd3acf266e3b28a4d':
|
| |\ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \
| | | | | | | | | | | | | | | | | |
| | | | | | | | | | | | | | | | | |
| | | | | | | | | | | | | | | | | |
| | | | | | | | | | | | | | | | | |
| | | | | | | | | | | | | | | | | | |
changes I9fecff3c,I2c1eb07f
* commit '0eaea6a8d71e3b323f2fe3bccb3829162c04e33c':
|
|\ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \
| |/ / / / / / / / / / / / / / / / /
| | | | | | | | | | | | | | | | | |
| | | | | | | | | | | | | | | | | |
| | | | | | | | | | | | | | | | | |
| | | | | | | | | | | | | | | | | | |
6965d891 to klp-modular-dev-plus-aosp
* commit '1af058a52b92a90c7d215f8627a7366cfe1185cf':
|
| |\ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \
| | | | | | | | | | | | | | | | | | |
| | | | | | | | | | | | | | | | | | |
| | | | | | | | | | | | | | | | | | |
| | | | | | | | | | | | | | | | | | |
| | | | | | | | | | | | | | | | | | | |
klp-modular-dev-plus-aosp
* commit '0ce2c26133762a55c52c0262bbe393370b806276':
|
|\ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \
| |/ / / / / / / / / / / / / / / / / /
| | | | | | | | | | | | | | | | | | |
| | | | | | | | | | | | | | | | | | |
| | | | | | | | | | | | | | | | | | |
| | | | | | | | | | | | | | | | | | | |
a8af729b: Merge "Allow whitespace in nano codegen options."
* commit '5843426abfdb490874f9d523dac04a825580c7af':
|
| |\ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \
| | | | | | | | | | | | | | | | | | | |
| | | | | | | | | | | | | | | | | | | |
| | | | | | | | | | | | | | | | | | | |
| | | | | | | | | | | | | | | | | | | |
| | | | | | | | | | | | | | | | | | | | |
"Allow whitespace in nano codegen options."
* commit '0c063c66604c5dee434534ff775eb6d18ce4ed7b':
|
|\ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \
| |/ / / / / / / / / / / / / / / / / / /
| | | | | | | | | | | | | | | | | | | |
| | | | | | | | | | | | | | | | | | | |
| | | | | | | | | | | | | | | | | | | |
| | | | | | | | | | | | | | | | | | | | |
4b5874fa: Merge "Correctness: floating point equality using bits instead of ==."
* commit 'd043ff9d86baa219256036053f09dc5190f38f63':
|
| |\ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \
| | | | | | | | | | | | | | | | | | | | |
| | | | | | | | | | | | | | | | | | | | |
| | | | | | | | | | | | | | | | | | | | |
| | | | | | | | | | | | | | | | | | | | |
| | | | | | | | | | | | | | | | | | | | | |
"Correctness: floating point equality using bits instead of ==."
* commit '06396abfe648b84e4c17d0e4a98a6cd34d57aaab':
|
|\ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \
| |/ / / / / / / / / / / / / / / / / / / /
| | | | | | | | | | | | | | | | | | | | |
| | | | | | | | | | | | | | | | | | | | |
| | | | | | | | | | | | | | | | | | | | |
| | | | | | | | | | | | | | | | | | | | | |
d6aeae14: Merge "Don\'t serialize required fields whose \'has\' flags are unset."
* commit 'b22123d1d9331a35fa6a5b081acf04db090cc9b4':
|
| |\ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \
| | | | | | | | | | | | | | | | | | | | | |
| | | | | | | | | | | | | | | | | | | | | |
| | | | | | | | | | | | | | | | | | | | | |
| | | | | | | | | | | | | | | | | | | | | |
| | | | | | | | | | | | | | | | | | | | | | |
"Don\'t serialize required fields whose \'has\' flags are unset."
* commit 'e41d4c041cb2c6d58c4508cf792cd4e987991b2a':
|
|\ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \
| |/ / / / / / / / / / / / / / / / / / / / /
| | | | | | | | | | | | | | | | | | | | | |
| | | | | | | | | | | | | | | | | | | | | |
| | | | | | | | | | | | | | | | | | | | | |
| | | | | | | | | | | | | | | | | | | | | | |
e7741c06: Merge "Fix MessageNanoPrinter for accessors"
* commit '3628a851ca99c7b2058702aad9bb97f408513e56':
|
| |\ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \
| | | | | | | | | | | | | | | | | | | | | | |
| | | | | | | | | | | | | | | | | | | | | | |
| | | | | | | | | | | | | | | | | | | | | | |
| | | | | | | | | | | | | | | | | | | | | | |
| | | | | | | | | | | | | | | | | | | | | | | |
MessageNanoPrinter for accessors"
* commit '11b030c32e2b740283ddd455e1e29748667cf314':
|