From 9fb360ec4c47d750711c8f1776c180e3802b0aab Mon Sep 17 00:00:00 2001 From: David 'Digit' Turner Date: Wed, 4 May 2011 22:01:28 +0200 Subject: Correct fix for snapshot saving speed QEMU is a weird animal. The "snapshot" property speeds-up snapshot saving but also redirect all stores to a temporary file which is deleted when the emulator exit. Use a different property to get the desired speed-up. Note that using "writeback" instead of "unsafe" forces the use of fdatasync() which will still be horribly slow. + Argument checking in avd snapshot commands in the console. (trying to load a name-less snapshot actually crashes the emulator). Change-Id: Ie61f110f037bbb3539c7f9892cb03bee8bfec6bd --- vl-android.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'vl-android.c') diff --git a/vl-android.c b/vl-android.c index b024bef..a1b88be 100644 --- a/vl-android.c +++ b/vl-android.c @@ -5095,9 +5095,9 @@ int main(int argc, char **argv, char **envp) hdb_opts = drive_add(spath, HD_ALIAS, 1); /* VERY IMPORTANT: * Set this property or the file will be mounted with O_DIRECT, - * which will slow down snapshot saving.x100 ! + * which will slow down snapshot saving x100 ! */ - qemu_opt_set(hdb_opts, "snapshot", "on"); + qemu_opt_set(hdb_opts, "cache", "unsafe"); } } -- cgit v1.1