diff options
| author | Steve Block <steveblock@google.com> | 2011-06-08 08:26:01 -0700 |
|---|---|---|
| committer | Android (Google) Code Review <android-gerrit@google.com> | 2011-06-08 08:26:01 -0700 |
| commit | 3742ac093d35d923c81693096ab6671e9b147700 (patch) | |
| tree | c2add9100f789dad45ef1ec5328bddde02c47a4c /Source/WebCore/accessibility/gtk | |
| parent | 901401d90459bc22580842455d4588b9a697514d (diff) | |
| parent | e5926f4a0d6adc9ad4a75824129f117181953560 (diff) | |
| download | external_webkit-3742ac093d35d923c81693096ab6671e9b147700.zip external_webkit-3742ac093d35d923c81693096ab6671e9b147700.tar.gz external_webkit-3742ac093d35d923c81693096ab6671e9b147700.tar.bz2 | |
Merge changes I55c6d71a,Ifb3277d4,Ia1b847a2,I7ba9cf3f,Ida2b2a8a,I1280ec90,I72f818d5,I2e3b588b,I9a4e6289,Ia724c78b,Icd8612c8,Ie31b15d7,Ie125edae,I77941a88,I89dae78b,I3516e5ca,I1a4c17b5,I2c4ecc1a,I9c8e6537,Ifac13115,Ie1f80e09,Ia541ed77,I60ce9d78
* changes:
Merge WebKit at r82507: Update ThirdPartyProject.prop
Merge WebKit at r82507: Cherry-pick change r88166 to add INSPECTOR guards to ScriptProfiler
Merge WebKit at r82507: Work around a V8 bug
Merge WebKit at r82507: JNIType renamed to JavaType
Merge WebKit at r82507: IconDatabaseClient interface expanded
Merge WebKit at r82507: Don't use new loss-free code path in HTMLCanvasElement::toDataURL()
Merge WebKit at r82507: IcondDatabaseBase::iconForPageURL() renamed
Merge WebKit at r82507: IconDatabaseBase::Open() signature changed
Merge WebKit at r82507: Node::isContentEditable() renamed
Merge WebKit at r82507: Use icon database through IconDatabaseBase
Merge WebKit at r82507: toInputElement() is now a member of Node
Merge WebKit at r82507: FrameLoaderClient::objectContentType() signature changed
Merge WebKit at r82507: StringImpl::computeHash() removed
Merge WebKit at r82507: Stub out FontPlatformData::setOrientation()
Merge WebKit at r82507: Path::strokeBoundingRect() is now const
Merge WebKit at r82507: Add missing UnusedParam.h include in ApplicationCacheGroup.cpp
Merge WebKit at r82507: Continue to use Android's version of FontPlatformData.h
Merge WebKit at r82507: Update signature of FontCustomPlatformData::fontPlatformData()
Merge WebKit at r82507: Fix conflicts due to JNI refactoring
Merge WebKit at r82507: Fix conflicts due to new StorageTracker
Merge WebKit at r82507: Fix conflicts
Merge WebKit at r82507: Fix makefiles
Merge WebKit at r82507: Initial merge by git
Diffstat (limited to 'Source/WebCore/accessibility/gtk')
4 files changed, 125 insertions, 34 deletions
diff --git a/Source/WebCore/accessibility/gtk/AXObjectCacheAtk.cpp b/Source/WebCore/accessibility/gtk/AXObjectCacheAtk.cpp index 0701ece..f910ca6 100644 --- a/Source/WebCore/accessibility/gtk/AXObjectCacheAtk.cpp +++ b/Source/WebCore/accessibility/gtk/AXObjectCacheAtk.cpp @@ -143,6 +143,17 @@ void AXObjectCache::postPlatformNotification(AccessibilityObject* coreObject, AX g_signal_emit_by_name(axObject, "state-change", "focused", true); } notifyChildrenSelectionChange(coreObject); + } else if (notification == AXValueChanged) { + if (!ATK_IS_VALUE(axObject)) + return; + + AtkPropertyValues propertyValues; + propertyValues.property_name = "accessible-value"; + + memset(&propertyValues.new_value, 0, sizeof(GValue)); + atk_value_get_current_value(ATK_VALUE(axObject), &propertyValues.new_value); + + g_signal_emit_by_name(ATK_OBJECT(axObject), "property-change::accessible-value", &propertyValues, NULL); } } diff --git a/Source/WebCore/accessibility/gtk/AccessibilityObjectAtk.cpp b/Source/WebCore/accessibility/gtk/AccessibilityObjectAtk.cpp index c8c1951..850bcbe 100644 --- a/Source/WebCore/accessibility/gtk/AccessibilityObjectAtk.cpp +++ b/Source/WebCore/accessibility/gtk/AccessibilityObjectAtk.cpp @@ -43,17 +43,10 @@ AccessibilityObjectInclusion AccessibilityObject::accessibilityPlatformIncludesO if (roleValue() == SplitterRole) return IncludeObject; - if (isGroup()) { - // When a list item is made up entirely of children (e.g. paragraphs) - // the list item gets ignored. We need it. - if (parent->isList()) - return IncludeObject; - - // We expect the parent of a table cell to be a table. - AccessibilityObject* child = firstChild(); - if (child && child->roleValue() == CellRole) - return IgnoreObject; - } + // When a list item is made up entirely of children (e.g. paragraphs) + // the list item gets ignored. We need it. + if (isGroup() && parent->isList()) + return IncludeObject; // Entries and password fields have extraneous children which we want to ignore. if (parent->isPasswordField() || parent->isTextControl()) @@ -105,7 +98,13 @@ void AccessibilityObject::setWrapper(AccessibilityObjectWrapper* wrapper) bool AccessibilityObject::allowsTextRanges() const { - return isTextControl() || isWebArea() || isGroup() || isLink() || isHeading() || isListItem(); + // Check type for the AccessibilityObject. + if (isTextControl() || isWebArea() || isGroup() || isLink() || isHeading() || isListItem()) + return true; + + // Check roles as the last fallback mechanism. + AccessibilityRole role = roleValue(); + return role == ParagraphRole || role == LabelRole || role == DivRole || role == FormRole; } unsigned AccessibilityObject::getLengthForTextRange() const diff --git a/Source/WebCore/accessibility/gtk/AccessibilityObjectWrapperAtk.cpp b/Source/WebCore/accessibility/gtk/AccessibilityObjectWrapperAtk.cpp index 1d23612..7dff2e3 100644 --- a/Source/WebCore/accessibility/gtk/AccessibilityObjectWrapperAtk.cpp +++ b/Source/WebCore/accessibility/gtk/AccessibilityObjectWrapperAtk.cpp @@ -158,6 +158,11 @@ static AccessibilityObject* core(AtkDocument* document) return core(ATK_OBJECT(document)); } +static AccessibilityObject* core(AtkValue* value) +{ + return core(ATK_OBJECT(value)); +} + static gchar* webkit_accessible_text_get_text(AtkText* text, gint startOffset, gint endOffset); static const gchar* webkit_accessible_get_name(AtkObject* object) @@ -471,6 +476,14 @@ static AtkRole atkRole(AccessibilityRole role) case ListItemRole: case ListBoxOptionRole: return ATK_ROLE_LIST_ITEM; + case ParagraphRole: + return ATK_ROLE_PARAGRAPH; + case LabelRole: + return ATK_ROLE_LABEL; + case DivRole: + return ATK_ROLE_SECTION; + case FormRole: + return ATK_ROLE_FORM; default: return ATK_ROLE_UNKNOWN; } @@ -478,31 +491,16 @@ static AtkRole atkRole(AccessibilityRole role) static AtkRole webkit_accessible_get_role(AtkObject* object) { - AccessibilityObject* axObject = core(object); + AccessibilityObject* coreObject = core(object); - if (!axObject) + if (!coreObject) return ATK_ROLE_UNKNOWN; - // WebCore does not know about paragraph role, label role, or section role - if (axObject->isAccessibilityRenderObject()) { - Node* node = static_cast<AccessibilityRenderObject*>(axObject)->renderer()->node(); - if (node) { - if (node->hasTagName(HTMLNames::pTag)) - return ATK_ROLE_PARAGRAPH; - if (node->hasTagName(HTMLNames::labelTag)) - return ATK_ROLE_LABEL; - if (node->hasTagName(HTMLNames::divTag)) - return ATK_ROLE_SECTION; - if (node->hasTagName(HTMLNames::formTag)) - return ATK_ROLE_FORM; - } - } - // Note: Why doesn't WebCore have a password field for this - if (axObject->isPasswordField()) + if (coreObject->isPasswordField()) return ATK_ROLE_PASSWORD_TEXT; - return atkRole(axObject->roleValue()); + return atkRole(coreObject->roleValue()); } static bool selectionBelongsToObject(AccessibilityObject* coreObject, VisibleSelection& selection) @@ -2301,6 +2299,63 @@ static void atk_document_interface_init(AtkDocumentIface* iface) iface->get_document_locale = webkit_accessible_document_get_locale; } + +static void webkitAccessibleValueGetCurrentValue(AtkValue* value, GValue* gValue) +{ + memset(gValue, 0, sizeof(GValue)); + g_value_init(gValue, G_TYPE_DOUBLE); + g_value_set_double(gValue, core(value)->valueForRange()); +} + +static void webkitAccessibleValueGetMaximumValue(AtkValue* value, GValue* gValue) +{ + memset(gValue, 0, sizeof(GValue)); + g_value_init(gValue, G_TYPE_DOUBLE); + g_value_set_double(gValue, core(value)->maxValueForRange()); +} + +static void webkitAccessibleValueGetMinimumValue(AtkValue* value, GValue* gValue) +{ + memset(gValue, 0, sizeof(GValue)); + g_value_init(gValue, G_TYPE_DOUBLE); + g_value_set_double(gValue, core(value)->minValueForRange()); +} + +static gboolean webkitAccessibleValueSetCurrentValue(AtkValue* value, const GValue* gValue) +{ + if (!G_VALUE_HOLDS_DOUBLE(gValue) && !G_VALUE_HOLDS_INT(gValue)) + return FALSE; + + AccessibilityObject* coreObject = core(value); + if (!coreObject->canSetValueAttribute()) + return FALSE; + + if (G_VALUE_HOLDS_DOUBLE(gValue)) + coreObject->setValue(String::number(g_value_get_double(gValue))); + else + coreObject->setValue(String::number(g_value_get_int(gValue))); + + return TRUE; +} + +static void webkitAccessibleValueGetMinimumIncrement(AtkValue* value, GValue* gValue) +{ + memset(gValue, 0, sizeof(GValue)); + g_value_init(gValue, G_TYPE_DOUBLE); + + // There's not such a thing in the WAI-ARIA specification, thus return zero. + g_value_set_double(gValue, 0.0); +} + +static void atkValueInterfaceInit(AtkValueIface* iface) +{ + iface->get_current_value = webkitAccessibleValueGetCurrentValue; + iface->get_maximum_value = webkitAccessibleValueGetMaximumValue; + iface->get_minimum_value = webkitAccessibleValueGetMinimumValue; + iface->set_current_value = webkitAccessibleValueSetCurrentValue; + iface->get_minimum_increment = webkitAccessibleValueGetMinimumIncrement; +} + static const GInterfaceInfo AtkInterfacesInitFunctions[] = { {(GInterfaceInitFunc)atk_action_interface_init, (GInterfaceFinalizeFunc) 0, 0}, @@ -2321,6 +2376,8 @@ static const GInterfaceInfo AtkInterfacesInitFunctions[] = { {(GInterfaceInitFunc)atkHyperlinkImplInterfaceInit, (GInterfaceFinalizeFunc) 0, 0}, {(GInterfaceInitFunc)atk_document_interface_init, + (GInterfaceFinalizeFunc) 0, 0}, + {(GInterfaceInitFunc)atkValueInterfaceInit, (GInterfaceFinalizeFunc) 0, 0} }; @@ -2334,7 +2391,8 @@ enum WAIType { WAI_TABLE, WAI_HYPERTEXT, WAI_HYPERLINK, - WAI_DOCUMENT + WAI_DOCUMENT, + WAI_VALUE, }; static GType GetAtkInterfaceTypeFromWAIType(WAIType type) @@ -2360,6 +2418,8 @@ static GType GetAtkInterfaceTypeFromWAIType(WAIType type) return ATK_TYPE_HYPERLINK_IMPL; case WAI_DOCUMENT: return ATK_TYPE_DOCUMENT; + case WAI_VALUE: + return ATK_TYPE_VALUE; } return G_TYPE_INVALID; @@ -2431,6 +2491,10 @@ static guint16 getInterfaceMaskFromObject(AccessibilityObject* coreObject) if (role == WebAreaRole) interfaceMask |= 1 << WAI_DOCUMENT; + // Value + if (role == SliderRole) + interfaceMask |= 1 << WAI_VALUE; + return interfaceMask; } diff --git a/Source/WebCore/accessibility/gtk/WebKitAccessibleHyperlink.cpp b/Source/WebCore/accessibility/gtk/WebKitAccessibleHyperlink.cpp index 5927430..b9e483c 100644 --- a/Source/WebCore/accessibility/gtk/WebKitAccessibleHyperlink.cpp +++ b/Source/WebCore/accessibility/gtk/WebKitAccessibleHyperlink.cpp @@ -32,6 +32,7 @@ #include "RenderListMarker.h" #include "RenderObject.h" #include "TextIterator.h" +#include "htmlediting.h" #include <atk/atk.h> #include <glib.h> @@ -230,11 +231,19 @@ static gint webkitAccessibleHyperlinkGetStartIndex(AtkHyperlink* link) if (!coreObject) return 0; + AccessibilityObject* parentUnignored = coreObject->parentObjectUnignored(); + if (!parentUnignored) + return 0; + Node* node = coreObject->node(); if (!node) return 0; - RefPtr<Range> range = Range::create(node->document(), firstPositionInNode(node->parentNode()), firstPositionInNode(node)); + Node* parentNode = parentUnignored->node(); + if (!parentNode) + return 0; + + RefPtr<Range> range = Range::create(node->document(), firstPositionInOrBeforeNode(parentNode), firstPositionInOrBeforeNode(node)); return getRangeLengthForObject(coreObject, range.get()); } @@ -246,11 +255,19 @@ static gint webkitAccessibleHyperlinkGetEndIndex(AtkHyperlink* link) if (!coreObject) return 0; + AccessibilityObject* parentUnignored = coreObject->parentObjectUnignored(); + if (!parentUnignored) + return 0; + Node* node = coreObject->node(); if (!node) return 0; - RefPtr<Range> range = Range::create(node->document(), firstPositionInNode(node->parentNode()), lastPositionInNode(node)); + Node* parentNode = parentUnignored->node(); + if (!parentNode) + return 0; + + RefPtr<Range> range = Range::create(node->document(), firstPositionInOrBeforeNode(parentNode), lastPositionInOrAfterNode(node)); return getRangeLengthForObject(coreObject, range.get()); } |
