diff options
| author | Steve Block <steveblock@google.com> | 2011-11-24 10:58:55 +0000 |
|---|---|---|
| committer | Steve Block <steveblock@google.com> | 2011-11-24 11:39:50 +0000 |
| commit | 30a9d6dfa5ddf75aef0fcf23f7bfbffa41a704ff (patch) | |
| tree | 74d179d361be51475fb1e4091f515e4ba50b0fa6 /Source/WebCore/platform/NotImplemented.h | |
| parent | df2cb042a14f695da5b0de2c58f2065d3cfbea56 (diff) | |
| download | external_webkit-30a9d6dfa5ddf75aef0fcf23f7bfbffa41a704ff.zip external_webkit-30a9d6dfa5ddf75aef0fcf23f7bfbffa41a704ff.tar.gz external_webkit-30a9d6dfa5ddf75aef0fcf23f7bfbffa41a704ff.tar.bz2 | |
Only log from notImplemented() in debug builds
The upstream notImplemented() is only enabled in debug builds. Currently,
we use an Android-specific implementation of notImplemented(), which is enabled
in all builds.
We probably don't want this logging in all builds: logging in debug builds only
is sufficient. Also, now that WebKit logging is functional (b/5448972), we
don't need an Android-specific implementation of notImplemented().
This patch removes our local edit to address both of these.
Change-Id: I07e2e8cb42d99dece1c711508c297d8ae0bdda72
Diffstat (limited to 'Source/WebCore/platform/NotImplemented.h')
| -rw-r--r-- | Source/WebCore/platform/NotImplemented.h | 16 |
1 files changed, 1 insertions, 15 deletions
diff --git a/Source/WebCore/platform/NotImplemented.h b/Source/WebCore/platform/NotImplemented.h index 458604d..e9758b0 100644 --- a/Source/WebCore/platform/NotImplemented.h +++ b/Source/WebCore/platform/NotImplemented.h @@ -38,21 +38,7 @@ #define supressNotImplementedWarning() false #endif -#if OS(ANDROID) - -#include <cutils/log.h> -#ifndef LOG_TAG -#define LOG_TAG "WebCore" -#endif -#define notImplemented() do { \ - static bool havePrinted = false; \ - if (!havePrinted && !supressNotImplementedWarning()) { \ - ALOGV("%s: notImplemented", __PRETTY_FUNCTION__); \ - havePrinted = true; \ - } \ - } while (0) - -#elif defined(NDEBUG) +#if defined(NDEBUG) #define notImplemented() ((void)0) #else |