diff options
| author | Steve Block <steveblock@google.com> | 2011-07-11 10:39:10 +0100 |
|---|---|---|
| committer | Steve Block <steveblock@google.com> | 2011-07-12 10:53:43 +0100 |
| commit | a577c97987bfe6f96fee0081bcdf4d526a9f7d3f (patch) | |
| tree | a05449ba341f5cb6d7dc5603e0df2045e501eee8 /Source/WebCore/platform/NotImplemented.h | |
| parent | ad1bc825197d7f62d2a8d06d3b56fdc5f9c458b9 (diff) | |
| download | external_webkit-a577c97987bfe6f96fee0081bcdf4d526a9f7d3f.zip external_webkit-a577c97987bfe6f96fee0081bcdf4d526a9f7d3f.tar.gz external_webkit-a577c97987bfe6f96fee0081bcdf4d526a9f7d3f.tar.bz2 | |
notImplemented() should always log to logcat
- Update Android's version of notImplemented() to match that on other
platforms and only log once for each method.
- Remove lowPriority_notImplemented(), as this was added way back in
https://mondrian.corp.google.com/changelist/16159-p9 and I'm pretty
sure the distinction between that and notImplemented() has long
since been lost.
- Move verifiedOk() to FrameLoaderClientAndroid.cpp as this is the
only place it is used.
Bug: 5008643
Change-Id: I6552a2a736873b4dfb0933e55af3ab862b60f87c
Diffstat (limited to 'Source/WebCore/platform/NotImplemented.h')
| -rw-r--r-- | Source/WebCore/platform/NotImplemented.h | 25 |
1 files changed, 13 insertions, 12 deletions
diff --git a/Source/WebCore/platform/NotImplemented.h b/Source/WebCore/platform/NotImplemented.h index 61e4424..a71e99c 100644 --- a/Source/WebCore/platform/NotImplemented.h +++ b/Source/WebCore/platform/NotImplemented.h @@ -38,19 +38,20 @@ #define supressNotImplementedWarning() false #endif -#if defined ANDROID +#if OS(ANDROID) + +#include <cutils/log.h> +#ifndef LOG_TAG +#define LOG_TAG "WebCore" +#endif +#define notImplemented() do { \ + static bool havePrinted = false; \ + if (!havePrinted && !supressNotImplementedWarning()) { \ + LOGV("%s: notImplemented", __PRETTY_FUNCTION__); \ + havePrinted = true; \ + } \ + } while (0) - #if 1 && defined LOG_TAG - #ifndef _LIBS_UTILS_LOG_H - #undef LOG - #include <utils/Log.h> - #endif - #define notImplemented() LOGV("%s: notImplemented\n", __PRETTY_FUNCTION__) - #define lowPriority_notImplemented() //printf("%s\n", __PRETTY_FUNCTION__) - #define verifiedOk() // not a problem that it's not implemented - #else - #define notImplemented() fprintf(stderr, "%s\n", __PRETTY_FUNCTION__) - #endif #elif defined(NDEBUG) #define notImplemented() ((void)0) #else |