summaryrefslogtreecommitdiffstats
path: root/Source
diff options
context:
space:
mode:
authorJean-Baptiste Queru <jbq@google.com>2012-03-01 13:55:51 -0800
committerJean-Baptiste Queru <jbq@google.com>2012-03-01 13:56:11 -0800
commitf2296bfba333e80ebd11a63883d391b38f1ddb84 (patch)
tree9cc32dfff00075dcb94c44fc36e639938fc1c378 /Source
parent2285ad26b6524cc5a71f5282f8bd18a5ba9ce028 (diff)
parentd911316743c0757f8877db9f4d747ed24572b1e9 (diff)
downloadexternal_webkit-f2296bfba333e80ebd11a63883d391b38f1ddb84.zip
external_webkit-f2296bfba333e80ebd11a63883d391b38f1ddb84.tar.gz
external_webkit-f2296bfba333e80ebd11a63883d391b38f1ddb84.tar.bz2
Merge from ics-mr1
Change-Id: Ib2618ca7bd118da611e897f537b4f4ab5deb8e36
Diffstat (limited to 'Source')
-rw-r--r--Source/WebCore/rendering/RenderBlock.cpp21
1 files changed, 13 insertions, 8 deletions
diff --git a/Source/WebCore/rendering/RenderBlock.cpp b/Source/WebCore/rendering/RenderBlock.cpp
index 373523d..a90bf69 100644
--- a/Source/WebCore/rendering/RenderBlock.cpp
+++ b/Source/WebCore/rendering/RenderBlock.cpp
@@ -1561,6 +1561,16 @@ bool RenderBlock::handleRunInChild(RenderBox* child)
RenderBlock* currBlock = toRenderBlock(curr);
+ // First we destroy any :before/:after content. It will be regenerated by the new inline.
+ // Exception is if the run-in itself is generated.
+ if (child->style()->styleType() != BEFORE && child->style()->styleType() != AFTER) {
+ RenderObject* generatedContent;
+ if (child->getCachedPseudoStyle(BEFORE) && (generatedContent = child->beforePseudoElementRenderer()))
+ generatedContent->destroy();
+ if (child->getCachedPseudoStyle(AFTER) && (generatedContent = child->afterPseudoElementRenderer()))
+ generatedContent->destroy();
+ }
+
// Remove the old child.
children()->removeChildNode(this, blockRunIn);
@@ -1569,16 +1579,11 @@ bool RenderBlock::handleRunInChild(RenderBox* child)
RenderInline* inlineRunIn = new (renderArena()) RenderInline(runInNode ? runInNode : document());
inlineRunIn->setStyle(blockRunIn->style());
- bool runInIsGenerated = child->style()->styleType() == BEFORE || child->style()->styleType() == AFTER;
-
- // Move the nodes from the old child to the new child, but skip any :before/:after content. It has already
- // been regenerated by the new inline.
+ // Move the nodes from the old child to the new child
for (RenderObject* runInChild = blockRunIn->firstChild(); runInChild;) {
RenderObject* nextSibling = runInChild->nextSibling();
- if (runInIsGenerated || (runInChild->style()->styleType() != BEFORE && runInChild->style()->styleType() != AFTER)) {
- blockRunIn->children()->removeChildNode(blockRunIn, runInChild, false);
- inlineRunIn->addChild(runInChild); // Use addChild instead of appendChildNode since it handles correct placement of the children relative to :after-generated content.
- }
+ blockRunIn->children()->removeChildNode(blockRunIn, runInChild, false);
+ inlineRunIn->addChild(runInChild); // Use addChild instead of appendChildNode since it handles correct placement of the children relative to :after-generated content.
runInChild = nextSibling;
}