diff options
Diffstat (limited to 'Tools/Scripts/webkitpy/style/checker_unittest.py')
| -rwxr-xr-x | Tools/Scripts/webkitpy/style/checker_unittest.py | 31 |
1 files changed, 25 insertions, 6 deletions
diff --git a/Tools/Scripts/webkitpy/style/checker_unittest.py b/Tools/Scripts/webkitpy/style/checker_unittest.py index a796e0b..144d40a 100755 --- a/Tools/Scripts/webkitpy/style/checker_unittest.py +++ b/Tools/Scripts/webkitpy/style/checker_unittest.py @@ -52,6 +52,7 @@ from checker import CheckerDispatcher from checker import ProcessorBase from checker import StyleProcessor from checker import StyleProcessorConfiguration +from checkers.changelog import ChangeLogChecker from checkers.cpp import CppChecker from checkers.python import PythonChecker from checkers.text import TextChecker @@ -368,12 +369,10 @@ class CheckerDispatcherDispatchTest(unittest.TestCase): """Tests dispatch() method of CheckerDispatcher class.""" - def mock_handle_style_error(self): - pass - def dispatch(self, file_path): """Call dispatch() with the given file path.""" dispatcher = CheckerDispatcher() + self.mock_handle_style_error = DefaultStyleErrorHandler('', None, None, []) checker = dispatcher.dispatch(file_path, self.mock_handle_style_error, min_confidence=3) @@ -395,6 +394,10 @@ class CheckerDispatcherDispatchTest(unittest.TestCase): "got_class": got_class, "expected_class": expected_class}) + def assert_checker_changelog(self, file_path): + """Assert that the dispatched checker is a ChangeLogChecker.""" + self.assert_checker(file_path, ChangeLogChecker) + def assert_checker_cpp(self, file_path): """Assert that the dispatched checker is a CppChecker.""" self.assert_checker(file_path, CppChecker) @@ -411,6 +414,25 @@ class CheckerDispatcherDispatchTest(unittest.TestCase): """Assert that the dispatched checker is a XMLChecker.""" self.assert_checker(file_path, XMLChecker) + def test_changelog_paths(self): + """Test paths that should be checked as ChangeLog.""" + paths = [ + "ChangeLog", + "ChangeLog-2009-06-16", + os.path.join("Source", "WebCore", "ChangeLog"), + ] + + for path in paths: + self.assert_checker_changelog(path) + + # Check checker attributes on a typical input. + file_path = "ChangeLog" + self.assert_checker_changelog(file_path) + checker = self.dispatch(file_path) + self.assertEquals(checker.file_path, file_path) + self.assertEquals(checker.handle_style_error, + self.mock_handle_style_error) + def test_cpp_paths(self): """Test paths that should be checked as C++.""" paths = [ @@ -465,8 +487,6 @@ class CheckerDispatcherDispatchTest(unittest.TestCase): def test_text_paths(self): """Test paths that should be checked as text.""" paths = [ - "ChangeLog", - "ChangeLog-2009-06-16", "foo.ac", "foo.cc", "foo.cgi", @@ -491,7 +511,6 @@ class CheckerDispatcherDispatchTest(unittest.TestCase): "foo.wm", "foo.xhtml", "foo.y", - os.path.join("Source", "WebCore", "ChangeLog"), os.path.join("Source", "WebCore", "inspector", "front-end", "inspector.js"), os.path.join("Tools", "Scripts", "check-webkit-style"), ] |