diff options
Diffstat (limited to 'WebKitTools/Scripts/webkitpy/tool/commands/rebaseline.py')
| -rw-r--r-- | WebKitTools/Scripts/webkitpy/tool/commands/rebaseline.py | 9 |
1 files changed, 5 insertions, 4 deletions
diff --git a/WebKitTools/Scripts/webkitpy/tool/commands/rebaseline.py b/WebKitTools/Scripts/webkitpy/tool/commands/rebaseline.py index 78e06c6..abfa850 100644 --- a/WebKitTools/Scripts/webkitpy/tool/commands/rebaseline.py +++ b/WebKitTools/Scripts/webkitpy/tool/commands/rebaseline.py @@ -72,15 +72,15 @@ class Rebaseline(AbstractDeclarativeCommand): # FIXME: This should share more code with FailureReason._builder_to_explain def _builder_to_pull_from(self): - builder_statuses = self.tool.buildbot.builder_statuses() + builder_statuses = self._tool.buildbot.builder_statuses() red_statuses = [status for status in builder_statuses if not status["is_green"]] print "%s failing" % (pluralize("builder", len(red_statuses))) builder_choices = [status["name"] for status in red_statuses] - chosen_name = self.tool.user.prompt_with_list("Which builder to pull results from:", builder_choices) + chosen_name = self._tool.user.prompt_with_list("Which builder to pull results from:", builder_choices) # FIXME: prompt_with_list should really take a set of objects and a set of names and then return the object. for status in red_statuses: if status["name"] == chosen_name: - return (self.tool.buildbot.builder_with_name(chosen_name), status["build_number"]) + return (self._tool.buildbot.builder_with_name(chosen_name), status["build_number"]) def _replace_expectation_with_remote_result(self, local_file, remote_file): (downloaded_file, headers) = urllib.urlretrieve(remote_file) @@ -90,7 +90,8 @@ class Rebaseline(AbstractDeclarativeCommand): parsed_results = build.layout_test_results().parsed_results() # FIXME: This probably belongs as API on LayoutTestResults # but .failing_tests() already means something else. - return parsed_results[LayoutTestResults.fail_key] + failing_tests = parsed_results[LayoutTestResults.fail_key] + return self._tool.user.prompt_with_list("Which test(s) to rebaseline:", failing_tests, can_choose_multiple=True) def _results_url_for_test(self, build, test): test_base = os.path.splitext(test)[0] |