| Commit message (Collapse) | Author | Age | Files | Lines |
|\ |
|
| |
| |
| |
| |
| |
| | |
The original data in this file comes from FileFilter class in the old Dump Render Tree and was extracted from there on 30/07/2010
Change-Id: Ibc1101d08123ffaff51b765e5333d1b96c5ab02f
|
| |
| |
| |
| | |
This reverts commit 0ed6485271097ecf1b4cf4e790f9cfdbb57d921c.
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
This allows web pages to have fine-grain control over the appearance
of the rings drawn around nodes.
Generated links (email, addresses, phone numbers) are no longer
given unique colors. To preserve this feature, a separate change
could add an HTML extension similar to vlink to provide the cursor
ring defintions for theses links. The mechanism implemented below
isn't appropriate since these links don't necessarily correspond to
single DOM nodes or other DOM elements.
------------
CSS examples
------------
The CSS to specify the ring looks like:
-webkit-ring-fill-color:rgba(0,0,255,0.4);
-webkit-ring-inner-width:2 px;
-webkit-ring-outer-width:3.5 px;
-webkit-ring-outset: 8 px;
-webkit-ring-pressed-inner-color:rgba(0,0,255,0.8);
-webkit-ring-pressed-outer-color:rgba(0,0,127,0.3);
-webkit-ring-radius: 10 px;
-webkit-ring-selected-inner-color:rgba(63,63,255,0.8);
-webkit-ring-selected-outer-color:rgba(63,63,127,0.3);
and may be alternately defined with a property shortcut:
-webkit-ring:rgba(255,0,0,0.4) 5px 7px
rgba(255,0,0,0.8) rgba(127,0,0,0.3) 20px
rgba(255,63,63,0.8) rgba(127,63,63,0.3);
--------------------
Property definitions
--------------------
A vertical cross-section of the ring corresponds to these
parameters as shown:
______
R / ___O_ R = corner radius
/ / __I_ o I = inner ring
/ / / _O_ ^ O = outer ring
| | | / F | F = fill
|O|I|O| L o = outset
| | | \_F_ | L = original link
\ \ \__O_ V
\ \___I_ o
R \____O_
The fill color specifies what to draw inside the ring
when the link is followed. The fill area consists of the
original link area the outset.
The inner and outer widths specify the stoke width of the inner
and outer rings, respectively. The widths may be specified in
fractional pixels. The implementation captures 4 bits of the
fraction.
The outset specifies the distance from the edge of the original
link to the rings' center. Both rings are drawn at the same center
location.
The radius specifies the curvature of the corners at the center
of the rings.
-------------
Data lifetime
-------------
The selected colors specify the colors of the inner and outer
rings when the trackball or D-pad hovers over the link. The
pressed colors specify the colors of the rings when the
trackball center is pressed or the link is tapped.
The CSS data is recorded in the RenderStyle when the DOM
is parsed. The widths are scaled up by 16 to preserve the fraction.
When the nav cache is built, the CSS style information is
recorded in the CachedColor class. Only unique style sets
are recorded; many CachedNode instances can share the same
CachedColor instance.
When the cursor ring is drawn, the CachedColor is
retrieved by getting the index from the CachedNode, and
looking up the entry in the CachedFrame. The widths are
scaled down by 16 since Lengths are stored by the webkit as
integers.
----------
File Edits
----------
WebCore/Android.derived.mk
- Build the CSS data property tables by concatentating
Android specific data and optionally SVG data.
WebCore/config.h
- Add switch for these rings. This switch is meant
as a convenience for finding the code in WebKit
that was added to enable this feature. Since the
old code in DrawCursor has been removed, it does
not revert to the old behavior if the switch is
turned off.
WebCore/css/AndroidCSSPropertyNames.in
- The new ring properties, plus an old one we
added before.
WebCore/css/CSSComputedStyleDeclaration.cpp
WebCore/css/CSSMutableStyleDeclaration.cpp
WebCore/css/CSSParser.cpp
WebCore/css/CSSStyleSelector.cpp
- I can guess what these functions are for as
well as anyone, but I really don't know. Do
I need all of them? Do I need to modify
Mutable at all?
WebCore/css/CSSPropertyNames.in
- Moved Android addition to AndroidCSSPropertyNames.in
WebCore/platform/graphics/Color.h
- Added initial color values here.
WebCore/platform/graphics/android/android_graphics.*
- This draws the cursor ring. The code that draws
'synthetic' links has been discarded.
WebCore/rendering/style/RenderStyle.h
- Functions to get, set, and initialize the style
data.
WebCore/rendering/style/StyleRareInheritedData.*
- The storage for the style data and an equivalence
function.
WebKit/Android.mk
- Added CachedColor to the build.
WebKit/android/nav/CacheBuilder.cpp
- Record the color from the DOM into the cache.
WebKit/android/nav/CachedColor.*
- Store the cached color info.
WebKit/android/nav/CachedFrame.*
- Where the array of colors is stored.
WebKit/android/nav/CachedNode.*
- Where the index to the colors is stored.
Change-Id: Ia3a931f41d6545e47678e245aafe7c84d4658f94
http://b/2603197
|
|\ \ |
|
| | |
| | |
| | |
| | |
| | | |
issue: 2841402
Change-Id: Ia147b39f84be91a92dd4f491e8d3de263df4244b
|
|\ \ \
| |_|/
|/| | |
|
| |/
| |
| |
| |
| |
| |
| | |
The original webkit change is:
http://trac.webkit.org/changeset/64087
Change-Id: Ide7141ffec0a8a37f333c06bddabe3703d79af54
|
|\ \ |
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Ported the webkit fixes from http://trac.webkit.org/changeset/62965.
Harfbuzz does not do mirroring, so we iterate each character
in the string and mirror it if needed before passing the
string to harfbuzz for shaping.
Change-Id: Ifee1035f96e4e82a5a2641b57dd839cec3427b59
|
| |/
|/|
| |
| | |
Change-Id: I31e3786742f0ae05c9f6c8ab23b4dbd0c790dfc5
|
|\ \ |
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
All tests pass.
Note that the JSC-specific expected result for window-property.html is a
placeholder until https://bugs.webkit.org/show_bug.cgi?id=43025 is fixed.
Change-Id: I60a978231a10f0a57b3dc654876b181dc47eb455
|
|\ \ \
| |/ /
|/| |
| | | |
finished."
|
| |/
| |
| |
| |
| |
| | |
Already approved in https://android-git.corp.google.com/g/#change,58487
Change-Id: Ib9718053edacd76b77a41b76782fd20769f57823
|
|\ \ |
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
These all pass.
Note that the Android-V8-specific results are required because these tests rely
on Error.line, which is non-standard and not provided by V8.
A further 15 tests have no expected results so will be added to the
DumpRenderTree ignore list.
None of these tests are run on Chromium.
Change-Id: I6b7ea492586fa2d9cd60858f06641941c87ede14
|
| | |
| | |
| | |
| | | |
Change-Id: I2979ff9ad9c3813dbfc33874aea23414d6c71bdf
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Android. See http://trac.webkit.org/changeset/63599
See b/2869593
Change-Id: Ib7c8fda4a9bf62d470a4fa63823fa0951b5974ea
|
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
so add it and stub out platformTransformColorSpace.
See http://trac.webkit.org/changeset/63450
Change-Id: I2c84c13a19b1a787b0edbfb9fcefd08acd9ed6ff
|
| | |
| | |
| | |
| | |
| | |
| | | |
constants match their enums. See http://trac.webkit.org/changeset/63331
Change-Id: Ida82337eec825e26ab4afb8fc26e22fdb6c18786
|
| | |
| | |
| | |
| | |
| | |
| | | |
This is a cherry pick of http://trac.webkit.org/changeset/64007 to fix the build.
Change-Id: Ic86639eb7dbcd09f0273f614537354bfa7fd369d
|
| | |
| | |
| | |
| | |
| | |
| | | |
See http://trac.webkit.org/changeset/63332
Change-Id: Id019ee222d0b7dcfa464f97cfffdd5c08e2d0ee8
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
const QualfiedName&) function has been removed.
See http://trac.webkit.org/changeset/63358
Change-Id: I89c6a0a98d04f0a0cd40492229fa03f2e9782622
|
| | |
| | |
| | |
| | |
| | |
| | | |
WebKit. See http://trac.webkit.org/changeset/63638
Change-Id: I97784c98b694f28804421637716afa649aa09a6e
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
default hit test request
as we also wish to pass a padding rect to use the HITTEST_WITHSIZE codepath.
See http://trac.webkit.org/changeset/63807
Change-Id: I62109577c9468639971522a72adc3a543237516a
|
| | |
| | |
| | |
| | |
| | |
| | | |
http://trac.webkit.org/changeset/63602
Change-Id: I22392960cf91a1f826d37f257325fc988e2a8347
|
| | |
| | |
| | |
| | |
| | |
| | | |
http://trac.webkit.org/changeset/63339
Change-Id: I26df53fba097893a5adee2a957a63a0f1720def8
|
| | |
| | |
| | |
| | | |
Change-Id: I5a218be0b26003f4fceb964e7add0f1eda410710
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
html/HTMLCanvasElement.h due to http://trac.webkit.org/changeset/63502
html/HTMLLinkElement.cpp due to http://trac.webkit.org/changeset/63622
Android.mk and WebCore/Android.mk due to http://trac.webkit.org/changeset/63735
WebCore/page/Settings.cpp|h due to http://trac.webkit.org/changeset/63537
WebCore/page/EventHandler.cpp|h due to http://trac.webkit.org/changeset/63807
WebCore/Android.jscbindings.mk due to http://trac.webkit.org/changeset/63193
WebCore/platform/network/ResourceHandle.h due to http://trac.webkit.org/changeset/63332
Change-Id: I03c929b97550014373f044f56c248040b66118f0
|
| | |
| | |
| | |
| | | |
Change-Id: Ie8096c63ec7c991c9a9cba8bdd9c3b74a3b8ed62
|
| |/
|/|
| |
| |
| | |
issue: 2870827
Change-Id: I49f9a83fd7cd79100d7d8b0833db7d9f03c7e4f8
|
|\ \ |
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
2 problems were found in JSON-stringify.html test crash.
1. Dirty memory is re-used in FontAndroid.cpp.
2. Unnecessary delete/new GlyphArrays.
Change-Id: I16bfe96943815f35ef1730287d61295ecd3ea2ad
|
| | |
| | |
| | |
| | |
| | | |
Bug: 2862822
Change-Id: I9de300517eaa2bd4027608d6bae093bf5a1072e0
|
|\ \ \
| |_|/
|/| | |
|
| | |
| | |
| | |
| | | |
Change-Id: I5741bfe5d0907deb8a5158390b44e74b4485be67
|
|/ /
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Force a composite layer when the style says the content is scrollable.
Record the border and background in the main content picture. When
the contents of the layer are bigger than the size, record the
foreground contents in a separate picture which is clipped by the
border and size.
When updating the base layer, remember the scroll position of each
layer and update the new layer with the same position.
Bug: 1566791
Change-Id: If440e4f215db6bda9df32a781d754d1f5a238162
|
| |
| |
| |
| |
| |
| | |
This reverts commit 31dbf1e39c75fa71a6175b95ce2172727630129b.
The underlying issue in the compiler has been fixed.
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
When the selected text visual order doesn't match the picture
order, the text is selected spacially. The rectangle described
by the start and end points limits what text is selected.
This can fail when the rectangle described is too narrow to
enclose all the lines between the top and bottom. This change
extends the lines by including the text adjacent to the start
and end when computing the limit bounds.
And:
- Refactor the code so that drawing the region and selecting
the text can share this logic.
- Add slashes as characters that prevent inserting spaces at
the ends of lines. (ASCII characters space, dash, slash, and
backslash cause lines to wrap.)
- Narrow the error term for detecting spaces. The 1/2 value
before inserted spaces incorrectly.
Change-Id: I645f38dc246c61b1bc7c94e61553e5e6e36e3f85
http://b/2817635
|
|\ \
| | |
| | |
| | | |
because it fixes http://b/issue?id=2838936, but includes more refactoring than my original fix at https://android-git.corp.google.com/g/#change,58175"
|
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
because it fixes http://b/issue?id=2838936, but includes more refactoring
than my original fix at https://android-git.corp.google.com/g/#change,58175
Change-Id: I67884fc153bff81c9580f36b7be1662acdda194e
|
|/ /
| |
| |
| | |
Change-Id: I38c7939b81cd0afaaf925b9f74104bcbe27b5977
|
| |
| |
| |
| |
| |
| | |
isPrefetch should return true when the resource is a prefetch, not when it isn't
Change-Id: I73389e302ba7c57b6c4f6bf871f230a968d09c81
|
| |
| |
| |
| | |
Change-Id: I5f7614cdfda3e1c73027c60cb71dff1d9b7d3282
|
| |
| |
| |
| |
| |
| |
| |
| | |
release method.
leakPtr appears to be the alternative.
Change-Id: I55d7c2a927e86cfd23ec5a1bb292d2058bcacb09
|
| |
| |
| |
| | |
Change-Id: I1c86a2881f5bef152f1b9841d6dce41da91b03ac
|
| |
| |
| |
| |
| |
| | |
case doesn't seem to compile
Change-Id: I16ee514aa06762fe8c4df50d6739d394d03b6d1b
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Note that MathML tags and attribute names are now generated,
and SVG tags and attribute names are always generated. This is because
the HTML5 parser relies on knowing about the tags even if the features
are disabled. See
https://bugs.webkit.org/show_bug.cgi?id=42050
https://bugs.webkit.org/show_bug.cgi?id=42059
Change-Id: Ie8b66217989673f90ffc61aabf499ab91a6a6bd1
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Android.v8bindings.mk: IDBBindingUtilities caused by http://trac.webkit.org/changeset/63064
CSSCompitedStyleDeclaration.cpp conflict caused by http://trac.webkit.org/changeset/63038
'Computed style is not implemented for padding-start, padding-end, margin-start, margin-end'
HTMLDocumentParser.cpp conflict caused by http://trac.webkit.org/changeset/63165
'HTML5 Parser: document.write after onload blows away document'
Navigator.h conflict caused by http://trac.webkit.org/changeset/62577
Page.cpp caused by http://trac.webkit.org/changeset/62502
ResourceHandleAndroid.cpp by http://trac.webkit.org/changeset/62736
HTMLLinkElement.* by the upstreaming of link prefetching at http://trac.webkit.org/changeset/63032
Change-Id: I5b9d3eef87cd525a9fc7d862676a41fc4122cba0
|