| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
| |
Bug: 2928878, 2928899
Change-Id: I90ca6f93a61c921b520731e6a143e5b4457fa44c
|
|
|
|
| |
Change-Id: Ib097f8fda80cf33185d9b6a3a00a47ca83a7e678
|
|\ |
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
In Apple's DerivedSources.make, XLinkNames are built all the time.
Change our Android.derived.mk to do the same, instead of only
building when SVG is enabled.
Change-Id: I69d903788e4416e2140068f2aa907d65b336ce68
|
|/
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Set the foreground clip after drawing. Use the absolute bounds to
compute the local foreground clip in order to compensate for any
outline.
Consolidate the check for overflow scrolling into RenderLayer.
Request a compositing update after computing the scroll dimensions.
Only change the foregroundRect of the layer during paint so that the
outline rect (and background/layerBounds) are correct.
Draw the outline as part of the background phase. During painting of
a layer, scroll to (0,0), paint, then scroll back.
When clicking on an element in a layer, scroll to the position of the
element but do not scroll back. This makes text input fields visible
to the tree and will properly update when typing. Record the original
scroll position of layers in order to offset the bounds of nodes when
checking the nav cache. Make sure to reset all cached layers during
setRootLayer. Otherwise we were reaching into layers from the wrong
thread.
Change-Id: Id9827ec461989b0869a8252d4d2563ecd12c5fac
|
|
|
|
| |
Change-Id: I20f36620033e6249fe5b749ae74392e2ac64c09c
|
|
|
|
|
|
|
|
|
|
|
| |
EmptyDeviceMotionClient
See https://android-git.corp.google.com/g/#change,61020 which picked
part of this change for EmptyDeviceOrientationClient.
See also https://bugs.webkit.org/show_bug.cgi?id=43848
Change-Id: Idefd9becf89199ae9afe475074fc56a66252db8a
|
|
|
|
|
|
|
|
|
| |
Cherry pick of http://trac.webkit.org/changeset/65258
http://trac.webkit.org/changeset/64722 introduced a build break when
INSPECTOR is not enabled.
Change-Id: I8791737a6c399245b84a8adc9830364ac4df907d
|
|
|
|
|
|
|
|
|
|
|
| |
Cherry pick of WebKit r65240.
http://trac.webkit.org/changeset/65005 introduced a bug in the
V8 Code Generator.
See http://trac.webkit.org/changeset/65240
Change-Id: I992c56b073611a4d9caf4c2c0ae0d231e774213a
|
|
|
|
|
|
| |
See http://trac.webkit.org/changeset/65021
Change-Id: I779a8ec0c3e1e0aed8f8d1894cfc1e5ca33ee549
|
|
|
|
|
|
|
|
|
|
|
|
| |
HTMLInputElement.cpp: New include. See http://trac.webkit.org/changeset/64616
TemporaryLinkStubs.cpp, Navigator.h: Relocation of string forwarders. See http://trac.webkit.org/changeset/65021
GraphicsContext.h, ImageSource.h: addition of WebCore namespace on Chromium's NativeImagePtr type. See http://trac.webkit.org/changeset/64584
Platform.h: Renaming of iPhone PLATFORM macros. See http://trac.webkit.org/changeset/64798
Change-Id: Ife412e30f733fe6bb66321a3600814d6499ddf70
|
|
|
|
| |
Change-Id: I2da1ae98ee39f7f817d4b4363140872b931ac8bf
|
|
|
|
| |
Change-Id: Ibcf418498376b2660aacb7f8d46ea7085ef91585
|
|
|
|
| |
Change-Id: Id6c9cfc92ba2aeaae15724e789e9531a451e04fa
|
|
|
|
|
|
|
|
|
|
|
| |
This is a partial cherry-pick of WebKit change 64106
See https://bugs.webkit.org/show_bug.cgi?id=43848
We can't take the complete change because we don't yet have
DeviceMotion in our version of WebKit.
Bug: 2907653
Change-Id: Ie038a21f9e989af46fb6b77decd7ea10da734b3c
|
|
|
|
|
|
|
|
|
| |
VisitedLinkStrategy.h
This is required to build on Mac.
See http://trac.webkit.org/changeset/64527
Change-Id: Id60a76a57cf354e0bb84d41eeef4c14257bfaedc
|
|
|
|
|
|
| |
See http://trac.webkit.org/changeset/64732
Change-Id: I5fe2041764991c6c621bb634df1ed4bcb896f7eb
|
|
|
|
|
|
|
|
| |
methods
See http://trac.webkit.org/changeset/64513
Change-Id: I9f55ae27989f7a246c0c1e5f771677c66a9b1556
|
|
|
|
|
|
|
|
| |
for Android
See http://trac.webkit.org/changeset/64434
Change-Id: Icbf0fed42fbef71340c697537fb0ff4815b574fd
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- WebCore/Android.mk
Conflict due to error introduced upstream.
See http://trac.webkit.org/changeset/64344/trunk/WebCore/Android.mk
and http://trac.webkit.org/changeset/60228/trunk/WebCore/Android.mk
- WebCore/html/HTMLFrameSetElement.cpp
Conflict due to ANDROID_FLATTEN_FRAMESET
See http://trac.webkit.org/changeset/64383
- WebCore/page/Navigator.h
Conflict due to APPLICATION_INSTALLED
See http://trac.webkit.org/changeset/64371
- WebCore/rendering/SVGResourcesCycleSolver.cpp
Conflict due to local ENABLE(FILTERS) guard
See http://trac.webkit.org/changeset/64440
Change-Id: Ibafe3b92117c3a7b3eaaa44c6cf3d04c8c6027c2
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
A modified version of this Android-specific code was upstreamed in
http://trac.webkit.org/changeset/64272
For the most part, the differences between the Android and upstreamed
versions are syntactic only. In these cases, we take the upstream
version.
In a small number of cases, logical changes exist. In these cases, the
Android logic has been retained, guarded with ANDROID_HITTEST_WITHSIZE,
but using the new syntax.
In particular ...
- Android's HitTestResult::intersects(x, y, rect) is logically equivalent
to the uspstream IntRect::intersects(HitTestPoint::rectFromPoint(x, y))).
- Android's HitTestResult::addRawNode() is logically equivalent to the
upstream HitTestResult::m_rectBasedTestResult.add().
- Android's HitTestResult::isRegionTest() is slightly different from the
upstream HitTestResult::isRectBasedTest(). The latter is modified with
a new ANDROID_HITTEST_WITHSIZE guard in HitTestResult::HitTestResult()
to maintain the same behaviour.
- The upstreamed code uses
HitTestResult::addNodeToRectBasedTestResult() as a helper method in
place of inline logic in the Android version. The slight difference
in behaviour between this helper and the Android logic is reflected in
the new ANDROID_HITTEST_WITHSIZE guard in the helper.
This change should introduce no change in behaviour.
Change-Id: I974d68e3ac963f18334418e32b08c3fd9ab1182e
|
|
|
|
| |
Change-Id: Ibb796c6802e757b1d9b40f58205cfbe4da95fcd4
|
|\
| |
| |
| | |
r64264"
|
| |
| |
| |
| |
| |
| | |
See https://android-git.corp.google.com/g/#change,59749
Change-Id: I0ea44ef95fcd8035adc27a32fb75e7c19f23c975
|
|/
|
|
|
|
| |
Cherry pick of webkit.org r64638.
Change-Id: I50ea47544af219cc04717a060d4b70f478a40877
|
|
|
|
|
|
|
|
| |
GraphicsContext.h
Change introduced here: http://trac.webkit.org/changeset/63864/trunk/WebCore/platform/graphics/GraphicsContext.h
Change-Id: I471797fff394396ec375db10c3bcb4e9c00feb3e
|
|
|
|
|
|
|
|
|
|
|
| |
Introduced here: http://trac.webkit.org/changeset/64196/trunk/WebCore/rendering/SVGResourcesCycleSolver.cpp
Partially upstreamed as the file has changed upstream after the merge, and the newer version doesn't have both places where guards were needed.
Upstream bug: https://bugs.webkit.org/show_bug.cgi?id=43338
Upstream CL: http://trac.webkit.org/changeset/64465/trunk/WebCore/rendering/SVGResourcesCycleSolver.cpp
Upstream change after merge where we have guards: http://trac.webkit.org/changeset/64440/trunk/WebCore/rendering/SVGResourcesCycleSolver.cpp
Change-Id: Iaab4595ded78485c81d6f61a726a5bd0f48c5621
|
|
|
|
|
|
|
|
|
|
|
|
| |
Introduced here: http://trac.webkit.org/changeset/63891/trunk/WebCore/bindings/v8/ScriptValue.cpp
The JSC version is guarded.
This change has been upstreamed, and this is the bug:
https://bugs.webkit.org/show_bug.cgi?id=43345
And the webkit CL:
http://trac.webkit.org/changeset/64464/trunk/WebCore/bindings/v8/ScriptValue.cpp
Change-Id: Ic1e5b7a7352a9f290210776f2f1ce220952c6725
|
|
|
|
|
|
| |
http://trac.webkit.org/changeset/63994/trunk/WebCore/rendering/RenderTableSection.h
Change-Id: I52787b9723791822d9c95ef52d7a81c23c2aeca7
|
|
|
|
| |
Change-Id: Ie4783363cff9eb7f70d6bbfec1a6237b5f5a72b5
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Tracs of the changes:
WebCore/html/HTMLDocumentParser.cpp
http://trac.webkit.org/changeset/63998/trunk/WebCore/html/HTMLDocumentParser.cpp
WebCore/page/EventHandler.cpp
WebCore/page/EventHandler.h
http://trac.webkit.org/changeset/63888
WebCore/page/Page.cpp
http://trac.webkit.org/changeset/64208
WebCore/page/Settings.cpp
WebCore/page/Settings.h
http://trac.webkit.org/changeset/64110
WebCore/rendering/RenderLayerCompositor.h
http://trac.webkit.org/changeset/64054/trunk/WebCore/rendering/RenderLayerCompositor.h
WebCore/rendering/RenderTableSection.cpp
http://trac.webkit.org/changeset/63994/trunk/WebCore/rendering/RenderTableSection.cpp
WebCore/rendering/break_lines.cpp
http://trac.webkit.org/changeset/64207
Change-Id: I34167b43899ee5066e33b40867cd569ce53f9207
|
|
|
|
| |
Change-Id: Ic42bef02efef8217a0f84c47176a9c617c28d1f1
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
EventHandler:
* Added IgnoreClipping in order to touch nodes that are clipped
out.
android_graphics:
* Remember the absolute bounds of the node for invals.
RenderBox:
* Fix a compiler warning.
RenderLayer:
* Do not record the entire layer contents unless the scroll
dimensions are larger than the client dimensions.
* Change isSelfPaintingLayer to check for an overflow clip
instead of the scrollable dimensions since it can be too
early to check at this point.
RenderLayerCompositor:
* Same as RenderLayer for checking the overflow clip.
WebViewCore:
* Scroll the containing layer to the node bounds and offset the
mouse position if scrolled. Once the mouse event is processed,
restore the layer to 0,0.
CacheBuilder:
* The body position is no longer used.
* Do not clip out nodes if the layer is scrollable.
CachedFrame:
* Add unadjustBounds to restore adjusted bounds to their original
position (fixed position elements).
* Call unadjustBounds when a node has been found. This new set of
bounds is passed over to WebViewCore to handle clicks.
* Reject empty node bounds.
CachedLayer:
* Document adjustBounds and add unadjustBounds. Add in the scroll
position to the node bounds.
CachedRoot:
* Unadjust the mouse bounds.
WebView:
* Unadjust the mouse bounds and use the absolute bounds of the ring
during inval.
Bug: 1566791
Change-Id: Ia55f2cbb61869087176d3ff61882e40324614c6a
|
|
|
|
| |
This reverts commit 0ed6485271097ecf1b4cf4e790f9cfdbb57d921c.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This allows web pages to have fine-grain control over the appearance
of the rings drawn around nodes.
Generated links (email, addresses, phone numbers) are no longer
given unique colors. To preserve this feature, a separate change
could add an HTML extension similar to vlink to provide the cursor
ring defintions for theses links. The mechanism implemented below
isn't appropriate since these links don't necessarily correspond to
single DOM nodes or other DOM elements.
------------
CSS examples
------------
The CSS to specify the ring looks like:
-webkit-ring-fill-color:rgba(0,0,255,0.4);
-webkit-ring-inner-width:2 px;
-webkit-ring-outer-width:3.5 px;
-webkit-ring-outset: 8 px;
-webkit-ring-pressed-inner-color:rgba(0,0,255,0.8);
-webkit-ring-pressed-outer-color:rgba(0,0,127,0.3);
-webkit-ring-radius: 10 px;
-webkit-ring-selected-inner-color:rgba(63,63,255,0.8);
-webkit-ring-selected-outer-color:rgba(63,63,127,0.3);
and may be alternately defined with a property shortcut:
-webkit-ring:rgba(255,0,0,0.4) 5px 7px
rgba(255,0,0,0.8) rgba(127,0,0,0.3) 20px
rgba(255,63,63,0.8) rgba(127,63,63,0.3);
--------------------
Property definitions
--------------------
A vertical cross-section of the ring corresponds to these
parameters as shown:
______
R / ___O_ R = corner radius
/ / __I_ o I = inner ring
/ / / _O_ ^ O = outer ring
| | | / F | F = fill
|O|I|O| L o = outset
| | | \_F_ | L = original link
\ \ \__O_ V
\ \___I_ o
R \____O_
The fill color specifies what to draw inside the ring
when the link is followed. The fill area consists of the
original link area the outset.
The inner and outer widths specify the stoke width of the inner
and outer rings, respectively. The widths may be specified in
fractional pixels. The implementation captures 4 bits of the
fraction.
The outset specifies the distance from the edge of the original
link to the rings' center. Both rings are drawn at the same center
location.
The radius specifies the curvature of the corners at the center
of the rings.
-------------
Data lifetime
-------------
The selected colors specify the colors of the inner and outer
rings when the trackball or D-pad hovers over the link. The
pressed colors specify the colors of the rings when the
trackball center is pressed or the link is tapped.
The CSS data is recorded in the RenderStyle when the DOM
is parsed. The widths are scaled up by 16 to preserve the fraction.
When the nav cache is built, the CSS style information is
recorded in the CachedColor class. Only unique style sets
are recorded; many CachedNode instances can share the same
CachedColor instance.
When the cursor ring is drawn, the CachedColor is
retrieved by getting the index from the CachedNode, and
looking up the entry in the CachedFrame. The widths are
scaled down by 16 since Lengths are stored by the webkit as
integers.
----------
File Edits
----------
WebCore/Android.derived.mk
- Build the CSS data property tables by concatentating
Android specific data and optionally SVG data.
WebCore/config.h
- Add switch for these rings. This switch is meant
as a convenience for finding the code in WebKit
that was added to enable this feature. Since the
old code in DrawCursor has been removed, it does
not revert to the old behavior if the switch is
turned off.
WebCore/css/AndroidCSSPropertyNames.in
- The new ring properties, plus an old one we
added before.
WebCore/css/CSSComputedStyleDeclaration.cpp
WebCore/css/CSSMutableStyleDeclaration.cpp
WebCore/css/CSSParser.cpp
WebCore/css/CSSStyleSelector.cpp
- I can guess what these functions are for as
well as anyone, but I really don't know. Do
I need all of them? Do I need to modify
Mutable at all?
WebCore/css/CSSPropertyNames.in
- Moved Android addition to AndroidCSSPropertyNames.in
WebCore/platform/graphics/Color.h
- Added initial color values here.
WebCore/platform/graphics/android/android_graphics.*
- This draws the cursor ring. The code that draws
'synthetic' links has been discarded.
WebCore/rendering/style/RenderStyle.h
- Functions to get, set, and initialize the style
data.
WebCore/rendering/style/StyleRareInheritedData.*
- The storage for the style data and an equivalence
function.
WebKit/Android.mk
- Added CachedColor to the build.
WebKit/android/nav/CacheBuilder.cpp
- Record the color from the DOM into the cache.
WebKit/android/nav/CachedColor.*
- Store the cached color info.
WebKit/android/nav/CachedFrame.*
- Where the array of colors is stored.
WebKit/android/nav/CachedNode.*
- Where the index to the colors is stored.
Change-Id: Ia3a931f41d6545e47678e245aafe7c84d4658f94
http://b/2603197
|
|\ |
|
| |
| |
| |
| |
| |
| |
| | |
The original webkit change is:
http://trac.webkit.org/changeset/64087
Change-Id: Ide7141ffec0a8a37f333c06bddabe3703d79af54
|
|\ \ |
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Ported the webkit fixes from http://trac.webkit.org/changeset/62965.
Harfbuzz does not do mirroring, so we iterate each character
in the string and mirror it if needed before passing the
string to harfbuzz for shaping.
Change-Id: Ifee1035f96e4e82a5a2641b57dd839cec3427b59
|
| |/
|/|
| |
| | |
Change-Id: I31e3786742f0ae05c9f6c8ab23b4dbd0c790dfc5
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
All tests pass.
Note that the JSC-specific expected result for window-property.html is a
placeholder until https://bugs.webkit.org/show_bug.cgi?id=43025 is fixed.
Change-Id: I60a978231a10f0a57b3dc654876b181dc47eb455
|
| |
| |
| |
| |
| |
| |
| |
| | |
Android. See http://trac.webkit.org/changeset/63599
See b/2869593
Change-Id: Ib7c8fda4a9bf62d470a4fa63823fa0951b5974ea
|
| |
| |
| |
| |
| |
| |
| | |
so add it and stub out platformTransformColorSpace.
See http://trac.webkit.org/changeset/63450
Change-Id: I2c84c13a19b1a787b0edbfb9fcefd08acd9ed6ff
|
| |
| |
| |
| |
| |
| | |
constants match their enums. See http://trac.webkit.org/changeset/63331
Change-Id: Ida82337eec825e26ab4afb8fc26e22fdb6c18786
|
| |
| |
| |
| |
| |
| | |
This is a cherry pick of http://trac.webkit.org/changeset/64007 to fix the build.
Change-Id: Ic86639eb7dbcd09f0273f614537354bfa7fd369d
|
| |
| |
| |
| |
| |
| | |
See http://trac.webkit.org/changeset/63332
Change-Id: Id019ee222d0b7dcfa464f97cfffdd5c08e2d0ee8
|
| |
| |
| |
| |
| |
| |
| |
| | |
const QualfiedName&) function has been removed.
See http://trac.webkit.org/changeset/63358
Change-Id: I89c6a0a98d04f0a0cd40492229fa03f2e9782622
|
| |
| |
| |
| |
| |
| | |
WebKit. See http://trac.webkit.org/changeset/63638
Change-Id: I97784c98b694f28804421637716afa649aa09a6e
|
| |
| |
| |
| | |
Change-Id: I5a218be0b26003f4fceb964e7add0f1eda410710
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
html/HTMLCanvasElement.h due to http://trac.webkit.org/changeset/63502
html/HTMLLinkElement.cpp due to http://trac.webkit.org/changeset/63622
Android.mk and WebCore/Android.mk due to http://trac.webkit.org/changeset/63735
WebCore/page/Settings.cpp|h due to http://trac.webkit.org/changeset/63537
WebCore/page/EventHandler.cpp|h due to http://trac.webkit.org/changeset/63807
WebCore/Android.jscbindings.mk due to http://trac.webkit.org/changeset/63193
WebCore/platform/network/ResourceHandle.h due to http://trac.webkit.org/changeset/63332
Change-Id: I03c929b97550014373f044f56c248040b66118f0
|