| Commit message (Collapse) | Author | Age | Files | Lines |
... | |
|
|
|
| |
Fixes http://b/issue?id=2210152
|
|
|
|
|
|
|
| |
Google's real time search has many results outside of an overflow
div that should be ignored by the nav cache. Make it so.
fixes http://b/2298478
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Help to fix http://b/issue?id=1890360 and http://b/issue?id=2150538
CacheBuilder.cpp:
Explicitly set isTextField to false for textareas.
CachedRoot:
Remove the code which checks to see if the textfield is a search,
since if it is, we can avoid this path altogether.
WebView:
Return a single integer which tells what type the current text
input field is.
Requires a change to frameworks/base.
|
|
|
|
|
|
|
| |
SEARCH <input>
Fixes http://b/issue?id=2299660 and http://b/issue?id=2299650
Also remove isPassword, which is redundant.
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Some of the fields in CachedNode are relevant only to input
fields and text areas. Move these into their own vector
so that we can add more data without making all CacheNodes
bigger.
Remove CacheNode entries that are no longer used, or can
be consolidated into the node type. Alphabetize some interfaces
and implementations. Update the debugging output.
part of http://b/2299660
|
|
|
|
|
|
|
|
| |
This is a fairly conservative fix, since it actually checks to
see if a parent element is clipped out, rather than the bounds
of the element itself.
fixes http://b/2291936
|
|
|
|
|
|
|
|
|
|
|
|
| |
The nav cache attempts to take advantage of the order that
the dom is walked to know when multiple nodes have the same
parent. The old implementation doesn't always work, and a
simpler non-cached version makes more sense.
The algorithm now walks nodes until the parent has more than
one child, and assigns that parent as the 'parent group'. On
the other end, nodes with no parent group are never allowed
to get preferential matching treatment.
|
|
|
|
|
|
|
| |
Fix errors in empty frames, escape character sequences,
and characters outside the ascii range. These fixes are
specific to dumping the nav cache and are commented out
in all builds.
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
These files have not yet been upstreamed to webkit.org.
WebKit requires either a BSD-style or LGPL 2.1 license for all code.
We use a BSD-style 2-clause license for Android-specific files that will be upstreamed to webkit.org.
This change adds licenses where absent or simply fixes the names of copyright holders in the license
text to 'THE COPYRIGHT OWNER' and cleans up formatting.
Files in stl/ currently use licenses other than BSD-style and will require more careful treatment.
Change-Id: I67ad4b8932e432d3eaaeecdfeb0d09418496228d
|
|
|
|
|
|
|
|
| |
The renderer may be displaying a placeholder (attribute on HTMLInputElement
and HTMLTextAreaElement), which will be deleted when the field gains
focus, so take the text directly from the node instead.
Fixes http://b/issue?id=2163427
|
|
|
|
|
|
|
|
|
|
|
| |
Separate nodes that are hidden from nodes that disable
drawing the focus ring. If a node draws its own focus state,
other than not drawing the ring, it should be indistinguishable
from other focusable nodes.
Fix the nav cache dump to be in line with the latest webkit.
fixes http://b/issue?id=2201049
|
|
|
|
|
|
| |
See http://trac.webkit.org/changeset?new=47440
Change-Id: I140b6be130c1fb175c653f5ba2ba19fdc323bbc9
|
|
|
|
|
|
|
|
| |
methods.
See http://trac.webkit.org/changeset/48701
Change-Id: I627b40265f2aff72fdd4ad5884596be9820b642d
|
|
|
|
|
|
| |
See http://trac.webkit.org/changeset/47313
Change-Id: Ic33083eedfc8468c171cd7af6f112aca0eeef615
|
|
|
|
|
|
|
|
| |
method.
See http://trac.webkit.org/changeset/49160
Change-Id: I75e1d6701f4d16fab7513f5924abf00e958e865c
|
|
|
|
|
|
|
| |
Partial fix for http://b/issue?id=2159869. Add a field to CachedNode
for readonly. In WebView.cpp, only call displaySoftKeyboard if the
node is not readonly. Also call displaySoftKeyboard in nativeTextMotionUp
to replace a call being removed in WebView.touchUpOnTextField(java).
|
|
|
|
|
|
|
|
| |
Webkit implementation for passing in the data for file uploads.
Requires a change to frameworks/base to not break things; also
requires a change to packages/apps/Browser to work.
Fixes http://b/issue?id=675743
|
|
|
|
|
|
|
|
|
| |
Address detection on web pages creates arrays of pointers to
words, and compares them against a set of permitted street types.
This change adds the array of end pointers so that the check
does not look past the end of the word.
Fixes http://b/issue?id=2166591
|
|
|
|
|
| |
KURL::protocolIs no longer likes "javascript" and has a different method called
protocolIsJavaScript.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This fixes detecting "4 E. 86th St New York, NY"
The old logic found 'New York' and assumed that St was the city
name. Since 86th is not a valid street suffix, the test failed.
The new logic looks for a valid street suffix instead of skipping
'city'. If it finds one, and the subsequent street suffix test
fails, it resets to search again for a valid state name while
retaining the starting point for the address (the street number).
Fixing this exposed a bug in the zip code detection code
where it dropped the first character of the actual state name.
|
|\
| |
| |
| |
| |
| |
| |
| |
| | |
AtomicString is not thread safe.
Merge commit 'b116c1a08412db8a748998c7e8a2ce851cbacacd'
* commit 'b116c1a08412db8a748998c7e8a2ce851cbacacd':
Make deep copy of the String when use them in the UI thread as AtomicString is not thread safe.
|
| |
| |
| |
| | |
is not thread safe.
|
| |
| |
| |
| | |
http://b/issue?id=1945476
|
| |
| |
| |
| |
| |
| |
| |
| | |
Add clicking, key debug statements in WebViewCore.cpp.
Fix dumping nav tree to use NamedNodeMap.
Set click point to be start of text field, end of text area, middle
of others.
Make CachedRoot::getSimulatedMousePosition, callers const
|
| |
| |
| |
| |
| |
| |
| |
| | |
New public interface is set @hide for now. Old interface
uses the new one.
Requires a companion change to frameworks/base
http://b/issue?id=1649036
|
| |
| |
| |
| |
| |
| |
| |
| | |
http://b/issue?id=1918891
set cursor node hidden to 'true' to hide it
also fixing crash if detecting text address
runs out of text to look at
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
WebViewCore.cpp:
Add parameter to CachedRoot::findAt to suppress check for
hidden nodes. This helps find a best match for newly built
nav caches.
Require that the new cursor node closely match the bounds
of the prior cursor node. This may need tuning.
CacheBuilder.cpp:
Remove isInput flag on cached nodes (no longer used)
CachedFrame.cpp:
Add hideCursor to complement clearCursor. Hide prevents
the cursor from drawing but does not move it. Clear removes
it altogether so that the next movement starts from the viewPort
edge.
CachedHistory.cpp:
Don't special case text fields when doing history navigation.
This special casing in part allowed setting the focus to
the homepage input, but since focus is no longer set by nav,
it is not required.
CachedNode.cpp:
Add hideCursor; clean up debugging
CachedRoot.cpp:
Use navBounds from history instead of cursor bounds to
determine next move. Clean up some obsolete code.
WebView.cpp:
Add hideCursor; call it when appropriate.
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Several years ago, the absolute bounds reported by webkit
for nodes other than anchors were sometimes wildly different
than the node bounds. Nowadays, the absolute bounds are used
by iPhone to show hot spots and are more accurate.
When nodes are added on the fly, their node bounds may be
uncomputed, so the added nodes may not show up in the
nav cache. Using the absolute bounds instead makes these
nodes visible.
Also, removed a special case for Bank of America, tied to
the node bounds (not absolute bounds) since it is no longer
applicable.
Remove unused local min focusable width and height.
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Add convenience routines to consolidate cache builder
and current focus fetches into one place.
Remove unused functions.
Use wantsKeyEvents attribute where applicable.
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Older code treated the trackball as a four way dpad with
equivalents to moving up, down, left and right by generating
arrow key events. This change makes the trackball solely
generate mousemove events.
The old arrow keys in turn were mapped to be as close as
possible to tab-key events that moved the focus. The new
model leaves focus-changes to the DOM.
Clicking the dpad is distinguished from pressing the enter
key to be more compatible with desktop-authored web pages.
|
| |
| |
| |
| | |
Fix for buganizer issue 1800613: Image map not accessible. We were attempting to cache associtations of <area> elements to their RenderImages so we would not have to search for them. However, we were storing them in CacheBuilder. When we search for them, we search in the <area> element's frame, even though when we built the cache, we stored it in the main frame. Another issue arose on a page where <area> elements show up before their RenderImages. In this case, we were storing an empty rectangle for the bounds, and caching the associations afterwards, when it was too late. In order to clean up/simplify things, while fixing both bugs, I have changed validNode into a static function which takes the starting Frame as a parameter. Any time we need to find the rectangle of an <area> element, we have to traverse the DOM to find its associated RenderImage. This may be slower, but it will always get the correct answer. In the future, we may need to investigate a universal location for caching the associations for better performance.
|
| |
| |
| |
| |
| |
| | |
The render tree has changed and the old dump logic
no longer compiles. This output isn't used anymore, so
remove it.
|
| |
| |
| |
| | |
Automated import of CL 145877
|
| |
| |
| |
| | |
Automated import of CL 145796
|
|/ |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
|
|