summaryrefslogtreecommitdiffstats
path: root/WebKit/android/nav
Commit message (Collapse)AuthorAgeFilesLines
* nav to container if it wants key eventsCary Clark2009-12-022-6/+6
| | | | | | | | | | | | When a text field or text area (or plugin) has another navable element completely overlaying it, allow the trackball to move from that inner element to the outer one. Also, allow this to get a 'second chance' -- treat the case when one element overlays another as a spacial nav and allow it to retry in nav find algorithms. fixes http://b/2266756
* navigate preferably between children of the same parentCary Clark2009-11-303-8/+12
| | | | | | | | | | | | The nav cache attempts to take advantage of the order that the dom is walked to know when multiple nodes have the same parent. The old implementation doesn't always work, and a simpler non-cached version makes more sense. The algorithm now walks nodes until the parent has more than one child, and assigns that parent as the 'parent group'. On the other end, nodes with no parent group are never allowed to get preferential matching treatment.
* fix bugs in nav cache dumpCary Clark2009-11-302-8/+20
| | | | | | | Fix errors in empty frames, escape character sequences, and characters outside the ascii range. These fixes are specific to dumping the nav cache and are commented out in all builds.
* Remove nativeTextInputMotionUp.Leon Scroggins2009-11-251-31/+0
| | | | Function is not needed. Requires a change to frameworks/base
* rename nativeFindIsDown to nativeFindIsUpCary Clark2009-11-171-3/+3
| | | | | | companion fix is in framework/base fixes bug http://b/issue?id=2264941
* Fixes license headers for all files in WebKit/android, other than those in stl/.Steve Block2009-11-1318-19/+19
| | | | | | | | | | | | | These files have not yet been upstreamed to webkit.org. WebKit requires either a BSD-style or LGPL 2.1 license for all code. We use a BSD-style 2-clause license for Android-specific files that will be upstreamed to webkit.org. This change adds licenses where absent or simply fixes the names of copyright holders in the license text to 'THE COPYRIGHT OWNER' and cleans up formatting. Files in stl/ currently use licenses other than BSD-style and will require more careful treatment. Change-Id: I67ad4b8932e432d3eaaeecdfeb0d09418496228d
* Store the Node's text rather than the renderer's text.Leon Scroggins2009-11-061-2/+4
| | | | | | | | The renderer may be displaying a placeholder (attribute on HTMLInputElement and HTMLTextAreaElement), which will be deleted when the field gains focus, so take the text directly from the node instead. Fixes http://b/issue?id=2163427
* Fix a clicking bug.Leon Scroggins2009-10-283-15/+5
| | | | | | | | | | | Remove some code that simulates a mouse click at the beginning of a textarea and the end of a textfield. The original goal was to make the click change the selection to be at the beginning or end of the field, respectively. However, we actually make another call which prevents this click from the selection. Further, the selection actually gets changed elsewhere. Fixes http://b/issue?id=2219233
* pass the current cursor when computing the mouse positionCary Clark2009-10-283-6/+7
| | | | | | | | | Most of the time, the simulated mouse position can be computed from the current cursor. But when the cursor is changed, the current cursor info could be out of date and generate a bus error. fixes http://b/issue?id=2061211
* Allow touches to change the selection.Leon Scroggins2009-10-271-3/+10
| | | | | | | | Fixes http://b/issue?id=1650395 Lets touches change the selection while ignoring changes from trackball events. When a touch puts a textfield in focus, tell the WebTextView to set mOkayForFocusNotToMatch. Requires a change in frameworks/base.
* changing how plugins gain/lose focus.Derek Sollenberger2009-10-271-72/+10
| | | | | | | | | | Previously we were keeping our own state in the UI thread to determine when to send events to the plugin. This change removes that logic and uses the document focus to determine when events are to be sent. This also fixes problems with the plugins occasionally not receiving lose focus events. see bug http://b/2033843
* tweak select textCary Clark2009-10-271-53/+26
| | | | | | | | | | | | | | | | | | | | webkit changed the behavior of hitTestResultAtPoint; it used to return the innermost node hit, but does so no longer. Work around this by searching the returned node for a text node. Start the text detection one pixel lower. This fixes picking up the first line of a link on m.msn.com. Simplify the selection drawing. Share code between the arrow and the i-beam. Center the i-beam on the arrow. Use relative path construction to simplify the i-beam. Add debugging. Requires a companion change in frameworks/base partially fixes http://b/issue?id=1667690
* Allow java WebView to check the readonly status of a node.Leon Scroggins2009-10-231-0/+8
| | | | | Required for a change to frameworks/base (https://android-git.corp.google.com/g/30939 )
* Remove some unused variables.Leon Scroggins2009-10-231-1/+1
|
* fix multiple text areas, and text areas without focus ringsCary Clark2009-10-213-15/+12
| | | | | | | | | | | Separate nodes that are hidden from nodes that disable drawing the focus ring. If a node draws its own focus state, other than not drawing the ring, it should be indistinguishable from other focusable nodes. Fix the nav cache dump to be in line with the latest webkit. fixes http://b/issue?id=2201049
* Merge webkit.org at R49305 : Update rendering to use new overflow methods.Steve Block2009-10-201-1/+1
| | | | | | See http://trac.webkit.org/changeset?new=47440 Change-Id: I140b6be130c1fb175c653f5ba2ba19fdc323bbc9
* Merge webkit.org at R49305 : Update CacheBuilder to use new event listener ↵Steve Block2009-10-201-8/+3
| | | | | | | | methods. See http://trac.webkit.org/changeset/48701 Change-Id: I627b40265f2aff72fdd4ad5884596be9820b642d
* Merge webkit.org at R49305 : Text::string renamed to dataImpl.Steve Block2009-10-201-5/+5
| | | | | | See http://trac.webkit.org/changeset/47313 Change-Id: Ic33083eedfc8468c171cd7af6f112aca0eeef615
* Merge webkit.org at R49305 : Update String::copy call sites to use new copy ↵Steve Block2009-10-201-3/+5
| | | | | | | | method. See http://trac.webkit.org/changeset/49160 Change-Id: I75e1d6701f4d16fab7513f5924abf00e958e865c
* Do not bring up the soft keyboard for readonly input fields.Leon Scroggins2009-10-153-4/+18
| | | | | | | Partial fix for http://b/issue?id=2159869. Add a field to CachedNode for readonly. In WebView.cpp, only call displaySoftKeyboard if the node is not readonly. Also call displaySoftKeyboard in nativeTextMotionUp to replace a call being removed in WebView.touchUpOnTextField(java).
* fix copy/paste using trackball on passionCary Clark2009-10-151-21/+15
| | | | | | | | | | | | | | | This fix should be considered for passion mr1, but does not affect sholes -- this is a trackball only bug. The selection caret and arrow now take the scale factor and the height of the title bar into account when preparing the canvas for drawing. Also, simply call to CopyPaste::findClosest, and remove logic to attempt to pin the arrow to the current cursor. Requires a companion fix in framework/base Fixes http://b/issue?id=2187591
* add debugging, tweak data for flash work in progressCary Clark2009-10-123-27/+34
| | | | | | | | | Attempts to get the plugin to scroll when the ime appears. Add debugging strings to help track events to show plugin object. Add focusCandidate interfaces. Tweak rectangles from plugin so they don't disappear. Prefer found matches in nav cache that are later in the document.
* File upload.Leon Scroggins2009-10-091-2/+1
| | | | | | | | Webkit implementation for passing in the data for file uploads. Requires a change to frameworks/base to not break things; also requires a change to packages/apps/Browser to work. Fixes http://b/issue?id=675743
* address detection may look at uninitialized memoryCary Clark2009-10-062-19/+25
| | | | | | | | | Address detection on web pages creates arrays of pointers to words, and compares them against a set of permitted street types. This change adds the array of end pointers so that the check does not look past the end of the word. Fixes http://b/issue?id=2166591
* Add check null of getRealObject(). When a WebView isGrace Kloba2009-10-021-21/+91
| | | | | | | removed, there is a slight chance that getRealObject() for WebView's JavaObject be null. Fix http://b/issue?id=2159815
* Fix a few crashes with assertions enabled.Patrick Scott2009-09-291-1/+1
| | | | | KURL::protocolIs no longer likes "javascript" and has a different method called protocolIsJavaScript.
* Whether or not a textfield is the last or only, make its action GO.Leon Scroggins2009-09-231-3/+2
| | | | | | Fix for http://b/issue?id=2136097 Change-Id: I8ca00498dd5a8d611bc0de5a941faaf596d9f76d
* fix parent index of focus when building nav cacheCary Clark2009-09-152-1/+4
| | | | | | | | | | | When a focused node is found while walking the DOM, the CachedFrame tree doesn't have its parent pointer set. Fix the focus index in the parent when fixing the parent pointer. Also fix a debug statement so that it doesn't depend on the focus parent. Fixes http://b/issue?id=2048186
* start in the proper subframe when finding the next text fieldCary Clark2009-09-031-1/+1
| | | | fixes http://b/issue?id=2048180
* when finding left edge of text block, don't merge in tall bitmapCary Clark2009-08-261-52/+61
| | | | | | | | | | Zooming in to yahoo.com fails sometimes if the block of text has a large bitmap on the left. This change prevents the bitmap from being seen as a part of the text paragraph. Also, cleaned up the debugging statements. Fixes http://b/issue?id=2066236
* Merge change 22590 into eclairAndroid (Google) Code Review2009-08-251-4/+25
|\ | | | | | | | | * changes: fix address detection when the city and state are both valid states
| * fix address detection when the city and state are both valid statesCary Clark2009-08-251-4/+25
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This fixes detecting "4 E. 86th St New York, NY" The old logic found 'New York' and assumed that St was the city name. Since 86th is not a valid street suffix, the test failed. The new logic looks for a valid street suffix instead of skipping 'city'. If it finds one, and the subsequent street suffix test fails, it resets to search again for a valid state name while retaining the starting point for the address (the street number). Fixing this exposed a bug in the zip code detection code where it dropped the first character of the actual state name.
* | fix a couple of debug print errorsCary Clark2009-08-251-2/+2
|/
* Pass clicks to webkit's textfield to determine the new selection.Leon Scroggins2009-08-131-6/+33
| | | | | | | | | | | | Requires a corresponding change to frameworks/base. We were previously letting WebTextView handle clicks, determine the change in selection, and pass that down to webkit. This sometimes resulted in a different placement of the caret if the WebTextView and the webkit-rendered textfield did not line up exactly. Now, we pass the click directly to webkit, which determines the new selection and passes that info back to the WebTextView. This also has the benefit of letting the WebTextView reflect changes in the selection that originated from webkit. Also remove some unused parameters.
* Fix a bug in find.Leon Scroggins2009-07-311-10/+9
| | | | | | | | | | | Fix for http://b/issue?id=2021424. When trying to draw the matches, if we find that the page needs to be scrolled to put the match on screen, we request a scroll, do a viewInvalidate and stop, so that the matches will be drawn after the invalidate. Unfortunately, for some values, we do not end up scrolling, because contentToView turns the scroll into a no op. So we forever request scrolls, and never draw the matches. Fix this by getting a return value from scrollBy, and if it returned false, go ahead and draw the matches.
* rebuild the nav cache on mouse clicks during page loadCary Clark2009-07-313-22/+37
| | | | | | | | | | | | | | | While the page is loading, the nav cache is not rebuilt. Double-click zooms out the web page by using the nav cache to find the left edge of the column -- but fails to work during page load. This change rebuilds the nav cache (if the page is loading) each time a mouse click is sent to webkit. This doesn't fix the bug where the first double click doesn't align the column correctly, but helps with subsequent clicks. Also, pass scale information to getBlockLeftEdge so it can restrict its search to the area that will be zoomed to. Default to the point clicked if no alignment info can be found.
* Allow user to jump to the next textfield.Leon Scroggins2009-07-315-21/+139
| | | | | | | | In CachedFrame, add methods to find the next textfield and to determine which ImeAction should be associated with a given textfield. In WebView, uses these apis to determine the ImeAction and jump to the next textfield and scroll it on screen. Requires a change to frameworks/base.
* Support double tap in the Browser.Grace Kloba2009-07-281-0/+19
| | | | | | | | | | | | | | | Add api to get the left edge of the block from the current (x,y). The code was copied from Cary's change. Todo: 1.need some tuning as we can see from nytimes.com that some times the left edge is not correct. 2.currently nav cache is not up to date while loading. This means the left edge may not be correct during loading. 3.if (x,y) is over an edit text box, or image, it should return the left edge of it. Currently it is not working as expected. Added the code to store the extra scale factor, so that back/forward history works correctly.
* Merge change 7883Android (Google) Code Review2009-07-282-0/+121
|\ | | | | | | | | * changes: Find left edge of column using nav cache data.
| * Find left edge of column using nav cache data.Cary Clark2009-07-282-0/+121
| | | | | | | | | | The function is currently unused, but will be used by Grace's double-tap experiment.
* | Clear the WebTextView when clicking on another node.Leon Scroggins2009-07-231-0/+1
|/ | | | | | | | | | | | We already cleared it in the above case, when the user clicks on empty space. If the user clicks on a node, and it is not a text input, clear it. This fixes a bug on the Google home page, where the user has typed into the textfield, but then clicks on "more" and is then unable to click on Gmail, which is covered by the (invisible) WebTextView.
* Merge change 6306Android (Google) Code Review2009-07-101-0/+2
|\ | | | | | | | | * changes: hide the cursor when the link is followed
| * hide the cursor when the link is followedCary Clark2009-07-061-0/+2
| | | | | | | | | | | | | | | | | | The cursor position is preserved, so additional trackball navigation will start from where the cursor ring was drawn last. Hiding the cursor gets rid of confusion where the cursor ring stays visible when clicking on a link that does not go to a new page, or when the new page has a link at the same physical location as the old page.
* | am b116c1a0: Make deep copy of the String when use them in the UI thread as ↵Grace Kloba2009-07-061-2/+2
|\ \ | |/ |/| | | | | | | | | | | | | AtomicString is not thread safe. Merge commit 'b116c1a08412db8a748998c7e8a2ce851cbacacd' * commit 'b116c1a08412db8a748998c7e8a2ce851cbacacd': Make deep copy of the String when use them in the UI thread as AtomicString is not thread safe.
| * Make deep copy of the String when use them in the UI thread as AtomicString ↵Grace Kloba2009-07-061-3/+3
| | | | | | | | is not thread safe.
| * AI 143189: am: CL 142939 Fix for issue 1730904: Find in page only searches ↵Leon Scroggins2009-03-271-1/+3
| | | | | | | | | | | | | | | | | | the first part of large pages. Cap the width and height of the page so we do not overflow a 16 bit int and think the page is smaller than it is when performing the find. Original author: scroggo Merged from: //branches/cupcake/... Automated import of CL 143189
| * Automated import from //branches/donutburger/...@142283,142283Cary Clark2009-03-241-0/+3
| |
* | In WebTextView, check the focus before sending a key.Leon Scroggins2009-07-061-0/+8
| | | | | | | | | | | | | | | | This fixes a bug where the DOM has moved the focus, but the WebTextView is still sending keys to the old focus. Requires a change in frameworks/base. This part of the change just gives WebView a way to get a pointer to the currently focused node (regardless of the cursor).
* | added gain/loose focus support for plugins. (focus = eligible to receive ↵Derek Sollenberger2009-07-021-6/+29
| | | | | | | | user events)
* | Update the nav cache when selected elements change or moveCary Clark2009-07-011-0/+1
| | | | | | | | | | | | This helps superpudu recompute the cursor ring more frequently when the floating bar moves. It also helps update the nav cache when navigating during a page load.
generated by cgit v1.1 at 2025-11-29 07:45:05 +0000