summaryrefslogtreecommitdiffstats
path: root/WebKit/android/nav
Commit message (Collapse)AuthorAgeFilesLines
* Add proper support for fixed position elementsNicolas Roard2010-01-141-3/+4
| | | | | | | this is two-part change, see http://android-git.corp.google.com/g/#change,37092 for the java counterpart. This CL implements fixed position elements (css position: fixed) using layers, supporting pixels and percent lengths. It addresses http://b/1914365
* Merge "Compare Node pointers rather than CachedNode pointers." into eclair-mr2Leon Scroggins2010-01-121-2/+2
|\
| * Compare Node pointers rather than CachedNode pointers.Leon Scroggins2010-01-121-2/+2
| | | | | | | | Fixes http://b/issue?id=2369028
* | Ensure that the current textfield is actually a textfield before treating it ↵Leon Scroggins2010-01-121-2/+2
|/ | | | | | like one. Fix for http://b/issue?id=2368868
* Bring up the IME after receiving a response from webkit.Leon Scroggins2010-01-114-41/+1
| | | | | | Fix for http://b/issue?id=2361658 Requires a change to frameworks/base.
* In motionUp, update the CachedHistory's mMouseBounds.Leon Scroggins2010-01-071-1/+3
| | | | | | mMouseBounds is later used to determine the point of clicking. Fixes http://b/issue?id=2313991
* remove unused jni interfacesCary Clark2010-01-071-8/+0
| | | | companion change is in frameworks/base
* Request <label> info only when accessing a textfield.Leon Scroggins2010-01-074-38/+0
| | | | | | | Previously, we were storing the label info each time we build the navigation cache. Requires a change to frameworks/base.
* In findBestHitAt, set x and y to the intersection of slop and cursor.Leon Scroggins2010-01-063-30/+24
| | | | Fixes http://b/issue?id=2201866
* Store label information to be used for hint text.Leon Scroggins2010-01-064-6/+49
| | | | | | Fix for http://b/issue?id=2331526 Requires a change to frameworks/base.
* webkit layers supportNicolas Roard2010-01-041-0/+92
|
* If the DOM changes textfield focus, make the IME work properly.Leon Scroggins2010-01-043-25/+41
| | | | | | | | | | | | | | Fix for http://b/issue?id=2219166 Requires a change to frameworks/base Remove the old change to update the WebTextView when a key is pressed, since the IME does not generate key events. Instead, when the focus changes, and the IME is serving the WebTextView, immediately clear the cursor and update the WebTextView, so the user can continue typing. Also, allow "Next" to work on the currently focused textfield, even if it's not the cursor. Further, check for a new action if there is a focus but not a cursor.
* check to see if nav cache is up to date on tapCary Clark2009-12-154-5/+66
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | - WebKit/android/jni/WebViewCore.cpp - WebKit/android/jni/WebViewCore.h Add validNodeAndBounds() to determine if the clicked cached node is good. First check to see if the pointer to the frame and node still exist in the DOM. If they do, see if the hit test bounds they point to is the same as when the cache was recorded. - WebKit/android/nav/CacheBuilder.cpp - WebKit/android/nav/CachedNode.h Record the original absolute bounds for later comparison. - WebKit/android/nav/CacheBuilder.h Make getAreaRect() public so it can be called by validation. - WebKit/android/nav/WebView.cpp Enhance motionUp() with additional validation: use pointInNavCache() to see if there's a cached node; wait for message from webkit to see if bounds is unchanged; then use motionUp() to pass the original or altered click. This is a two-part change with frameworks/base. Fixes http://b/2249425
* Pass a message to move the focus when user hits "Next".Leon Scroggins2009-12-091-4/+18
| | | | | | | | Directly move the focus rather than passing a click. Fixes http://b/issue?id=2292683 Requires a change to frameworks/base
* Show "Go" for the last textfield in a form.Leon Scroggins2009-12-084-3/+13
| | | | Fixes http://b/issue?id=2210152
* exclude from cache nodes that are entirely clipped outCary Clark2009-12-081-6/+3
| | | | | | | Google's real time search has many results outside of an overflow div that should be ignored by the nav cache. Make it so. fixes http://b/2298478
* Merge change Ia8a49e0d into eclair-mr2Android (Google) Code Review2009-12-081-1/+2
|\ | | | | | | | | * changes: fix debugging output
| * fix debugging outputCary Clark2009-12-071-1/+2
| |
* | Provide <input> type information to Java side.Leon Scroggins2009-12-074-15/+39
|/ | | | | | | | | | | | | | | | | Help to fix http://b/issue?id=1890360 and http://b/issue?id=2150538 CacheBuilder.cpp: Explicitly set isTextField to false for textareas. CachedRoot: Remove the code which checks to see if the textfield is a search, since if it is, we can avoid this path altogether. WebView: Return a single integer which tells what type the current text input field is. Requires a change to frameworks/base.
* fix crash reading readonly node stateCary Clark2009-12-071-4/+4
| | | | | | | | | | | | Something about rebuildTextView() invalidates the current cached frame -- reading the last obtained frame after calling it may crash. Why, I don't know. Until I figure that out, read the cached state first. Also remove some tests for null frame and node since the null case has already been handled earlierin motionUp(). fixes http://b/2307964
* Store InputType information for <input> fields, return SEARCH action for ↵Leon Scroggins2009-12-075-8/+21
| | | | | | | SEARCH <input> Fixes http://b/issue?id=2299660 and http://b/issue?id=2299650 Also remove isPassword, which is redundant.
* fix nav cache debuggingCary Clark2009-12-041-4/+3
| | | | last change broke debugging code outside of the build
* move input-related fields out of CachedNode to expandCary Clark2009-12-0411-174/+318
| | | | | | | | | | | | | Some of the fields in CachedNode are relevant only to input fields and text areas. Move these into their own vector so that we can add more data without making all CacheNodes bigger. Remove CacheNode entries that are no longer used, or can be consolidated into the node type. Alphabetize some interfaces and implementations. Update the debugging output. part of http://b/2299660
* Merge change I3aa3fc5b into eclair-mr2Android (Google) Code Review2009-12-021-4/+8
|\ | | | | | | | | * changes: skip nodes when building nav cache if parents are clipped out
| * skip nodes when building nav cache if parents are clipped outCary Clark2009-12-021-4/+8
| | | | | | | | | | | | | | | | This is a fairly conservative fix, since it actually checks to see if a parent element is clipped out, rather than the bounds of the element itself. fixes http://b/2291936
* | nav to container if it wants key eventsCary Clark2009-12-022-6/+6
|/ | | | | | | | | | | | When a text field or text area (or plugin) has another navable element completely overlaying it, allow the trackball to move from that inner element to the outer one. Also, allow this to get a 'second chance' -- treat the case when one element overlays another as a spacial nav and allow it to retry in nav find algorithms. fixes http://b/2266756
* navigate preferably between children of the same parentCary Clark2009-11-303-8/+12
| | | | | | | | | | | | The nav cache attempts to take advantage of the order that the dom is walked to know when multiple nodes have the same parent. The old implementation doesn't always work, and a simpler non-cached version makes more sense. The algorithm now walks nodes until the parent has more than one child, and assigns that parent as the 'parent group'. On the other end, nodes with no parent group are never allowed to get preferential matching treatment.
* fix bugs in nav cache dumpCary Clark2009-11-302-8/+20
| | | | | | | Fix errors in empty frames, escape character sequences, and characters outside the ascii range. These fixes are specific to dumping the nav cache and are commented out in all builds.
* Remove nativeTextInputMotionUp.Leon Scroggins2009-11-251-31/+0
| | | | Function is not needed. Requires a change to frameworks/base
* rename nativeFindIsDown to nativeFindIsUpCary Clark2009-11-171-3/+3
| | | | | | companion fix is in framework/base fixes bug http://b/issue?id=2264941
* Fixes license headers for all files in WebKit/android, other than those in stl/.Steve Block2009-11-1318-19/+19
| | | | | | | | | | | | | These files have not yet been upstreamed to webkit.org. WebKit requires either a BSD-style or LGPL 2.1 license for all code. We use a BSD-style 2-clause license for Android-specific files that will be upstreamed to webkit.org. This change adds licenses where absent or simply fixes the names of copyright holders in the license text to 'THE COPYRIGHT OWNER' and cleans up formatting. Files in stl/ currently use licenses other than BSD-style and will require more careful treatment. Change-Id: I67ad4b8932e432d3eaaeecdfeb0d09418496228d
* Store the Node's text rather than the renderer's text.Leon Scroggins2009-11-061-2/+4
| | | | | | | | The renderer may be displaying a placeholder (attribute on HTMLInputElement and HTMLTextAreaElement), which will be deleted when the field gains focus, so take the text directly from the node instead. Fixes http://b/issue?id=2163427
* Fix a clicking bug.Leon Scroggins2009-10-283-15/+5
| | | | | | | | | | | Remove some code that simulates a mouse click at the beginning of a textarea and the end of a textfield. The original goal was to make the click change the selection to be at the beginning or end of the field, respectively. However, we actually make another call which prevents this click from the selection. Further, the selection actually gets changed elsewhere. Fixes http://b/issue?id=2219233
* pass the current cursor when computing the mouse positionCary Clark2009-10-283-6/+7
| | | | | | | | | Most of the time, the simulated mouse position can be computed from the current cursor. But when the cursor is changed, the current cursor info could be out of date and generate a bus error. fixes http://b/issue?id=2061211
* Allow touches to change the selection.Leon Scroggins2009-10-271-3/+10
| | | | | | | | Fixes http://b/issue?id=1650395 Lets touches change the selection while ignoring changes from trackball events. When a touch puts a textfield in focus, tell the WebTextView to set mOkayForFocusNotToMatch. Requires a change in frameworks/base.
* changing how plugins gain/lose focus.Derek Sollenberger2009-10-271-72/+10
| | | | | | | | | | Previously we were keeping our own state in the UI thread to determine when to send events to the plugin. This change removes that logic and uses the document focus to determine when events are to be sent. This also fixes problems with the plugins occasionally not receiving lose focus events. see bug http://b/2033843
* tweak select textCary Clark2009-10-271-53/+26
| | | | | | | | | | | | | | | | | | | | webkit changed the behavior of hitTestResultAtPoint; it used to return the innermost node hit, but does so no longer. Work around this by searching the returned node for a text node. Start the text detection one pixel lower. This fixes picking up the first line of a link on m.msn.com. Simplify the selection drawing. Share code between the arrow and the i-beam. Center the i-beam on the arrow. Use relative path construction to simplify the i-beam. Add debugging. Requires a companion change in frameworks/base partially fixes http://b/issue?id=1667690
* Allow java WebView to check the readonly status of a node.Leon Scroggins2009-10-231-0/+8
| | | | | Required for a change to frameworks/base (https://android-git.corp.google.com/g/30939 )
* Remove some unused variables.Leon Scroggins2009-10-231-1/+1
|
* fix multiple text areas, and text areas without focus ringsCary Clark2009-10-213-15/+12
| | | | | | | | | | | Separate nodes that are hidden from nodes that disable drawing the focus ring. If a node draws its own focus state, other than not drawing the ring, it should be indistinguishable from other focusable nodes. Fix the nav cache dump to be in line with the latest webkit. fixes http://b/issue?id=2201049
* Merge webkit.org at R49305 : Update rendering to use new overflow methods.Steve Block2009-10-201-1/+1
| | | | | | See http://trac.webkit.org/changeset?new=47440 Change-Id: I140b6be130c1fb175c653f5ba2ba19fdc323bbc9
* Merge webkit.org at R49305 : Update CacheBuilder to use new event listener ↵Steve Block2009-10-201-8/+3
| | | | | | | | methods. See http://trac.webkit.org/changeset/48701 Change-Id: I627b40265f2aff72fdd4ad5884596be9820b642d
* Merge webkit.org at R49305 : Text::string renamed to dataImpl.Steve Block2009-10-201-5/+5
| | | | | | See http://trac.webkit.org/changeset/47313 Change-Id: Ic33083eedfc8468c171cd7af6f112aca0eeef615
* Merge webkit.org at R49305 : Update String::copy call sites to use new copy ↵Steve Block2009-10-201-3/+5
| | | | | | | | method. See http://trac.webkit.org/changeset/49160 Change-Id: I75e1d6701f4d16fab7513f5924abf00e958e865c
* Do not bring up the soft keyboard for readonly input fields.Leon Scroggins2009-10-153-4/+18
| | | | | | | Partial fix for http://b/issue?id=2159869. Add a field to CachedNode for readonly. In WebView.cpp, only call displaySoftKeyboard if the node is not readonly. Also call displaySoftKeyboard in nativeTextMotionUp to replace a call being removed in WebView.touchUpOnTextField(java).
* fix copy/paste using trackball on passionCary Clark2009-10-151-21/+15
| | | | | | | | | | | | | | | This fix should be considered for passion mr1, but does not affect sholes -- this is a trackball only bug. The selection caret and arrow now take the scale factor and the height of the title bar into account when preparing the canvas for drawing. Also, simply call to CopyPaste::findClosest, and remove logic to attempt to pin the arrow to the current cursor. Requires a companion fix in framework/base Fixes http://b/issue?id=2187591
* add debugging, tweak data for flash work in progressCary Clark2009-10-123-27/+34
| | | | | | | | | Attempts to get the plugin to scroll when the ime appears. Add debugging strings to help track events to show plugin object. Add focusCandidate interfaces. Tweak rectangles from plugin so they don't disappear. Prefer found matches in nav cache that are later in the document.
* File upload.Leon Scroggins2009-10-091-2/+1
| | | | | | | | Webkit implementation for passing in the data for file uploads. Requires a change to frameworks/base to not break things; also requires a change to packages/apps/Browser to work. Fixes http://b/issue?id=675743
* address detection may look at uninitialized memoryCary Clark2009-10-062-19/+25
| | | | | | | | | Address detection on web pages creates arrays of pointers to words, and compares them against a set of permitted street types. This change adds the array of end pointers so that the check does not look past the end of the word. Fixes http://b/issue?id=2166591
* Add check null of getRealObject(). When a WebView isGrace Kloba2009-10-021-21/+91
| | | | | | | removed, there is a slight chance that getRealObject() for WebView's JavaObject be null. Fix http://b/issue?id=2159815