| Commit message (Collapse) | Author | Age | Files | Lines |
| |\ |
|
| | |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Since we moved the autofill initiation code out of the constructor
and into it's own method, we may crash if there is an autofill profile
set but the feature is turned off (i.e. the user had it on at one point
and had a profile set up but turned it off without deleting the
profile). That's because in this case we execute setAutoFillProfile()
in WebSettings without having first called the new init method. It makes
sense to not sync any profiles though when the feature is not enabled,
so add that check.
Change-Id: I9d99e96347770e5b08c982513f2370cb770cbe94
|
| |/
|
|
|
|
|
| |
initChromiumLogging is now renamed to the more generic initChromium,
the files are renamed to ChromiumInit.*
Change-Id: Ic9639d637f25e664b51d076b9b0ee58c2867c1b5
|
| |
|
|
|
|
|
|
|
|
|
|
| |
This change switches from using a pair of WebRequestContexts (one for
private browsing, one for regular browsing) to using one
WebRequestContext per WebView. This is required to allow us to set the
userAgent on each WebView.
The WebRequestContext is now owned by the WebView.
Bug: 3113804
Change-Id: Iba2b1490e7ce4ff65c08a04a310963fa2c7e4f83
|
| |\ |
|
| | |
| |
| |
| | |
Change-Id: I628b6fdd82089207c5a25ad816d3e6475d85911a
|
| |\ \ |
|
| | | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Currently, much of the AutoFill setup is done in the WebAutoFill
constructor, which is called when the Page is created. This change moves
this setup to be done lazily when searchDocument() is called, which is
the entry point into the feature.
Change-Id: I0d437ed53391b5a7d8d16ec1000dc783c710e564
|
| |\ \ \
| |/ / |
|
| | | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Delete the singleton WebCache and WebCookieJar objects when we
clear up private browsing, so that they are correctly recreated when
next required.
Note that this patch causes the WebCache to leak the HostResolver
object, as was the case before the refactoring in b/3113804. See
b/3243797.
Bug: 3113804
Change-Id: Ic0e2a45b5fd2b30097880e57eac2f6cadbd5dc85
|
| |\ \ \
| |/ /
|/| | |
|
| | | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Fix for bug 3242961
Note that the youtube player crashes when you launch it,
but that also happens with old style urls.
Tested with the testcase in the bug.
Change-Id: I0cb59f8404fe47aabec34c0a21e614f553ea0c32
|
| | | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
It is sometimes desirable to return a valid but 0-length string created
from a 0-length WTF string but currently the WtfStringToJString function
will always return a null jstring on an empty input. Add a parameter to
specify that it should return an empty jstring on empty WTF string and
default it to false.
Change-Id: Ia449f1f9ae9b37c3da7d0272424e4fd4878ceb31
|
| |\ \ \ |
|
| | |/ /
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
The browser app will use this to sync cookies to flash when it is
sent to the background. Corresponding Java code is in I04e96aff.
Depends on external/chromium changes in Ie600c588.
Bug: 3231371
Change-Id: Ia9b56f3cdb5acd1fca23102b68b2f83a94ba6e69
|
| |/ /
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
During a long press, the original pointer to the
node and frame may change. Pass the location instead
to attempt to find the anchor.
companion change in frameworks/base
bug:3240869
Change-Id: Idf5eb67e2cb544dfa312e41f9224813c6ca80563
|
| |\ \ |
|
| | |/
| |
| |
| |
| |
| |
| |
| |
| | |
An older test incorrectly discards nodes if they are partially
off the screen. The test was attempting to ignore nodes that
were fully invisible, so change the test to do that.
bug:3198707
Change-Id: I3cb13de3c86b43d3388849161bdfc44f84d93b3d
|
| | |
| |
| |
| | |
Change-Id: I290228dce1ce3e0be56666775f591c6c2b7dab32
|
| |\ \
| |/
|/|
| | |
factory function"
|
| | |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
In b/3044989, AutoFill was modified to take a factory function for the
URLRequestContext (which was then created when needed), rather than
taking the context directly. This was to avoid a race condition where
the context is created before the required storage paths have been
synced to the WebCore thread through the BrowserFrame.
Since https://android-git.corp.google.com/g/76579 and
https://android-git.corp.google.com/g/80056, we read the required
paths directly from JniUtils, so the race condition no longer exists. We
can therefore provide the context directly to AutoFill.
Note that while the context may be created before the Settings have been
synced to the WebCore thread, the necessary properties will be updated
as part of this sync before the context is used.
This change will also simplify things when we use one context per
WebView.
Also requires a change in external/chromium ...
https://android-git.corp.google.com/g/82146
Change-Id: Idfc34d435bae21654a02e5898aef0e84da98218a
|
| |\ \ |
|
| | | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
AutoFill profiles now use GUIDs that they generate themselves
rather than injecting a unique int ID so we no longer need to
reach into the java class to grab the ID.
Change-Id: I26492aeddd130831e941ec79ef1f5e36271903c8
|
| |\ \ \
| | |/
| |/|
| | |
| | |
| | |
| | | |
* changes:
Moves implementation of ResourceLoaderAndroid to ResourceLoaderAndroid.cpp
Add a static WebRequestContext::acceptLanguage() method
Make WebCookieJar::get() threadsafe
|
| | | |
| | |
| | |
| | |
| | |
| | |
| | | |
This means that the implmentation of this class for both HTTP stacks is
in the same place.
Change-Id: I006cddf27c245a88327643314bb7564a2486ff38
|
| | | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
This removes the need for PlatformBridge::computeDefaultLanguage() to
get an instance of WebRequestContext. This is part of the refactoring to
use a WebRequestContext per WebView.
Bug: 3113804
Change-Id: Ib304a8457a82d09d80fe4d6298f00f688ec53b7c
|
| | | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
This should have been part of
https://android-git.corp.google.com/g/78476 which factored
WebCookieJar out of WebRequestContext.
Also, now that WebRequestContext::get() is called nly on the WebCore
thread, it does not need to be threadsafe.
Bug: 3113804
Change-Id: I4622749d1650be0b9ca0d37541361955a367110f
|
| | | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Return the bounds of a layer.
support for a companion change in frameworks/base
bug:3186988
Change-Id: Ie8f69dc8c46c6329fd0b093ecdba4715f8cde2a9
|
| |\ \ \
| |/ /
| | /
| |/
|/| |
|
| | |
| |
| |
| |
| |
| |
| |
| |
| | |
This is the second step in allowing us to have a WebRequestContext per
WebView, which is required to allow the useragent string to be
configured per WebView.
Bug: 3113804
Change-Id: Idcd252194562d1ef91d9d6e2baf8c65b8ff088d4
|
| |\ \
| |/ |
|
| | |
| |
| |
| | |
Change-Id: Ia68bac6bd93b0afeff049a9ac0f056191d92d2a0
|
| |\ \
| |/ |
|
| | |
| |
| |
| |
| |
| |
| |
| |
| | |
This is the first step in allowing us to have a WebRequestContext per
WebView, which is required to allow the useragent string to be
configured per WebView.
Bug: 3113804
Change-Id: I9ccf07d4a277147e74e2f3e701bd6d2166954280
|
| |\ \
| |/
| |
| | |
WebRequestContext.cleanupPrivateBrowsingFiles()"
|
| | |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
WebRequestContext.cleanupPrivateBrowsingFiles()
Requires the following changes to frameworks/base and packages/apps/Browser
https://android-git.corp.google.com/g/81782
https://android-git.corp.google.com/g/81780
Bug: 3232569
Change-Id: I73cabb561e206beee2bc1716f04aed8764797cc1
|
| |\ \
| |/
|/| |
|
| | |
| |
| |
| |
| |
| |
| |
| | |
We now correctly set the cookie load flags and the cache control HTTP
headers.
Bug: 2889880
Change-Id: I759a3131b73a8fc82432a067a31754fcc566c136
|
| | |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
We previously checked !IsPersistent() to determine whether a
cookie is a session cookie, but now all cookies are persistent,
so we need to call the new method IsSessionCookie().
Depends on https://android-git.corp.google.com/g/81755
Bug: 2864791
Change-Id: Ia44cd0cdc5e68a4b0a61bdeebd70cdccfc8e4e1b
|
| | |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
This flag previously defaulted to false, but the Android CTS
specifies that a "sufficient" implementation should return true
on the first authentication request. (The second and subsequent
auth requests aren't tested.)
This CL sets the flag to true on the first authentication request
for a given WebRequest, but false for subsequent requests (i.e.,
if the first attempt to authenticate failed).
Using a counter rather than a flag in WebRequest for readability.
"isFirstAuthRequest" would be a bit ambiguous as a member variable,
but "authRequestCount" seems pretty clear.
Change-Id: Id9baae4c30111f743e079f90940078b07498b168
|
| |\ \ |
|
| | | |
| | |
| | |
| | |
| | |
| | |
| | | |
These asserts have not been triggered in months, so removing the
crash (but keeping logging), and closing bug 2951985.
Change-Id: I5bb31c6e23c18e83301428582ad895b0b679ff86
|
| | | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Radio and checkbox input types draw only a bitmap in
their navigation bounds, and require some special treatment.
Never treat them as transparent.
Use the slop box instead of the exact box when detecting
them, since our asset may be larger than the space webkit
provides.
Also, fix a debug test if the layer is null.
bug:3215174
Change-Id: I3b573e3aa215268390db2d58435ac47115804ed7
|
| | | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
This captures the drawing in the UI thread, then passes
the drawing to the tile imaging thread.
The draw extras interface now takes an additional rectangle,
and each draw extra fills in the inval area formed as that
part is drawn.
The old extra implementation in GLWebViewState has been
removed. The inval portion of the setBaseLayer call has been split
out so it can be called directly.
bug:3161294
Change-Id: I28d3e6879059770b973e7c0f7c0796909f7359aa
|
| |/ /
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
This reverts commit 0c918ae77b5edfe59b726ff40a7c86dbc4a94307.
This was actually not really a regression as we were still broken
previously it's just that this change makes that breakage more visible.
The problem reproduces on tip of tree Chromium, so we can make the fix
upstream and then cherry pick into Android.
Change-Id: I4d65544b4ea137d77c00a39fcd29edb28b40aa1c
|
| |\ \ |
|
| | | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
If no profile is set then AutoFill will not inform Java that it has
found a form that could be autofilled. We want to be able to offer
the user the option Java side to set up a profile in this case, so
we set by default an empty profile that is active until the user
syncs their real profile. This ensures that the AutoFill detection
code will not early out.
Change-Id: I474b25c5b31dae59e4ddb23c7f398d013e9d3beb
|
| |\ \ \ |
|
| | | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
This will prompt the user to save the username and password
when posting a form. Same behaviour as the Android HTTP stack.
Bug: 3060688
Test: Logged into amazon.co.uk, checked that password is saved.
Change-Id: I4185b7ef2fbb299e4441b18b50f0018f0208d264
|
| |\ \ \ \
| |/ / / |
|