From e14391e94c850b8bd03680c23b38978db68687a8 Mon Sep 17 00:00:00 2001 From: John Reck Date: Thu, 4 Nov 2010 12:00:17 -0700 Subject: Merge Webkit at r70949: Initial merge by git. Change-Id: I77b8645c083b5d0da8dba73ed01d4014aab9848e --- WebCore/ChangeLog | 6987 ++++++++++++++++++++++++++++++++++++++++++++++++++++- 1 file changed, 6986 insertions(+), 1 deletion(-) (limited to 'WebCore/ChangeLog') diff --git a/WebCore/ChangeLog b/WebCore/ChangeLog index 83f63cc..44714b7 100644 --- a/WebCore/ChangeLog +++ b/WebCore/ChangeLog @@ -1,3 +1,6988 @@ +2010-10-29 Ryosuke Niwa + + Reviewed by Darin Adler. + + Remove RenderTextControl::setSelectionRange + https://bugs.webkit.org/show_bug.cgi?id=47870 + + Made RenderTextControl::setSelectionRange a global function. + Removed setSelectionStart, setSelectionEnd, and select from RenderTextControl. + + No new tests are added since there is no behavioral change. + + * accessibility/AccessibilityRenderObject.cpp: + (WebCore::AccessibilityRenderObject::setSelectedTextRange): Calls setSelectedTextRange. + * dom/InputElement.cpp: + (WebCore::InputElement::updateSelectionRange): Ditto. + * html/HTMLFormControlElement.cpp: + (WebCore::HTMLTextFormControlElement::setSelectionStart): Ditto. + (WebCore::HTMLTextFormControlElement::setSelectionEnd): Ditto. + (WebCore::HTMLTextFormControlElement::select): Ditto. + (WebCore::HTMLTextFormControlElement::setSelectionRange): Ditto. + * rendering/RenderTextControl.cpp: + (WebCore::RenderTextControl::hasVisibleTextArea): Added. + (WebCore::setSelectionRange): See above. + * rendering/RenderTextControl.h: + +2010-10-29 Carlos Garcia Campos + + Reviewed by Andreas Kling. + + [GTK] Crash in TextEncoding.cpp when using glib unicode + https://bugs.webkit.org/show_bug.cgi?id=48521 + + When the conversion to UTF-8 fails, try to encode the original string + without normalizing. Fixes tests cases: + fast/url/anchor.html + fast/url/query.html + fast/url/standard-url.html + + * platform/text/TextEncoding.cpp: + (WebCore::TextEncoding::encode): + +2010-10-29 Benjamin Poulain + + Reviewed by Antonio Gomes. + + TextureMapperGL get the driver info log but do not use it + https://bugs.webkit.org/show_bug.cgi?id=48247 + + Remove the call to glGetProgramInfoLog(). + + * platform/graphics/opengl/TextureMapperGL.cpp: + (WebCore::TexmapShaderInfo::createShaderProgram): + +2010-10-29 Benjamin Kalman + + Reviewed by Tony Chang. + + Deleting contenteditable text to the left of a non-contenteditable span inserts unnecessary placeholder
+ https://bugs.webkit.org/show_bug.cgi?id=48658 + + * WebCore.exp.in: Update is{Start,End}OfParagraph symbols. + * editing/DeleteSelectionCommand.cpp: + (WebCore::DeleteSelectionCommand::doApply): Cross editability boundaries when determining whether to insert placeholder. + * editing/visible_units.cpp: Allow editability boundary to be crossed in {start,end,isStart,isEnd}OfParagraph. + (WebCore::startOfParagraph): Also, avoid returning a position where renderer can't accept caret, like in endOfParagraph. + (WebCore::endOfParagraph): + (WebCore::isStartOfParagraph): + (WebCore::isEndOfParagraph): + * editing/visible_units.h: Ditto. + +2010-10-29 Pavel Feldman + + Reviewed by Timothy Hatcher. + + Web Inspector: last active panel is not restored upon opening inspector. + https://bugs.webkit.org/show_bug.cgi?id=48668 + + * inspector/Inspector.idl: + * inspector/InspectorController.cpp: + (WebCore::InspectorController::InspectorController): + (WebCore::InspectorController::inspect): + (WebCore::InspectorController::showPanel): + (WebCore::InspectorController::disconnectFrontend): + (WebCore::InspectorController::populateScriptObjects): + * inspector/InspectorController.h: + * inspector/InspectorState.cpp: + (WebCore::InspectorState::InspectorState): + * inspector/front-end/Settings.js: + (WebInspector.Settings): + * inspector/front-end/inspector.js: + (WebInspector.set currentPanel): + (WebInspector.doLoadedDone.onPopulateScriptObjects): + (WebInspector.doLoadedDone): + (WebInspector.documentClick.followLink): + (WebInspector.documentClick): + +2010-10-28 Michael Nordman + + Reviewed by ap. + + [Chrome] Fix an appcache regression introduced in r69226 + https://bugs.webkit.org/show_bug.cgi?id=48592 + Define a new ApplicationCacheHost method for the specific case of main resource redirect handling. + + Tests: the existing layout test applies + + * loader/MainResourceLoader.cpp: use the newly introduced method + (WebCore::MainResourceLoader::willSendRequest): + * loader/appcache/ApplicationCacheHost.cpp: + (WebCore::ApplicationCacheHost::maybeLoadMainResourceForRedirect): + * loader/appcache/ApplicationCacheHost.h: + +2010-10-29 Eric Carlson + + Reviewed by Adam Roben. + + Navigating to a .wav file creates a plugin document but should create a media document + https://bugs.webkit.org/show_bug.cgi?id=48546 + + + Test: media/media-can-play-wav-audio.html + + * platform/MIMETypeRegistry.cpp: Add mapping from ".wav" to "audio/x-wav". + +2010-10-29 Aaron Colwell + + Reviewed by James Robinson. + + Created helper method WebCore::PlatformContextSkia::getNormalizedAlpha() + to centralize alpha rounding & clipping logic. + https://bugs.webkit.org/show_bug.cgi?id=48094 + + Test: media/video-canvas-alpha.html + + * platform/graphics/skia/ImageSkia.cpp: + (WebCore::paintSkBitmap): + * platform/graphics/skia/PlatformContextSkia.cpp: + (WebCore::PlatformContextSkia::getNormalizedAlpha): + * platform/graphics/skia/PlatformContextSkia.h: + +2010-10-29 Nikolas Zimmermann + + Reviewed by Dirk Schulze. + + ASSERT when SVGAnimatedProperty instance is assigned to multiple elements. + https://bugs.webkit.org/show_bug.cgi?id=48555 + + Test: svg/custom/insertItemBefore-from-non-list-origin.svg + + * bindings/scripts/CodeGeneratorJS.pm: Include SVGAnimatedPropertyTearOff.h instead of SVGPropertyTearOff.h + * bindings/scripts/CodeGeneratorObjC.pm: Ditto. + * bindings/scripts/CodeGeneratorV8.pm: Ditto. + * svg/properties/SVGAnimatedListPropertyTearOff.h: + (WebCore::SVGAnimatedListPropertyTearOff::isAnimatedListTearOff): Return true. + (WebCore::SVGAnimatedListPropertyTearOff::removeItemFromList): Devirtualize function. + * svg/properties/SVGAnimatedProperty.h: + (WebCore::SVGAnimatedProperty::isAnimatedListTearOff): Return false. + * svg/properties/SVGListPropertyTearOff.h: + (WebCore::SVGListPropertyTearOff::removeItemFromListIfNeeded): Only try to remove the passed item from its list, if its actually a list and not just a SVGAnimatedProperty. + +2010-10-29 David Hyatt + + Reviewed by Adam Roben. + + https://bugs.webkit.org/show_bug.cgi?id=48444 + + Fix the dirty rect checks in RenderBoxLineList, InlineFlowBox, InlineTextBox. They were still assuming horizontal-tb writing-mode. + This patch makes the checks directionally abstract and also refactors the checks in RenderLineBoxList to share code. + + No tests yet, since the invalidation code for inlines still assumes horizontal-tb. That will be fixed in a follow-up bug, + and then repaint tests will be easy to write. + + * rendering/InlineBox.cpp: + (WebCore::InlineBox::adjustForFlippedBlocksWritingMode): + * rendering/InlineBox.h: + * rendering/InlineFlowBox.cpp: + (WebCore::InlineFlowBox::paint): + * rendering/InlineTextBox.cpp: + (WebCore::InlineTextBox::paint): + * rendering/RenderBox.cpp: + (WebCore::RenderBox::convertFromFlippedWritingMode): + * rendering/RenderBox.h: + * rendering/RenderLineBoxList.cpp: + (WebCore::RenderLineBoxList::rangeIntersectsDirtyRect): + (WebCore::RenderLineBoxList::anyLineIntersectsDirtyRect): + (WebCore::RenderLineBoxList::lineIntersectsDirtyRect): + (WebCore::RenderLineBoxList::paint): + (WebCore::RenderLineBoxList::hitTest): + * rendering/RenderLineBoxList.h: + +2010-10-29 Patrick Gansterer + + Reviewed by Adam Roben. + + Cleanup createGlobalImageFileDescriptor in ClipboardWin + https://bugs.webkit.org/show_bug.cgi?id=48189 + + * platform/win/ClipboardWin.cpp: + (WebCore::createGlobalURLContent): + (WebCore::createGlobalUrlFileDescriptor): + (WebCore::ClipboardWin::writeURL): + +2010-10-29 Dmitry Titov + + [Chromium clang] Unreviewed fix removing compiler warning. + If GIFImageReader is a struct, don't call it a class. + + * platform/image-decoders/gif/GIFImageDecoder.h: + +2010-10-29 Alexey Proskuryakov + + Fix the world (d'oh!) + + https://bugs.webkit.org/show_bug.cgi?id=48576 + Let WebKit2 client know when a frame is a frameset + + * html/HTMLFrameSetElement.cpp: + (WebCore::HTMLFrameSetElement::insertedIntoDocument): + (WebCore::HTMLFrameSetElement::removedFromDocument): + Call base class version. + +2010-10-29 Jian Li + + Unreviewed. Fix chromium build break. + + * bindings/v8/custom/V8FileReaderCustom.cpp: + (WebCore::V8FileReader::resultAccessorGetter): + +2010-10-29 Jian Li + + Reviewed by David Levin. + + Support readAsArrayBuffer in FileReader and FileReaderSync + https://bugs.webkit.org/show_bug.cgi?id=47691 + + Merge the similar code in FileReader and FileReaderSync into + FileReaderLoader. + + Test cases have been added to read-file-test-cases.js. + + * Android.jscbindings.mk: + * CMakeLists.txt: + * GNUmakefile.am: + * WebCore.gypi: + * WebCore.pro: + * WebCore.vcproj/WebCore.vcproj: + * WebCore.xcodeproj/project.pbxproj: + * bindings/v8/custom/V8FileReaderCustom.cpp: Added. + * fileapi/FileReader.cpp: + (WebCore::FileReader::FileReader): + (WebCore::FileReader::readAsArrayBuffer): + (WebCore::FileReader::readAsBinaryString): + (WebCore::FileReader::readAsText): + (WebCore::FileReader::readAsDataURL): + (WebCore::FileReader::readInternal): + (WebCore::FileReader::doAbort): + (WebCore::FileReader::terminate): + (WebCore::FileReader::start): + (WebCore::FileReader::didStartLoading): + (WebCore::FileReader::didReceiveData): + (WebCore::FileReader::didFinishLoading): + (WebCore::FileReader::didFail): + (WebCore::FileReader::fireEvent): + (WebCore::FileReader::arrayBufferResult): + (WebCore::FileReader::stringResult): + * fileapi/FileReader.h: + (WebCore::FileReader::readType): + * fileapi/FileReader.idl: + * fileapi/FileReaderLoader.cpp: Added. + * fileapi/FileReaderLoader.h: Added. + * fileapi/FileReaderLoaderClient.h: Added. + * fileapi/FileReaderSync.cpp: + (WebCore::FileReaderSync::FileReaderSync): + (WebCore::FileReaderSync::readAsArrayBuffer): + (WebCore::FileReaderSync::readAsBinaryString): + (WebCore::FileReaderSync::readAsText): + (WebCore::FileReaderSync::readAsDataURL): + (WebCore::FileReaderSync::startLoading): + * fileapi/FileReaderSync.h: + * fileapi/FileReaderSync.idl: + * html/canvas/ArrayBuffer.cpp: + (WebCore::ArrayBuffer::create): + * html/canvas/ArrayBuffer.h: + * loader/ThreadableLoaderClient.h: + +2010-10-29 Tony Chang + + Unreviewed, rolling out r70850. + http://trac.webkit.org/changeset/70850 + https://bugs.webkit.org/show_bug.cgi?id=45640 + + chromium and qt pixel test regressions + + * dom/Document.cpp: + * dom/Document.h: + * page/FrameView.cpp: + (WebCore::FrameView::invalidateRect): + (WebCore::FrameView::repaintContentRectangle): + (WebCore::FrameView::doDeferredRepaints): + * page/FrameView.h: + * rendering/RenderBlock.cpp: + (WebCore::RenderBlock::paintContents): + * rendering/RenderLayer.cpp: + (WebCore::RenderLayer::paintLayer): + +2010-10-29 Alexey Proskuryakov + + Reviewed by Darin Adler. + + https://bugs.webkit.org/show_bug.cgi?id=48576 + Let WebKit2 client know when a frame is a frameset + + This can change in two cases, when document changes, and when frame is navigated to another + document. + + * dom/Document.cpp: (WebCore::Document::documentDidBecomeActive): Update the client when + a document is restored from page cache. + + * loader/FrameLoaderClient.h: Added a new client call to notify client. + + * html/HTMLFrameSetElement.h: + * html/HTMLFrameSetElement.cpp: + (WebCore::HTMLFrameSetElement::insertedIntoDocument): + (WebCore::HTMLFrameSetElement::removedFromDocument): + Update the client when document changes, potentially becoming a frameset. Per WebCore + definition, a document is a frameset when it has a FRAMESET element as direct child of + document element (it may also have body elements). + + * loader/EmptyClients.h: (WebCore::EmptyFrameLoaderClient::dispatchDidBecomeFrameset): + Added an empty implementation. + +2010-10-29 Csaba Osztrogonác + + Unreviewed fix. Touch WebCorePrefix.h to fix incremental build failure after r70878. + + * WebCorePrefix.h: + +2010-10-29 Carlos Garcia Campos + + Reviewed by Martin Robinson. + + [GTK] Handle surrogate pairs in TextBreakIteratorGtk + https://bugs.webkit.org/show_bug.cgi?id=48227 + + TextBreakIteratorGtk uses UTF-8 because it's what pango expects, but we + need to return indices for the given input string that are in UTF-16. + The number of characters is the same for both UTF-16 and UTF-8 except when + the input string contains surrogate pairs. We need to keep both, the + index for the UTF-8 string to be used internally, and the index for the + UTF-16 string to be used as return value of the iterator interface. It + fixes test fast/forms/textarea-maxlength.html + + * platform/text/gtk/TextBreakIteratorGtk.cpp: + (WebCore::CharacterIterator::getText): + (WebCore::CharacterIterator::getLength): + (WebCore::CharacterIterator::getSize): + (WebCore::CharacterIterator::getIndex): + (WebCore::CharacterIterator::getUTF16Index): + (WebCore::CharacterIterator::getUTF16Length): + (WebCore::CharacterIterator::characterSize): + (WebCore::CharacterIterator::setText): + (WebCore::CharacterIterator::setIndex): + (WebCore::CharacterIterator::setUTF16Index): + (WebCore::CharacterIterator::first): + (WebCore::CharacterIterator::last): + (WebCore::CharacterIterator::next): + (WebCore::CharacterIterator::previous): + (WebCore::setUpIterator): + (WebCore::textBreakFirst): + (WebCore::textBreakLast): + (WebCore::textBreakNext): + (WebCore::textBreakPrevious): + (WebCore::textBreakPreceding): + (WebCore::textBreakFollowing): + (WebCore::textBreakCurrent): + (WebCore::isTextBreak): + +2010-10-29 Alexander Pavlov + + Reviewed by Pavel Feldman. + + Web Inspector: [REGRESSION] Addition of a new (blank) style property does not work + https://bugs.webkit.org/show_bug.cgi?id=48631 + + Test: inspector/styles-add-blank-property.html + + * inspector/front-end/StylesSidebarPane.js: + (WebInspector.StylePropertiesSection.prototype.addNewBlankProperty): + (WebInspector.ComputedStylePropertiesSection.prototype.onpopulate): + +2010-10-29 Pavel Feldman + + Reviewed by Timothy Hatcher. + + Web Inspector: add close button to network view, make tests pass for + resource manager on all ports. + https://bugs.webkit.org/show_bug.cgi?id=48628 + + * inspector/InspectorController.cpp: + (WebCore::InspectorController::didCommitLoad): + (WebCore::InspectorController::frameDetachedFromParent): + (WebCore::InspectorController::didLoadResourceFromMemoryCache): + (WebCore::InspectorController::identifierForInitialRequest): + (WebCore::InspectorController::willSendRequest): + (WebCore::InspectorController::markResourceAsCached): + (WebCore::InspectorController::didReceiveResponse): + (WebCore::InspectorController::didReceiveContentLength): + (WebCore::InspectorController::didFinishLoading): + (WebCore::InspectorController::didFailLoading): + (WebCore::InspectorController::resourceRetrievedByXMLHttpRequest): + (WebCore::InspectorController::scriptImported): + (WebCore::InspectorController::didCreateWebSocket): + (WebCore::InspectorController::willSendWebSocketHandshakeRequest): + (WebCore::InspectorController::didReceiveWebSocketHandshakeResponse): + (WebCore::InspectorController::didCloseWebSocket): + * inspector/front-end/NetworkPanel.js: + (WebInspector.NetworkPanel): + * inspector/front-end/ResourceManager.js: + (WebInspector.ResourceTreeModel.prototype.didCommitLoadForFrame): + * inspector/front-end/StoragePanel.js: + (WebInspector.StoragePanel.prototype.addResourceToFrame): + * inspector/front-end/inspector.js: + (WebInspector._createPanels): + * inspector/front-end/networkPanel.css: + (.network-close-button): + +2010-10-29 Nikolas Zimmermann + + Reviewed by Dirk Schulze. + + Convert SVGAnimatedEnumeration/Integer to the new SVGAnimatedPropertyTearOff concept + https://bugs.webkit.org/show_bug.cgi?id=48623 + + Besides converting SVGAnimatedEnumeration/Integer to the new animated property tear off concept, fix support + for multiple wrappers within the new concept, which was broken - covered by existing svg/dynamic-updates/ tests. + + Replace all 'extern char[]' usage when using the multiple wrappers macro, by static AtomicStrings. + + * GNUmakefile.am: Add SVGAnimatedEnumeration.h / SVGAnimatedInteger.h to build. + * WebCore.gypi: Ditto. + * WebCore.pro: Ditto. + * WebCore.vcproj/WebCore.vcproj: Ditto. + * WebCore.xcodeproj/project.pbxproj: Ditto. + * bindings/scripts/CodeGenerator.pm: Recognize SVGAnimatedEnumeration / SVGAnimatedInteger as animated types using the new concept. + * bindings/scripts/CodeGeneratorObjC.pm: Touched, to force regenerating ObjC bindings, dependency tracking is obviously broken. + * svg/DeprecatedSVGAnimatedPropertyTraits.h: Remove SVGAnimatedBoolean/Enumeration/Integer handling. + * svg/DeprecatedSVGAnimatedTemplate.h: Ditto. + * svg/SVGAnimatedEnumeration.h: Added. + * svg/SVGAnimatedEnumeration.idl: + * svg/SVGAnimatedInteger.h: Added. + * svg/SVGClipPathElement.h: Adapted all code to create new style animated property tear offs for long & int types. + * svg/SVGComponentTransferFunctionElement.h: + * svg/SVGFEBlendElement.h: + * svg/SVGFEColorMatrixElement.h: + * svg/SVGFECompositeElement.h: + * svg/SVGFEConvolveMatrixElement.h: + * svg/SVGFEDiffuseLightingElement.cpp: + (WebCore::SVGFEDiffuseLightingElement::kernelUnitLengthXIdentifier): Replaced extern[] char hack using a static AtomicString. + (WebCore::SVGFEDiffuseLightingElement::kernelUnitLengthYIdentifier): Ditto. + * svg/SVGFEDiffuseLightingElement.h: + * svg/SVGFEDisplacementMapElement.h: + * svg/SVGFEGaussianBlurElement.cpp: + (WebCore::SVGFEGaussianBlurElement::stdDeviationXIdentifier): Ditto. + (WebCore::SVGFEGaussianBlurElement::stdDeviationYIdentifier): Ditto. + * svg/SVGFEGaussianBlurElement.h: + * svg/SVGFEMorphologyElement.h: + * svg/SVGFESpecularLightingElement.cpp: + (WebCore::SVGFESpecularLightingElement::kernelUnitLengthXIdentifier): Ditto. + (WebCore::SVGFESpecularLightingElement::kernelUnitLengthYIdentifier): Ditto. + * svg/SVGFESpecularLightingElement.h: + * svg/SVGFETurbulenceElement.cpp: + (WebCore::SVGFETurbulenceElement::baseFrequencyXIdentifier): Ditto. + (WebCore::SVGFETurbulenceElement::baseFrequencyYIdentifier): Ditto. + * svg/SVGFETurbulenceElement.h: + * svg/SVGFilterElement.cpp: + (WebCore::SVGFilterElement::filterResXIdentifier): Ditto. + (WebCore::SVGFilterElement::filterResYIdentifier): Ditto. + * svg/SVGFilterElement.h: + * svg/SVGGradientElement.h: + * svg/SVGMarkerElement.cpp: + (WebCore::SVGMarkerElement::orientTypeIdentifier): Ditto. + (WebCore::SVGMarkerElement::orientAngleIdentifier): Ditto. + * svg/SVGMarkerElement.h: + * svg/SVGMaskElement.h: + * svg/SVGPatternElement.h: + * svg/SVGTextContentElement.h: + * svg/SVGTextPathElement.h: + * svg/properties/SVGAnimatedPropertyMacros.h: Add new macro for multiple wrappers using static properties. + +2010-10-29 Andreas Kling + + Reviewed by Kenneth Rohde Christiansen. + + [Qt] Make GraphicsContext cheaper to construct + https://bugs.webkit.org/show_bug.cgi?id=48626 + + Do less unnecessary things when creating the Qt GraphicsContext: + - Don't create a black QBrush that's immediately discarded. + - Don't call setPlatform*(), set the painter brush and pen directly. + - Call setRenderHints() once instead of multiple setRenderHint(). + + * platform/graphics/qt/GraphicsContextQt.cpp: + (WebCore::GraphicsContextPlatformPrivate::GraphicsContextPlatformPrivate): + (WebCore::GraphicsContext::GraphicsContext): + +2010-10-29 Andreas Kling + + Reviewed by Simon Hausmann. + + [Qt] GraphicsLayer: Don't notifySyncRequired() more than necessary + https://bugs.webkit.org/show_bug.cgi?id=48624 + + Don't queue multiple meta method invocations for notifySyncRequired() + + 4% speedup on + + * platform/graphics/qt/GraphicsLayerQt.cpp: + (WebCore::GraphicsLayerQtImpl::GraphicsLayerQtImpl): + (WebCore::GraphicsLayerQtImpl::notifySyncRequired): + (WebCore::GraphicsLayerQtImpl::notifyChange): + +2010-10-29 Zhenyao Mo + + Reviewed by Chris Marrin. + + drawArrays/drawElements with first/offset out of range but size==0 should generate no error + https://bugs.webkit.org/show_bug.cgi?id=48601 + + * html/canvas/WebGLRenderingContext.cpp: + (WebCore::WebGLRenderingContext::drawArrays): + (WebCore::WebGLRenderingContext::drawElements): + +2010-10-29 Leandro Gracia Gil + + Reviewed by Jeremy Orlow. + + Patch the current speech input implementation to use the nearest + language tag. The language is now passed to the startRecognition + methods so that language-specific recognition could be used. Also added + a second parameter to setMockSpeechInputResult for the language used in + speech recognition. + https://bugs.webkit.org/show_bug.cgi?id=47089 + + This is the 2nd of a 4-sided patch in Chromium and WebKit. For more + details see http://codereview.chromium.org/3615005/show, + http://codereview.chromium.org/3595018/show and + https://bugs.webkit.org/show_bug.cgi?id=47420. + + Test: fast/speech/input-text-language-tag.html + + * page/SpeechInput.cpp: + (WebCore::SpeechInput::startRecognition): + * page/SpeechInput.h: + * page/SpeechInputClient.h: + * platform/mock/SpeechInputClientMock.cpp: + (WebCore::SpeechInputClientMock::startRecognition): + (WebCore::SpeechInputClientMock::setRecognitionResult): + (WebCore::SpeechInputClientMock::timerFired): + * platform/mock/SpeechInputClientMock.h: + * rendering/TextControlInnerElements.cpp: + (WebCore::TextControlInnerElement::attachInnerElement): + (WebCore::SearchFieldCancelButtonElement::detach): + (WebCore::SpinButtonElement::defaultEventHandler): + (WebCore::InputFieldSpeechButtonElement::defaultEventHandler): + (WebCore::InputFieldSpeechButtonElement::detach): + +2010-10-29 Mads Ager + + Reviewed by Pavel Feldman. + + [V8] The DateExtension cannot handle overwritten Date + https://bugs.webkit.org/show_bug.cgi?id=48621 + + Check that the Date property is an object before attempting to get + hidden properties from it. + + Test: fast/dom/Window/slow-unload-handler-overwritten-date.html + + * bindings/v8/DateExtension.cpp: + (WebCore::DateExtension::setAllowSleep): + +2010-10-27 Nikolas Zimmermann + + Reviewed by Dirk Schulze. + + Convert SVGAnimatedBoolean to the new SVGAnimatedPropertyTearOff concept + https://bugs.webkit.org/show_bug.cgi?id=48469 + + Convert the next SVG animated primitive type to use the SVGAnimatedPropertyTearOff concept: SVGAnimatedBoolean. + Added new test verifying that StrictTypeChecking is enabled for SVGAnimatedBooleans. It also tests that this type is "static", see LayoutTests/ChangeLog for details. + + Add support for StrictTypeChecking for boolean types. + + Test: svg/dom/SVGExternalResourcesRequired.html + + * GNUmakefile.am: Add SVGAnimatedBoolean.h and SVGAnimatedStaticPropertyTearOff.h to build. + * WebCore.gypi: Ditto. + * WebCore.pro: Ditto. + * WebCore.vcproj/WebCore.vcproj: Ditto. + * WebCore.xcodeproj/project.pbxproj: Ditto. + * bindings/scripts/CodeGenerator.pm: Add SVGAnimatedBoolean to the new style svg animated bindings list. + * bindings/scripts/CodeGeneratorJS.pm: Add StrictTypeChecking support for boolean types. + * bindings/scripts/CodeGeneratorObjC.pm: Ditto. Only generate kit() usage for new style animated types, if the wrapped type needs a tear off. + * bindings/scripts/CodeGeneratorV8.pm: Ditto. + * svg/DeprecatedSVGAnimatedTemplate.h: Remove SVGAnimatedBoolean handling. + * svg/SVGAElement.h: s/DECLARE_ANIMATED_PROPERTY/DECLARE_ANIMATED_STATIC_PROPERTY_NEW/ for boolean types everywhere. Include SVGAnimatedPropertyMacros.h where needed. + * svg/SVGAnimatedBoolean.h: Added. + * svg/SVGAnimatedBoolean.idl: + * svg/SVGAnimationElement.h: + * svg/SVGCircleElement.h: + * svg/SVGClipPathElement.h: + * svg/SVGCursorElement.h: + * svg/SVGDefsElement.h: + * svg/SVGEllipseElement.h: + * svg/SVGExternalResourcesRequired.cpp: + * svg/SVGExternalResourcesRequired.h: + (WebCore::SVGExternalResourcesRequired::~SVGExternalResourcesRequired): + * svg/SVGFEConvolveMatrixElement.h: + * svg/SVGFEImageElement.h: + * svg/SVGFilterElement.h: + * svg/SVGFontElement.h: + * svg/SVGForeignObjectElement.h: + * svg/SVGGElement.h: + * svg/SVGGradientElement.h: + * svg/SVGImageElement.h: + * svg/SVGLineElement.h: + * svg/SVGMPathElement.h: + * svg/SVGMarkerElement.h: + * svg/SVGMaskElement.h: + * svg/SVGPathElement.h: + * svg/SVGPatternElement.h: + * svg/SVGPolyElement.h: + * svg/SVGRectElement.h: + * svg/SVGSVGElement.h: + * svg/SVGScriptElement.h: + * svg/SVGSwitchElement.h: + * svg/SVGSymbolElement.h: + * svg/SVGTextContentElement.h: + * svg/SVGUseElement.h: + * svg/SVGViewElement.h: + * svg/properties/SVGAnimatedListPropertyTearOff.h: Moved RefPtr m_baseVal/m_animVal from SVGAnimatedProperty, as SVGAnimatedStaticPropertyTearOff doesn't need them. + * svg/properties/SVGAnimatedProperty.h: Remove m_baseVal/m_animVal. + (WebCore::SVGAnimatedProperty::commitChange): New method to share code between the SVGAnimated*PropertyTearOff classes. + * svg/properties/SVGAnimatedPropertyMacros.h: Add new DECLARE_ANIMATED_STATIC_PROPERTY_NEW macro which creates SVGAnimatedStaticPropertyTearOff types. + * svg/properties/SVGAnimatedPropertyTearOff.h: Moved RefPtr m_baseVal/m_animVal from SVGAnimatedProperty, as SVGAnimatedStaticPropertyTearOff doesn't need them. + * svg/properties/SVGAnimatedStaticPropertyTearOff.h: Added. + (WebCore::SVGAnimatedStaticPropertyTearOff::baseVal): Directly returns the stored m_property as reference, no tear off is created. + (WebCore::SVGAnimatedStaticPropertyTearOff::animVal): Ditto. + (WebCore::SVGAnimatedStaticPropertyTearOff::setBaseVal): Directly updates the stored m_property reference, and invalidates the SVG attributes. + (WebCore::SVGAnimatedStaticPropertyTearOff::setAnimVal): Not implemented. + (WebCore::SVGAnimatedStaticPropertyTearOff::create): + (WebCore::SVGAnimatedStaticPropertyTearOff::SVGAnimatedStaticPropertyTearOff): + * svg/properties/SVGListPropertyTearOff.h: + (WebCore::SVGListPropertyTearOff::commitChange): Share code, use SVGAnimatedProperty::commitChange. + * svg/properties/SVGPropertyTearOff.h: + (WebCore::SVGPropertyTearOff::commitChange): Ditto. + +2010-10-28 MORITA Hajime + + Reviewed by Kent Tamura. + + should be optimum. + https://bugs.webkit.org/show_bug.cgi?id=48613 + + Changed to make the condition inclusive for better case consistently. + - Values on the border between optimum and subsequntial go optimum. + - Values on the border between suboptimal and even-less-than-good go suboptimal. + + Test: fast/dom/HTMLMeterElement/meter-boundary-values.html + + * html/HTMLMeterElement.cpp: + (WebCore::HTMLMeterElement::gaugeRegion): + +2010-10-29 Kenichi Ishibashi + + Reviewed by Kent Tamura. + + [HTML5] Add DOMSettableTokenList + https://bugs.webkit.org/show_bug.cgi?id=47810 + + Adds DOMSettableTokenList interface to support element. + The DOMTokenList interface was refactored since its was tightly coupled + with HTMLElement.classList property. + + * Android.derived.jscbindings.mk: Added JSDOMSettableTokenList.h file. + * Android.derived.v8bindings.mk: Added V8DOMSettableTokenList.h file. + * Android.jscbindings.mk: Added JSDOMSettableTokenList.cpp file. + * Android.mk: Added ClassList.cpp file. + * CMakeLists.txt: Added DOMSettableTokenList.{cpp,idl} and ClassList.cpp files. + * DerivedSources.cpp: Added JSDOMSettableTokenList.cpp file. + * DerivedSources.make: Added DOMSettableTokenList entry. + * GNUmakefile.am: Added JSDOMSettableTokenList.{h,cpp} and ClassList.{h,cpp} files. + * WebCore.gypi: Added DOMSettableTokenList.{h,cpp,idl}, V8DOMSettableTokenListCustom.cpp and ClassList.{h,cpp} files. + * WebCore.pri: Added DOMSettableTokenList.idl file. + * WebCore.pro: Added V8DOMSettableTokenListCustom.cpp, ClassList.{h,cpp} and DOMSettableTokenList.{h,cpp} files. + * WebCore.vcproj/WebCore.vcproj: Added JSDOMSettableTokenList.{h,cpp}, ClassList.{h,cpp} and DOMSettableTokenList.{h,cpp} files. + * WebCore.xcodeproj/project.pbxproj: Added ClassList.{h,cpp}, DOMSettabletokenList.{h,cpp} and JSDOMSettableTokenList.{h,cpp} + * bindings/gobject/GNUmakefile.am: Added WebKitDOMDOMSettableTokenList.{h,cpp} and WebKitDOMDOMSettableTokenListPrivate.cpp files. + * bindings/scripts/CodeGeneratorJS.pm: Modified IndexGetterReturnsStrings() returns 1 for DOMSettableTokenList. + * bindings/v8/custom/V8DOMSettableTokenListCustom.cpp: Added. + (WebCore::V8DOMSettableTokenList::indexedPropertyGetter): + * dom/Element.cpp: Replaced DOMTokenList to ClassList. + (WebCore::Element::classList): + * dom/ElementRareData.h: ditto. + * dom/SpaceSplitString.cpp: Added add() and remove() functions. + (WebCore::SpaceSplitStringData::add): + (WebCore::SpaceSplitStringData::remove): + (WebCore::SpaceSplitString::add): + (WebCore::SpaceSplitString::remove): + * dom/SpaceSplitString.h: Added add() and remove() functions. + * dom/StyledElement.cpp: Replaced DOMTokenList to ClassList. + (WebCore::StyledElement::classAttributeChanged): + * dom/StyledElement.h: ditto. + * html/ClassList.cpp: Added, mostly from original DOMTokenList.cpp. + (WebCore::ClassList::ClassList): + (WebCore::ClassList::ref): + (WebCore::ClassList::deref): + (WebCore::ClassList::length): + (WebCore::ClassList::item): + (WebCore::ClassList::contains): + (WebCore::ClassList::containsInternal): + (WebCore::ClassList::add): + (WebCore::ClassList::addInternal): + (WebCore::ClassList::remove): + (WebCore::ClassList::removeInternal): + (WebCore::ClassList::toggle): + (WebCore::ClassList::toString): + (WebCore::ClassList::reset): + (WebCore::ClassList::classNames): + * html/ClassList.h: Added, mostly from original DOMTokenList.h. + (WebCore::ClassList::create): + (WebCore::ClassList::element): + * html/DOMSettableTokenList.cpp: Added. + (WebCore::DOMSettableTokenList::DOMSettableTokenList): + (WebCore::DOMSettableTokenList::~DOMSettableTokenList): + (WebCore::DOMSettableTokenList::item): + (WebCore::DOMSettableTokenList::contains): + (WebCore::DOMSettableTokenList::add): + (WebCore::DOMSettableTokenList::addInternal): + (WebCore::DOMSettableTokenList::remove): + (WebCore::DOMSettableTokenList::removeInternal): + (WebCore::DOMSettableTokenList::toggle): + (WebCore::DOMSettableTokenList::setValue): + * html/DOMSettableTokenList.h: Added. + (WebCore::DOMSettableTokenList::create): + (WebCore::DOMSettableTokenList::ref): + (WebCore::DOMSettableTokenList::deref): + (WebCore::DOMSettableTokenList::length): + (WebCore::DOMSettableTokenList::toString): + (WebCore::DOMSettableTokenList::value): + * html/DOMSettableTokenList.idl: Added. + * html/DOMTokenList.cpp: Refactored to be an abstract interface for both of ClassList and DOMSettableTokenList. + (WebCore::DOMTokenList::validateToken): Changed to be a static member function of DOMTokenList. + (WebCore::DOMTokenList::addToken): Added, mostly from original DOMTokenList::addInternal(). + (WebCore::DOMTokenList::removeToken): Added, mostly from original DOMTokenList::removeInternal(). + * html/DOMTokenList.h: Refactored to be an abstract interface for both of ClassList and DOMSettableTokenList. + (WebCore::DOMTokenList::~DOMTokenList): + (WebCore::DOMTokenList::element): + * page/DOMWindow.cpp: Added an entry for DOMSettableTokenList. + * page/DOMWindow.idl: ditto. + +2010-10-29 Pavel Feldman + + Reviewed by Timothy Hatcher. + + Web Inspector: make legacy resource tracking optional in the native code, + make cookeis work against new resource manager. + https://bugs.webkit.org/show_bug.cgi?id=48532 + + * inspector/InspectorCSSStore.cpp: + (WebCore::InspectorCSSStore::resourceStyleSheetText): + * inspector/InspectorController.cpp: + (WebCore::InspectorController::InspectorController): + (WebCore::InspectorController::~InspectorController): + (WebCore::InspectorController::connectFrontend): + (WebCore::InspectorController::releaseFrontendLifetimeAgents): + (WebCore::InspectorController::populateScriptObjects): + (WebCore::InspectorController::unbindAllResources): + (WebCore::InspectorController::didCommitLoad): + (WebCore::InspectorController::frameDetachedFromParent): + (WebCore::InspectorController::didLoadResourceFromMemoryCache): + (WebCore::InspectorController::identifierForInitialRequest): + (WebCore::InspectorController::willSendRequest): + (WebCore::InspectorController::markResourceAsCached): + (WebCore::InspectorController::didReceiveResponse): + (WebCore::InspectorController::didReceiveContentLength): + (WebCore::InspectorController::didFinishLoading): + (WebCore::InspectorController::didFailLoading): + (WebCore::InspectorController::resourceRetrievedByXMLHttpRequest): + (WebCore::InspectorController::scriptImported): + (WebCore::InspectorController::setResourceTrackingEnabled): + (WebCore::InspectorController::getCookies): + (WebCore::InspectorController::deleteCookie): + (WebCore::InspectorController::didCreateWebSocket): + (WebCore::InspectorController::willSendWebSocketHandshakeRequest): + (WebCore::InspectorController::didReceiveWebSocketHandshakeResponse): + (WebCore::InspectorController::didCloseWebSocket): + (WebCore::InspectorController::breakpointsSettingKey): + (WebCore::InspectorController::getResourceContent): + * inspector/InspectorController.h: + * inspector/InspectorResource.cpp: + (WebCore::InspectorResource::updateScriptObject): + (WebCore::InspectorResource::markFailed): + * inspector/InspectorResource.h: + * inspector/InspectorResourceAgent.cpp: + (WebCore::populateObjectWithFrameResources): + * inspector/front-end/CookieItemsView.js: + (WebInspector.CookieItemsView.prototype._updateWithCookies): + (WebInspector.CookieItemsView.prototype._filterCookiesForDomain): + * inspector/front-end/Resource.js: + (WebInspector.Resource.prototype._mimeTypeIsConsistentWithType): + (WebInspector.Resource.prototype._checkWarning): + * inspector/front-end/ResourceManager.js: + (WebInspector.ResourceManager.prototype._updateResourceWithResponse): + (WebInspector.ResourceManager.prototype.didFailLoading): + * inspector/front-end/inspector.js: + (WebInspector.forAllResources): + (WebInspector.updateResource): + +2010-10-29 MORITA Hajime + + Unreviewed attempt for fixing build break for http://trac.webkit.org/changeset/70847 + + * editing/EditingAllInOne.cpp: + +2010-10-29 Mihai Parparita + + Reviewed by Adam Barth. + + Support RegExp in V8 implementation of SerializedScriptValue + https://bugs.webkit.org/show_bug.cgi?id=44809 + + Add RegExp serialization/deserialization now that V8 provides API access + to the RegExp type. + + * bindings/v8/SerializedScriptValue.cpp: + (WebCore::ZigZag::Writer::writeRegExp): + (WebCore::ZigZag::Serializer::writeRegExp): + (WebCore::ZigZag::Serializer::doSerialize): + (WebCore::ZigZag::Reader::read): + (WebCore::ZigZag::Reader::readRegExp): + +2010-10-13 MORITA Hajime + + Reviewed by David Hyatt. + + Navigating dark background websites results in blinding white flashes between pages. + https://bugs.webkit.org/show_bug.cgi?id=45640 + + This FOUC is caused by an early layout request before the is ready, + and the page's background style given for , instead of . + So many sites have such stylesheets that we should care them. + + - Some DOM operation such as 'element.offsetLeft' causes page layout. + - The page layout results page repaint + - The page page repaint makes a white screen. because there is nothing to paint + before is available. + + This change: + - extracted existing FOUC check on RenderBlock and RenderLayer to + Document::mayCauseFlashOfUnstyledContent(), + - checked availability on mayCauseFlashOfUnstyledContent(), and + - added FOUC guards before requesting reapint on FrameView. + + No new tests. The data loading speed matters and it cannot be + captured by DRT. + + * dom/Document.cpp: + (WebCore::Document::mayCauseFlashOfUnstyledContent): Added. + * dom/Document.h: + * page/FrameView.cpp: + (WebCore::FrameView::invalidateRect): Added a guard. + (WebCore::FrameView::repaintContentRectangle): Added a guard. + (WebCore::FrameView::doDeferredRepaints): Added a guard. + (WebCore::FrameView::shouldUpdate): Added. + * page/FrameView.h: + * rendering/RenderBlock.cpp: + (WebCore::RenderBlock::paintContents): Replaced FOUC check to use mayCauseFlashOfUnstyledContent + * rendering/RenderLayer.cpp: + (WebCore::RenderLayer::paintLayer): Replaced FOUC check to use mayCauseFlashOfUnstyledContent + +2010-10-29 David Hyatt + + Reviewed by Dan Bernstein. + + https://bugs.webkit.org/show_bug.cgi?id=48618 + + Backgrounds should clip to the border radius properly for vertical lines. The code that does this still assumes horizontal lines. + The testcase to cover this used nested spans, which also exposed a bug in the propagation of the vertical bit through the line + box tree. + + Added fast/blockflow/border-radius-clipping-vertical-lr.html. + + * rendering/RenderBlockLineLayout.cpp: + (WebCore::RenderBlock::createLineBoxes): + * rendering/RenderBoxModelObject.cpp: + (WebCore::RenderBoxModelObject::paintFillLayerExtended): + +2010-10-26 MORITA Hajime + + Reviewed by Kent Tamura. + + Refactoring: Spellchecking related static functions could form a class + https://bugs.webkit.org/show_bug.cgi?id=48287 + + Extracted spellcheck related static functions to TextCheckingHelper class, + which has EditorClient and Range as its member. + + No new tests. Just a refactoring. + + * CMakeLists.txt: + * GNUmakefile.am: + * WebCore.gypi: + * WebCore.pro: + * WebCore.vcproj/WebCore.vcproj: + * WebCore.xcodeproj/project.pbxproj: + * editing/Editor.cpp: + (WebCore::Editor::advanceToNextMisspelling): + (WebCore::Editor::isSelectionUngrammatical): + (WebCore::Editor::guessesForUngrammaticalSelection): + (WebCore::Editor::guessesForMisspelledOrUngrammaticalSelection): + (WebCore::Editor::markMisspellingsAfterTypingToPosition): + (WebCore::Editor::markMisspellingsOrBadGrammar): + (WebCore::Editor::markMisspellings): + (WebCore::Editor::markBadGrammar): + (WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges): + (WebCore::Editor::changeBackToReplacedString): + * editing/Editor.h: + * editing/TextCheckingHelper.cpp: Added. + (WebCore::TextCheckingHelper::TextCheckingHelper): + (WebCore::TextCheckingHelper::~TextCheckingHelper): + (WebCore::TextCheckingHelper::paragraphAlignedRange): + (WebCore::TextCheckingHelper::findFirstMisspelling): + (WebCore::TextCheckingHelper::findFirstMisspellingOrBadGrammar): + (WebCore::TextCheckingHelper::findFirstGrammarDetail): + (WebCore::TextCheckingHelper::findFirstBadGrammar): + (WebCore::TextCheckingHelper::isUngrammatical): + (WebCore::TextCheckingHelper::guessesForMisspelledOrUngrammaticalRange): + (WebCore::TextCheckingHelper::markAllMisspellings): + (WebCore::TextCheckingHelper::markAllBadGrammar): + * editing/TextCheckingHelper.h: Added. + +2010-10-28 Adam Barth + + Reviewed by Eric Seidel, Peter Kasting, and Darin Fisher. + (Eric reviewed the CoreGraphics interactions, Peter reviewed the image + decoder interaction, and Darin Fisher SGTMed the policy decision.) + + [chromium] Chromium Mac should use WebKit's image decoders + https://bugs.webkit.org/show_bug.cgi?id=47974 + + This patch teaches WebKit's image decoders how to talk to CoreGraphics. + This patch doesn't handle color profiles, but that will come in a + subsequent patch. + + * WebCore.gyp/WebCore.gyp: + * WebCore.gypi: + * loader/CachedImage.cpp: + (WebCore::CachedImage::createImage): + * platform/graphics/ImageSource.h: + * platform/image-decoders/ImageDecoder.cpp: + (WebCore::RGBA32Buffer::clear): + (WebCore::RGBA32Buffer::zeroFill): + (WebCore::RGBA32Buffer::copyBitmapData): + (WebCore::RGBA32Buffer::setSize): + * platform/image-decoders/ImageDecoder.h: + (WebCore::RGBA32Buffer::getAddr): + * platform/image-decoders/cg: Added. + * platform/image-decoders/cg/ImageDecoderCG.cpp: Added. + (WebCore::RGBA32Buffer::copyBitmapData): + (WebCore::RGBA32Buffer::setSize): + (WebCore::RGBA32Buffer::asNewNativeImage): + +2010-10-28 Sergio Villar Senin + + Reviewed by Xan Lopez. + + [GTK] GObject bindings generator issues + https://bugs.webkit.org/show_bug.cgi?id=48135 + + GObject code generator must not generate conditional API's. This + patch also adds an alternative return value for non-void + conditional methods. With this change the conditionalMethods hack + is no longer needed. + + * bindings/scripts/CodeGeneratorGObject.pm: + +2010-10-28 David Hyatt + + Reviewed by Dan Bernstein. + + https://bugs.webkit.org/show_bug.cgi?id=48569 + + Box shadows on vertical inlines don't paint properly. Fix the paintBoxShadow method to treat the edges to include as + logical (so that top/bottom are used instead of left/right for vertical lines). In order to make my box-shadow tests + work I had to fix a bug in the transform code of InlineTextBox that was causing the baselines of vertical lines to + be wrong. + + Added fast/blockflow/box-shadow-* tests + + * rendering/InlineTextBox.cpp: + (WebCore::InlineTextBox::paint): + * rendering/RenderBoxModelObject.cpp: + (WebCore::RenderBoxModelObject::paintBoxShadow): + * rendering/RenderBoxModelObject.h: + +2010-10-28 James Robinson + + Reviewed by Simon Fraser. + + iframes forced into slow scrolling mode by containing RenderLayer sometimes + https://bugs.webkit.org/show_bug.cgi?id=48570 + + Only performs the overlap test for RenderLayers that paint themselves. This + prevents marking RenderWidgets as being overlapped unnecessarily. + + Test: fast/repaint/iframe-scroll-repaint.html + + * rendering/RenderLayer.cpp: + (WebCore::RenderLayer::paintLayer): + +2010-10-28 Sheriff Bot + + Unreviewed, rolling out r70814. + http://trac.webkit.org/changeset/70814 + https://bugs.webkit.org/show_bug.cgi?id=48612 + + Caused media/controls-drag-timebar.html to fail on multiple + platforms (Requested by aroben on #webkit). + + * html/HTMLMediaElement.cpp: + (WebCore::HTMLMediaElement::seek): + * platform/graphics/MediaPlayer.cpp: + * platform/graphics/MediaPlayer.h: + * platform/graphics/MediaPlayerPrivate.h: + * platform/graphics/mac/MediaPlayerPrivateQTKit.h: + * platform/graphics/mac/MediaPlayerPrivateQTKit.mm: + * platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.cpp: + * platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.h: + * platform/graphics/win/QTMovie.cpp: + * platform/graphics/win/QTMovie.h: + +2010-10-28 Dan Bernstein + + Reviewed by Simon Fraser. + + Crash triggered by incremental layout of block truncated by line-clamp + https://bugs.webkit.org/show_bug.cgi?id=48602 + + Test: fast/flexbox/line-clamp-crash.html + + * rendering/RenderFlexibleBox.cpp: + (WebCore::RenderFlexibleBox::applyLineClamp): Even if the child needs layout, call clearTruncation(), + since layout itself may be partial and not touch the truncated line (but touch its markup box). + +2010-10-28 Jian Li + + Reviewed by Dmitry Titov. + + [chromium] UUID generation does not work in Linux that has sandbox + turned on + https://bugs.webkit.org/show_bug.cgi?id=48571 + + This is because we cannot access /proc when sandbox is on. The fix is to + use random numbers to construct UUID. + + * platform/UUID.cpp: + (WebCore::createCanonicalUUIDString): + +2010-10-28 Jia Pu + + Reviewed by Dan Bernstein. + + Editing a word with misspell or autocorrection underline should remove the underline when the editing changes the word. + https://bugs.webkit.org/show_bug.cgi?id=48078 + + + Tests: platform/mac/editing/spelling/editing-multiple-words-with-markers.html + platform/mac/editing/spelling/editing-word-with-marker-1.html + platform/mac/editing/spelling/editing-word-with-marker-2.html + + This patch is part of on-going improvement of autocorrection feature on Mac OS X. When an editing + occurs, if it affects words (by deleting/inserting characters, spliting word, merging words) that + have Spelling and/or CorrectionIndicator markers, we want to remove the markers. If subsequntial + spelling checking finds spelling error in newlly formed words, it will add the markers back in. + + * dom/DocumentMarker.h: Changed MarkerType to bit masks to make search multiple types easier. + + * dom/DocumentMarkerController.cpp: Refactored two removeMarkers() methods to support remove + markers with specific type from a node. + (WebCore::DocumentMarkerController::removeMarkers): Changed signature to remove marker with specific type. + (WebCore::DocumentMarkerController::removeMarkersFromMarkerMapVectorPair): Refactoring. + (WebCore::DocumentMarkerController::hasMarkers): Convenience method to search markers in range. + + * dom/DocumentMarkerController.h: Added new methods and matched new signature of removeMarkers(). + + * editing/Editor.cpp: + (WebCore::Editor::respondToChangedContents): Remove existing markers if the change formed new word. + (WebCore::Editor::cut): Remove markers on words that will be modified by this editing. + (WebCore::Editor::paste): Ditto. + (WebCore::Editor::pasteAsPlainText): Ditto. + (WebCore::Editor::removeSpellAndCorrectionMarkersFromWordsToBeEdited): Main logic for removing + markers on words affected by editing. + + * editing/Editor.h: Added removeSpellAndCorrectionMarkersFromWordsToBeEdited(). Added + REMOVE_MARKERS_UPON_EDITING and SUPPORT_AUTOCORRECTION_PANEL macro to improve readability. + + * editing/TypingCommand.cpp: + (WebCore::TypingCommand::insertText): Remove markers on words that will be modified by this editing. + (WebCore::TypingCommand::deleteKeyPressed): Ditto. + (WebCore::TypingCommand::forwardDeleteKeyPressed): Ditto. + +2010-10-28 Brian Weinstein + + Reviewed by Brady Eidson. + + Part of + userscripts/user-script-*-document.html tests are flaky on Windows + + In WebFrameLoaderClient::committedLoad on Windows, we call through to PluginStream::didRecieveData + if our manual loader is a plugin stream, and we can call didRecieveData with a 0 length. + + We shouldn't ASSERT that length is 0, because code paths exists where we call it with a 0 length. + + This is tested by re-enabling user-script-plugin-document.html on Windows. + + * plugins/PluginStream.cpp: + (WebCore::PluginStream::didReceiveData): + +2010-10-28 Mihai Parparita + + Reviewed by Darin Adler. + + [Chromium] History related tests REGRESSED after r70723 + https://bugs.webkit.org/show_bug.cgi?id=48513 + + Remove backItem(), forwardItem() and currentItem() from the Chromium + BackForwardList implementation, since they can use the base class + behavior now (which call itemAtIndex with -1, 1, and 0 respectively). + + * history/BackForwardList.h: + * history/BackForwardListChromium.cpp: + +2010-10-28 Ryosuke Niwa + + Reviewed by Tony Chang. + + chrome.dll!WebCore::Node::shadowAncestorNode ReadAV@NULL (98643190851b5662363449cc7303d8a5) + https://bugs.webkit.org/show_bug.cgi?id=47888 + + The crash was caused by the while loop in ApplyStyleCommand::fixRangeAndApplyInlineStyle + not considering the case where startNode is the root editable element. + Fixed the bug by not entering the loop when startNode is the editable root. + + Test: editing/style/fix-range-from-root-editable-crash.html + + * editing/ApplyStyleCommand.cpp: + (WebCore::ApplyStyleCommand::fixRangeAndApplyInlineStyle): + +2010-10-28 Noam Rosenthal + + Reviewed by Ariya Hidayat. + + [Texmap] [Qt] Texture mapper initial implementation + https://bugs.webkit.org/show_bug.cgi?id=47070 + + Build fix, some wrong changes slipped into the previous patch. + No new tests: build fix. + + * platform/graphics/GraphicsLayer.h: + * platform/graphics/opengl/TextureMapperGL.cpp: + (WebCore::BitmapTextureGL::setContentsToImage): + * platform/graphics/texmap/GraphicsLayerTextureMapper.cpp: + (WebCore::TextureMapperNode::uploadTextureFromContent): + (WebCore::TextureMapperNode::paintRecursive): + * platform/qt/QWebPageClient.h: + (QWebPageClient::setRootGraphicsLayer): + +2010-10-28 David Hyatt + + Reviewed by James Robinson. + + https://bugs.webkit.org/show_bug.cgi?id=48568 + + Backgrounds don't work right with vertical RenderInlines. Make background painting + do the right thing for vertical strips. + + Added fast/blockflow/background-* tests + + * rendering/InlineFlowBox.cpp: + (WebCore::InlineFlowBox::paintFillLayer): + +2010-10-28 Eric Carlson + + Reviewed by Adam Roben. + + Seeking by very small increment doesn't generate 'seeked' event + https://bugs.webkit.org/show_bug.cgi?id=48530 + + Test: media/video-seek-by-small-increment.html + + * html/HTMLMediaElement.cpp: + (WebCore::HTMLMediaElement::seek): Ask the media engine for its closest time value so we can + avoid asking it to seek to the current time. + + * platform/graphics/MediaPlayer.cpp: + (WebCore::MediaPlayer::mediaTimeForTimeValue): New. + * platform/graphics/MediaPlayer.h: + * platform/graphics/MediaPlayerPrivate.h: + (WebCore::MediaPlayerPrivateInterface::mediaTimeForTimeValue): Ditto. + + * platform/graphics/mac/MediaPlayerPrivateQTKit.h: + * platform/graphics/mac/MediaPlayerPrivateQTKit.mm: + (WebCore::MediaPlayerPrivate::mediaTimeForTimeValue): Return the closest value in the movie's time scale. + + * platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.cpp: + (WebCore::MediaPlayerPrivateQuickTimeVisualContext::mediaTimeForTimeValue): Ditto + * platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.h: + + * platform/graphics/win/QTMovie.cpp: + (QTMovie::timeScale): Return the movie's time scale. + * platform/graphics/win/QTMovie.h: + +2010-10-28 David Hyatt + + Reviewed by Beth Dakin. + + https://bugs.webkit.org/show_bug.cgi?id=48443 + + Border images don't work right with vertical RenderInlines. Make border/mask/background painting + do the right thing for vertical strips. + + Added fast/blockflow/border-image-* tests. + + * rendering/InlineFlowBox.cpp: + (WebCore::InlineFlowBox::paintBoxDecorations): + (WebCore::InlineFlowBox::paintMask): + +2010-10-28 Patrick Gansterer + + Reviewed by Adam Roben. + + Port ContextMenuItemWin.cpp to WinCE + https://bugs.webkit.org/show_bug.cgi?id=48407 + + * platform/win/ContextMenuItemWin.cpp: + +2010-10-28 Ryosuke Niwa + + Reviewed by Darin Adler. + + queryCommandValue should fall back to queryCommandState + https://bugs.webkit.org/show_bug.cgi?id=48479 + + Added a fallback to Command::value so that commands with a state function without a value function + returns the value returned by the state function as a string. + + * editing/EditorCommand.cpp: + (WebCore::Editor::Command::value): + +2010-10-28 Pavel Feldman + + Not reviewed. Rolling out r70800. + +2010-10-28 Alexey Proskuryakov + + Reviewed by Dan Bernstein. + + https://bugs.webkit.org/show_bug.cgi?id=48551 + HTMLDocument::isFrameSet() should not depend on renderer + + No change in functionality, so no new tests. + + * html/HTMLDocument.cpp: (WebCore::HTMLDocument::isFrameSet): Omit the check for renderer. + + * rendering/RenderLayer.h: Removed unneeded includes and forward declarations. + +2010-10-28 Pavel Feldman + + Reviewed by Timothy Hatcher. + + Web Inspector: make legacy resource tracking optional in the native code, + make cookeis work against new resource manager. + https://bugs.webkit.org/show_bug.cgi?id=48532 + + * inspector/InspectorCSSStore.cpp: + (WebCore::InspectorCSSStore::resourceStyleSheetText): + * inspector/InspectorController.cpp: + (WebCore::InspectorController::InspectorController): + (WebCore::InspectorController::~InspectorController): + (WebCore::InspectorController::connectFrontend): + (WebCore::InspectorController::releaseFrontendLifetimeAgents): + (WebCore::InspectorController::populateScriptObjects): + (WebCore::InspectorController::unbindAllResources): + (WebCore::InspectorController::didCommitLoad): + (WebCore::InspectorController::frameDetachedFromParent): + (WebCore::InspectorController::didLoadResourceFromMemoryCache): + (WebCore::InspectorController::identifierForInitialRequest): + (WebCore::InspectorController::willSendRequest): + (WebCore::InspectorController::markResourceAsCached): + (WebCore::InspectorController::didReceiveResponse): + (WebCore::InspectorController::didReceiveContentLength): + (WebCore::InspectorController::didFinishLoading): + (WebCore::InspectorController::didFailLoading): + (WebCore::InspectorController::resourceRetrievedByXMLHttpRequest): + (WebCore::InspectorController::scriptImported): + (WebCore::InspectorController::setResourceTrackingEnabled): + (WebCore::InspectorController::getCookies): + (WebCore::InspectorController::deleteCookie): + (WebCore::InspectorController::didCreateWebSocket): + (WebCore::InspectorController::willSendWebSocketHandshakeRequest): + (WebCore::InspectorController::didReceiveWebSocketHandshakeResponse): + (WebCore::InspectorController::didCloseWebSocket): + (WebCore::InspectorController::breakpointsSettingKey): + (WebCore::InspectorController::getResourceContent): + * inspector/InspectorController.h: + * inspector/InspectorResource.cpp: + (WebCore::InspectorResource::updateScriptObject): + (WebCore::InspectorResource::markFailed): + * inspector/InspectorResource.h: + * inspector/InspectorResourceAgent.cpp: + (WebCore::populateObjectWithFrameResources): + * inspector/front-end/Resource.js: + (WebInspector.Resource.prototype._mimeTypeIsConsistentWithType): + * inspector/front-end/ResourceManager.js: + (WebInspector.ResourceManager.prototype._updateResourceWithResponse): + (WebInspector.ResourceManager.prototype.didFailLoading): + * inspector/front-end/inspector.js: + (WebInspector.updateResource): + +2010-10-28 Pavel Podivilov + + Reviewed by Pavel Feldman. + + Web Inspector: fix pausing on next JavaScript statement + https://bugs.webkit.org/show_bug.cgi?id=48534 + + * inspector/InspectorDebuggerAgent.cpp: + (WebCore::InspectorDebuggerAgent::InspectorDebuggerAgent): + (WebCore::InspectorDebuggerAgent::schedulePauseOnNextStatement): + (WebCore::InspectorDebuggerAgent::cancelPauseOnNextStatement): + (WebCore::InspectorDebuggerAgent::pause): + (WebCore::InspectorDebuggerAgent::didPause): + * inspector/InspectorDebuggerAgent.h: + +2010-10-28 Yuzo Fujishima + + Reviewed by David Hyatt. + + Fix for Bug 14550 - Non-layout style change does not update nested first-letter + https://bugs.webkit.org/show_bug.cgi?id=14550 + + If a render text fragment is accompanied by a first letter, update the + first letter's style when the fragment's style is changed. + + Test: fast/css/first-letter-nested.html + + * rendering/RenderBlock.cpp: + (WebCore::RenderBlock::styleDidChange): Stop calling updateFirstLetter + from here. + * rendering/RenderBlock.h: Make updateFirstLetter accessbile from + RenderTextFragment. + * rendering/RenderTextFragment.cpp: + (WebCore::RenderTextFragment::styleDidChange): If appropriate, update + first letter after removing stale cached pseudo style. + (WebCore::RenderTextFragment::blockForAccompanyingFirstLetter): Helper + to get the block for the first letter. + * rendering/RenderTextFragment.h: + * rendering/style/RenderStyle.cpp: + (WebCore::RenderStyle::removeCachedPseudoStyle): Remove the specified + pseudo style from cache. + * rendering/style/RenderStyle.h: + +2010-10-28 Benoit Jacob + + Reviewed by Kenneth Russell. + + Ensure that WebGL stencil buffers are correctly initialized + https://bugs.webkit.org/show_bug.cgi?id=48351 + + * html/canvas/WebGLFramebuffer.cpp: + (WebCore::WebGLFramebuffer::initializeRenderbuffers): + +2010-10-28 Chris Fleizach + + Reviewed by Adele Peterson. + + AX: multi select group option does not handle setting of AXSelectedChildren correctly + https://bugs.webkit.org/show_bug.cgi?id=48464 + + Ensure that when selecting an item from a