From c7d0c5294bbef1855c84c8072058813371f1af16 Mon Sep 17 00:00:00 2001 From: Steve Block Date: Wed, 16 Dec 2009 12:57:38 +0000 Subject: Fixes a Geolocation bug with cached positions. In the case where a watch request returns a cached position, we must clear the cached position to prevent it from being used repeatedly in the case where the watch timer later fires. Also cleans up some code and adds some comments. This will be upstreamed to webkit.org in https://bugs.webkit.org/show_bug.cgi?id=30676 Change-Id: I4968731453c3dfd34a8d3466fdaee91d4c4158be --- WebCore/platform/android/GeolocationServiceAndroid.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'WebCore/platform') diff --git a/WebCore/platform/android/GeolocationServiceAndroid.cpp b/WebCore/platform/android/GeolocationServiceAndroid.cpp index d44b3f0..43a8f5f 100644 --- a/WebCore/platform/android/GeolocationServiceAndroid.cpp +++ b/WebCore/platform/android/GeolocationServiceAndroid.cpp @@ -92,7 +92,7 @@ bool GeolocationServiceAndroid::startUpdating(PositionOptions* options) void GeolocationServiceAndroid::stopUpdating() { // Called when the Geolocation object has no watches or one shots in - // progress. + // progress. This may be called repeatedly. m_javaBridge.clear(); // Reset last position and error to make sure that we always try to get a // new position from the system service when a request is first made. -- cgit v1.1