From d9975bf008036e4a597df404b62d0722645ba75c Mon Sep 17 00:00:00 2001 From: Mike Reed Date: Thu, 25 Feb 2010 17:07:06 -0500 Subject: make methods private (or static local) if possible to reduce surface area of API --- WebCore/platform/graphics/android/LayerAndroid.cpp | 10 +++++----- WebCore/platform/graphics/android/LayerAndroid.h | 3 +-- 2 files changed, 6 insertions(+), 7 deletions(-) (limited to 'WebCore/platform') diff --git a/WebCore/platform/graphics/android/LayerAndroid.cpp b/WebCore/platform/graphics/android/LayerAndroid.cpp index 0dedd64..9bd5a78 100644 --- a/WebCore/platform/graphics/android/LayerAndroid.cpp +++ b/WebCore/platform/graphics/android/LayerAndroid.cpp @@ -197,11 +197,11 @@ void LayerAndroid::bounds(SkRect* rect) const rect->fBottom = rect->fTop + size.height(); } -bool LayerAndroid::boundsIsUnique(SkTDArray* region, - const SkRect& local) const +static bool boundsIsUnique(const SkTDArray& region, + const SkRect& local) { - for (int i = 0; i < region->count(); i++) { - if ((*region)[i].contains(local)) + for (int i = 0; i < region.count(); i++) { + if (region[i].contains(local)) return false; } return true; @@ -223,7 +223,7 @@ void LayerAndroid::clipInner(SkTDArray* region, localBounds.intersect(local); if (localBounds.isEmpty()) return; - if (m_recordingPicture && boundsIsUnique(region, localBounds)) + if (m_recordingPicture && boundsIsUnique(*region, localBounds)) *region->append() = localBounds; for (int i = 0; i < countChildren(); i++) getChild(i)->clipInner(region, m_haveClip ? localBounds : local); diff --git a/WebCore/platform/graphics/android/LayerAndroid.h b/WebCore/platform/graphics/android/LayerAndroid.h index 4f8a5fe..940c4d6 100644 --- a/WebCore/platform/graphics/android/LayerAndroid.h +++ b/WebCore/platform/graphics/android/LayerAndroid.h @@ -130,7 +130,6 @@ public: */ void updatePositions(const SkRect& viewPort); - void bounds(SkRect* ) const; void clipArea(SkTDArray* region) const; const LayerAndroid* find(int x, int y) const; const LayerAndroid* findById(int uniqueID) const; @@ -144,8 +143,8 @@ protected: virtual void onDraw(SkCanvas*, SkScalar opacity); private: + void bounds(SkRect* ) const; bool prepareContext(bool force = false); - bool boundsIsUnique(SkTDArray* region, const SkRect& local) const; void clipInner(SkTDArray* region, const SkRect& local) const; bool m_isRootLayer; -- cgit v1.1