From 6f9b8a1745fc174f1c436237dde772fca8e47f06 Mon Sep 17 00:00:00 2001 From: Leon Scroggins Date: Wed, 28 Oct 2009 14:25:19 -0400 Subject: do not merge -- Fix a clicking bug. original at https://android-git.corp.google.com/g/#change,31300 Remove some code that simulates a mouse click at the beginning of a textarea and the end of a textfield. The original goal was to make the click change the selection to be at the beginning or end of the field, respectively. However, we actually make another call which prevents this click from the selection. Further, the selection actually gets changed elsewhere. Fixes http://b/issue?id=2219233 --- WebKit/android/nav/CachedRoot.cpp | 9 --------- 1 file changed, 9 deletions(-) (limited to 'WebKit/android') diff --git a/WebKit/android/nav/CachedRoot.cpp b/WebKit/android/nav/CachedRoot.cpp index 9fdd5dc..38417b1 100644 --- a/WebKit/android/nav/CachedRoot.cpp +++ b/WebKit/android/nav/CachedRoot.cpp @@ -878,15 +878,6 @@ void CachedRoot::getSimulatedMousePosition(WebCore::IntPoint* point) const int height = mouseBounds.height(); point->setX(x + (width >> 1)); // default to box center point->setY(y + (height >> 1)); - const CachedNode* cursor = currentCursor(); - if (cursor && cursor->bounds().contains(mHistory->mMouseBounds)) { - if (cursor->isTextField()) // if text field, return end of line - point->setX(x + width - 1); - else if (cursor->isTextArea()) { // if text area, return start - point->setX(x + 1); - point->setY(y + 1); - } - } #if DEBUG_NAV_UI const WebCore::IntRect& navBounds = mHistory->mNavBounds; DBG_NAV_LOGD("mHistory->mNavBounds={%d,%d,%d,%d} " -- cgit v1.1