From 643ca7872b450ea4efacab6188849e5aac2ba161 Mon Sep 17 00:00:00 2001 From: Steve Block Date: Tue, 15 Dec 2009 10:12:09 +0000 Subject: Merge webkit.org at r51976 : Initial merge by git. Change-Id: Ib0e7e2f0fb4bee5a186610272edf3186f0986b43 --- WebKit/cf/WebCoreSupport/WebInspectorClientCF.cpp | 83 ++--------------------- 1 file changed, 7 insertions(+), 76 deletions(-) (limited to 'WebKit/cf/WebCoreSupport/WebInspectorClientCF.cpp') diff --git a/WebKit/cf/WebCoreSupport/WebInspectorClientCF.cpp b/WebKit/cf/WebCoreSupport/WebInspectorClientCF.cpp index 600d58d..cb47205 100644 --- a/WebKit/cf/WebCoreSupport/WebInspectorClientCF.cpp +++ b/WebKit/cf/WebCoreSupport/WebInspectorClientCF.cpp @@ -64,7 +64,7 @@ static inline CFStringRef createKeyForPreferences(const String& key) return CFStringCreateWithFormat(0, 0, CFSTR("WebKit Web Inspector Setting - %@"), keyCFString.get()); } -void WebInspectorClient::populateSetting(const String& key, InspectorController::Setting& setting) +void WebInspectorClient::populateSetting(const String& key, String* setting) { RetainPtr preferencesKey(AdoptCF, createKeyForPreferences(key)); RetainPtr value(AdoptCF, CFPreferencesCopyAppValue(preferencesKey.get(), kCFPreferencesCurrentApplication)); @@ -74,88 +74,19 @@ void WebInspectorClient::populateSetting(const String& key, InspectorController: CFTypeID type = CFGetTypeID(value.get()); if (type == CFStringGetTypeID()) - setting.set(static_cast(static_cast(value.get()))); + *setting = static_cast(static_cast(value.get())); else if (type == CFBooleanGetTypeID()) - setting.set(static_cast(CFBooleanGetValue(static_cast(value.get())))); - else if (type == CFNumberGetTypeID()) { - CFNumberRef number = static_cast(value.get()); - if (CFNumberIsFloatType(number)) { - double doubleNumber = 0.0; - CFNumberGetValue(static_cast(value.get()), kCFNumberDoubleType, &doubleNumber); - setting.set(doubleNumber); - } else { - long longNumber = 0; - CFNumberGetValue(static_cast(value.get()), kCFNumberLongType, &longNumber); - setting.set(longNumber); - } - } else if (type == CFArrayGetTypeID()) { - Vector strings; - - CFArrayRef array = static_cast(value.get()); - unsigned length = CFArrayGetCount(array); - for (unsigned i = 0; i < length; ++i) { - CFStringRef string = static_cast(CFArrayGetValueAtIndex(array, i)); - if (CFGetTypeID(string) == CFStringGetTypeID()) - strings.append(static_cast(static_cast(string))); - } - - setting.set(strings); - } else - ASSERT_NOT_REACHED(); + *setting = static_cast(CFBooleanGetValue(static_cast(value.get()))) ? "true" : "false"; + else + *setting = ""; } -void WebInspectorClient::storeSetting(const String& key, const InspectorController::Setting& setting) +void WebInspectorClient::storeSetting(const String& key, const String& setting) { RetainPtr objectToStore; - - switch (setting.type()) { - default: - case InspectorController::Setting::NoType: - ASSERT_NOT_REACHED(); - break; - case InspectorController::Setting::StringType: - objectToStore.adoptCF(setting.string().createCFString()); - break; - case InspectorController::Setting::BooleanType: - objectToStore = (setting.booleanValue() ? kCFBooleanTrue : kCFBooleanFalse); - break; - - case InspectorController::Setting::DoubleType: { - double value = setting.doubleValue(); - objectToStore.adoptCF(CFNumberCreate(0, kCFNumberDoubleType, &value)); - break; - } - - case InspectorController::Setting::IntegerType: { - long value = setting.integerValue(); - objectToStore.adoptCF(CFNumberCreate(0, kCFNumberLongType, &value)); - break; - } - - case InspectorController::Setting::StringVectorType: { - const Vector& strings = setting.stringVector(); - const unsigned length = strings.size(); - - RetainPtr array(AdoptCF, CFArrayCreateMutable(0, length, &kCFTypeArrayCallBacks)); - - for (unsigned i = 0; i < length; ++i) { - RetainPtr string(AdoptCF, strings[i].createCFString()); - CFArraySetValueAtIndex(array.get(), i, string.get()); - } - - objectToStore = array; - break; - } - } - + objectToStore.adoptCF(setting.createCFString()); ASSERT(objectToStore); RetainPtr preferencesKey(AdoptCF, createKeyForPreferences(key)); CFPreferencesSetAppValue(preferencesKey.get(), objectToStore.get(), kCFPreferencesCurrentApplication); } - -void WebInspectorClient::removeSetting(const String& key) -{ - RetainPtr preferencesKey(AdoptCF, createKeyForPreferences(key)); - CFPreferencesSetAppValue(preferencesKey.get(), 0, kCFPreferencesCurrentApplication); -} -- cgit v1.1