2011-02-13 Mark Rowe Reviewed by Maciej Stachowiak. WebCoreAuthenticationClientAsChallengeSender doesn't implement some necessary methods. * platform/network/mac/AuthenticationMac.mm: (-[WebCoreAuthenticationClientAsChallengeSender performDefaultHandlingForAuthenticationChallenge:]): (-[WebCoreAuthenticationClientAsChallengeSender rejectProtectionSpaceAndContinueWithChallenge:]): 2011-02-13 Simon Fraser Reviewed by Andreas Kling. Repeating gradients drawn incorrectly https://bugs.webkit.org/show_bug.cgi?id=53502 The 'forward-fill' logic for repeating gradients used the wrong starting stop index (0 rather than the original first index), which resulted in incorrect gradients if backwards-fill had already been applied. Test: fast/gradients/css3-repeating-end-fill.html * css/CSSGradientValue.cpp: (WebCore::CSSGradientValue::addStops): 2011-02-13 Benjamin Poulain Reviewed by Andreas Kling. Unused variable result in RenderBlock::addOverflowFromFloats() https://bugs.webkit.org/show_bug.cgi?id=54363 Remove the unused variable. * rendering/RenderBlock.cpp: (WebCore::RenderBlock::addOverflowFromFloats): 2011-02-13 Cameron Zwarich Reviewed by Anders Carlsson. WebCore fails to build with Clang's -Woverloaded-virtual https://bugs.webkit.org/show_bug.cgi?id=54367 * loader/PingLoader.h: (WebCore::PingLoader::didReceiveData): Change the method signature to match the signature in the base class. 2011-02-13 Nico Weber Reviewed by Anders Carlsson. RenderBR::width() tries but fails to override RenderText::width() https://bugs.webkit.org/show_bug.cgi?id=54301 The superclass method's signature changed, e.g. in http://trac.webkit.org/changeset/57215, but the subclass was not updated. * rendering/RenderBR.h: (WebCore::RenderBR::width): 2011-02-13 Andreas Kling Reviewed by Dirk Schulze. Canvas: 2d.fillStyle.parse.system.html fails https://bugs.webkit.org/show_bug.cgi?id=39168 Based on previous work by Julien Chaffraix and Jan Erik Hanssen * css/CSSParser.cpp: (WebCore::CSSParser::parseColor): Changed the function to better match our early return policy. Also we now return false when we don't parse the color. This is needed for createFromString to fallback to using parseSystemColor. (WebCore::CSSParser::parseSystemColor): Made use of the RenderTheme to get the system colors. * css/CSSParser.h: Added the new parseSystemColor method. * html/canvas/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::setStrokeColor): Pass the document to createFromString. (WebCore::CanvasRenderingContext2D::setFillColor): Ditto. * html/canvas/CanvasStyle.cpp: (WebCore::parseColor): (WebCore::parseColorOrCurrentColor): (WebCore::CanvasStyle::createFromString): Try to parse the color using CSSParser::parseColor and fall back to parseSystemColor if it did not work. * html/canvas/CanvasStyle.h: Added the new Document* parameter to createFromString. 2011-02-13 Jeremy Moskovich Reviewed by Adam Barth. Add a compile-time option to completely disable WebArchive support. https://bugs.webkit.org/show_bug.cgi?id=52712 Add an ENABLE(WEB_ARCHIVE) compile-time setting and use it for all WebArchive code. ArchiveResource and ArchiveResourceCollection are notably still compiled in. They are used in Safari for functionality such as "Save Image As" and Image copy & paste independent of WebArchive support. Ports Affected: WebArchive support is currently enabled for all ports that define PLATFORM(CF) apart from Qt. This patch preserves this behavior except that it also disables support in the Chromium port. No behavior changes so no new tests. * WebCore.gyp/WebCore.gyp: Don't compile LegacyWebArchive.cpp and friends. * WebCore.pro: Don't compile ArchiveFactory.cpp in Qt port. * loader/DocumentLoader.cpp: Surround WebArchive code with #ifdef. (WebCore::DocumentLoader::commitLoad): (WebCore::DocumentLoader::setupForReplaceByMIMEType): (WebCore::DocumentLoader::archiveResourceForURL): * loader/DocumentLoader.h: * loader/FrameLoader.cpp: (WebCore::FrameLoader::loadURLIntoChildFrame): (WebCore::FrameLoader::stopAllLoaders): (WebCore::FrameLoader::finishedLoadingDocument): * loader/FrameLoader.h: * loader/ResourceLoader.cpp: (WebCore::ResourceLoader::start): * loader/archive/ArchiveFactory.cpp: Remove #ifdef since feature is now enabled/disabled wholesale. (WebCore::archiveMIMETypes): * page/Settings.cpp: * page/Settings.h: * platform/MIMETypeRegistry.cpp: (WebCore::initializeSupportedNonImageMimeTypes): 2011-02-13 Aparna Nandyal Reviewed by Andreas Kling. [Qt] QtWebKit does not properly handle D&D of a percent-encoded URL. https://bugs.webkit.org/show_bug.cgi?id=53320 The encoding that was done is corrected in the fix. Replaced the KURL encoding function with QUrl API. * platform/qt/DragDataQt.cpp: (WebCore::DragData::asURL): 2011-02-13 Leo Yang Reviewed by Andreas Kling. Unnecessary call of containingBlock() in RenderBoxModelObject::relativePositionOffsetX() https://bugs.webkit.org/show_bug.cgi?id=54351 We were calling containingBlock() twice if the left is not auto. We only need to call it once because we can use 'cb' variable in the following line. No functionality change, no new tests. * rendering/RenderBoxModelObject.cpp: (WebCore::RenderBoxModelObject::relativePositionOffsetX): 2011-02-13 Jarred Nicholls Reviewed by Simon Fraser. getComputedStyle returns wrong value for margin-right https://bugs.webkit.org/show_bug.cgi?id=13343 Matching IE, Firefox, and Opera behavior by returning the computed margin values as specified, rather than the used/auto values (calculated via RenderBox). Also CSS 2.1+ compliant by returning margin percentage as specified, if applicable. Note: Firefox and Opera return calculated fixed lengths for percentage margins, IE returns the specified percentage. Tests: fast/css/getComputedStyle/getComputedStyle-margin-auto.html fast/css/getComputedStyle/getComputedStyle-margin-length.html fast/css/getComputedStyle/getComputedStyle-margin-percentage.html * css/CSSComputedStyleDeclaration.cpp: (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): 2011-02-13 Adam Barth Reviewed by Sam Weinig. crypto.getRandomValues should throw TYPE_MISMATCH_ERR https://bugs.webkit.org/show_bug.cgi?id=54346 As requested by Sam. * page/Crypto.cpp: (WebCore::Crypto::getRandomValues): 2011-02-13 Alexey Proskuryakov Reviewed by Dan Bernstein. https://bugs.webkit.org/show_bug.cgi?id=54349 Inline some accessors in PrintContext No change in behavior, so no tests. * WebCore.exp.in: * page/PrintContext.cpp: * page/PrintContext.h: (WebCore::PrintContext::pageCount): (WebCore::PrintContext::pageRect): Inline pageCount() and pageRect() to match pageRects(). 2011-02-13 Sam Weinig Roll r78424 [Extra scrolling required when scrolling with a scroll wheel (Mighty Mouse)] back in with fixes to make it work with render layers. * platform/mac/ScrollAnimatorMac.h: * platform/mac/ScrollAnimatorMac.mm: (WebCore::ScrollAnimatorMac::scrollToOffsetWithoutAnimation): (WebCore::ScrollAnimatorMac::adjustScrollXPositionIfNecessary): (WebCore::ScrollAnimatorMac::adjustScrollYPositionIfNecessary): (WebCore::ScrollAnimatorMac::adjustScrollPositionIfNecessary): (WebCore::ScrollAnimatorMac::immediateScrollToPoint): (WebCore::ScrollAnimatorMac::immediateScrollByDeltaX): (WebCore::ScrollAnimatorMac::immediateScrollByDeltaY): * rendering/RenderLayer.cpp: (WebCore::RenderLayer::RenderLayer): (WebCore::RenderLayer::contentsSize): (WebCore::RenderLayer::visibleHeight): (WebCore::RenderLayer::visibleWidth): (WebCore::RenderLayer::updateScrollInfoAfterLayout): * rendering/RenderLayer.h: * rendering/RenderListBox.cpp: (WebCore::RenderListBox::visibleHeight): (WebCore::RenderListBox::visibleWidth): * rendering/RenderListBox.h: 2011-02-13 Sam Weinig Reviewed by Dan Bernstein. Some Scrollbar functions assume an attached ScrollableArea but can be called without one https://bugs.webkit.org/show_bug.cgi?id=54262 Make sure that all calls to the scrollable area are null checked. * platform/Scrollbar.cpp: (WebCore::Scrollbar::autoscrollPressedPart): (WebCore::Scrollbar::moveThumb): (WebCore::Scrollbar::mouseMoved): 2011-02-13 Sam Weinig Roll out r78424. It broke a bunch of tests. * platform/mac/ScrollAnimatorMac.h: * platform/mac/ScrollAnimatorMac.mm: (WebCore::ScrollAnimatorMac::scrollToOffsetWithoutAnimation): (WebCore::ScrollAnimatorMac::immediateScrollToPoint): (WebCore::ScrollAnimatorMac::immediateScrollByDeltaX): (WebCore::ScrollAnimatorMac::immediateScrollByDeltaY): * rendering/RenderLayer.cpp: * rendering/RenderLayer.h: (WebCore::RenderLayer::contentsSize): * rendering/RenderListBox.cpp: * rendering/RenderListBox.h: 2011-02-12 Sam Weinig Reviewed by Dan Bernstein. WK2: Extra scrolling required when scrolling with a scroll wheel (Mighty Mouse) When going down the smooth scroll path, constrained scrolls (such as those from a Mighty Mouse) were being correctly constrained at the ScrollView level, but the duplicate values being stored by the animator were not being constrained correctly. In order to implement the constraint at this level, more of the ScrollableArea's API needed to be filled in for RenderLayer and RenderListBox. * platform/mac/ScrollAnimatorMac.h: * platform/mac/ScrollAnimatorMac.mm: (WebCore::ScrollAnimatorMac::scrollToOffsetWithoutAnimation): Call immediateScrollToPoint to stay consistent and get the desired behavior. (WebCore::ScrollAnimatorMac::adjustScrollXPositionIfNecessary): (WebCore::ScrollAnimatorMac::adjustScrollYPositionIfNecessary): (WebCore::ScrollAnimatorMac::adjustScrollPositionIfNecessary): (WebCore::ScrollAnimatorMac::immediateScrollToPoint): (WebCore::ScrollAnimatorMac::immediateScrollByDeltaX): (WebCore::ScrollAnimatorMac::immediateScrollByDeltaY): Ensure that the scroll animators view of the current scroll position is the same as the scrollable areas by correctly clamping the value. * rendering/RenderLayer.cpp: (WebCore::RenderLayer::contentsSize): Correct implementation to use the scroll size, not the visible size. (WebCore::RenderLayer::visibleHeight): (WebCore::RenderLayer::visibleWidth): * rendering/RenderLayer.h: * rendering/RenderListBox.cpp: (WebCore::RenderListBox::visibleHeight): (WebCore::RenderListBox::visibleWidth): * rendering/RenderListBox.h: Add implementations for visibleHeight/visibleWidth. 2011-02-12 Adam Barth Reviewed by Sam Weinig. crypto.getRandomValues should support all integer array types https://bugs.webkit.org/show_bug.cgi?id=54342 As discussed on whatwg, we should support all the integer array types. Test: security/crypto-random-values-types.html * page/Crypto.cpp: (WebCore::Crypto::getRandomValues): 2011-02-12 Adam Barth Reviewed by Mark Rowe. Use /dev/urandom as the OSRandomSource on OS(DARWIN) https://bugs.webkit.org/show_bug.cgi?id=54279 Update the ifdef. OS(UNIX) includes OS(DARWIN), so this change is should be a NOP. * config.h: 2011-02-11 Zhenyao Mo Reviewed by Kenneth Russell. [chromium] Allow turning off multisampling through web preference settings https://bugs.webkit.org/show_bug.cgi?id=54321 * html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::create): Disable multisampling in WebGL if web reference says so. * page/Settings.cpp: Add a flag for multisampling preference. (WebCore::Settings::Settings): (WebCore::Settings::setOpenGLMultisamplingEnabled): * page/Settings.h: Ditto. (WebCore::Settings::openGLMultisamplingEnabled): 2011-02-12 Ryosuke Niwa Reviewed by Tony Chang. Deploy EditingStyle in applyBlockStyle and applyInlineStyle https://bugs.webkit.org/show_bug.cgi?id=53911 Deployed EditingStyle in ApplyStyleCommand::applyBlockStyle and ApplyStyleCommand::applyInlineStyle. Extracted EditingStyle::extractAndRemoveTextDirection from applyInlineStyle. Also added propertiesToInclude to the argument list of EditingStyle's constructor that takes Node* so that splitAncestorsWithUnicodeBidi can call EditingStyle::textDirection to obtain the text direction. No new tests are added since this is a refactoring. * editing/ApplyStyleCommand.cpp: (WebCore::ApplyStyleCommand::doApply): Passes EditingStyle* to applyBlockStyle and applyInlineStyle. (WebCore::ApplyStyleCommand::applyBlockStyle): Takes EditingStyle*. (WebCore::ApplyStyleCommand::splitAncestorsWithUnicodeBidi): Changed the type of allowedDirection from int to WritingDirection. Uses EditingStyle's textDirection to obtain the writing direction. (WebCore::ApplyStyleCommand::applyInlineStyle): Takes EditingStyle*. (WebCore::ApplyStyleCommand::removeInlineStyleFromElement): Allows style to be null; exit early instead. (WebCore::ApplyStyleCommand::removeImplicitlyStyledElement): Asserts that style is not null. (WebCore::ApplyStyleCommand::removeInlineStyle): Allows style to be null. * editing/ApplyStyleCommand.h: Includes WritingDirection.h; prototype changes. * editing/EditingStyle.cpp: (WebCore::EditingStyle::EditingStyle): Added PropertiesToInclude to the argument. (WebCore::EditingStyle::init): Supports PropertiesToInclude. (WebCore::EditingStyle::extractAndRemoveTextDirection): Extracted from applyInlineStyle. * editing/EditingStyle.h: (WebCore::EditingStyle::create): Supports PropertiesToInclude. 2011-02-12 Jochen Eisinger Reviewed by Jeremy Orlow. Implement IDBObjectStore::clear https://bugs.webkit.org/show_bug.cgi?id=54193 Test: storage/indexeddb/objectstore-clear.html * storage/IDBObjectStore.cpp: (WebCore::IDBObjectStore::clear): * storage/IDBObjectStore.h: * storage/IDBObjectStore.idl: * storage/IDBObjectStoreBackendImpl.cpp: (WebCore::IDBObjectStoreBackendImpl::clear): (WebCore::doDelete): (WebCore::IDBObjectStoreBackendImpl::clearInternal): * storage/IDBObjectStoreBackendImpl.h: * storage/IDBObjectStoreBackendInterface.h: 2011-02-12 Adam Barth Another attempt to fix the EFL build. Looks like we're missing one more file. * CMakeLists.txt: 2011-02-12 Adam Barth Attempt to fix the EFL build. Apparently the CMake build had no concept of ArrayBuffers. * CMakeLists.txt: 2011-02-12 Ryosuke Niwa Unreviewed build fix. * dom/Range.cpp: (WebCore::lengthOfContentsInNode): Replaced static const unsigned LengthOfContentsInNode. (WebCore::Range::processContents): (WebCore::Range::processContentsBetweenOffsets): 2011-02-12 Adam Barth CPP files belong in SOURCES not in HEADERS. There are more errors like this for other disabled features, but I'm not fixing them in this patch. * WebCore.pro: 2011-02-12 Adam Barth Apparently lines in .pro files need to be \-terminated. * WebCore.pro: 2011-02-11 Ryosuke Niwa Reviewed by Darin Adler. Extract a function to process contents for one node from Range::processContents https://bugs.webkit.org/show_bug.cgi?id=54282 Extracted Range::processContentsBetweenOffsets, which process contents of a node between two offsets. This function is used for the simple case where the start and the end containers are of the same node, and to process start and end containers in the complex case. When the function takes a non-null fragment (simple case), it appends the processed contents to the fragment; character data and processing instruction's contents are copied between the offsets, and descendants are copied for node of other types (not node itself). When the fragment is null (complex case), the function copies contents of character data, processing instruction, and node of other types (including node itself). No new tests are added since this is a refactoring. * dom/Range.cpp: (WebCore::highestAncestorUnderCommonRoot): Added. (WebCore::Range::processContents): Calls highestAncestorUnderCommonRoot and processContentsBetweenOffsets. (WebCore::Range::processContentsBetweenOffsets): Added. * dom/Range.h: 2011-02-12 Adam Barth Attempt to fix the Qt Windows build. * WebCore.pro: 2011-02-12 Adam Barth Reviewed by Kenneth Russell. Enable ArrayBuffers by default https://bugs.webkit.org/show_bug.cgi?id=54310 As discussed on webkit-dev, ArrayBuffers are used by a bunch of different APIs, implemented by Firefox, and appear to be stable. Keeping them conditional is a large mantainance burden than it's worth. * DerivedSources.cpp: * WebCore.vcproj/WebCore.vcproj: * bindings/generic/RuntimeEnabledFeatures.h: (WebCore::RuntimeEnabledFeatures::setWebGLEnabled): * bindings/js/JSArrayBufferCustom.cpp: * bindings/js/JSBindingsAllInOne.cpp: * bindings/js/JSDOMWindowCustom.cpp: * bindings/js/JSDataViewCustom.cpp: * bindings/js/JSFloat32ArrayCustom.cpp: * bindings/js/JSInt16ArrayCustom.cpp: * bindings/js/JSInt32ArrayCustom.cpp: * bindings/js/JSInt8ArrayCustom.cpp: * bindings/js/JSUint16ArrayCustom.cpp: * bindings/js/JSUint32ArrayCustom.cpp: * bindings/js/JSUint8ArrayCustom.cpp: * bindings/v8/custom/V8ArrayBufferCustom.cpp: * bindings/v8/custom/V8ArrayBufferViewCustom.h: * bindings/v8/custom/V8DataViewCustom.cpp: * bindings/v8/custom/V8Float32ArrayCustom.cpp: * bindings/v8/custom/V8Int16ArrayCustom.cpp: * bindings/v8/custom/V8Int32ArrayCustom.cpp: * bindings/v8/custom/V8Int8ArrayCustom.cpp: * bindings/v8/custom/V8Uint16ArrayCustom.cpp: * bindings/v8/custom/V8Uint32ArrayCustom.cpp: * bindings/v8/custom/V8Uint8ArrayCustom.cpp: * html/canvas/ArrayBuffer.cpp: * html/canvas/ArrayBuffer.idl: * html/canvas/ArrayBufferView.cpp: * html/canvas/ArrayBufferView.idl: * html/canvas/DataView.cpp: * html/canvas/DataView.idl: * html/canvas/Float32Array.cpp: * html/canvas/Float32Array.idl: * html/canvas/Int16Array.cpp: * html/canvas/Int16Array.idl: * html/canvas/Int32Array.cpp: * html/canvas/Int32Array.idl: * html/canvas/Int8Array.cpp: * html/canvas/Int8Array.idl: * html/canvas/Uint16Array.cpp: * html/canvas/Uint16Array.idl: * html/canvas/Uint32Array.cpp: * html/canvas/Uint32Array.idl: * html/canvas/Uint8Array.cpp: * html/canvas/Uint8Array.idl: * page/Crypto.cpp: (WebCore::Crypto::getRandomValues): * page/Crypto.h: * page/Crypto.idl: * page/DOMWindow.idl: * workers/WorkerContext.idl: 2011-02-11 Yael Aharon Reviewed by Darin Adler. Background image positioning on RTL text https://bugs.webkit.org/show_bug.cgi?id=32862 When the style of InlineFlowBox is right-to-left, the strips should be rearranged in reverse order. Tests: fast/inline/inline-box-background-long-image.html fast/inline/inline-box-background-repeat-x.html fast/inline/inline-box-background-repeat-y.html fast/inline/inline-box-background.html * rendering/InlineFlowBox.cpp: (WebCore::InlineFlowBox::paintFillLayer): 2011-02-11 Sheriff Bot Unreviewed, rolling out r78044. http://trac.webkit.org/changeset/78044 https://bugs.webkit.org/show_bug.cgi?id=54318 Broke Safari extensions (Requested by eseidel on #webkit). * platform/KURL.cpp: (WebCore::KURL::parse): 2011-02-11 Beth Dakin Reviewed by Sam Weinig. Fix for Scrollbars for overflow areas never appear for WKScrollbarPainter scrollers Call ScrollableArea::didAddVerticalScrollbar() and ScrollableArea::willRemoveVerticalScrollbar() when appropriate for RenderLayers. * rendering/RenderLayer.cpp: (WebCore::RenderLayer::setHasHorizontalScrollbar): (WebCore::RenderLayer::setHasVerticalScrollbar): 2011-02-11 Eric Seidel Reviewed by Adam Barth. KURL should remove default port numbers when cannonicalizing urls (to match every other browser) https://bugs.webkit.org/show_bug.cgi?id=54090 * platform/KURL.cpp: (WebCore::isDefaultPortForScheme): (WebCore::KURL::parse): 2011-02-11 Mike Reed Reviewed by James Robinson. Need makeContextCurrent() called in prepareForSoftwareDraw(), in the case that skia's backend is the gpu. This matches the pattern in GraphicsContext3DOpenGL.cpp No new tests. All existing canvas layouttests exercise this code path * platform/graphics/skia/PlatformContextSkia.cpp: (WebCore::PlatformContextSkia::prepareForSoftwareDraw): 2011-02-11 Adam Klein Reviewed by Darin Adler. Check for empty scheme before accessing URLSchemeMaps in SchemeRegistry https://bugs.webkit.org/show_bug.cgi?id=54304 This avoids potential crashes in HashMap, as WTF's StringHash doesn't accept empty Strings. * platform/SchemeRegistry.cpp: (WebCore::SchemeRegistry::shouldTreatURLSchemeAsNoAccess): (WebCore::SchemeRegistry::shouldTreatURLSchemeAsSecure): (WebCore::SchemeRegistry::shouldLoadURLSchemeAsEmptyDocument): 2011-02-11 Adam Klein Reviewed by Darin Fisher. [fileapi] Add support for filesystem: URI handling https://bugs.webkit.org/show_bug.cgi?id=53529 There are two major parts to this patch: one is to add an implementation of Entry.toURI to the FileSystem API. The other is to implement security origin checking for this new scheme. All changes are guarded by the FILE_SYSTEM feature. An accompanying Chromium change, to support loading of filesystem: URIs, has recently been submitted as Chromium r74082. Spec: http://dev.w3.org/2009/dap/file-system/file-dir-sys.html#methods-2 Proposed URI format, and discussion of security origin issues: http://lists.w3.org/Archives/Public/public-webapps/2011JanMar/0218.html Tests: fast/filesystem/directory-entry-to-uri.html fast/filesystem/file-entry-to-uri.html fast/filesystem/filesystem-uri-origin.html http/tests/security/filesystem-iframe-from-remote.html * fileapi/Entry.cpp: (WebCore::Entry::toURI): * fileapi/Entry.h: * fileapi/Entry.idl: - Added toURI method to the IDL, omitting the MIME type argument specified in the spec as it will soon be removed. * page/SecurityOrigin.cpp: (WebCore::SecurityOrigin::SecurityOrigin): - crack the filesystem: URI to get at the origin of the site (WebCore::SecurityOrigin::canDisplay): - canDisplay for filesystem: URIs is equivalent to canRequest * platform/AsyncFileSystem.cpp: (WebCore::AsyncFileSystem::create): (WebCore::AsyncFileSystem::openFileSystem): * platform/AsyncFileSystem.h: (WebCore::AsyncFileSystem::type): - Exposed filesystem type to allow toURI to use it as part of the path. (WebCore::AsyncFileSystem::AsyncFileSystem): * platform/SchemeRegistry.cpp: (WebCore::canDisplayOnlyIfCanRequestSchemes): (WebCore::SchemeRegistry::canDisplayOnlyIfCanRequest): (WebCore::SchemeRegistry::registerAsCanDisplayOnlyIfCanRequest): - Generalized canDisplayOnlyIfCanRequest as it applies to both filesystem: and blob: URIs. * platform/SchemeRegistry.h: 2011-02-11 Beth Dakin Reviewed by Darin Adler. Fix for CrashTracer: [USER] 1 crash at com.apple.WebCore: -[ScrollbarPainterControllerDelegate scrollerImpPair:updateScrollerStyleForNewRecommendedScrollerStyle:] + 62 Must check for null _animator. * platform/mac/ScrollAnimatorMac.mm: (-[ScrollbarPainterControllerDelegate scrollAnimatorDestroyed]): (-[ScrollbarPainterControllerDelegate contentAreaRectForScrollerImpPair:]): (-[ScrollbarPainterControllerDelegate inLiveResizeForScrollerImpPair:]): (-[ScrollbarPainterControllerDelegate mouseLocationInContentAreaForScrollerImpPair:]): (-[ScrollbarPainterControllerDelegate scrollerImpPair:convertContentPoint:toScrollerImp:]): (-[ScrollbarPainterControllerDelegate scrollerImpPair:updateScrollerStyleForNewRecommendedScrollerStyle:]): (WebCore::ScrollAnimatorMac::~ScrollAnimatorMac): 2011-02-11 Chris Rogers Reviewed by Kenneth Russell. Throw exception when AudioContext's createBuffer() fails to properly decode audio file data https://bugs.webkit.org/show_bug.cgi?id=54158 No new tests since audio API is not yet implemented. * bindings/js/JSAudioContextCustom.cpp: (WebCore::JSAudioContextConstructor::constructJSAudioContext): (WebCore::JSAudioContext::createBuffer): * bindings/v8/custom/V8AudioContextCustom.cpp: (WebCore::V8AudioContext::createBufferCallback): * platform/audio/chromium/AudioBusChromium.cpp: (WebCore::createBusFromInMemoryAudioFile): * webaudio/AudioContext.idl: 2011-02-11 Mike Reed Reviewed by James Robinson. Fix toDataURL() to use device->readPixels() if need be, rather than always dereferencing the address returned by getPixels() (as the device may not be backed by a CPU bitmap) https://bugs.webkit.org/show_bug.cgi?id=54224 No new tests. Existing canvas tests exercise this... fast/canvas/script-tests/canvas-createPattern-fillRect-shadow.html * platform/graphics/skia/ImageBufferSkia.cpp: (WebCore::ImageBuffer::toDataURL): 2011-02-11 Andrew Wason Reviewed by David Levin. Files missing ENABLE_VIDEO #ifdef https://bugs.webkit.org/show_bug.cgi?id=53390 No new tests. * html/canvas/WebGLRenderingContext.cpp: * html/canvas/WebGLRenderingContext.h: * html/canvas/WebGLRenderingContext.idl: Wrap methods and declarations that use HTMLVideoElement with #if ENABLE(VIDEO). 2011-02-11 Sheriff Bot Unreviewed, rolling out r78331. http://trac.webkit.org/changeset/78331 https://bugs.webkit.org/show_bug.cgi?id=54295 This patch broke 11 tests in GTK bots (Requested by svillar on #webkit). * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (webkit_accessible_get_name): (webkit_accessible_detach): 2011-02-11 Gustavo Noronha Silva Reviewed by Xan Lopez. [GDOM] Video element needs proper wrapping https://bugs.webkit.org/show_bug.cgi?id=54231 Use the same strategy as the one used for the audio tag to wrap video as well. No layout tests because this only adds API. * bindings/gobject/GNUmakefile.am: * bindings/gobject/WebKitHTMLElementWrapperFactory.cpp: (WebKit::createVideoWrapper): (WebKit::createHTMLElementWrapper): 2011-02-11 Dirk Schulze Reviewed by Andreas Kling. SVGStyledElement::fillAttributeToPropertyTypeMap triggers a clang warning (-Woverloaded-virtual) https://bugs.webkit.org/show_bug.cgi?id=54259 Renamed fillAttributeToPropertyTypeMap with passed map to fillPassedAttributeToPropertyTypeMap to avoid overloading a virtual function. No change of functionality. Just fixing a build warning, so no new tests. * svg/SVGAElement.cpp: (WebCore::SVGAElement::fillAttributeToPropertyTypeMap): * svg/SVGAltGlyphElement.cpp: (WebCore::SVGAltGlyphElement::fillAttributeToPropertyTypeMap): * svg/SVGCircleElement.cpp: (WebCore::SVGCircleElement::fillAttributeToPropertyTypeMap): * svg/SVGClipPathElement.cpp: (WebCore::SVGClipPathElement::fillAttributeToPropertyTypeMap): * svg/SVGEllipseElement.cpp: (WebCore::SVGEllipseElement::fillAttributeToPropertyTypeMap): * svg/SVGFEBlendElement.cpp: (WebCore::SVGFEBlendElement::fillAttributeToPropertyTypeMap): * svg/SVGFEColorMatrixElement.cpp: (WebCore::SVGFEColorMatrixElement::fillAttributeToPropertyTypeMap): * svg/SVGFEComponentTransferElement.cpp: (WebCore::SVGFEComponentTransferElement::fillAttributeToPropertyTypeMap): * svg/SVGFECompositeElement.cpp: (WebCore::SVGFECompositeElement::fillAttributeToPropertyTypeMap): * svg/SVGFEConvolveMatrixElement.cpp: (WebCore::SVGFEConvolveMatrixElement::fillAttributeToPropertyTypeMap): * svg/SVGFEDiffuseLightingElement.cpp: (WebCore::SVGFEDiffuseLightingElement::fillAttributeToPropertyTypeMap): * svg/SVGFEDisplacementMapElement.cpp: (WebCore::SVGFEDisplacementMapElement::fillAttributeToPropertyTypeMap): * svg/SVGFEFloodElement.cpp: (WebCore::SVGFEFloodElement::fillAttributeToPropertyTypeMap): * svg/SVGFEGaussianBlurElement.cpp: (WebCore::SVGFEGaussianBlurElement::fillAttributeToPropertyTypeMap): * svg/SVGFEImageElement.cpp: (WebCore::SVGFEImageElement::fillAttributeToPropertyTypeMap): * svg/SVGFEMergeElement.cpp: (WebCore::SVGFEMergeElement::fillAttributeToPropertyTypeMap): * svg/SVGFEMorphologyElement.cpp: (WebCore::SVGFEMorphologyElement::fillAttributeToPropertyTypeMap): * svg/SVGFEOffsetElement.cpp: (WebCore::SVGFEOffsetElement::fillAttributeToPropertyTypeMap): * svg/SVGFESpecularLightingElement.cpp: (WebCore::SVGFESpecularLightingElement::fillAttributeToPropertyTypeMap): * svg/SVGFETileElement.cpp: (WebCore::SVGFETileElement::fillAttributeToPropertyTypeMap): * svg/SVGFETurbulenceElement.cpp: (WebCore::SVGFETurbulenceElement::fillAttributeToPropertyTypeMap): * svg/SVGFilterElement.cpp: (WebCore::SVGFilterElement::fillAttributeToPropertyTypeMap): * svg/SVGFilterPrimitiveStandardAttributes.cpp: (WebCore::SVGFilterPrimitiveStandardAttributes::fillPassedAttributeToPropertyTypeMap): * svg/SVGFilterPrimitiveStandardAttributes.h: * svg/SVGFontElement.cpp: (WebCore::SVGFontElement::fillAttributeToPropertyTypeMap): * svg/SVGForeignObjectElement.cpp: (WebCore::SVGForeignObjectElement::fillAttributeToPropertyTypeMap): * svg/SVGGlyphElement.cpp: (WebCore::SVGGlyphElement::fillAttributeToPropertyTypeMap): * svg/SVGGradientElement.cpp: (WebCore::SVGGradientElement::fillPassedAttributeToPropertyTypeMap): * svg/SVGGradientElement.h: * svg/SVGImageElement.cpp: (WebCore::SVGImageElement::fillAttributeToPropertyTypeMap): * svg/SVGLineElement.cpp: (WebCore::SVGLineElement::fillAttributeToPropertyTypeMap): * svg/SVGLinearGradientElement.cpp: (WebCore::SVGLinearGradientElement::fillAttributeToPropertyTypeMap): * svg/SVGMarkerElement.cpp: (WebCore::SVGMarkerElement::fillAttributeToPropertyTypeMap): * svg/SVGMaskElement.cpp: (WebCore::SVGMaskElement::fillAttributeToPropertyTypeMap): * svg/SVGMissingGlyphElement.cpp: (WebCore::SVGMissingGlyphElement::fillAttributeToPropertyTypeMap): * svg/SVGPathElement.cpp: (WebCore::SVGPathElement::fillAttributeToPropertyTypeMap): * svg/SVGPatternElement.cpp: (WebCore::SVGPatternElement::fillAttributeToPropertyTypeMap): * svg/SVGPolyElement.cpp: (WebCore::SVGPolyElement::fillAttributeToPropertyTypeMap): * svg/SVGRadialGradientElement.cpp: (WebCore::SVGRadialGradientElement::fillAttributeToPropertyTypeMap): * svg/SVGRectElement.cpp: (WebCore::SVGRectElement::fillAttributeToPropertyTypeMap): * svg/SVGStopElement.cpp: (WebCore::SVGStopElement::fillAttributeToPropertyTypeMap): * svg/SVGStyledElement.cpp: (WebCore::SVGStyledElement::fillPassedAttributeToPropertyTypeMap): * svg/SVGStyledElement.h: * svg/SVGStyledTransformableElement.cpp: (WebCore::SVGStyledTransformableElement::fillPassedAttributeToPropertyTypeMap): * svg/SVGStyledTransformableElement.h: * svg/SVGSwitchElement.cpp: (WebCore::SVGSwitchElement::fillAttributeToPropertyTypeMap): * svg/SVGSymbolElement.cpp: (WebCore::SVGSymbolElement::fillAttributeToPropertyTypeMap): * svg/SVGTRefElement.cpp: (WebCore::SVGTRefElement::fillAttributeToPropertyTypeMap): * svg/SVGTSpanElement.cpp: (WebCore::SVGTSpanElement::fillAttributeToPropertyTypeMap): * svg/SVGTextContentElement.cpp: (WebCore::SVGTextContentElement::fillPassedAttributeToPropertyTypeMap): * svg/SVGTextContentElement.h: * svg/SVGTextElement.cpp: (WebCore::SVGTextElement::fillAttributeToPropertyTypeMap): * svg/SVGTextPathElement.cpp: (WebCore::SVGTextPathElement::fillAttributeToPropertyTypeMap): * svg/SVGTextPositioningElement.cpp: (WebCore::SVGTextPositioningElement::fillPassedAttributeToPropertyTypeMap): * svg/SVGTextPositioningElement.h: * svg/SVGTitleElement.cpp: (WebCore::SVGTitleElement::fillAttributeToPropertyTypeMap): * svg/SVGUseElement.cpp: (WebCore::SVGUseElement::fillAttributeToPropertyTypeMap): * svg/SVGViewElement.cpp: (WebCore::SVGViewElement::fillAttributeToPropertyTypeMap): 2011-02-11 Andrey Adaikin Reviewed by Pavel Feldman. Web Inspector: [REGRESSION] click on error message in console doesn't scroll into view https://bugs.webkit.org/show_bug.cgi?id=54089 * inspector/front-end/Drawer.js: (WebInspector.Drawer.prototype.show.animationFinished): (WebInspector.Drawer.prototype.show): (WebInspector.Drawer.prototype.hide): (WebInspector.Drawer.prototype.resize): (WebInspector.Drawer.prototype.immediatelyFinishAnimation): (WebInspector.Drawer.prototype._cancelAnimationIfNeeded): (WebInspector.Drawer.prototype._animateDrawerHeight.animationFinished): (WebInspector.Drawer.prototype._animateDrawerHeight): (WebInspector.Drawer.prototype._statusBarDragging): * inspector/front-end/inspector.js: (WebInspector.animateStyle): (WebInspector.animateStyle.forceComplete): (WebInspector.animateStyle.cancel): (WebInspector.showSourceLine): 2011-02-10 Nate Chapin Reviewed by Adam Barth. Make DocumentWriter a member of DocumentLoader instead of FrameLoader. https://bugs.webkit.org/show_bug.cgi?id=50489 Refactor, no new tests. * bindings/ScriptControllerBase.cpp: (WebCore::ScriptController::executeIfJavaScriptURL): * dom/Document.cpp: (WebCore::Document::Document): (WebCore::Document::explicitClose): (WebCore::Document::lastModified): (WebCore::Document::initSecurityContext): (WebCore::Document::updateURLForPushOrReplaceState): * dom/Document.h: (WebCore::Document::setDocumentLoader): (WebCore::Document::loader): * html/MediaDocument.cpp: (WebCore::MediaDocument::replaceMediaElementTimerFired): * html/PluginDocument.cpp: (WebCore::PluginDocumentParser::createDocumentStructure): * loader/DocumentLoader.cpp: (WebCore::DocumentLoader::DocumentLoader): (WebCore::DocumentLoader::finishedLoading): (WebCore::DocumentLoader::commitData): (WebCore::DocumentLoader::setupForReplaceByMIMEType): (WebCore::DocumentLoader::setFrame): * loader/DocumentLoader.h: (WebCore::DocumentLoader::writer): * loader/DocumentWriter.cpp: (WebCore::DocumentWriter::begin): * loader/DocumentWriter.h: (WebCore::DocumentWriter::setFrame): * loader/FrameLoader.cpp: (WebCore::FrameLoader::FrameLoader): (WebCore::FrameLoader::init): (WebCore::FrameLoader::clear): (WebCore::FrameLoader::receivedFirstData): (WebCore::FrameLoader::transitionToCommitted): (WebCore::FrameLoader::open): (WebCore::FrameLoader::finishedLoadingDocument): (WebCore::FrameLoader::addExtraFieldsToRequest): * loader/FrameLoader.h: (WebCore::FrameLoader::notifier): * svg/graphics/SVGImage.cpp: (WebCore::SVGImage::dataChanged): 2011-02-10 Pavel Feldman Reviewed by Yury Semikhatsky. Web Inspector: make InspectorAgent own sub-agents, align agent creation/deletion routines. https://bugs.webkit.org/show_bug.cgi?id=54227 * dom/Document.cpp: (WebCore::Document::finishedParsing): * inspector/InspectorAgent.cpp: (WebCore::InspectorAgent::restoreInspectorStateFromCookie): (WebCore::InspectorAgent::setFrontend): (WebCore::InspectorAgent::disconnectFrontend): (WebCore::InspectorAgent::releaseFrontendLifetimeAgents): (WebCore::InspectorAgent::didCommitLoad): (WebCore::InspectorAgent::domContentLoadedEventFired): (WebCore::InspectorAgent::loadEventFired): (WebCore::InspectorAgent::startTimelineProfiler): (WebCore::InspectorAgent::stopTimelineProfiler): * inspector/InspectorAgent.h: * inspector/InspectorCSSAgent.cpp: * inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::InspectorDOMAgent): (WebCore::InspectorDOMAgent::startListening): (WebCore::InspectorDOMAgent::stopListening): (WebCore::InspectorDOMAgent::mainDOMContentLoaded): (WebCore::InspectorDOMAgent::loadEventFired): * inspector/InspectorDOMAgent.h: (WebCore::InspectorDOMAgent::create): * inspector/InspectorDOMStorageAgent.cpp: (WebCore::InspectorDOMStorageAgent::~InspectorDOMStorageAgent): * inspector/InspectorDOMStorageAgent.h: (WebCore::InspectorDOMStorageAgent::create): * inspector/InspectorDOMStorageResource.h: * inspector/InspectorDatabaseAgent.cpp: (WebCore::InspectorDatabaseAgent::~InspectorDatabaseAgent): (WebCore::InspectorDatabaseAgent::executeSQL): (WebCore::InspectorDatabaseAgent::selectDatabase): (WebCore::InspectorDatabaseAgent::InspectorDatabaseAgent): * inspector/InspectorDatabaseAgent.h: (WebCore::InspectorDatabaseAgent::FrontendProvider::create): (WebCore::InspectorDatabaseAgent::FrontendProvider::~FrontendProvider): (WebCore::InspectorDatabaseAgent::FrontendProvider::frontend): (WebCore::InspectorDatabaseAgent::FrontendProvider::clearFrontend): (WebCore::InspectorDatabaseAgent::FrontendProvider::FrontendProvider): (WebCore::InspectorDatabaseAgent::create): * inspector/InspectorDatabaseResource.cpp: (WebCore::InspectorDatabaseResource::InspectorDatabaseResource): (WebCore::InspectorDatabaseResource::bind): * inspector/InspectorDatabaseResource.h: * inspector/InspectorInstrumentation.cpp: (WebCore::InspectorInstrumentation::domContentLoadedEventFiredImpl): (WebCore::InspectorInstrumentation::loadEventFiredImpl): * inspector/InspectorInstrumentation.h: (WebCore::InspectorInstrumentation::domContentLoadedEventFired): (WebCore::InspectorInstrumentation::loadEventFired): * inspector/InspectorState.cpp: (WebCore::InspectorState::InspectorState): (WebCore::InspectorState::mute): (WebCore::InspectorState::updateCookie): * inspector/InspectorState.h: (WebCore::InspectorState::~InspectorState): * inspector/InspectorTimelineAgent.cpp: (WebCore::InspectorTimelineAgent::restore): (WebCore::InspectorTimelineAgent::~InspectorTimelineAgent): (WebCore::InspectorTimelineAgent::didCommitLoad): (WebCore::InspectorTimelineAgent::setFrontend): (WebCore::InspectorTimelineAgent::InspectorTimelineAgent): * inspector/InspectorTimelineAgent.h: (WebCore::InspectorTimelineAgent::create): * page/DOMWindow.cpp: (WebCore::DOMWindow::dispatchLoadEvent): 2011-02-11 Pavel Feldman Reviewed by Yury Semikhatsky. Web Inspector: command line API $0 regressed. https://bugs.webkit.org/show_bug.cgi?id=54283 * inspector/InjectedScriptSource.js: 2011-02-11 Janne Koskinen Reviewed by Andreas Kling. [Qt][S60] Vertical borders of buttons and frames are misaligned https://bugs.webkit.org/show_bug.cgi?id=51169 Force anti-aliasing for lines and rects when using OpenVG backend on Symbian. OpenVG cannot guarantee rendering to be on pixel in floating point co-ordinates without anti-aliasing. Patch idea by Laszlo Agocs. * platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContextPlatformPrivate::GraphicsContextPlatformPrivate): 2011-02-11 Mario Sanchez Prada Reviewed by Xan Lopez. [GTK] events missing when a document is (re)loaded https://bugs.webkit.org/show_bug.cgi?id=25831 Make sure webArea returns a proper name and that a signal 'state-change::defunct' is emitted when detaching the wrapper. Test: platform/gtk/accessibility/document-reload-events.html * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (webkit_accessible_get_name): Returns the current document's title as fallback mechanism for webArea objects. (webkit_accessible_detach): Emit 'state-change::defunct' function as soon as the wrapper is detached from the related core object. 2011-02-11 Pavel Feldman Reviewed by Yury Semikhatsky. Web Inspector: command line's API inspect() is broken. https://bugs.webkit.org/show_bug.cgi?id=54275 Test: inspector/command-line-api.html * inspector/InjectedScriptSource.js: 2011-02-11 Adam Barth Turns out window.crypto is supposed to be readonly. * page/DOMWindow.idl: 2011-02-11 Adam Barth Actually add Crypto.cpp to the Windows build. I'm terrible. * WebCore.vcproj/WebCore.vcproj: 2011-02-11 Adam Barth Attempt to fix the Windows build. Apparently we don't support conditional attributes on functions. This patch makes the whole Crypto interface conditional on ArrayBuffer support. * page/DOMWindow.idl: * page/Crypto.cpp: * page/Crypto.h: * page/Crypto.idl: 2011-02-10 Antti Koivisto Reviewed by Dave Hyatt. Enable ancestor identifier filtering for tree building https://bugs.webkit.org/show_bug.cgi?id=54241 Call CSSStyleSelector::push/popParent() during tree building too, fix up the parent element stack as needed. This roughly halves the remaining time in style matching over a typical page load. * css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::pushParentStackFrame): (WebCore::CSSStyleSelector::popParentStackFrame): (WebCore::CSSStyleSelector::pushParent): (WebCore::CSSStyleSelector::popParent): * css/CSSStyleSelector.h: (WebCore::CSSStyleSelector::ParentStackFrame::ParentStackFrame): * dom/Document.h: (WebCore::Document::styleSelectorIfExists): * dom/Element.cpp: (WebCore::Element::beginParsingChildren): (WebCore::Element::finishParsingChildren): * dom/Element.h: 2011-02-10 Adam Barth Reviewed by Eric Seidel. WebKit should have a cryptographic RNG https://bugs.webkit.org/show_bug.cgi?id=22049 Add crypto.getRandomValues. Yes, all these diffs are required to expose a single function to the DOM. Test: security/crypto-random-values.html * Android.mk: * CMakeLists.txt: * DerivedSources.cpp: * DerivedSources.make: * ForwardingHeaders/wtf/CryptographicallyRandomNumber.h: Added. * GNUmakefile.am: * WebCore.gypi: * WebCore.pri: * WebCore.pro: * WebCore.vcproj/WebCore.vcproj: * WebCore.xcodeproj/project.pbxproj: * bindings/js/JSDOMWindowCustom.cpp: * bindings/v8/custom/V8DOMWindowCustom.cpp: * config.h: * page/Crypto.cpp: Added. (WebCore::Crypto::Crypto): (WebCore::Crypto::getRandomValues): * page/Crypto.h: Added. (WebCore::Crypto::create): * page/Crypto.idl: Added. * page/DOMWindow.cpp: (WebCore::DOMWindow::clear): (WebCore::DOMWindow::crypto): * page/DOMWindow.h: (WebCore::DOMWindow::optionalCrypto): * page/DOMWindow.idl: 2011-02-11 Ryuan Choi Unreviewed build fix. [GTK] Build break with 2.18.3 https://bugs.webkit.org/show_bug.cgi?id=54057 * platform/gtk/ScrollbarThemeGtk2.cpp: Include GtkVersioning.h 2011-02-11 Cosmin Truta Reviewed by Adam Barth. Templatize KURLGooglePrivate::init https://bugs.webkit.org/show_bug.cgi?id=53749 No new tests. Refactoring. * platform/KURLGoogle.cpp: (WebCore::KURLGooglePrivate::init): * platform/KURLGooglePrivate.h: 2011-02-10 Andy Estes Reviewed by Eric Seidel. Convert ContainerNode::firstElementChild() to a free function. https://bugs.webkit.org/show_bug.cgi?id=54269 No new tests. No change in behavior. It seemed incorrect to have a method on ContainerNode that had the concept of an Element but couldn't return an Element*, but a method on Element could not be called by holders of ContainerNodes or other non-Element ContainerNode subclasses. A free function can both return an Element* and be called by anyone with a ContainerNode*. * dom/ContainerNode.h: (WebCore::ContainerNode::lastChild): (WebCore::Node::lastChild): * dom/Document.cpp: (WebCore::Document::cacheDocumentElement): * dom/Element.cpp: (WebCore::Element::firstElementChild): * dom/Element.h: (WebCore::firstElementChild): * html/parser/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::FragmentParsingContext::finished): 2011-02-10 Mads Ager Reviewed by Nate Chapin. [V8] Don't crash on exception getting event handler function https://bugs.webkit.org/show_bug.cgi?id=54216 Check for exceptions when attempting to get the handleEvent property of an event-handler object. Test: fast/dom/exception-getting-event-handler.html * bindings/v8/V8EventListener.cpp: (WebCore::V8EventListener::getListenerFunction): 2011-02-10 Naoki Takano Reviewed by James Robinson. [Chromium] Layout Test canvas/philip/tests/2d.composite.globalAlpha.fill.html with --accelerated-2d-canvas. https://bugs.webkit.org/show_bug.cgi?id=53857 globalAlpha is not applied to fillPath() and fillRect(). Test: fast/canvas/2d.composite.globalAlpha.fillPath.html and canvas/philip/tests/2d.composite.globalAlpha.fill.html with --accelerated-2d-canvas. * platform/graphics/chromium/GLES2Canvas.cpp: (WebCore::GLES2Canvas::State::applyAlpha): Append a new function to apply global alpha when fillRect() and fillPath() are called. (WebCore::GLES2Canvas::fillRect): Global alpha is applied to m_fillColor. (WebCore::GLES2Canvas::fillPath): Global alpha is applied to m_fillColor. 2011-02-10 Andy Estes Reviewed by Adam Barth. Remove an unneeded argument from HTMLDocument::create(). https://bugs.webkit.org/show_bug.cgi?id=54268 Now that HTMLTreeBuilder no longer uses a dummy HTMLDocument for fragment parsing, there isn't a need to explicitly specify a baseURL when constructing an HTMLDocument. We can remove the unneeded argument. Also fix some style issues in Document.h and HTMLDocument.h caught by check-webkit-style. No new tests. No change in behavior. * dom/Document.cpp: (WebCore::Document::Document): * dom/Document.h: * html/HTMLDocument.cpp: (WebCore::HTMLDocument::HTMLDocument): * html/HTMLDocument.h: (WebCore::HTMLDocument::create): 2011-02-10 Michael Saboff Reviewed by Geoffrey Garen. Cached JavaScript Parser Data Being Left in Memory Cache https://bugs.webkit.org/show_bug.cgi?id=54245 Added logic in CachedScript to clear SourceProviderCache data in destroyDecodedData(). Added and changed CachedScript timeout to act similar to CachedImage. Changed didAddClient to call super class method instead of duplicating the logic in the derived classes. * loader/cache/CachedImage.cpp: (WebCore::CachedImage::didAddClient): * loader/cache/CachedScript.cpp: (WebCore::CachedScript::didAddClient): (WebCore::CachedScript::allClientsRemoved): (WebCore::CachedScript::script): (WebCore::CachedScript::destroyDecodedData): * loader/cache/CachedScript.h: 2011-02-10 Cosmin Truta Reviewed by David Levin. Fix style in KURLGooglePrivate https://bugs.webkit.org/show_bug.cgi?id=54228 Replace occurrences of NULL with 0, '\0' or null (as applicable), to appease check-webkit-style. No new tests. This is a style fix. * platform/KURLGoogle.cpp: * platform/KURLGooglePrivate.h: 2011-02-10 Andy Estes Reviewed by Darin Adler. HTML5 TreeBuilder regressed a Peacekeeper DOM test by 40% https://bugs.webkit.org/show_bug.cgi?id=48719 The HTML5 fragment parsing algorithm specifies that a new Document should be created to serve as the temporary parent of fragment nodes during parsing. Document creation is expensive and accounts for ~38% of the Peacekeeper DOM performance regression. Avoid the cost of creating a dummy document by using the already-created DocumentFragment as the root node during fragment parsing. With this patch, the regression in Peacekeeper from Safari 5.0.3 to ToT is ~24%. Test: fast/parser/fragment-parser-doctype.html * dom/ContainerNode.h: (WebCore::ContainerNode::firstElementChild): Add a method that returns the first element-typed child from a ContainerNode. * dom/Document.cpp: (WebCore::Document::cacheDocumentElement): Call ContainerNode::firstElementChild() to retrieve and cache the document element. * html/parser/HTMLConstructionSite.cpp: (WebCore::HTMLConstructionSite::HTMLConstructionSite): Initialize the root ContainerNode. (WebCore::HTMLConstructionSite::detach): Clear the reference to the root ContainerNode. (WebCore::HTMLConstructionSite::insertHTMLHtmlStartTagBeforeHTML): Attach the new element to the root ContainerNode. (WebCore::HTMLConstructionSite::insertDoctype): Ditto. (WebCore::HTMLConstructionSite::insertCommentOnDocument): Ditto. * html/parser/HTMLConstructionSite.h: Store a pointer to a ContainerNode that will be used as the root node for document parsing. This node might or might not be the same as m_document. * html/parser/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::HTMLTreeBuilder): Initialize the HTMLConstructionSite with the correct root ContainerNode based on whether or not we're parsing a fragment. (WebCore::HTMLTreeBuilder::FragmentParsingContext::FragmentParsingContext): Remove m_dummyDocumentForFragmentParsing. (WebCore::HTMLTreeBuilder::FragmentParsingContext::finished): If the fragment has a context element, store only the children of the root element (HTML5 Section 10.4, Step 7). * html/parser/HTMLTreeBuilder.h: 2011-02-10 Beth Dakin Reviewed by Oliver Hunt. Speculative fix for CrashTracer: 6 crashes in WebProcess at com.apple.AppKit: -[NSAnimation(NSInternal) _advanceTimeWithTimer:] + 154 * platform/mac/ScrollAnimatorMac.mm: (-[ScrollbarPartAnimation scrollAnimatorDestroyed]): 2011-02-09 Jeremy Orlow Reviewed by Nate Chapin. IndexedDB event targets need to ensure their wrappers aren't garbage collected https://bugs.webkit.org/show_bug.cgi?id=54144 hasActivityPending should return true as long as it's possible that we'll fire more event listeners on our event targets. It is still possible for user generated events to run into problems, but I'm not sure how to address that yet (or how big of a deal it is). There's really no way to test this deterministically. Testing by hand makes it seem like this patch works as expected though. * storage/IDBCursorBackendImpl.cpp: * storage/IDBDatabase.cpp: (WebCore::IDBDatabase::IDBDatabase): (WebCore::IDBDatabase::~IDBDatabase): (WebCore::IDBDatabase::hasPendingActivity): (WebCore::IDBDatabase::stop): * storage/IDBDatabase.h: * storage/IDBRequest.cpp: (WebCore::IDBRequest::IDBRequest): (WebCore::IDBRequest::hasPendingActivity): (WebCore::IDBRequest::dispatchEvent): (WebCore::IDBRequest::enqueueEvent): * storage/IDBRequest.h: * storage/IDBTransaction.cpp: (WebCore::IDBTransaction::finished): (WebCore::IDBTransaction::hasPendingActivity): (WebCore::IDBTransaction::dispatchEvent): (WebCore::IDBTransaction::canSuspend): (WebCore::IDBTransaction::contextDestroyed): (WebCore::IDBTransaction::enqueueEvent): * storage/IDBTransaction.h: 2011-02-10 Ademar de Souza Reis Jr Reviewed by Andreas Kling. [Qt] create pkg-config files for mingw https://bugs.webkit.org/show_bug.cgi?id=54238 (mingw is mostly the same as unix) This change was applied in the Qt repository (qt/src/3rdparty/webkit), so we should do the same here in QtWebKit. Patch by Mark Brand , reviewed (there) by Oswald Buddenhagen 45fe2dddc3a0677b9ec9fce09f07cd4129e37afa * WebCore.pro: 2011-02-10 Andreas Kling Reviewed by Antti Koivisto. RenderStyle: Remove duplicate comparison of InheritedFlags::_text_transform https://bugs.webkit.org/show_bug.cgi?id=54246 * rendering/style/RenderStyle.h: 2011-02-10 Dirk Schulze Reviewed by Andreas Kling. SVG animation avoid unnecessary adjust for currentColor https://bugs.webkit.org/show_bug.cgi?id=54243 At the moment we try to adjust every animation value for currentColor - independent of the animation type. Since the value is a string and the target element may needs to get called by getElementById, this could be an expensive and unnecessary operation. Also after we adjust for currentColor, we save the result back as a string and parse it to Color afterwards again. With the patch we just adjust an animation value, if we use color animation. The color won't get saved and parsed as a string again. No change of functionality, no new tests. * svg/SVGAnimateElement.cpp: (WebCore::adjustForCurrentColor): (WebCore::SVGAnimateElement::calculateFromAndToValues): (WebCore::SVGAnimateElement::calculateFromAndByValues): * svg/SVGAnimationElement.cpp: (WebCore::SVGAnimationElement::currentValuesForValuesAnimation): (WebCore::SVGAnimationElement::startedActiveInterval): 2011-02-10 Ademar de Souza Reis Jr Reviewed by Andreas Kling. [Qt] Remove the use of deprecated qFindChildren() https://bugs.webkit.org/show_bug.cgi?id=54232 This was applied on the Qt repository and affects QtWebKit there. (13833beb641289c45faed337848d37280195aadc) The side effect of this change is that we won't be able to build QtWebKit with MSVC 6, as it doesn't support member template functions (not sure if that's possible today anyway). Original patch from Olivier Goffart , with review reported as being from the mailing list. The changes are result of the following commands: git grep -O"sed -i 's/qF\(indChildr*e*n*<[^>]*>\)(this,* */f\\1(/'" qFindChild git grep -O"sed -i 's/qF\(indChildr*e*n*<[^>]*>\)(&\([^\(),]*\),* */\\2.f\\1(/'" qFindChild git grep -O"sed -i 's/qF\(indChildr*e*n*<[^>]*>\)(\([^\(),]*()\),* */\\2->f\\1(/'" qFindChild git grep -O"sed -i 's/qF\(indChildr*e*n*<[^>]*>\)(\([^\(),]*\):\([^\(),]*\),* */(\\2:\\3)->f\\1(/'" qFindChild git grep -O"sed -i 's/qF\(indChildr*e*n*<[^>]*>\)(\([^\(),]*\),* */\\2->f\\1(/'" qFindChild * platform/graphics/qt/MediaPlayerPrivatePhonon.cpp: (WebCore::MediaPlayerPrivatePhonon::MediaPlayerPrivatePhonon): 2011-02-10 Ademar de Souza Reis Jr Reviewed by Andreas Kling. [Qt] Rename build target from "embedded" to "qpa" https://bugs.webkit.org/show_bug.cgi?id=54233 This flag is used by Qt's configure script to enable a QPA build ("QPA is a window system agnostic implementation of Qt" -- previously known as lighthouse). On the Qt repository, this was changed by two commits: 13a0b4935900093607f2b3b7688e1452d22770fd (from embedded to embedded_lite) 9716e12e0f5590ebc23ad9fb7ba75c6a3c5aadab (from embedded_lite to qpa) * WebCore.pro: 2011-02-10 Kenneth Russell Reviewed by James Robinson. Incorporate algorithm for processing paths into GPU-renderable triangle meshes https://bugs.webkit.org/show_bug.cgi?id=45521 Adding an implementation of Loop and Blinn's GPU accelerated path rendering algorithm from GPU Gems 3. This implementation pays particular attention to the efficiency of the curve subdivision phase needed for correct rendering. It utilizes the OpenGL utility library tessellator for triangulation of the interior of the shape. The regions handled by Loop and Blinn's algorithm are handled by the local triangulator previously incorporated. No tests yet; pixel tests will eventually be used to verify this algorithm and prevent regressions. * platform/graphics/gpu/LoopBlinnPathProcessor.cpp: Added. (WebCore::LoopBlinnPathProcessorImplementation::Segment::Segment): (WebCore::LoopBlinnPathProcessorImplementation::Segment::setup): (WebCore::LoopBlinnPathProcessorImplementation::Segment::kind): (WebCore::LoopBlinnPathProcessorImplementation::Segment::getPoint): (WebCore::LoopBlinnPathProcessorImplementation::Segment::next): (WebCore::LoopBlinnPathProcessorImplementation::Segment::prev): (WebCore::LoopBlinnPathProcessorImplementation::Segment::setNext): (WebCore::LoopBlinnPathProcessorImplementation::Segment::setPrev): (WebCore::LoopBlinnPathProcessorImplementation::Segment::contour): (WebCore::LoopBlinnPathProcessorImplementation::Segment::subdivide): (WebCore::LoopBlinnPathProcessorImplementation::Segment::boundingBox): (WebCore::LoopBlinnPathProcessorImplementation::Segment::numCrossingsForXRay): (WebCore::LoopBlinnPathProcessorImplementation::Segment::numberOfTriangles): (WebCore::LoopBlinnPathProcessorImplementation::Segment::getTriangle): (WebCore::LoopBlinnPathProcessorImplementation::Segment::numberOfInteriorVertices): (WebCore::LoopBlinnPathProcessorImplementation::Segment::getInteriorVertex): (WebCore::LoopBlinnPathProcessorImplementation::Segment::markedForSubdivision): (WebCore::LoopBlinnPathProcessorImplementation::Segment::setMarkedForSubdivision): (WebCore::LoopBlinnPathProcessorImplementation::Segment::toString): (WebCore::LoopBlinnPathProcessorImplementation::Segment::computeBoundingBox): (WebCore::LoopBlinnPathProcessorImplementation::Contour::Contour): (WebCore::LoopBlinnPathProcessorImplementation::Contour::add): (WebCore::LoopBlinnPathProcessorImplementation::Contour::subdivide): (WebCore::LoopBlinnPathProcessorImplementation::Contour::begin): (WebCore::LoopBlinnPathProcessorImplementation::Contour::end): (WebCore::LoopBlinnPathProcessorImplementation::Contour::isOrientedCounterClockwise): (WebCore::LoopBlinnPathProcessorImplementation::Contour::setIsOrientedCounterClockwise): (WebCore::LoopBlinnPathProcessorImplementation::Contour::boundingBox): (WebCore::LoopBlinnPathProcessorImplementation::Contour::fillSide): (WebCore::LoopBlinnPathProcessorImplementation::Contour::setFillSide): (WebCore::LoopBlinnPathProcessorImplementation::Segment::triangulate): (WebCore::LoopBlinnPathProcessor::LoopBlinnPathProcessor): (WebCore::LoopBlinnPathProcessor::~LoopBlinnPathProcessor): (WebCore::LoopBlinnPathProcessor::process): (WebCore::LoopBlinnPathProcessor::buildContours): (WebCore::LoopBlinnPathProcessor::allSegmentsOverlappingY): (WebCore::LoopBlinnPathProcessor::determineSidesToFill): (WebCore::LoopBlinnPathProcessor::determineOrientation): (WebCore::SweepData::SweepEvent::SweepEvent): (WebCore::SweepData::SweepEvent::setup): (WebCore::SweepData::SweepEvent::x): (WebCore::SweepData::SweepEvent::entry): (WebCore::SweepData::SweepEvent::interval): (WebCore::SweepData::SweepEvent::operator<): (WebCore::SweepData::trianglesOverlap): (WebCore::LoopBlinnPathProcessor::subdivideCurves): (WebCore::LoopBlinnPathProcessor::conditionallySubdivide): (WebCore::LoopBlinnPathProcessor::subdivideCurvesSlow): (WebCore::TessellationState::vertexCallback): (WebCore::TessellationState::combineCallback): (WebCore::TessellationState::edgeFlagCallback): (WebCore::LoopBlinnPathProcessor::tessellateInterior): * platform/graphics/gpu/LoopBlinnPathProcessor.h: Added. 2011-02-10 Ademar de Souza Reis Jr Reviewed by Andreas Kling. [Qt] Remove the use of deprecated qVariant* https://bugs.webkit.org/show_bug.cgi?id=54229 This was applied on the Qt repository and affects QtWebKit there. (633f3f45e5420663cf4ceadea79e62fea44cd2eb) The side effect of this change is that we won't be able to build QtWebKit with MSVC 6, as it doesn't support member template functions (not sure if it's possible today anyway). Original patch from Olivier Goffart , with review reported as being from the mailing list. The changes are result of the following commands: git grep -O"sed -i 's/qVariantValue]*\)> *(\([^&*\(),]*\), */\\2.setValue<\\1>(/'" qVariantSetValue git grep -O"sed -i 's/qVariantCanConvert *<\([^>]*\)> *(\([^&*\(),]*\))/\\2.canConvert<\\1>()/g'" qVariantCanConvert git grep -O"sed -i 's/qVariantCanConvert *<\([^>]*\)> *(\([^&*\(),]*([^&*\(),]*)\))/\\2.canConvert<\\1>()/g'" qVariantCanConvert git grep -O"sed -i 's/qVariantFromValue\( *[(<]\)/QVariant::fromValue\\1/'" qVariantFromValue * bridge/qt/qt_runtime.cpp: (JSC::Bindings::convertValueToQVariant): * platform/graphics/qt/MediaPlayerPrivateQt.cpp: (WebCore::MediaPlayerPrivateQt::commitLoad): 2011-02-10 Nico Weber Reviewed by Darin Adler. Fix clang warning "WebCore::HTMLAreaElement::getRect' hides overloaded virtual function [-Woverloaded-virtual]" https://bugs.webkit.org/show_bug.cgi?id=54221 The method name conflicts with ContainerNode::getRect() so rename it to computeRect(). Rename getPath() to computePath() for consistency as well. No intended functionality change, covered by existing tests. * accessibility/AccessibilityImageMapLink.cpp: (WebCore::AccessibilityImageMapLink::elementRect): * html/HTMLAreaElement.cpp: (WebCore::HTMLAreaElement::computePath): (WebCore::HTMLAreaElement::computeRect): * html/HTMLAreaElement.h: * page/SpatialNavigation.cpp: (WebCore::virtualRectForAreaElementAndDirection): * rendering/RenderImage.cpp: (WebCore::RenderImage::paintFocusRing): 2011-02-10 Alexis Menard Reviewed by Andreas Kling. [Qt] Default focus ring is too wide https://bugs.webkit.org/show_bug.cgi?id=51854 We now respect the outline property and html.css defines the outline of the focus ring to be 5px. This is propagated until GraphicsContext::drawFocusRing which uses it as the pen size. We should ignore the size and keep a default one. I also reverted the SolidLine to DotLine so that the selection looks nicer. Chromium Skia, CG Win, Haiku, WinCE ports also ignore the width. * platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::drawFocusRingForPath): (WebCore::GraphicsContext::drawFocusRing): 2011-02-10 Martin Robinson Reviewed by Gustavo Noronha Silva. [Soup] ResourceHandleSoup does not ever call didSendData for file uploads https://bugs.webkit.org/show_bug.cgi?id=52090 Call didSendData as body data is uploaded to the server. This is necessary for XHR upload events to function properly. * platform/network/ResourceHandleInternal.h: (WebCore::ResourceHandleInternal::ResourceHandleInternal): Add two new members. One to track the total amount of body data and one to track the total amount of body data sent so far. * platform/network/soup/ResourceHandleSoup.cpp: (WebCore::wroteBodyDataCallback): Added. (WebCore::addFormElementsToSoupMessage): Split this out into a helper function. Will now now sum the total amount of body data. (WebCore::startHttp): Attach a wrote-body-data signal handler. 2011-02-10 Bill Budge Reviewed by David Levin. Add fields to ResourceRequest and ResourceResponse in preparation for adding CORS support to AssociatedURLLoader. https://bugs.webkit.org/show_bug.cgi?id=53925 * platform/network/chromium/ResourceRequest.cpp: (WebCore::ResourceRequest::doPlatformCopyData): (WebCore::ResourceRequest::doPlatformAdopt): * platform/network/chromium/ResourceRequest.h: (WebCore::ResourceRequest::ResourceRequest): (WebCore::ResourceRequest::downloadToFile): (WebCore::ResourceRequest::setDownloadToFile): * platform/network/chromium/ResourceResponse.cpp: (WebCore::ResourceResponse::doPlatformCopyData): (WebCore::ResourceResponse::doPlatformAdopt): * platform/network/chromium/ResourceResponse.h: (WebCore::ResourceResponse::downloadFilePath): (WebCore::ResourceResponse::setDownloadFilePath): 2011-02-10 Dirk Schulze Reviewed by Nikolas Zimmermann. SVGAnimateElement needs information about the animated attribute type https://bugs.webkit.org/show_bug.cgi?id=53442 For animations, we need to know the SVG property type for a XML attribute. A global static mapping between attribute name and a type is not possible, since one attribute name can be bound to different property types: x can be a SVGNumberList, a SVGNumber or a SVGLength. So we have to ask every target element, if it supports the animated attribute and of which type it is. Just for CSS properties we can share an explicit mapping between the name and the type. This is done in a static map in SVGStyledElement. All other mappings are stored in local static HashMaps for all SVG elements with animated properties. These maps get filled once with the fillAttributeToPropertyTypeMap function that needs to be included in every SVG element. The function is not virtual in base classes for performance reasons. No change of functionality, so no new test cases. * svg/SVGAElement.cpp: (WebCore::SVGAElement::attributeToPropertyTypeMap): (WebCore::SVGAElement::fillAttributeToPropertyTypeMap): * svg/SVGAElement.h: * svg/SVGAltGlyphElement.cpp: (WebCore::SVGAltGlyphElement::attributeToPropertyTypeMap): (WebCore::SVGAltGlyphElement::fillAttributeToPropertyTypeMap): * svg/SVGAltGlyphElement.h: * svg/SVGAnimateElement.cpp: (WebCore::SVGAnimateElement::determinePropertyType): * svg/SVGCircleElement.cpp: (WebCore::SVGCircleElement::attributeToPropertyTypeMap): (WebCore::SVGCircleElement::fillAttributeToPropertyTypeMap): * svg/SVGCircleElement.h: * svg/SVGClipPathElement.cpp: (WebCore::SVGClipPathElement::attributeToPropertyTypeMap): (WebCore::SVGClipPathElement::fillAttributeToPropertyTypeMap): * svg/SVGClipPathElement.h: * svg/SVGComponentTransferFunctionElement.cpp: (WebCore::SVGComponentTransferFunctionElement::attributeToPropertyTypeMap): (WebCore::SVGComponentTransferFunctionElement::fillAttributeToPropertyTypeMap): * svg/SVGComponentTransferFunctionElement.h: * svg/SVGCursorElement.cpp: (WebCore::SVGCursorElement::attributeToPropertyTypeMap): (WebCore::SVGCursorElement::fillAttributeToPropertyTypeMap): * svg/SVGCursorElement.h: * svg/SVGElement.cpp: (WebCore::SVGElement::attributeToPropertyTypeMap): (WebCore::SVGElement::animatedPropertyTypeForAttribute): * svg/SVGElement.h: (WebCore::SVGElement::fillAttributeToPropertyTypeMap): * svg/SVGEllipseElement.cpp: (WebCore::SVGEllipseElement::attributeToPropertyTypeMap): (WebCore::SVGEllipseElement::fillAttributeToPropertyTypeMap): * svg/SVGEllipseElement.h: * svg/SVGFEBlendElement.cpp: (WebCore::SVGFEBlendElement::attributeToPropertyTypeMap): (WebCore::SVGFEBlendElement::fillAttributeToPropertyTypeMap): * svg/SVGFEBlendElement.h: * svg/SVGFEColorMatrixElement.cpp: (WebCore::SVGFEColorMatrixElement::attributeToPropertyTypeMap): (WebCore::SVGFEColorMatrixElement::fillAttributeToPropertyTypeMap): * svg/SVGFEColorMatrixElement.h: * svg/SVGFEComponentTransferElement.cpp: (WebCore::SVGFEComponentTransferElement::attributeToPropertyTypeMap): (WebCore::SVGFEComponentTransferElement::fillAttributeToPropertyTypeMap): * svg/SVGFEComponentTransferElement.h: * svg/SVGFECompositeElement.cpp: (WebCore::SVGFECompositeElement::attributeToPropertyTypeMap): (WebCore::SVGFECompositeElement::fillAttributeToPropertyTypeMap): * svg/SVGFECompositeElement.h: * svg/SVGFEConvolveMatrixElement.cpp: (WebCore::SVGFEConvolveMatrixElement::attributeToPropertyTypeMap): (WebCore::SVGFEConvolveMatrixElement::fillAttributeToPropertyTypeMap): * svg/SVGFEConvolveMatrixElement.h: * svg/SVGFEDiffuseLightingElement.cpp: (WebCore::SVGFEDiffuseLightingElement::attributeToPropertyTypeMap): (WebCore::SVGFEDiffuseLightingElement::fillAttributeToPropertyTypeMap): * svg/SVGFEDiffuseLightingElement.h: * svg/SVGFEDisplacementMapElement.cpp: (WebCore::SVGFEDisplacementMapElement::attributeToPropertyTypeMap): (WebCore::SVGFEDisplacementMapElement::fillAttributeToPropertyTypeMap): * svg/SVGFEDisplacementMapElement.h: * svg/SVGFEFloodElement.cpp: (WebCore::SVGFEFloodElement::attributeToPropertyTypeMap): (WebCore::SVGFEFloodElement::fillAttributeToPropertyTypeMap): * svg/SVGFEFloodElement.h: * svg/SVGFEGaussianBlurElement.cpp: (WebCore::SVGFEGaussianBlurElement::attributeToPropertyTypeMap): (WebCore::SVGFEGaussianBlurElement::fillAttributeToPropertyTypeMap): * svg/SVGFEGaussianBlurElement.h: * svg/SVGFEImageElement.cpp: (WebCore::SVGFEImageElement::attributeToPropertyTypeMap): (WebCore::SVGFEImageElement::fillAttributeToPropertyTypeMap): * svg/SVGFEImageElement.h: * svg/SVGFELightElement.cpp: (WebCore::SVGFELightElement::attributeToPropertyTypeMap): (WebCore::SVGFELightElement::fillAttributeToPropertyTypeMap): * svg/SVGFELightElement.h: * svg/SVGFEMergeElement.cpp: (WebCore::SVGFEMergeElement::attributeToPropertyTypeMap): (WebCore::SVGFEMergeElement::fillAttributeToPropertyTypeMap): * svg/SVGFEMergeElement.h: * svg/SVGFEMergeNodeElement.cpp: (WebCore::SVGFEMergeNodeElement::attributeToPropertyTypeMap): (WebCore::SVGFEMergeNodeElement::fillAttributeToPropertyTypeMap): * svg/SVGFEMergeNodeElement.h: * svg/SVGFEMorphologyElement.cpp: (WebCore::SVGFEMorphologyElement::attributeToPropertyTypeMap): (WebCore::SVGFEMorphologyElement::fillAttributeToPropertyTypeMap): * svg/SVGFEMorphologyElement.h: * svg/SVGFEOffsetElement.cpp: (WebCore::SVGFEOffsetElement::attributeToPropertyTypeMap): (WebCore::SVGFEOffsetElement::fillAttributeToPropertyTypeMap): * svg/SVGFEOffsetElement.h: * svg/SVGFESpecularLightingElement.cpp: (WebCore::SVGFESpecularLightingElement::attributeToPropertyTypeMap): (WebCore::SVGFESpecularLightingElement::fillAttributeToPropertyTypeMap): * svg/SVGFESpecularLightingElement.h: * svg/SVGFETileElement.cpp: (WebCore::SVGFETileElement::attributeToPropertyTypeMap): (WebCore::SVGFETileElement::fillAttributeToPropertyTypeMap): * svg/SVGFETileElement.h: * svg/SVGFETurbulenceElement.cpp: (WebCore::SVGFETurbulenceElement::attributeToPropertyTypeMap): (WebCore::SVGFETurbulenceElement::fillAttributeToPropertyTypeMap): * svg/SVGFETurbulenceElement.h: * svg/SVGFilterElement.cpp: (WebCore::SVGFilterElement::attributeToPropertyTypeMap): (WebCore::SVGFilterElement::fillAttributeToPropertyTypeMap): * svg/SVGFilterElement.h: * svg/SVGFilterPrimitiveStandardAttributes.cpp: (WebCore::SVGFilterPrimitiveStandardAttributes::fillAttributeToPropertyTypeMap): * svg/SVGFilterPrimitiveStandardAttributes.h: * svg/SVGFontElement.cpp: (WebCore::SVGFontElement::attributeToPropertyTypeMap): (WebCore::SVGFontElement::fillAttributeToPropertyTypeMap): * svg/SVGFontElement.h: (WebCore::SVGFontElement::rendererIsNeeded): * svg/SVGForeignObjectElement.cpp: (WebCore::SVGForeignObjectElement::attributeToPropertyTypeMap): (WebCore::SVGForeignObjectElement::fillAttributeToPropertyTypeMap): * svg/SVGForeignObjectElement.h: * svg/SVGGlyphElement.cpp: (WebCore::SVGGlyphElement::attributeToPropertyTypeMap): (WebCore::SVGGlyphElement::fillAttributeToPropertyTypeMap): * svg/SVGGlyphElement.h: * svg/SVGGradientElement.cpp: (WebCore::SVGGradientElement::fillAttributeToPropertyTypeMap): * svg/SVGGradientElement.h: * svg/SVGImageElement.cpp: (WebCore::SVGImageElement::attributeToPropertyTypeMap): (WebCore::SVGImageElement::fillAttributeToPropertyTypeMap): * svg/SVGImageElement.h: * svg/SVGLineElement.cpp: (WebCore::SVGLineElement::attributeToPropertyTypeMap): (WebCore::SVGLineElement::fillAttributeToPropertyTypeMap): * svg/SVGLineElement.h: * svg/SVGLinearGradientElement.cpp: (WebCore::SVGLinearGradientElement::attributeToPropertyTypeMap): (WebCore::SVGLinearGradientElement::fillAttributeToPropertyTypeMap): * svg/SVGLinearGradientElement.h: * svg/SVGMPathElement.cpp: (WebCore::SVGMPathElement::attributeToPropertyTypeMap): (WebCore::SVGMPathElement::fillAttributeToPropertyTypeMap): * svg/SVGMPathElement.h: * svg/SVGMarkerElement.cpp: (WebCore::SVGMarkerElement::attributeToPropertyTypeMap): (WebCore::SVGMarkerElement::fillAttributeToPropertyTypeMap): * svg/SVGMarkerElement.h: * svg/SVGMaskElement.cpp: (WebCore::SVGMaskElement::attributeToPropertyTypeMap): (WebCore::SVGMaskElement::fillAttributeToPropertyTypeMap): * svg/SVGMaskElement.h: * svg/SVGMissingGlyphElement.cpp: (WebCore::SVGMissingGlyphElement::attributeToPropertyTypeMap): (WebCore::SVGMissingGlyphElement::fillAttributeToPropertyTypeMap): * svg/SVGMissingGlyphElement.h: * svg/SVGPathElement.cpp: (WebCore::SVGPathElement::attributeToPropertyTypeMap): (WebCore::SVGPathElement::fillAttributeToPropertyTypeMap): * svg/SVGPathElement.h: * svg/SVGPatternElement.cpp: (WebCore::SVGPatternElement::attributeToPropertyTypeMap): (WebCore::SVGPatternElement::fillAttributeToPropertyTypeMap): * svg/SVGPatternElement.h: * svg/SVGPolyElement.cpp: (WebCore::SVGPolyElement::attributeToPropertyTypeMap): (WebCore::SVGPolyElement::fillAttributeToPropertyTypeMap): * svg/SVGPolyElement.h: * svg/SVGRadialGradientElement.cpp: (WebCore::SVGRadialGradientElement::attributeToPropertyTypeMap): (WebCore::SVGRadialGradientElement::fillAttributeToPropertyTypeMap): * svg/SVGRadialGradientElement.h: * svg/SVGRectElement.cpp: (WebCore::SVGRectElement::attributeToPropertyTypeMap): (WebCore::SVGRectElement::fillAttributeToPropertyTypeMap): * svg/SVGRectElement.h: * svg/SVGSVGElement.cpp: (WebCore::SVGSVGElement::attributeToPropertyTypeMap): (WebCore::SVGSVGElement::fillAttributeToPropertyTypeMap): * svg/SVGSVGElement.h: * svg/SVGScriptElement.cpp: (WebCore::SVGScriptElement::attributeToPropertyTypeMap): (WebCore::SVGScriptElement::fillAttributeToPropertyTypeMap): * svg/SVGScriptElement.h: * svg/SVGStopElement.cpp: (WebCore::SVGStopElement::attributeToPropertyTypeMap): (WebCore::SVGStopElement::fillAttributeToPropertyTypeMap): * svg/SVGStopElement.h: * svg/SVGStyledElement.cpp: (WebCore::cssPropertyToTypeMap): (WebCore::SVGStyledElement::animatedPropertyTypeForCSSProperty): (WebCore::SVGStyledElement::fillAttributeToPropertyTypeMap): * svg/SVGStyledElement.h: * svg/SVGStyledTransformableElement.cpp: (WebCore::SVGStyledTransformableElement::fillAttributeToPropertyTypeMap): * svg/SVGStyledTransformableElement.h: * svg/SVGSwitchElement.cpp: (WebCore::SVGSwitchElement::attributeToPropertyTypeMap): (WebCore::SVGSwitchElement::fillAttributeToPropertyTypeMap): * svg/SVGSwitchElement.h: * svg/SVGSymbolElement.cpp: (WebCore::SVGSymbolElement::attributeToPropertyTypeMap): (WebCore::SVGSymbolElement::fillAttributeToPropertyTypeMap): * svg/SVGSymbolElement.h: * svg/SVGTRefElement.cpp: (WebCore::SVGTRefElement::attributeToPropertyTypeMap): (WebCore::SVGTRefElement::fillAttributeToPropertyTypeMap): * svg/SVGTRefElement.h: * svg/SVGTSpanElement.cpp: (WebCore::SVGTSpanElement::attributeToPropertyTypeMap): (WebCore::SVGTSpanElement::fillAttributeToPropertyTypeMap): * svg/SVGTSpanElement.h: * svg/SVGTextContentElement.cpp: (WebCore::SVGTextContentElement::fillAttributeToPropertyTypeMap): * svg/SVGTextContentElement.h: * svg/SVGTextElement.cpp: (WebCore::SVGTextElement::attributeToPropertyTypeMap): (WebCore::SVGTextElement::fillAttributeToPropertyTypeMap): * svg/SVGTextElement.h: * svg/SVGTextPathElement.cpp: (WebCore::SVGTextPathElement::attributeToPropertyTypeMap): (WebCore::SVGTextPathElement::fillAttributeToPropertyTypeMap): * svg/SVGTextPathElement.h: * svg/SVGTextPositioningElement.cpp: (WebCore::SVGTextPositioningElement::fillAttributeToPropertyTypeMap): * svg/SVGTextPositioningElement.h: * svg/SVGTitleElement.cpp: (WebCore::SVGTitleElement::attributeToPropertyTypeMap): (WebCore::SVGTitleElement::fillAttributeToPropertyTypeMap): * svg/SVGTitleElement.h: * svg/SVGUseElement.cpp: (WebCore::SVGUseElement::attributeToPropertyTypeMap): (WebCore::SVGUseElement::fillAttributeToPropertyTypeMap): * svg/SVGUseElement.h: * svg/SVGViewElement.cpp: (WebCore::SVGViewElement::attributeToPropertyTypeMap): (WebCore::SVGViewElement::fillAttributeToPropertyTypeMap): * svg/SVGViewElement.h: 2011-02-10 Alexis Menard Reviewed by Andreas Kling. Fix a Warning after removing FileSystem support for the inspector. * WebCore.pro: 2011-02-10 Chris Fleizach Reviewed by Anders Carlsson. AX: AX needs to stop using WebCoreViewFactory https://bugs.webkit.org/show_bug.cgi?id=54153 WebKit2 no longer uses WebCoreViewFactory, which means that accessibility code needs to get off of it and use WebCoreSystemInterface, like other clients. * WebCore.exp.in: * accessibility/AXObjectCache.h: * accessibility/mac/AXObjectCacheMac.mm: (WebCore::AXObjectCache::handleFocusedUIElementChanged): * accessibility/mac/AccessibilityObjectWrapper.h: * accessibility/mac/AccessibilityObjectWrapper.mm: (-[AccessibilityObjectWrapper unregisterUniqueIdForUIElement]): (CFAutoreleaseHelper): (AXObjectIsTextMarker): (AXObjectIsTextMarkerRange): (AXTextMarkerRange): (AXTextMarkerRangeStart): (AXTextMarkerRangeEnd): (textMarkerForVisiblePosition): (-[AccessibilityObjectWrapper textMarkerForVisiblePosition:]): (visiblePositionForTextMarker): (-[AccessibilityObjectWrapper visiblePositionForTextMarker:]): (visiblePositionForStartOfTextMarkerRange): (visiblePositionForEndOfTextMarkerRange): (textMarkerRangeFromMarkers): (AXAttributeStringSetElement): (-[AccessibilityObjectWrapper doAXAttributedStringForTextMarkerRange:]): (textMarkerRangeFromVisiblePositions): (-[AccessibilityObjectWrapper textMarkerRangeFromVisiblePositions:endPosition:]): (-[AccessibilityObjectWrapper visiblePositionRangeForTextMarkerRange:]): (-[AccessibilityObjectWrapper textMarkerRangeForSelection]): (-[AccessibilityObjectWrapper accessibilitySetValue:forAttribute:]): (-[AccessibilityObjectWrapper accessibilityAttributeValue:forParameter:]): * editing/mac/SelectionControllerMac.mm: (WebCore::accessibilityConvertScreenRect): (WebCore::SelectionController::notifyAccessibilityForSelectionChange): * platform/mac/WebCoreSystemInterface.h: * platform/mac/WebCoreSystemInterface.mm: 2011-02-10 Alexis Menard Reviewed by Andreas Kling. [Qt] In trunk with Qt Multimedia the full screen mode doesn't work. https://bugs.webkit.org/show_bug.cgi?id=54201 Add files for the fullscreen video playback handling. It also fix a missing header. * WebCore.pro: 2011-02-09 Pavel Feldman Reviewed by Yury Semikhatsky. Web Inspector: Remove FileSystem support from the inspector. https://bugs.webkit.org/show_bug.cgi?id=50695 * CMakeLists.txt: * GNUmakefile.am: * WebCore.gypi: * WebCore.pro: * WebCore.vcproj/WebCore.vcproj: * WebCore.xcodeproj/project.pbxproj: * inspector/Inspector.idl: * inspector/InspectorApplicationCacheAgent.cpp: (WebCore::InspectorApplicationCacheAgent::InspectorApplicationCacheAgent): (WebCore::InspectorApplicationCacheAgent::getApplicationCaches): * inspector/InspectorApplicationCacheAgent.h: * inspector/InspectorFileSystemAgent.cpp: Removed. * inspector/InspectorFileSystemAgent.h: Removed. * inspector/InspectorInstrumentation.cpp: (WebCore::InspectorInstrumentation::identifierForInitialRequestImpl): (WebCore::InspectorInstrumentation::willSendRequestImpl): (WebCore::InspectorInstrumentation::markResourceAsCachedImpl): (WebCore::InspectorInstrumentation::didLoadResourceFromMemoryCacheImpl): (WebCore::InspectorInstrumentation::didReceiveResourceResponseImpl): (WebCore::InspectorInstrumentation::didReceiveContentLengthImpl): (WebCore::InspectorInstrumentation::didFinishLoadingImpl): (WebCore::InspectorInstrumentation::didFailLoadingImpl): (WebCore::InspectorInstrumentation::resourceRetrievedByXMLHttpRequestImpl): (WebCore::InspectorInstrumentation::scriptImportedImpl): (WebCore::InspectorInstrumentation::networkStateChangedImpl): (WebCore::InspectorInstrumentation::updateApplicationCacheStatusImpl): (WebCore::InspectorInstrumentation::retrieveResourceAgent): * inspector/front-end/FileSystemView.js: Removed. * inspector/front-end/WebKit.qrc: * inspector/front-end/inspector.html: 2011-02-10 Sheriff Bot Unreviewed, rolling out r78219. http://trac.webkit.org/changeset/78219 https://bugs.webkit.org/show_bug.cgi?id=54215 breaks editing/style/iframe-onload-crash.html on GTK 64-bit Debug (Requested by philn-tp on #webkit). * dom/Document.h: * dom/DocumentFragment.h: * dom/Element.h: * dom/Node.h: * dom/Text.h: * editing/htmlediting.cpp: (WebCore::editingIgnoresContent): (WebCore::canHaveChildrenForEditing): * editing/htmlediting.h: * html/HTMLBRElement.h: * html/HTMLButtonElement.h: * html/HTMLDataGridElement.h: * html/HTMLFormControlElement.h: * html/HTMLFrameElementBase.h: * html/HTMLHRElement.h: * html/HTMLImageElement.h: * html/HTMLMeterElement.h: * html/HTMLOutputElement.h: * html/HTMLPlugInElement.h: * html/HTMLProgressElement.h: * wml/WMLBRElement.h: * wml/WMLDoElement.h: * wml/WMLImageElement.h: * wml/WMLInputElement.h: * wml/WMLSelectElement.h: 2011-02-10 Andras Becsi Rubber-stamped by Csaba Osztrogonác. [Qt][V8] Fix the build. No new tests needed. * bindings/v8/WorkerContextExecutionProxy.cpp: add missing CString header. * loader/cache/CachedScript.h: do not use extra qualification for base class enum. 2011-02-10 Alexander Pavlov Reviewed by Yury Semikhatsky. Web Inspector: [STYLES] Suggest CSS property values once Up/Down is pressed with an empty input https://bugs.webkit.org/show_bug.cgi?id=54205 * inspector/front-end/CSSCompletions.js: (WebInspector.CSSCompletions): (WebInspector.CSSCompletions.prototype._firstIndexOfPrefix): * inspector/front-end/CSSKeywordCompletions.js: (WebInspector.CSSKeywordCompletions.forProperty): * inspector/front-end/StylesSidebarPane.js: (): * inspector/front-end/TextPrompt.js: (WebInspector.TextPrompt.prototype.complete): 2011-02-10 Renata Hodovan Reviewed by Dirk Schulze. SVGFESpecularLightingElement doesn't support dynamic invalidation, when attributes change. https://bugs.webkit.org/show_bug.cgi?id=54186 The dynamic changes are captured by the svgAttributeChange function, and invalidate the filter primitive if necessary. Tests: svg/dynamic-updates/SVGFESpecularLightingElement-dom-in-attr.html svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularConstant-attr.html svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularExponent-attr.html svg/dynamic-updates/SVGFESpecularLightingElement-dom-suraceScale-attr.html svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-in-prop.html svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularConstant-prop.html svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularExponent-prop.html svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-suraceScale-prop.html * svg/SVGFESpecularLightingElement.cpp: (WebCore::SVGFESpecularLightingElement::svgAttributeChanged): * svg/SVGFESpecularLightingElement.h: 2011-02-10 Andrey Adaikin Reviewed by Pavel Feldman. Web Inspector: Error messages are not displayed for the last line in a script https://bugs.webkit.org/show_bug.cgi?id=54204 * inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame.prototype.addMessage): (WebInspector.SourceFrame.prototype._addMessageToSource): (WebInspector.SourceFrame.prototype._createConditionElement): 2011-02-10 Ryosuke Niwa Reviewed by Eric Seidel. Make canHaveChildrenForEditing more efficient https://bugs.webkit.org/show_bug.cgi?id=53564 Improved the performance (1-2% in release and 20% in debug) by adding virtual member function canContainRangeEndPoint to Node. It returns true whenever the associated node can have be a container node for a position. As of this revision, canContainRangeEndPoint returns true on Document, DocumentFragment, Text nodes and any elements except: HTML: applet, br, button, datagrid, embed, frame, frameset, hr, img, input, meter, object, output, progress, and select. WML: br, do, img, input, and select. No new tests are added since this change cannot be tested directly. * dom/Document.h: (WebCore::Document::canContainRangeEndPoint): Added; returns false. * dom/DocumentFragment.h: (WebCore::DocumentFragment::canContainRangeEndPoint): Added; returns true. * dom/Element.h: (WebCore::Element::canContainRangeEndPoint): Ditto. * dom/Node.h: (WebCore::Node::canContainRangeEndPoint): Added; returns false. * dom/Text.h: (WebCore::Text::canContainRangeEndPoint): Added; returns true. * editing/htmlediting.cpp: Removed editingIgnoresContent and canHaveChildrenForEditing. * editing/htmlediting.h: (WebCore::editingIgnoresContent): Moved from htmlediting.cpp; made it inline. (WebCore::canHaveChildrenForEditing): Ditto. * html/HTMLBRElement.h: (WebCore::HTMLBRElement::canContainRangeEndPoint): Added; returns false. * html/HTMLButtonElement.h: (WebCore::HTMLButtonElement::canContainRangeEndPoint): Ditto. * html/HTMLDataGridElement.h: (WebCore::HTMLDataGridElement::canContainRangeEndPoint): Ditto. * html/HTMLFormControlElement.h: (WebCore::HTMLFormControlElementWithState::canContainRangeEndPoint): Ditto. * html/HTMLFrameElementBase.h: (WebCore::HTMLFrameElementBase::canContainRangeEndPoint): Ditto. * html/HTMLHRElement.h: (WebCore::HTMLHRElement::canContainRangeEndPoint): Ditto. * html/HTMLImageElement.h: (WebCore::HTMLImageElement::canContainRangeEndPoint): Ditto. * html/HTMLMeterElement.h: (WebCore::HTMLMeterElement::canContainRangeEndPoint): Ditto. * html/HTMLOutputElement.h: (WebCore::HTMLOutputElement::canContainRangeEndPoint): Ditto. * html/HTMLPlugInElement.h: (WebCore::HTMLPlugInElement::canContainRangeEndPoint): Ditto. * html/HTMLProgressElement.h: (WebCore::HTMLProgressElement::canContainRangeEndPoint): Ditto. * wml/WMLBRElement.h: (WebCore::WMLBRElement::canContainRangeEndPoint): Ditto. * wml/WMLDoElement.h: (WebCore::WMLDoElement::canContainRangeEndPoint): Ditto. * wml/WMLImageElement.h: (WebCore::WMLImageElement::canContainRangeEndPoint): Ditto. * wml/WMLInputElement.h: (WebCore::WMLInputElement::canContainRangeEndPoint): Ditto. * wml/WMLSelectElement.h: (WebCore::WMLSelectElement::canContainRangeEndPoint): Ditto. 2011-02-10 Pavel Feldman Reviewed by Yury Semikhatsky. Web Inspector: define interface per domain in Inspector.idl. https://bugs.webkit.org/show_bug.cgi?id=54135 * inspector/CodeGeneratorInspector.pm: * inspector/Inspector.idl: 2011-02-10 Andrey Adaikin Reviewed by Pavel Feldman. Web Inspector: [regression] Fix syncing heights of the gutter and main panel lines, and add 2px padding-left https://bugs.webkit.org/show_bug.cgi?id=54098 * inspector/front-end/TextViewer.js: (WebInspector.TextViewer): (WebInspector.TextViewer.prototype._updatePanelOffsets): (WebInspector.TextViewer.prototype._syncScroll): (WebInspector.TextViewer.prototype._syncDecorationsForLine): (WebInspector.TextEditorChunkedPanel.prototype._totalHeight): (WebInspector.TextEditorChunkedPanel.prototype.resize): (WebInspector.TextEditorGutterPanel): (WebInspector.TextEditorGutterChunk.prototype.set expanded): (WebInspector.TextEditorGutterChunk.prototype.get height): (WebInspector.TextEditorMainChunk.prototype.get height): * inspector/front-end/textViewer.css: (.webkit-line-content): 2011-02-10 takano takumi Reviewed by Dan Bernstein. A full-width character rotated leftward 90 degrees in text-combine https://bugs.webkit.org/show_bug.cgi?id=54169 * rendering/RenderCombineText.cpp: (WebCore::RenderCombineText::combineText): - Fixed by resetting font's orientation to horizontal when we decided to make combined text. Otherwise the text will be unexpectedly rotated in showGlyphsWithAdvances() in FontMac.mm. 2011-02-10 Alexey Proskuryakov Reviewed by Darin Adler. https://bugs.webkit.org/show_bug.cgi?id=50306 REGRESSION: WebChromeClient::shouldReplaceWithGeneratedFileForUpload() uses an initialized result value (breaks form submission with clang-built WebKit) No new test, because I can't reproduce the observable effect with my gcc build. * platform/network/FormData.cpp: (WebCore::FormData::appendKeyValuePairItems): Restore an empty path check - an empty path was causing an exception in Foundation. 2011-02-09 Andrey Kosyakov Reviewed by Pavel Feldman. Web Inspector: Network & Resource panels make multiple requests for images with no content https://bugs.webkit.org/show_bug.cgi?id=54085 - Added success parameter to resourceContent - NetworkManager.requestContent() now returns empty for zero-length resources, null for errors * inspector/Inspector.idl: * inspector/InspectorResourceAgent.cpp: (WebCore::InspectorResourceAgent::resourceData): (WebCore::InspectorResourceAgent::resourceContent): * inspector/InspectorResourceAgent.h: * inspector/front-end/NetworkManager.js: (WebInspector.NetworkManager.prototype.requestContent): * inspector/front-end/Resource.js: (WebInspector.Resource.prototype.requestContent): (WebInspector.Resource.prototype._contentURL): 2011-02-10 Renata Hodovan Reviewed by Dirk Schulze. Move the light source implementations into their own files. https://bugs.webkit.org/show_bug.cgi?id=53996 Splitting LightSource.cpp into 3 files. No new tests are added since this is a refactoring. * Android.mk: * CMakeLists.txt: * GNUmakefile.am: * WebCore.gypi: * WebCore.pro: * WebCore.vcproj/WebCore.vcproj: * WebCore.xcodeproj/project.pbxproj: * platform/graphics/filters/DistantLightSource.cpp: Added. (WebCore::DistantLightSource::initPaintingData): (WebCore::DistantLightSource::updatePaintingData): (WebCore::DistantLightSource::setAzimuth): (WebCore::DistantLightSource::setElevation): (WebCore::DistantLightSource::externalRepresentation): * platform/graphics/filters/LightSource.cpp: * platform/graphics/filters/PointLightSource.cpp: Added. (WebCore::PointLightSource::initPaintingData): (WebCore::PointLightSource::updatePaintingData): (WebCore::PointLightSource::setX): (WebCore::PointLightSource::setY): (WebCore::PointLightSource::setZ): (WebCore::operator<<): (WebCore::PointLightSource::externalRepresentation): * platform/graphics/filters/SpotLightSource.cpp: Added. (WebCore::SpotLightSource::initPaintingData): (WebCore::SpotLightSource::updatePaintingData): (WebCore::SpotLightSource::setX): (WebCore::SpotLightSource::setY): (WebCore::SpotLightSource::setZ): (WebCore::SpotLightSource::setPointsAtX): (WebCore::SpotLightSource::setPointsAtY): (WebCore::SpotLightSource::setPointsAtZ): (WebCore::SpotLightSource::setSpecularExponent): (WebCore::SpotLightSource::setLimitingConeAngle): (WebCore::operator<<): (WebCore::SpotLightSource::externalRepresentation): 2011-02-10 Avi Drissman Reviewed by Darin Fisher.