2011-03-30 Alexey Proskuryakov Reviewed by Darin Adler. REGRESSION (r82320): Spacebar no longer pages down https://bugs.webkit.org/show_bug.cgi?id=57423 Also includes some unrelated cleanup that I had in my tree. * WebView/WebHTMLView.mm: (-[WebHTMLView _interpretKeyEvent:savingCommands:]): Added an assertion that the event is being dispatched to the right frame. (-[WebHTMLView setMarkedText:selectedRange:]): Use 0 for a pointer, not NULL. (-[WebHTMLView doCommandBySelector:]): Update eventInterpretationHadSideEffects with "|=". Even if this specific command hasn't been handled, that doesn't nullify side effects from previous commands. (-[WebHTMLView insertText:]): Besides looking at the return value of insertText() to fix the bug, removed setting _private->interpretKeyEventsParameters to 0. I don't see any way for another WebHTMLView NSTextInput method to be called from within insertText:, so no one is going to look at it. 2011-03-30 Sam Weinig Reviewed by Brady Eidson. WebKit2: Attempting to view css file from url causes it to download https://bugs.webkit.org/show_bug.cgi?id=57501 * WebView/WebHTMLRepresentation.h: * WebView/WebHTMLRepresentation.mm: (+[WebHTMLRepresentation unsupportedTextMIMETypes]): * WebView/WebHTMLView.mm: (+[WebHTMLView unsupportedTextMIMETypes]): Re-factor unsupportedTextMIMETypes to pull from WebCore's MIMETypeRegistry, so that the list can be shared with WebKit2. 2011-03-29 Beth Dakin Reviewed by Maciej Stachowiak. Fix for https://bugs.webkit.org/show_bug.cgi?id=57408 webkit-min-device-pixel-ratio media query doesn't work post-SnowLeopard -and corresponding- * Misc/WebNSControlExtras.m: (-[NSControl sizeToFitAndAdjustWindowHeight]): * WebCoreSupport/WebChromeClient.mm: (WebChromeClient::scaleFactor): * WebView/WebHTMLView.mm: (-[WebHTMLView viewDidMoveToWindow]): (-[WebHTMLView attachRootLayer:]): 2011-03-29 Kent Tamura Reviewed by Dimitri Glazkov. Make validation message bubble testable https://bugs.webkit.org/show_bug.cgi?id=57290 * WebView/WebView.mm: (-[WebView _preferencesChangedNotification:]): Copy the private value of the timer magnification to WebCore::Settings. (-[WebView validationMessageTimerMagnification]): Added. (-[WebView setValidationMessageTimerMagnification:]): Added. * WebView/WebViewData.h: Declare a member for the timer magnification. * WebView/WebViewData.mm: (-[WebViewPrivate init]): Initialize the timer magnification. * WebView/WebViewPrivate.h: Declare a setter and a getter for the timer magnification. 2011-03-29 Kent Tamura Reviewed by Dimitri Glazkov. [Mac] Enable interactive-validation tests on Mac DRT https://bugs.webkit.org/show_bug.cgi?id=57308 * WebView/WebView.mm: (-[WebView _preferencesChangedNotification:]): Convey a WebView flag for interactive validation to WebCore::Settings. (-[WebView interactiveFormValidationEnabled]): Added. (-[WebView setInteractiveFormValidationEnabled:]): Added. * WebView/WebViewData.h: Add interactiveFormValidationEnabled. * WebView/WebViewData.mm: (-[WebViewPrivate init]): Initialize interactiveFormValidationEnabled. * WebView/WebViewPrivate.h: Add setter and getter for interactiveFormValidationEnabled. 2011-03-29 Timothy Hatcher Update the order of the context menu to better match AppKit on Mac. Reviewed by John Sullivan. * DefaultDelegates/WebDefaultContextMenuDelegate.mm: (-[WebDefaultUIDelegate webView:contextMenuItemsForElement:defaultMenuItems:]): Update the order of items. * WebCoreSupport/WebPlatformStrategies.h: * WebCoreSupport/WebPlatformStrategies.mm: (WebPlatformStrategies::contextMenuItemTagLookUpInDictionary): Added argument for selected string. 2011-03-29 Alexey Proskuryakov Reviewed by Darin Adler. https://bugs.webkit.org/show_bug.cgi?id=57379 Clean up WK1 key event handling logic No bugs knowingly fixed, but this makes the code more consistent. * WebView/WebHTMLView.mm: (struct WebHTMLViewInterpretKeyEventsParameters): Renamed eventWasHandled to eventInterpretationHadSideEffects, because "handled" doesn't really mean much. (-[WebHTMLView _executeSavedEditingCommands]): Factored out from _interpretKeyEvent for use from other functions. We need to execute saved commands when an input method asks for current state, because providing stale state could confuse it. (-[WebHTMLView _interpretKeyEvent:savingCommands:]): Heavily commented, and updated for other changes. (-[WebHTMLView characterIndexForPoint:]): Call _executeSavedEditingCommands, because otherwise, the answer would be stale. (-[WebHTMLView firstRectForCharacterRange:]): Ditto. (-[WebHTMLView selectedRange]): Ditto. (-[WebHTMLView markedRange]): Ditto. (-[WebHTMLView attributedSubstringFromRange:]): Ditto. (-[WebHTMLView hasMarkedText]): Ditto. (-[WebHTMLView unmarkText]): Call _executeSavedEditingCommands, because otherwise, we'd be operating on stale data. Also, updated for eventWasHandled renaming. (-[WebHTMLView setMarkedText:selectedRange:]): Ditto. (-[WebHTMLView doCommandBySelector:]): Removed special handling for noop:. I verified that it's no longer needed for bug 14522, presumably due to WebCore level changes. It was also fragile, because there is no guarantee about when noop: is sent (also, a custom key binding could have a noop: as one of its commands, although that's hardly practical). Added the same "from input method" logic that we have in insertText: - I don't know of any IMs that call this method, but we clearly need to execute it as part of IM processing when there is marked text. (-[WebHTMLView insertText:]): Removed a confusing check for [text length]. Always set eventInterpretationHadSideEffects to true, becasue there is no reason to try multiple times if current selection isn't editable. This is different from doCommandBySelector:, where we need to give super class a chance to handle the event if our processing fails. Removed a nonsense "consumedByIM = true" assignment - we no longer need it now that the return value of _interpretKeyEvent is computed differently. 2011-03-28 Adele Peterson Reviewed by Eric Seidel. Fix for REGRESSION (r79411): "Check grammar with spelling" context menu doesn't check as you type https://bugs.webkit.org/show_bug.cgi?id=57173 * WebView/WebFrame.mm: (-[WebFrame hasSpellingMarker:length:]): Call new selectionStartHasMarkerFor method instead of selectionStartHasSpellingMarkerFor. (-[WebFrame hasGrammarMarker:length:]): Call new selectionStartHasMarkerFor method. * WebView/WebFramePrivate.h: Add hasGrammarMarker so grammar marking can be tested. 2011-03-28 Alexey Proskuryakov Reviewed by Darin Adler. https://bugs.webkit.org/show_bug.cgi?id=57260 Clean up text input code a little * WebCoreSupport/WebEditorClient.mm: (WebEditorClient::handleKeyboardEvent): (WebEditorClient::handleInputMethodKeydown): * WebView/WebHTMLViewInternal.h: Renamed _interceptEditingKeyEvent:shouldSaveCommand:, becasue it doesn't really intercept anything. It's just a version it interpretKeyEvents: that tells us whether it was handled, and also possibly saves resulting commands for later execution. * WebView/WebHTMLView.mm: (-[WebHTMLView _interpretKeyEvent:savingCommands:]): Changed to use early return. Changed return value in case platformEvent is null to be less mysterious. Moved receivedNOOP from WebHTMLViewPrivate to WebHTMLViewInterpretKeyEventsParameters, as this is just part of event handling state, like the other booleans there. Don't call interpretKeyEvents: again simply because the first call resulted in no saved commands, becasue it's confusing and apparently useless (I couldn't find any broken behavior). (-[WebHTMLView unmarkText]): Cleaned upo BOOL vs. bool constants. (-[WebHTMLView setMarkedText:selectedRange:]): Ditto. (-[WebHTMLView doCommandBySelector:]): Ditto. (-[WebHTMLView insertText:]): Ditto. * WebView/WebViewInternal.h: There was no _interceptEditingKeyEvent:shouldSaveCommand: method on WebView. 2011-03-27 Jer Noble Reviewed by Maciej Stachowiak. Full Screen: disable keyboard access by default https://bugs.webkit.org/show_bug.cgi?id=56684 Take into account whether keyboard access was requested when deciding whether full screen mode is supported. * WebCoreSupport/WebChromeClient.h: * WebCoreSupport/WebChromeClient.mm: (WebChromeClient::supportsFullScreenForElement): * WebView/WebView.mm: (-[WebView _supportsFullScreenForElement:WebCore::withKeyboard:]): * WebView/WebViewInternal.h: 2011-03-26 Jer Noble Reviewed by Eric Carlson. Enable the Full Screen API by default in WebKit/mac and WebKit2 https://bugs.webkit.org/show_bug.cgi?id=56956 * WebView/WebPreferences.mm: (+[WebPreferences initialize]): Default the WebKitFullScreenEnabled preference to true. 2011-03-25 Andy Estes Reviewed by Adele Peterson. REGRESSION (r70748): latest nightly builds kills AC_QuickTime.js https://bugs.webkit.org/show_bug.cgi?id=49016 Update objectContentType() implementation to handle the shouldPreferPlugInsForImages flag. * WebCoreSupport/WebFrameLoaderClient.h: * WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::objectContentType): 2011-03-24 Sheriff Bot Unreviewed, rolling out r81939. http://trac.webkit.org/changeset/81939 https://bugs.webkit.org/show_bug.cgi?id=57084 Rolling out 81939, as it's causing a number of app cache test failures. (Requested by jernoble on #webkit). * WebView/WebView.mm: (-[WebView _preferencesChangedNotification:]): 2011-03-23 Jer Noble Reviewed by Maciej Stachowiak. Application Cache should save audio/ and video/ mime types as flat files https://bugs.webkit.org/show_bug.cgi?id=53784 No new tests. Initialize the AppCache Total size quotas with the values for WebKitPreferences upon startup. * WebView/WebView.mm: (-[WebView _preferencesChangedNotification:]): 2011-03-24 Sheriff Bot Unreviewed, rolling out r81916 and r81917. http://trac.webkit.org/changeset/81916 http://trac.webkit.org/changeset/81917 https://bugs.webkit.org/show_bug.cgi?id=57071 broke a test on platforms that do not have QuickTime installed (Requested by estes on #webkit). * WebCoreSupport/WebFrameLoaderClient.h: * WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::objectContentType): 2011-03-24 Andy Estes Reviewed by Darin Adler. REGRESSION (r70748): latest nightly builds kills AC_QuickTime.js https://bugs.webkit.org/show_bug.cgi?id=49016 Update objectContentType() implementation to handle the shouldPreferPlugInsForImages flag. * WebCoreSupport/WebFrameLoaderClient.h: * WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::objectContentType): 2011-03-24 Geoffrey Garen Reviewed by Oliver Hunt. Ensure that all compilation takes place within a dynamic global object scope https://bugs.webkit.org/show_bug.cgi?id=57054 * WebView/WebScriptDebugDelegate.mm: (-[WebScriptCallFrame evaluateWebScript:]): Updated for signature change. 2011-03-24 Jia Pu Reviewed by Darin Adler. Dismissed reversion suggestion is incorrectly learned. https://bugs.webkit.org/show_bug.cgi?id=57039 CorrectionPanel should always use [NSSpellChecker dismissCorrectionBubbleForView]. [NSSpellChecker cancelCorrectionBubbleForView] is reserved for situation where correction panel is dismissed explicitly by ESC key or clicking the dimiss button. Misusing these causes incorrect automatic learning. * WebCoreSupport/CorrectionPanel.mm: (CorrectionPanel::dismissInternal): 2011-03-24 David Kilzer ENABLE_PLUGIN_PROXY_FOR_VIDEO should be defined to 0 on Mac OS X Reviewed by Joseph Pecoraro. * Plugins/WebPluginContainerPrivate.h: Changed value of ENABLE_PLUGIN_PROXY_FOR_VIDEO from 1 to 0. 2011-03-23 Jia Pu Reviewed by Darin Adler. Hook up new AppKit autocorrection UI with WK2. https://bugs.webkit.org/show_bug.cgi?id=56055 Please see WebCore/ChangeLog for detail. * WebCoreSupport/CorrectionPanel.h: Added. (CorrectionPanel::isShowing): * WebCoreSupport/CorrectionPanel.mm: Added. (correctionBubbleType): (CorrectionPanel::CorrectionPanel): (CorrectionPanel::~CorrectionPanel): (CorrectionPanel::show): (CorrectionPanel::dismiss): (CorrectionPanel::dismissSoon): (CorrectionPanel::dismissInternal): (CorrectionPanel::recordAutocorrectionResponse): * WebCoreSupport/WebEditorClient.h: * WebCoreSupport/WebEditorClient.mm: (WebEditorClient::WebEditorClient): (WebEditorClient::showCorrectionPanel): (WebEditorClient::dismissCorrectionPanel): (WebEditorClient::dismissCorrectionPanelSoon): (WebEditorClient::recordAutocorrectionResponse): * WebView/WebView.mm: (-[WebView handleCorrectionPanelResult:]): * WebView/WebViewPrivate.h: 2011-03-23 Enrica Casucci Reviewed by Alexey Proskuryakov. Services menu item to convert selected Simplified/Traditional Chinese Text is not working. https://bugs.webkit.org/show_bug.cgi?id=56974 This fixes a regression introduced by http://trac.webkit.org/changeset/61794 where readSelectionFromPasteboard was accidentally removed. This method and writeSelectionToPasteboard are needed to support Mac OS X services. * WebView/WebHTMLView.mm: (-[WebHTMLView _pasteAsPlainTextWithPasteboard:]): Added. (-[WebHTMLView readSelectionFromPasteboard:]): Added. 2011-03-23 Brady Eidson Reviewed by Sam Weinig. Change IconDatabase opening to allow for arbitrary filenames https://bugs.webkit.org/show_bug.cgi?id=56977 * Misc/WebIconDatabase.mm: (-[WebIconDatabase _startUpIconDatabase]): 2011-03-22 Anton D'Auria Reviewed by Alexey Proskuryakov. Add +[WebApplicationCache getOriginsWithCache] https://bugs.webkit.org/show_bug.cgi?id=56722 Call existing WebCore::ApplicationCacheStorage::getOriginsWithCache API. * WebCoreSupport/WebApplicationCache.h: * WebCoreSupport/WebApplicationCache.mm: (+[WebApplicationCache originsWithCache]): 2011-03-22 Anders Carlsson Reviewed by Sam Weinig. OBJECT element with DivX source is always downloaded https://bugs.webkit.org/show_bug.cgi?id=56879 * Plugins/WebBasePluginPackage.mm: (-[WebBasePluginPackage getPluginInfoFromPLists]): Always try to split every element in the "WebPluginExtensions" array, since the DivX plug-in specifies multiple file extensions in a single element. 2011-03-22 Brady Eidson Reviewed by Sam Weinig. and https://bugs.webkit.org/show_bug.cgi?id=56876 WK2 Icon DB: Expand IconDatabaseClient interface and move it to the main thread Note that while the new client calls always come through on the main thread, our mechanisms to route dispatches to the main thread are still valid and will still work. Update to the new IconDatabaseClient interface: * WebCoreSupport/WebIconDatabaseClient.h: * WebCoreSupport/WebIconDatabaseClient.mm: (WebIconDatabaseClient::didRemoveAllIcons): (WebIconDatabaseClient::didImportIconURLForPageURL): (WebIconDatabaseClient::didImportIconDataForPageURL): (WebIconDatabaseClient::didChangeIconForPageURL): (WebIconDatabaseClient::didFinishURLImport): 2011-03-22 Matthew Delaney Reviewed by Simon Fraser. Have WebKit push acceleratedDrawing preferences to settings https://bugs.webkit.org/show_bug.cgi?id=56792 * WebView/WebView.mm: 2011-03-21 Nate Chapin Reviewed by Brady Eidson. Expose a preference to use caching quirks for QuickLook, and use it if the QuickLook framework is loaded. https://bugs.webkit.org/show_bug.cgi?id=38690 * WebView/WebPreferenceKeysPrivate.h: * WebView/WebPreferences.mm: (useQuickLookQuirks): (+[WebPreferences initialize]): (-[WebPreferences useQuickLookResourceCachingQuirks]): * WebView/WebPreferencesPrivate.h: * WebView/WebView.mm: (-[WebView _preferencesChangedNotification:]): 2011-03-21 Chris Fleizach Reviewed by Darin Adler. AX: showContextMenu not working in WK2 https://bugs.webkit.org/show_bug.cgi?id=56734 Implement showContextMenu() so accessibility related code can call this independent of whether WK1 or WK2 is running. * WebCoreSupport/WebChromeClient.h: * WebCoreSupport/WebChromeClient.mm: (WebChromeClient::showContextMenu): 2011-03-21 Chang Shu Reviewed by Alexey Proskuryakov. REGRESSION (r79953): Can't type in MS Outlook 2011 https://bugs.webkit.org/show_bug.cgi?id=56665 r79953 removed the WebView level editablity which is persistent no matter whether underlying document itself is changed and editability gets lost. The resolution is to set this WebView editable value to WebCore. This avoids the callback from WebCore to WebKit which was the main goal in r79953 to improve performance. * WebView/WebView.mm: (-[WebView setEditable:]): (-[WebView isEditable]): 2011-03-19 Anton D'Auria Reviewed by Alexey Proskuryakov. ApplicationCacheGroup is not obsolete after being deleted via ApplicationCacheStorage::deleteEntriesForOrigin https://bugs.webkit.org/show_bug.cgi?id=56415 Use new ApplicationCache API to delete all cache for an origin. * WebCoreSupport/WebApplicationCache.h: * WebCoreSupport/WebApplicationCache.mm: (+[WebApplicationCache deleteOrigin:]): 2011-03-17 Brady Eidson Reviewed by Sam Weinig. https://bugs.webkit.org/show_bug.cgi?id=56425 More groundwork for WebKit2 IconDatabase Update already-used function names: * Misc/WebIconDatabase.mm: (-[WebIconDatabase iconForURL:withSize:cache:]): (-[WebIconDatabase iconURLForURL:]): * WebView/WebView.mm: (-[WebView _dispatchDidReceiveIconFromWebFrame:]): 2011-03-18 Pavel Podivilov Reviewed by Yury Semikhatsky. Web Inspector: implement inspector session storage. https://bugs.webkit.org/show_bug.cgi?id=56643 * WebCoreSupport/WebInspectorClient.h: * WebCoreSupport/WebInspectorClient.mm: (WebInspectorClient::saveSessionSetting): (WebInspectorClient::loadSessionSetting): (WebInspectorFrontendClient::saveSessionSetting): (WebInspectorFrontendClient::loadSessionSetting): (-[WebInspectorWindowController inspectorClient]): 2011-03-17 Geoffrey Garen Reviewed by Oliver Hunt. Fixed a leak seen on the buildbot. * WebCoreSupport/WebInspectorClient.mm: (WebInspectorClient::openInspectorFrontend): Smart pointers are smart. 2011-03-16 Jeff Johnson Reviewed by Alexey Proskuryakov. Logic error in -[WebHTMLView close] https://bugs.webkit.org/show_bug.cgi?id=56445 Page is always nil at this point, because [self _webView] is nil, so the conditional code is never run. * WebView/WebHTMLView.mm: (-[WebHTMLView close]): 2011-03-16 Chris Fleizach Reviewed by Darin Adler. WK2: Need to propagate enhanced accessibility flag from UI -> web process https://bugs.webkit.org/show_bug.cgi?id=56379 * WebView/WebFrame.mm: (-[WebFrame accessibilityRoot]): 2011-03-15 Oliver Hunt Reviewed by Geoffrey Garen. Make Structure creation require a JSGlobalData https://bugs.webkit.org/show_bug.cgi?id=56438 Mechanical change to make all Structure creation use a JSGlobalData& * Plugins/Hosted/ProxyInstance.mm: (WebKit::ProxyRuntimeMethod::createStructure): * Plugins/Hosted/ProxyRuntimeObject.h: (WebKit::ProxyRuntimeObject::createStructure): 2011-03-15 Alexey Proskuryakov Forgot to save a modification to this file when committing. * WebCoreSupport/WebKeyGenerator.mm: Changed "Apple Computer" to "Apple" in copyright header. 2011-03-15 Alexey Proskuryakov Reviewed by Darin Adler. REGRESSION (WebKit2): keygen element doesn't work https://bugs.webkit.org/show_bug.cgi?id=56402 * WebCoreSupport/WebKeyGenerator.h: * WebCoreSupport/WebKeyGenerator.m: Removed. * WebCoreSupport/WebKeyGenerator.mm: Copied from Source/WebKit/mac/WebCoreSupport/WebKeyGenerator.m. (+[WebKeyGenerator sharedGenerator]): (toWebCertificateParseResult): WebCore no longer needs WebKeyGenerator. Safari still does need a part of it, so keeping this misnamed and misplaced code for now. * WebCoreSupport/WebPlatformStrategies.h: * WebCoreSupport/WebPlatformStrategies.mm: (WebPlatformStrategies::keygenMenuItem512): (WebPlatformStrategies::keygenMenuItem1024): (WebPlatformStrategies::keygenMenuItem2048): (WebPlatformStrategies::keygenKeychainItemName): Added strings used by keygen. * WebCoreSupport/WebSystemInterface.mm: (InitWebCoreSystemInterface): Initialize a WebCore pointer to a function used by keygen. * WebView/WebFrameView.mm: (-[WebFrameView initWithFrame:]): WebKeyGenerator can be lazily initialized now. 2011-03-15 Beth Dakin Reviewed by Simon Fraser. WebKit part of Overlay scrollbars slow down PLT by 6% New WebKitystemInterface function to force the scrollbars to flash * WebCoreSupport/WebSystemInterface.mm: (InitWebCoreSystemInterface): 2011-03-15 Ilya Sherman Reviewed by Tony Chang. Autofilled form elements are assigned fixed background color but not text color https://bugs.webkit.org/show_bug.cgi?id=48382 * DOM/WebDOMOperations.mm: (-[DOMHTMLInputElement _setAutofilled:]): Added (wrapper). * DOM/WebDOMOperationsPrivate.h: 2011-03-15 Adam Roben Fix a leak in WebStorageTrackerClient::dispatchDidModifyOrigin Fixes SecurityOrigin leaks seen in WebStorageTrackerClient::dispatchDidModifyOrigin Reviewed by Antti Koivisto. * Storage/WebStorageTrackerClient.mm: (WebStorageTrackerClient::dispatchDidModifyOriginOnMainThread): Adopt the reference passed to us by dispatchDidModifyOrigin. (WebStorageTrackerClient::dispatchDidModifyOrigin): Added a comment and removed an unnecessary cast. 2011-03-15 Kevin Ollivier Reviewed by Darin Adler. Introduce WTF_USE_EXPORT_MACROS, which will allow us to put shared library import/export info into the headers rather than in export symbol definition files, but disable it on all platforms initially so we can deal with port build issues one port at a time. https://bugs.webkit.org/show_bug.cgi?id=27551 * WebKitPrefix.h: 2011-03-14 Brady Eidson Reviewed by Anders Carlsson. https://bugs.webkit.org/show_bug.cgi?id=56320 Remove HistoryItem::icon() and the WebCore dependency on "IconDatabaseBase::defaultIcon()" * History/WebHistoryItem.mm: (-[WebHistoryItem icon]): This far-future FIXME is now irrelevant. 2011-03-13 Pratik Solanki Reviewed by Brady Eidson. Make adjustMIMETypeIfNecessary use CFNetwork directly https://bugs.webkit.org/show_bug.cgi?id=55912 * WebCoreSupport/WebSystemInterface.mm: (InitWebCoreSystemInterface): Support for new WKSI functions. 2011-03-12 Mark Rowe Fix the 32-bit build. * Carbon/CarbonWindowAdapter.mm: (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:disableOrdering:carbon:]): Use a more appropriate format specifier. (-[CarbonWindowAdapter _carbonWindowClass]): Ditto. 2011-03-11 Brady Eidson Reviewed by Anders Carlsson and https://bugs.webkit.org/show_bug.cgi?id=56216 Rework disabled IconDatabase builds while allowing for a pluggable icon database implementation. * Misc/WebIconDatabase.mm: (+[WebIconDatabase _checkIntegrityBeforeOpening]): Call these static methods on IconDatabase::, not iconDatabase(). (-[WebIconDatabase _startUpIconDatabase]): Ditto. (importToWebCoreFormat): 2011-03-11 Anton D'Auria Reviewed and landed by Brady Eidson. https://bugs.webkit.org/show_bug.cgi?id=51878 Add WebKit1 API to view and delete local storage * Storage/WebStorageManager.mm: Added. (+[WebStorageManager sharedWebStorageManager]): (-[WebStorageManager origins]): (-[WebStorageManager deleteAllOrigins]): (-[WebStorageManager deleteOrigin:]): (-[WebStorageManager syncLocalStorage]): (-[WebStorageManager syncFileSystemAndTrackerDatabase]): (storageDirectoryPath): (WebKitInitializeStorageIfNecessary): * Storage/WebStorageManagerInternal.h: Added. * Storage/WebStorageManagerPrivate.h: Added. * Storage/WebStorageTrackerClient.h: Added. * Storage/WebStorageTrackerClient.mm: Added. (WebStorageTrackerClient::sharedWebStorageTrackerClient): (WebStorageTrackerClient::WebStorageTrackerClient): (WebStorageTrackerClient::~WebStorageTrackerClient): (WebStorageTrackerClient::dispatchDidModifyOriginOnMainThread): (WebStorageTrackerClient::dispatchDidModifyOrigin): * WebCoreSupport/WebSecurityOrigin.mm: (-[WebSecurityOrigin protocol]): (-[WebSecurityOrigin host]): (-[WebSecurityOrigin databaseIdentifier]): (-[WebSecurityOrigin domain]): (-[WebSecurityOrigin _initWithWebCoreSecurityOrigin:]): * WebCoreSupport/WebSecurityOriginPrivate.h: * WebKit.exp: * WebView/WebView.mm: (-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]): 2011-03-10 Anders Carlsson Reviewed by Sam Weinig. Don't paint more than 60 times per second even when scrolling * WebView/WebClipView.mm: (-[WebClipView _immediateScrollToPoint:]): 2011-03-09 Matthew Delaney Reviewed by Simon Fraser. Plumb through settings for accelerated drawing for canvas https://bugs.webkit.org/show_bug.cgi?id=56039 * WebView/WebPreferenceKeysPrivate.h: * WebView/WebPreferences.mm: * WebView/WebPreferencesPrivate.h: 2011-03-10 Ryosuke Niwa Reviewed by Tony Chang. VisiblePosition's next and previous should take an enum instead of a boolean https://bugs.webkit.org/show_bug.cgi?id=56135 SelectionController::isAll now takes EditingBoundaryCrossingRule instead of StayInEditableContent. * WebView/WebView.mm: (-[WebView _selectionIsAll]): 2011-03-09 Jessie Berlin Reviewed by Adam Roben. Use the Cookie Storage from the Private Browsing Storage Session directly https://bugs.webkit.org/show_bug.cgi?id=55986 * WebCoreSupport/WebSystemInterface.mm: (InitWebCoreSystemInterface): 2011-03-08 Darin Adler Reviewed by Timothy Hatcher. Promote a method used outside WebKit from internal to private https://bugs.webkit.org/show_bug.cgi?id=55949 * Misc/WebNSPasteboardExtras.mm: Removed an unused category declaration. Minor tweak, not directly related to the rest of this patch. * WebView/WebFrame.mm: (-[WebFrame _computePageRectsWithPrintScaleFactor:pageSize:]): Moved this method from the internal category into the private category. Streamlined the code a bit. * WebView/WebFrameInternal.h: Removed _computePageRects method. * WebView/WebFramePrivate.h: Added _computePageRects method. 2011-03-07 Ryosuke Niwa Reviewed by Darin Adler. selectionHasStyle and selectionStartHasStyle should use EditingStyle https://bugs.webkit.org/show_bug.cgi?id=55902 selectionHasStyle now takes a property id and a value instead of a CSSMutableStyleDeclaration. * WebView/WebHTMLView.mm: Removed unused selectionHasStyle. (-[WebHTMLView validateUserInterfaceItemWithoutDelegate:]): Calls Editor::selectionHasStyle. 2011-03-07 Dan Bernstein LLVM Compiler build fix. * WebCoreSupport/WebEditorClient.mm: (WebEditorClient::checkGrammarOfString): 2011-03-07 Chris Fleizach Reviewed by Beth Dakin. AX: WK1 needs to use ScrollView attachment for AXScrollArea, WK2 does not https://bugs.webkit.org/show_bug.cgi?id=55706 Make sure WebDynamicScrollBarsView appear in the AX tree in WK1 (since this object returns the scroll bar objects). Make the accessibilityRoot object be the web area in WK1 because WebDynamicScrollBarsView will expect that as its child, instead of the WebCore ScrollView object. * WebView/WebDynamicScrollBarsView.mm: (-[WebDynamicScrollBarsView accessibilityIsIgnored]): * WebView/WebFrame.mm: (-[WebFrame accessibilityRoot]): 2011-03-07 Sam Weinig Reviewed by Anders Carlsson. Replace WebKit2's decidePolicyForMIMEType with decidePolicyForResponse https://bugs.webkit.org/show_bug.cgi?id=55827 Renamed FrameLoaderClient::dispatchDecidePolicyForMIMEType to dispatchDecidePolicyForResponse and pass the entire response, instead of just the MIMEType. * WebCoreSupport/WebFrameLoaderClient.h: * WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::dispatchDecidePolicyForResponse): 2011-03-06 Dan Bernstein LLVM Compiler build fix. * DOM/WebDOMOperations.mm: (-[DOMHTMLInputElement _setValueForUser:]): 2011-03-06 Jessie Berlin Reviewed by Sam Weinig. WebKit2: Use CFNetwork Sessions API. https://bugs.webkit.org/show_bug.cgi?id=55435. When Private Browsing is enabled, use cookies from a in-memory cookie storage based on the Private Browsing Storage Session. * WebCoreSupport/WebSystemInterface.mm: (InitWebCoreSystemInterface): Add support for using the new WKSI functions in WebCore. 2011-03-05 Ilya Sherman Reviewed by Darin Adler. HTMLInputElement::setValue() should schedule change event when the element is focused In service of https://code.google.com/p/chromium/issues/detail?id=42716 https://bugs.webkit.org/show_bug.cgi?id=53160 * DOM/WebDOMOperations.mm: (-[DOMHTMLInputElement _setValueForUser:]): Expose HTMLInputElement::setValueForUser() to tests * DOM/WebDOMOperationsPrivate.h: * WebView/WebViewInternal.h: 2011-03-04 Jia Pu Reviewed by Darin Adler. On Mac, the bounding box sent to EditorClient::showCorrectionPanel() is incorrect when the correction occurs in an iframe. https://bugs.webkit.org/show_bug.cgi?id=55717 With the change in WebCore, the bounding box passed into EditorClient::showCorrectionPanel() is already in window coordinate. We don't need to do further conversion anymore. * WebCoreSupport/WebEditorClient.mm: (WebEditorClient::showCorrectionPanel): 2011-03-04 Jessie Berlin Reviewed by Maciej Stachowiak. WebKit2: Use CFNetwork Sessions API. https://bugs.webkit.org/show_bug.cgi?id=55435. When Private Browsing is enabled, get the cached url response from the cache associated with the Private Browsing Storage Session. * WebView/WebView.mm: (-[WebView _cachedResponseForURL:]): 2011-03-03 Anders Carlsson Reviewed by Sam Weinig. Get rid of Page::globalHistoryItem https://bugs.webkit.org/show_bug.cgi?id=55738 * WebCoreSupport/WebFrameLoaderClient.h: * WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::updateGlobalHistoryItemForPage): Get the current history item and update it using -[WebView _setGlobalHistoryItem:]. * WebView/WebView.mm: (-[WebView _globalHistoryItem]): (-[WebView _setGlobalHistoryItem:]): Set _globalHistoryItem ivar. * WebView/WebViewData.h: * WebView/WebViewData.mm: Add _globalHistoryItem ivar. 2011-03-03 Brady Eidson Reviewed by Darin Adler. https://bugs.webkit.org/show_bug.cgi?id=55721 Global IconDatabase should be returned by reference, not as a pointer * Misc/WebCoreStatistics.mm: (+[WebCoreStatistics iconPageURLMappingCount]): (+[WebCoreStatistics iconRetainedPageURLCount]): (+[WebCoreStatistics iconRecordCount]): (+[WebCoreStatistics iconsWithDataCount]): * Misc/WebIconDatabase.mm: (-[WebIconDatabase init]): (-[WebIconDatabase iconForURL:withSize:cache:]): (-[WebIconDatabase iconURLForURL:]): (-[WebIconDatabase defaultIconWithSize:]): (-[WebIconDatabase retainIconForURL:]): (-[WebIconDatabase releaseIconForURL:]): (-[WebIconDatabase isEnabled]): (-[WebIconDatabase setEnabled:]): (-[WebIconDatabase removeAllIcons]): (+[WebIconDatabase _checkIntegrityBeforeOpening]): (-[WebIconDatabase _startUpIconDatabase]): (-[WebIconDatabase _applicationWillTerminate:]): (-[WebIconDatabase _resetCachedWebPreferences:]): (importToWebCoreFormat): * WebView/WebView.mm: (-[WebView _dispatchDidReceiveIconFromWebFrame:]): 2011-03-03 Jessie Berlin Reviewed by Adam Roben. WebKit2: Use CFNetwork Sessions API. https://bugs.webkit.org/show_bug.cgi?id=55435. Set the Private Browsing Storage Session on requests when Private Browsing is enabled. * WebCoreSupport/WebSystemInterface.mm: (InitWebCoreSystemInterface): Support using WKCopyRequestWithStorageSession in WebCore. 2011-03-02 Alexey Proskuryakov Reviewed by Darin Adler. REGRESSION (WebKit2): Tab keys no longer observe Full Keyboard Access https://bugs.webkit.org/show_bug.cgi?id=55633 * WebCoreSupport/WebChromeClient.h: * WebCoreSupport/WebChromeClient.mm: Removed tabsToLinks(). Mac WebKit already implements keyboardUIMode(). * WebView/WebView.mm: (-[WebView _retrieveKeyboardUIModeFromPreferences:]): Removed an incorrect comment. We actually get a value of 2 on Snow Leopard, and we don't require both bits to be set. The rest of the comment might be wrong too, but I'm not sure, so I've preserved it. 2011-03-02 Jessie Berlin Rubber-stamped by Dan Bernstein. Fix crashes in private browsing tests in WK1 on Snow Leopard. * WebCoreSupport/WebSystemInterface.mm: (InitWebCoreSystemInterface): Put the INIT call for wkCreatePrivateStorageSession outside of the #if !defined(BUILDING_ON_TIGER) && !defined(BUILDING_ON_LEOPARD) && !defined(BUILDING_ON_SNOW_LEOPARD) guards. 2011-03-02 Jessie Berlin Reviewed by Adam Roben. WebKit2: Use CFNetwork Sessions API. https://bugs.webkit.org/show_bug.cgi?id=55435. Add the ability to create a Private Browsing Storage Session. * WebCoreSupport/WebSystemInterface.mm: (InitWebCoreSystemInterface): Support calling wkCreatePrivateStorageSession from WebCore. 2011-03-02 Daniel Cheng Reviewed by David Levin. Add feature define for data transfer items https://bugs.webkit.org/show_bug.cgi?id=55510 * Configurations/FeatureDefines.xcconfig: 2011-03-02 Sam Weinig Reviewed by Anders Carlsson. Fix remaining localization issues by piping all localized strings through WebCore's localization bottleneck. * DefaultDelegates/WebDefaultContextMenuDelegate.mm: (-[WebDefaultUIDelegate menuItemWithTag:target:representedObject:]): * Misc/WebKitErrors.m: * Misc/WebLocalizableStringsInternal.h: Added. * Misc/WebLocalizableStringsInternal.mm: Added. (WebLocalizedStringInternal): * Panels/WebAuthenticationPanel.m: (-[WebAuthenticationPanel setUpForChallenge:]): * Plugins/Hosted/NetscapePluginHostManager.mm: (WebKit::NetscapePluginHostManager::spawnPluginHost): * WebCoreSupport/WebEditorClient.mm: (undoNameForEditAction): * WebCoreSupport/WebInspectorClient.mm: (WebInspectorFrontendClient::updateWindowTitle): (-[WebInspectorWindowController validateUserInterfaceItem:]): * WebCoreSupport/WebKeyGenerator.m: (-[WebKeyGenerator strengthMenuItemTitles]): (-[WebKeyGenerator signedPublicKeyAndChallengeStringWithStrengthIndex:challenge:pageURL:]): * WebCoreSupport/WebPlatformStrategies.mm: * WebView/WebHTMLView.mm: (-[WebHTMLView validateUserInterfaceItemWithoutDelegate:]): * WebView/WebPDFView.mm: (-[WebPDFView menuForEvent:]): 2011-03-01 Brian Weinstein Reviewed by Adam Roben. Part of WebKit2: Need a way to send notifications to client when cookies change https://bugs.webkit.org/show_bug.cgi?id=55427 Add stubs for CookiesStrategy on Mac WebKit1. * WebCoreSupport/WebPlatformStrategies.h: * WebCoreSupport/WebPlatformStrategies.mm: (WebPlatformStrategies::createCookiesStrategy): (WebPlatformStrategies::notifyCookiesChanged): 2011-03-01 Philippe Normand Reviewed by Eric Carlson. [GStreamer] support in mac video fullscreen controller https://bugs.webkit.org/show_bug.cgi?id=52280 Factored the code to configure the video overlay in a new private method of the controller and added GStreamer support to it. * WebView/WebVideoFullscreenController.h: * WebView/WebVideoFullscreenController.mm: (-[WebVideoFullscreenController setupVideoOverlay:]): (-[WebVideoFullscreenController windowDidLoad]): (-[WebVideoFullscreenController setMediaElement:WebCore::]): (-[WebVideoFullscreenController windowDidExitFullscreen]): 2011-02-23 Joseph Pecoraro Reviewed by Timothy Hatcher. All Console Messages should be passed to ChromeClients. https://bugs.webkit.org/show_bug.cgi?id=54926 Add a new private UIDelegate method, -webView:addMessageToConsole:withSource:, which supersedes -webView:addMessageToConsole if it exists. The new delegate does not filter to only JavaScript originated console messages. The old delegate is left around for clients that expect filtered messages, like DashCode and older versions of Safari. The dictionary message passed to the delegate now includes more information about the message source, type, and level. * WebCoreSupport/WebChromeClient.mm: (stringForMessageSource): (stringForMessageType): (stringForMessageLevel): (WebChromeClient::addMessageToConsole): * WebView/WebUIDelegatePrivate.h: 2011-03-01 Levi Weintraub Reviewed by Ryosuke Niwa. Stop instantiating legacy editing Positions in VisiblePosition https://bugs.webkit.org/show_bug.cgi?id=52919 Changing usage of legacy VisiblePosition constructor. Since we were dealing with positions from DOM Ranges, we're guaranteed a parent-anchored position. * WebView/WebFrame.mm: (-[WebFrame _caretRectAtPosition:affinity:]): * WebView/WebFrameInternal.h: * WebView/WebTextCompletionController.mm: (-[WebTextCompletionController doCompletion]): 2011-03-01 Sam Weinig Reviewed by Timothy Hatcher. WebKit2 needs to be made localizable https://bugs.webkit.org/show_bug.cgi?id=55483 * WebCoreSupport/WebPlatformStrategies.mm: Use WebCore's localizedString function instead of WebLocalizableStrings since WebCore is now responsible for localization. 2011-02-25 Steve Block Reviewed by Jeremy Orlow. Bridge.h should not include BridgeJSC.h https://bugs.webkit.org/show_bug.cgi?id=55212 Include BridgeJSC.h directly instead. * Plugins/Hosted/ProxyInstance.h: * Plugins/Hosted/WebHostedNetscapePluginView.mm: 2011-02-28 Chang Shu Reviewed by Ryosuke Niwa. Remove the support of Frame::isContentEditable and its dependencies. https://bugs.webkit.org/show_bug.cgi?id=54292 Remove the WebKit side implementation. Make WebKit support depend on Document::inDesignMode. * WebCoreSupport/WebEditorClient.h: * WebCoreSupport/WebEditorClient.mm: * WebView/WebView.mm: (-[WebView setEditable:]): (-[WebView isEditable]): * WebView/WebViewData.h: 2011-02-28 Oliver Hunt Reviewed by Gavin Barraclough. Make ScopeChainNode GC allocated https://bugs.webkit.org/show_bug.cgi?id=55283 More updates for the absence of the ScopeChain class * WebView/WebScriptDebugDelegate.mm: (-[WebScriptCallFrame scopeChain]): 2011-02-26 Vsevolod Vlasov Reviewed by Pavel Feldman. DumpRenderTree should reset frame opener between tests. https://bugs.webkit.org/show_bug.cgi?id=54874 Added clearOpener method to WebFramePrivate. * WebView/WebFrame.mm: (-[WebFrame _clearOpener]): * WebView/WebFramePrivate.h: 2011-02-26 Sheriff Bot Unreviewed, rolling out r79764. http://trac.webkit.org/changeset/79764 https://bugs.webkit.org/show_bug.cgi?id=55295 "broke Chromium builds" (Requested by rniwa on #webkit). * WebView/WebFrame.mm: * WebView/WebFramePrivate.h: 2011-02-26 Yongjun Zhang Reviewed by David Kilzer. https://bugs.webkit.org/show_bug.cgi?id=48781 Add a resource load delegate method to query if WebCore should paint the default broken image for failed images. Add a new resource load client method (shouldPaintBrokenImage). WebKit client can decide if WebCore should paint the default broken image when an image fails to load or decode. The method also passes the URL of the failed image. * WebCoreSupport/WebFrameLoaderClient.h: * WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::shouldPaintBrokenImage): * WebView/WebDelegateImplementationCaching.h: * WebView/WebDelegateImplementationCaching.mm: Added case for passing one object. (CallResourceLoadDelegateReturningBoolean): * WebView/WebResourceLoadDelegatePrivate.h: * WebView/WebView.mm: (-[WebView _cacheResourceLoadDelegateImplementations]): 2011-02-26 Vsevolod Vlasov Reviewed by Pavel Feldman. DumpRenderTree should reset frame opener between tests. https://bugs.webkit.org/show_bug.cgi?id=54874 Added clearOpener method to WebFramePrivate. * WebView/WebFrame.mm: (-[WebFrame _clearOpener]): * WebView/WebFramePrivate.h: 2011-02-25 Mark Rowe Build fix. * Misc/QuickDrawCompatibility.h: 2011-02-24 Anders Carlsson Fix clang build. * WebCoreSupport/WebKeyGenerator.m: (toWebCertificateParseResult): (-[WebKeyGenerator addCertificatesToKeychainFromData:]): * WebView/WebTextCompletionController.mm: 2011-02-24 Peter Kasting Reviewed by Eric Seidel. Drop the "U; " encryption level from the User Agent string. https://bugs.webkit.org/show_bug.cgi?id=54566 * WebView/WebView.mm: (+[WebView _standardUserAgentWithApplicationName:]): 2011-02-24 Andrew Wilson Unreviewed, rolling out r79570. http://trac.webkit.org/changeset/79570 https://bugs.webkit.org/show_bug.cgi?id=54874 Breaks chromium build because glue/mocks/mock_web_frame.h/cc was not updated * WebView/WebFrame.mm: * WebView/WebFramePrivate.h: 2011-02-24 Vsevolod Vlasov Reviewed by Alexey Proskuryakov. DumpRenderTree should reset frame opener between tests. https://bugs.webkit.org/show_bug.cgi?id=54874 Added clearOpener method to WebFramePrivate. * WebView/WebFrame.mm: (-[WebFrame _clearOpener]): * WebView/WebFramePrivate.h: 2011-02-22 Laszlo Gombos Reviewed by Alexey Proskuryakov. Drop the language tag part from the User Agent string https://bugs.webkit.org/show_bug.cgi?id=54560 * WebView/WebView.mm: (+[WebView _standardUserAgentWithApplicationName:]): Drop the language tag part. 2011-02-22 Brady Eidson Reviewed by Anders Carlsson. Part of and https://bugs.webkit.org/show_bug.cgi?id=54514 API to view and delete Application Cache data by origin. * WebCoreSupport/WebApplicationCache.mm: (+[WebApplicationCache deleteAllApplicationCaches]): Move this implementation into WebCore itself. 2011-02-17 Ryosuke Niwa Reviewed by Kent Tamura. Rename Position::node() to Position::deprecatedNode() https://bugs.webkit.org/show_bug.cgi?id=54622 * WebView/WebFrame.mm: (-[WebFrame _smartDeleteRangeForProposedRange:]): 2011-02-17 Ryosuke Niwa Reviewed by Kent Tamura. Rename Position::node() to Position::deprecatedNode() https://bugs.webkit.org/show_bug.cgi?id=54622 Done the rename. * WebView/WebFrame.mm: (-[WebFrame _smartDeleteRangeForProposedRange:]): Since newStart and newEnd are parent-anchored, use containerNode() and offsetInContainerNode() instead of deprecated member functions. 2011-02-18 Gavin Barraclough Reviewed by Sam Weinig. Bug 54786 - Devirtualize JSCell::classInfo() Instead of making a virtual function call, add a pointer to the ClassInfo onto Structure. This removes a virtual function call, and paves the way towards removing all the createStructure methods, and StructureFlags/AnonymousSlotCount properties (these should be able to move onto ClassInfo). Calls to Structure::create must now pass a pointer to the ClassInfo for the structure. All objects now have a ClassInfo pointer, non-object cell types still do not. Changes are most mechanical, involving three steps: * Remove virtual classInfo() methods. * Add &s_info parameter to calls to Structure::create. * Rename ClassInfo static members on classes from 'info' to 's_info', for consistency. * Plugins/Hosted/ProxyInstance.mm: (WebKit::ProxyRuntimeMethod::ProxyRuntimeMethod): (WebKit::ProxyRuntimeMethod::createStructure): * Plugins/Hosted/ProxyRuntimeObject.h: (WebKit::ProxyRuntimeObject::createStructure): * Plugins/Hosted/ProxyRuntimeObject.mm: (WebKit::ProxyRuntimeObject::ProxyRuntimeObject): * WebView/WebView.mm: (aeDescFromJSValue): 2011-02-19 Brian Ryner Reviewed by Adam Barth. Add missing #include of DocumentLoader.h, needed since the transitive include through Document.h is removed. https://bugs.webkit.org/show_bug.cgi?id=50489 * WebView/WebFrame.mm: 2011-02-19 Charlie Reis Reviewed by Mihai Parparita. Ensure loading has stopped in HistoryController::goToItem https://bugs.webkit.org/show_bug.cgi?id=54517 Add a FrameLoaderClient callback for whether to stop loading before goToItem. Test: http/tests/navigation/forward-to-fragment-fires-onload.html * WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::shouldStopLoadingForHistoryItem): Added. * WebCoreSupport/WebFrameLoaderClient.h: 2011-02-16 David Hyatt Reviewed by Dan Bernstein. https://bugs.webkit.org/show_bug.cgi?id=54244 Convert the line box tree to floating point and eliminate font rounding hacks. This patch removes all of the rounding hacks from the Font code and makes sure all Font APIs involving width measurement and width offsets use floats. The line box tree's x, y and logicalWidth members have all been converted to floats and all of the line box APIs have been changed as well. In terms of pixel adjustments, overflow is using an enclosing model (so it will be enclosingIntRect of a line box's x/y/width/height). Background and border painting is using a rounding model, so borders and backgrounds will round to the nearest pixel when painting. Replaced elements still snap to integer positions on lines, and they use a rounding model as well, although their underlying line boxes still have a precise floating point position. Justification will now allow subpixel positioning to occur as well. Platforms that don't support subpixel positioning should already be rounding justification spacing in their font code. Many layout test results change on Mac, since rounding hacks were used there and are now gone. * Misc/WebKitNSStringExtras.mm: (-[NSString _web_drawAtPoint:font:textColor:allowingFontSmoothing:]): (-[NSString _web_widthWithFont:]): 2011-02-10 Luiz Agostini Reviewed by Adam Roben. HTML5
and : localized text https://bugs.webkit.org/show_bug.cgi?id=54260 The method defaultDetailsSummaryText was added to LocalizationStrategy class. It is used to provide the default label to be used by a
tag that has no child. * WebCoreSupport/WebPlatformStrategies.h: * WebCoreSupport/WebPlatformStrategies.mm: (WebPlatformStrategies::defaultDetailsSummaryText): 2011-02-16 Matthew Delaney Reviewed by Simon Fraser. Allow acceleratesDrawing for WebKit2 https://bugs.webkit.org/show_bug.cgi?id=54511 Plumb through preference for accelerated drawing. * WebView/WebPreferenceKeysPrivate.h: * WebView/WebPreferences.mm: (+[WebPreferences initialize]): (-[WebPreferences acceleratedDrawingEnabled]): (-[WebPreferences setAcceleratedDrawingEnabled:]): * WebView/WebPreferencesPrivate.h: 2011-02-15 David Kilzer Move -[WebDynamicScrollBarsView inProgrammaticScroll] to WebDynamicScrollBarsViewInternal.h Reviewed by Darin Adler. * WebView/WebDynamicScrollBarsView.h: (-[WebDynamicScrollBarsView inProgrammaticScroll]): Removed declaration. * WebView/WebDynamicScrollBarsView.mm: (-[WebDynamicScrollBarsView inProgrammaticScroll]): Moved implementation into correct category. * WebView/WebDynamicScrollBarsViewInternal.h: (-[WebDynamicScrollBarsView inProgrammaticScroll]): Added declaration. * WebView/WebHTMLView.mm: Included WebDynamicScrollBarsViewInternal.h instead of WebDynamicScrollBarsView.h. 2011-02-14 Oliver Hunt Reviewed by Gavin Barraclough and Geoff Garen. Refactor handles and weak pointers to become nicer and more automatic https://bugs.webkit.org/show_bug.cgi?id=54415 Update to use Global<> instead of ProtectedPtr, and refactored slightly to get global data to places it's needed for when we're assigning to Global<>s * ForwardingHeaders/collector/handles/Global.h: Added. * Plugins/Hosted/NetscapePluginInstanceProxy.h: * Plugins/Hosted/NetscapePluginInstanceProxy.mm: (WebKit::NetscapePluginInstanceProxy::LocalObjectMap::get): (WebKit::NetscapePluginInstanceProxy::LocalObjectMap::idForObject): (WebKit::NetscapePluginInstanceProxy::LocalObjectMap::forget): (WebKit::NetscapePluginInstanceProxy::getWindowNPObject): (WebKit::NetscapePluginInstanceProxy::getPluginElementNPObject): (WebKit::NetscapePluginInstanceProxy::evaluate): (WebKit::NetscapePluginInstanceProxy::invoke): (WebKit::NetscapePluginInstanceProxy::invokeDefault): (WebKit::NetscapePluginInstanceProxy::construct): (WebKit::NetscapePluginInstanceProxy::addValueToArray): * WebView/WebScriptDebugger.h: * WebView/WebScriptDebugger.mm: (WebScriptDebugger::WebScriptDebugger): 2011-02-15 Jia Pu Reviewed by Darin Adler. Autocorrection should respect undo. https://bugs.webkit.org/show_bug.cgi?id=52221 Please see WebCore/ChangeLog for detailed description. * WebCoreSupport/WebEditorClient.h: Updated for the new function declared in EditorClient. * WebCoreSupport/WebEditorClient.mm: (WebEditorClient::recordAutocorrectionResponse): Ditto. * WebView/WebFrame.mm: (-[WebFrame _replaceSelectionWithFragment:selectReplacement:smartReplace:matchStyle:]): Adopted new signature of ReplaceSelectionCommand::create(). 2011-02-15 David Kilzer Fix spelling of -inProgramaticScroll Reviewed by Darin Adler. * WebView/WebDynamicScrollBarsView.h: * WebView/WebDynamicScrollBarsView.mm: (-[WebDynamicScrollBarsView inProgrammaticScroll]): Renamed from -inProgramaticScroll. * WebView/WebHTMLView.mm: (-[WebHTMLView _frameOrBoundsChanged]): Corrected method name. 2011-02-15 Kenneth Russell Reviewed by Darin Fisher. Allow controlling minimum DOMTimer interval on a per-page basis https://bugs.webkit.org/show_bug.cgi?id=54312 Added needed methods to implement LayoutTestController's new setMinimumTimerInterval method. * WebView/WebView.mm: (-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]): (+[WebView _defaultMinimumTimerInterval]): (-[WebView _setMinimumTimerInterval:]): * WebView/WebViewPrivate.h: 2011-02-11 Geoffrey Garen Reviewed by Oliver Hunt. A little more encapsulation for the heap: Removed CollectorHeapIterator https://bugs.webkit.org/show_bug.cgi?id=54298 * Misc/WebCoreStatistics.mm: (+[WebCoreStatistics javaScriptProtectedObjectTypeCounts]): (+[WebCoreStatistics javaScriptObjectTypeCounts]): Updated for new typedef. 2011-02-10 Nate Chapin Reviewed by Adam Barth. Update calls to DocumentWriter. https://bugs.webkit.org/show_bug.cgi?id=50489 * WebView/WebFrame.mm: (-[WebFrame _canProvideDocumentSource]): 2011-02-10 Chris Fleizach Reviewed by Anders Carlsson. AX: AX needs to stop using WebCoreViewFactory https://bugs.webkit.org/show_bug.cgi?id=54153 * WebCoreSupport/WebSystemInterface.mm: (InitWebCoreSystemInterface): 2011-02-10 Peter Varga Reviewed by Csaba Osztrogonác. Remove PCRE source from trunk https://bugs.webkit.org/show_bug.cgi?id=54188 * ForwardingHeaders/pcre/pcre.h: Removed. 2011-02-09 Pavel Feldman Reviewed by Yury Semikhatsky. Web Inspector: follow up on InspectorAgent split - removing unnecessary methods from InspectorController. https://bugs.webkit.org/show_bug.cgi?id=54093 * WebInspector/WebInspector.mm: (-[WebInspector showConsole:]): (-[WebInspector stopProfilingJavaScript:]): 2011-02-08 Dan Bernstein Reviewed by Jon Honeycutt and Maciej Stachowiak. Find in Mail no longer cycles around * WebView/WebHTMLView.mm: (-[WebHTMLView searchFor:direction:caseSensitive:wrap:startInSelection:]): Set the wrap option according to the flag. 2011-02-08 Sheriff Bot Unreviewed, rolling out r77980. http://trac.webkit.org/changeset/77980 https://bugs.webkit.org/show_bug.cgi?id=54043 "Crashes on Windows and Linux..." (Requested by leviw on #webkit). * WebView/WebFrame.mm: (-[WebFrame _caretRectAtNode:offset:affinity:]): * WebView/WebFrameInternal.h: * WebView/WebTextCompletionController.mm: (-[WebTextCompletionController doCompletion]): 2011-02-08 Levi Weintraub Reviewed by Ryosuke Niwa. Stop instantiating legacy editing Positions in VisiblePosition https://bugs.webkit.org/show_bug.cgi?id=52919 Changing usage of legacy VisiblePosition constructor. Since we were dealing with positions from DOM Ranges, we're guaranteed a parent-anchored position. * WebView/WebFrame.mm: (-[WebFrame _caretRectAtPosition:affinity:]): * WebView/WebFrameInternal.h: * WebView/WebTextCompletionController.mm: (-[WebTextCompletionController doCompletion]): 2011-02-08 Adam Barth Reviewed by Eric Seidel. Remove orphan code from old parser https://bugs.webkit.org/show_bug.cgi?id=53984 * WebCoreSupport/WebChromeClient.h: 2011-02-02 Ilya Tikhonovsky Reviewed by Yury Semikhatsky. Web Inspector: move InspectorController's methods from InspectorAgent to InspectorController. https://bugs.webkit.org/show_bug.cgi?id=53169 Minor change enforced by major changes in WebCore/inspector/InspectorController. * WebInspector/WebInspector.mm: (-[WebInspector isTimelineProfilingEnabled]): 2011-02-07 Enrica Casucci Reviewed Adam Roben and Darin Adler. WebKit2: drag and drop support on Windows. https://bugs.webkit.org/show_bug.cgi?id=52775 Removed createDragImageForLink from DragClient. * WebCoreSupport/WebDragClient.h: * WebCoreSupport/WebDragClient.mm: (WebDragClient::startDrag): 2011-02-03 Yury Semikhatsky Reviewed by Pavel Feldman. Web Inspector: remove settings related methods from InspectorClient https://bugs.webkit.org/show_bug.cgi?id=53686 * WebCoreSupport/WebInspectorClient.h: * WebCoreSupport/WebInspectorClient.mm: (WebInspectorClient::openInspectorFrontend): (WebInspectorFrontendClient::WebInspectorFrontendClient): 2011-02-03 James Kozianski Reviewed by Dimitri Glazkov. Add navigator.registerProtocolHandler behind a flag. https://bugs.webkit.org/show_bug.cgi?id=52609 * Configurations/FeatureDefines.xcconfig: 2011-02-03 Adam Langley Reviewed by Adam Barth. Plumb mixed script URL to FrameLoaderClient https://bugs.webkit.org/show_bug.cgi?id=52384 Regressions covered by http/tests/security/mixedContent/* * WebCoreSupport/WebFrameLoaderClient.h: * WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::didRunInsecureContent): 2011-02-03 Beth Dakin Reviewed by Sam Weinig. Fix for Ability to animate track for WKPainter scrollers * WebCoreSupport/WebSystemInterface.mm: (InitWebCoreSystemInterface): 2011-02-02 Mark Rowe Reviewed by Beth Dakin. Crash when loading canvas pages inside HTMLCanvasElement::createImageBuffer(). * WebCoreSupport/WebSystemInterface.mm: (InitWebCoreSystemInterface): Add some missing initializers. 2011-02-02 Steve Lacey Reviewed by Eric Carlson. Implement basic media statistics on media elements. https://bugs.webkit.org/show_bug.cgi?id=53322 * Configurations/FeatureDefines.xcconfig: 2011-02-01 Sam Weinig Reviewed by Beth Dakin. Part 2 for Adopt WKScrollbarPainterController Use header detection to define scrollbar painting controller #define. * WebCoreSupport/WebSystemInterface.mm: (InitWebCoreSystemInterface): 2011-02-01 David Hyatt Reviewed by Oliver Hunt. https://bugs.webkit.org/show_bug.cgi?id=53520 Remove the physical terminology from IntRect and FloatRect. Now that we have flipped RenderBlocks for vertical-rl and horizontal-bt writing modes, we need to update our terminology to be more accurate. I'm borrowing a page from AppKit here (which also supports flipped NSViews) and renaming right() and bottom() to maxX() and maxY(). These terms remain accurate even for flipped rectangles. * WebView/WebHTMLView.mm: (setNeedsDisplayInRect): 2011-02-01 Beth Dakin Reviewed by Sam Weinig. Fix for Adopt WKScrollbarPainterController * WebCoreSupport/WebSystemInterface.mm: (InitWebCoreSystemInterface): 2011-02-01 Dave Hyatt Reviewed by Darin Adler. https://bugs.webkit.org/show_bug.cgi?id=46422, make printing and pagination work with vertical text. Change printing functions to check writing-mode and properly swap width and height as needed. * WebView/WebDynamicScrollBarsView.mm: (-[WebDynamicScrollBarsView setScrollOrigin:updatePositionAtAll:immediately:]): * WebView/WebFrame.mm: (-[WebFrame _computePageRectsWithPrintScaleFactor:pageSize:]): * WebView/WebFrameInternal.h: * WebView/WebHTMLView.mm: (-[WebHTMLView _web_setPrintingModeRecursive]): (-[WebHTMLView _web_clearPrintingModeRecursive]): (-[WebHTMLView _web_setPrintingModeRecursiveAndAdjustViewSize]): (-[WebHTMLView _beginPrintModeWithMinimumPageWidth:height:maximumPageWidth:]): (-[WebHTMLView _beginPrintModeWithPageWidth:height:shrinkToFit:]): (-[WebHTMLView _endPrintMode]): (-[WebHTMLView _beginScreenPaginationModeWithPageSize:shrinkToFit:]): (-[WebHTMLView _endScreenPaginationMode]): (-[WebHTMLView layoutToMinimumPageWidth:height:maximumPageWidth:adjustingViewSize:]): (-[WebHTMLView _setPrinting:minimumPageLogicalWidth:logicalHeight:maximumPageLogicalWidth:adjustViewSize:paginateScreenContent:]): (-[WebHTMLView adjustPageHeightNew:top:bottom:limit:]): (-[WebHTMLView _scaleFactorForPrintOperation:]): (-[WebHTMLView setPageWidthForPrinting:]): (-[WebHTMLView knowsPageRange:]): 2011-01-31 Oliver Hunt Convert markstack to a slot visitor API https://bugs.webkit.org/show_bug.cgi?id=53219 rolling r77098, r77099, r77100, r77109, and r77111 back in, along with a few more Qt fix attempts. * WebView/WebScriptDebugDelegate.mm: (-[WebScriptCallFrame scopeChain]): 2011-01-30 Csaba Osztrogonác Unreviewed, rolling out r77098, r77099, r77100, r77109, and r77111. http://trac.webkit.org/changeset/77098 http://trac.webkit.org/changeset/77099 http://trac.webkit.org/changeset/77100 http://trac.webkit.org/changeset/77109 http://trac.webkit.org/changeset/77111 https://bugs.webkit.org/show_bug.cgi?id=53219 Qt build is broken * WebView/WebScriptDebugDelegate.mm: (-[WebScriptCallFrame scopeChain]): 2011-01-30 Oliver Hunt Convert markstack to a slot visitor API https://bugs.webkit.org/show_bug.cgi?id=53219 rolling r77006 and r77020 back in. * WebView/WebScriptDebugDelegate.mm: (-[WebScriptCallFrame scopeChain]): 2011-01-28 Geoffrey Garen Reviewed by Maciej Stachowiak. Some more Heap cleanup. https://bugs.webkit.org/show_bug.cgi?id=53357 Updated for JavaScriptCore changes. * Misc/WebCoreStatistics.mm: (+[WebCoreStatistics memoryStatistics]): 2011-01-28 Sheriff Bot Unreviewed, rolling out r77006 and r77020. http://trac.webkit.org/changeset/77006 http://trac.webkit.org/changeset/77020 https://bugs.webkit.org/show_bug.cgi?id=53360 "Broke Windows tests" (Requested by rniwa on #webkit). * WebView/WebScriptDebugDelegate.mm: (-[WebScriptCallFrame scopeChain]): 2011-01-27 Oliver Hunt Reviewed by Geoffrey Garen. Convert markstack to a slot visitor API https://bugs.webkit.org/show_bug.cgi?id=53219 Update to new marking api * WebView/WebScriptDebugDelegate.mm: (-[WebScriptCallFrame scopeChain]): 2011-01-28 Dan Bernstein Reviewed by Sam Weinig.